summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-02-25Replace deprecated std::auto_ptr with boost::scoped_ptrTakeshi Abe
Change-Id: I72b0e8b07bd7309a23d5635b7e0b7dbdc9c2c721
2014-02-24Related: rhbz#1065807 rework #i66157# for multiple writable template dirsCaolán McNamara
if there are multiple user-level template dirs then we should be able to remove/rename content in all of them, not just the default writable target. The target scenario here is to default to ~/Templates when it exists as the template dir, but to retain ~/.config/libreoffice/user/template in the dir for any pre-existing templates and to treat both as equivalent in terms of removing their content etc. i#66157# wanted to avoid remove extensions templates and other internal ones, so rework that logic to instead just be hands off internal templates and allow modification of the remainder Change-Id: I56afe991d4297ba692e914ae95ea02d68553f60a
2014-02-24implicitboolconversion: warn about implicit conversion of call args to boolStephan Bergmann
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f "sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it" earlier when converting occurrences of sal_Bool to bool. Restricting this check to function call arguments avoids too much noise while hopefully still catching all the relevant problems. (This check partially overlaps the pointertobool check, so implicit conversions from pointers to bool call arguments will now generate two loplugin warnings, but that's harmless.) Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-24fix 'delete' not working in the Template ManagerCaolán McNamara
regression from b29c078c7f193dd7dae74baf89fe1abb9264239c because if the search view widget is visible then its assumed that we are in search view mode Change-Id: I8e81ffa06d5d3ac50e110105c9444707fd4c41c6
2014-02-24Replace exisiting TriState, AutoState with more generic TriStateStephan Bergmann
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-23coverity#440977 Dereference after null checkCaolán McNamara
Change-Id: I8350641f3b07e8a25080d4dfe7d9c212f89dd992
2014-02-23fdo#74913 The delete style confirmation dialog asks the question now.Rachit Gupta
Change-Id: I9d2ed3b233f83d05314c2ad1453be487b25d6be8 Reviewed-on: https://gerrit.libreoffice.org/8163 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23coverity#441618 Dereference null return valueCaolán McNamara
Change-Id: Id3e2ba08093bc618c17485122579898301df14d8
2014-02-21Bug #63962 Dynamically scan the config directory for icon themesTobias Lippert
The hard-coded icon themes have been replaced by a dynamic list which is filled by scanning the config directory Conflicts: include/vcl/settings.hxx vcl/source/app/settings.cxx vcl/source/window/window.cxx Change-Id: Ie3680ffe27d06e375acf22753e036cb6ddabc4ed Reviewed-on: https://gerrit.libreoffice.org/7935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21Add config option used when we try to link one huge object file.Matúš Kukan
In theory, it should not be used, we use it now to mark duplicated symbols from sdi slots as weak. See idl/source/objects/types.cxx. Change-Id: I3c6fccfb96884df6b9e6eb35b8615ba4d66ca208
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20cid#1078824 Dereference before null checkNoel Grandin
Change-Id: Ic68e7048786415a847a67723890a92cb542bbf80
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-19unotools: sal_Bool -> boolStephan Bergmann
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
2014-02-18vcl: CUPS printing: notify user if spooling failedMichael Stahl
CUPS does not accept jobs for a printer that has been stopped; pop up an error message in this case instead of silently ignoring failure. Change-Id: I1bc9120c9c9f438e350c964ed7ef29924a72ce78
2014-02-18Resolves: fdo#75121 align checkbox with message textCaolán McNamara
Change-Id: Ib8379cbdb6cf16f8799c1e34b9bd7ff2e62e27f4
2014-02-18Use correct log areaTor Lillqvist
Change-Id: Idcbb480be0c6bba1215bf75310cd6fc7bfd101a3
2014-02-18assert() is too harsh here I think, use SAL_WARN_IF() insteadTor Lillqvist
I run into the assertion now in TiledLibreOffice, but if I drop the assert(), it still works. So let's just print a warning (that everybody will cheerfully ignore, ha ha) instead. I have no idea what this code actually is doing... (Originally the code had DBG_ASSERT(), which despite its name also just prints a warning, which I changed to a real assert() in 8293b29304716d6bd117ab233b1238e1385ae592 for some reason.) Change-Id: I928078aaf3648c8d04c59f271504c7d3b02e1bb5
2014-02-18callcatcher: update unused code listsCaolán McNamara
Change-Id: Ie975f8a970eec63b593933ebb2394db76d537c51
2014-02-18tools: sal_Bool -> boolStephan Bergmann
Change-Id: I3aad235d92b3972b44199294c0f3de65ad57f450
2014-02-17comphelper: sal_Bool -> boolStephan Bergmann
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17Do not crash when no interfaces are registered.Matúš Kukan
Change-Id: Idee3bb5821e8b46da78243f6396780b35f23e30a
2014-02-17Resolves: fdo#72233 too long style names over-stretch dialogCaolán McNamara
Change-Id: Id6f102a3def1928ad8f6b4d27eb32f8c69bdba49
2014-02-17cid#705884 dereference before null checkNoel Grandin
Change-Id: I55258bb30034b95f53134a9747088fc488796564
2014-02-13cosmeticsMatúš Kukan
Change-Id: Ice4f20db3a590568a7ae4ae59fa0c4ff13e59051
2014-02-12Don't include filename extension in e-mail subjectStephan Bergmann
...as suggested to me by a user. Change-Id: Iaad83e761884b7b43cf92ebb10cf553df1b97cd0
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12coverity#441125 Dereference after null checkCaolán McNamara
Change-Id: Ia8046dc20ff46612ad3ffeba098bee079858e8da
2014-02-12coverity#441010 Dereference after null checkCaolán McNamara
Change-Id: I3f35f2ed2154f75303d561efecd1638b73872b61
2014-02-12coverity#440982 Dereference after null checkCaolán McNamara
Change-Id: I5e19801311c2cb038b6e1c5e7e52a6022f62ea86
2014-02-12coverity#440973 Dereference after null checkCaolán McNamara
Change-Id: I24caa53a66da4d724e4f8e5d4b06c7d3e9633f5e
2014-02-12coverity#708164 Uninitialized scalar fieldCaolán McNamara
Change-Id: I7de5d34dc2964f91cb4daa0eb754f9ad02e83667
2014-02-12callcatcher: update unused codeCaolán McNamara
Change-Id: Iaaad9302ef8edb47fa95ce8ca608b6f36449521b
2014-02-12cid#705226 missing break in switchNoel Grandin
Change-Id: Id9457d2e7a6778fee9fa5ec32d2bb97cb8b7d296
2014-02-12coverity#1130420 improper use of negativeNoel Grandin
Change-Id: I463764faffb1013a8c8d10c64695289080c3205c
2014-02-11coverity#1130402 Missing break in switchCaolán McNamara
Change-Id: Ifd86d24bb6a7957d4da392bed3f5ebda8d0fa690
2014-02-10coverity#441011 Dereference after null checkCaolán McNamara
Change-Id: I8a3430440bdd8cc1561eb60863c2bda3df8eac6d
2014-02-10Linked with -> Inherit from in style dialogAlexander Wilms
Change-Id: I3ca5f297217c898a12375f7f8e9c57841cd3db84 Reviewed-on: https://gerrit.libreoffice.org/7941 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-10related fdo#65430: forgot to 'unlink' setOpenTemplateHdlJoren De Cuyper
This was introduced in 96e7225260aac0815643a4043f4ddb4e6b5764a1 Change-Id: I9bb8abbc9e9167b1e43bebf4477cf73010bf2d92 Reviewed-on: https://gerrit.libreoffice.org/7958 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-10fdo#74782 search view doesn't hide local view when searching first timeJoren De Cuyper
See bug report for screenshot of current behavior. When the search button is hit, OnTemplateSearch() is called. If we switch from 'no search' to 'search' view, mpSearchView was not hidden. This'll result in SearchUpdateHdl that mpCurView will not hide. It doesn't matter if we hide it anyway (either when we would start searching, or end searching). If we start searching, we don't have any search term yet (so no result anyway). If we stop searching, it has to be hidden for sure. Change-Id: I6bcf540b4866eeb6a8196c171027b385635cf084 Reviewed-on: https://gerrit.libreoffice.org/7969 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-10coverity#1130368 Unchecked dynamic_castCaolán McNamara
Change-Id: Ib4ae0ce1647e15bf1b9d7fe8e2d3bcfcb8ec1466
2014-02-10the return of callcatcherCaolán McNamara
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10Resolves: rhbz#1063170 Don't URI-encode filename in e-mail subjectStephan Bergmann
Change-Id: I7e3f59af5bb7d89c74e2bf199a727b2419714121
2014-02-10startcenter: don't generate thumbnails in headless modeMiklos Vajna
Commit e2eda70f2746f08376d8cdf5e5360df217335aef (startcenter: fdo#72469: Thumbnails also for other file types than ODF, 2014-02-03) turned on thumbnail generation for non-ODF documents as well. This is not that interesting in case --headless is used, however it slows down unit tests quite a lot, resulting in about doubled toplevel noop make time. Numbers on my machine for toplevel 'make' (in case there is no code to rebuild): - before: real 5m56.857s - after: real 2m39.432s Change-Id: I0edc13c29a7713f8faf8158ba240151977cdfa4b
2014-02-09coverity#1169825 Dereference after null checkCaolán McNamara
Change-Id: I74df9084f46e38901b6682b892fa7d0f71d72572
2014-02-09Typo: I/internaly -> I/internallyJulien Nabet
Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a
2014-02-07coverity#735493 Logically dead codeCaolán McNamara
Change-Id: Iddf09c1acb7d2e812b86c6f14f5394a6a266d258
2014-02-07fdo#60586 - [Template manager] Switching tabs does not update breadcrumbsJoren De Cuyper
When applying a filter, lets go to the rootfolder of that filter Change-Id: I7034584da65ec777aa3cc288e1423596312caeec Reviewed-on: https://gerrit.libreoffice.org/7905 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-11 10:52:56 +0000