summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2017-04-28loplugin:unusedfieldsNoel Grandin
Change-Id: I67a0372d6982648717651f736c51e447d0b7d6a2 Reviewed-on: https://gerrit.libreoffice.org/37047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27tdf#39468 cleanup source code commentsdennisroczek
* translate German source code comments * remove ascii art * remove bogus source Code comments * remove old StarOffice/Sun internal bug tracker references Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451 Reviewed-on: https://gerrit.libreoffice.org/36005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27another name for a nonlocalized string is a stringCaolán McNamara
Change-Id: Ic4ff92720edd1c10dd6d5eff026e79cb02990005
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26loplugin:unusedmethodsNoel Grandin
Change-Id: If2e1241bbe8a3d17859e3ca076b0f55f25c48ea5 Reviewed-on: https://gerrit.libreoffice.org/36983 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26remove sfx2 bitmaps from .src filesCaolán McNamara
Change-Id: Ibc4261af5f479badd281211e467d2c7b524af3f3
2017-04-26remove sfx2 bitmaps from .src filesCaolán McNamara
Change-Id: I54448567db051f4446c36b16acdda2288b391537
2017-04-26use strong_int for LanguageTypeNoel Grandin
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25vcl: change ErrorHandlerFlags to DialogMaskChris Sherlock
Change-Id: I1959ac97f679d8d719f851f9869962b39a20ded9 Reviewed-on: https://gerrit.libreoffice.org/36841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25remove bitmaps from .src filesCaolán McNamara
and into includeable .hlst files, add them to postprocess/CustomTarget_images.mk to continue only including used bitmaps in icon-theme zips Change-Id: I5c24c3eca93a9c4101bcdcacb0e4b2712133968e Reviewed-on: https://gerrit.libreoffice.org/36941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25clang-tidy readability-simplify-boolean-expr in sfx2Noel Grandin
Change-Id: I388e0160daf6a7359881acb82145460ad5bbbbbf Reviewed-on: https://gerrit.libreoffice.org/36929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25make __RSC a builtin define for the RSC compilerNoel Grandin
instead of randomly defining it in only some of .src files Change-Id: Ifec3920740723d248400f451d717b5288c421b8d Reviewed-on: https://gerrit.libreoffice.org/36832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-24Do not pass a suggested name to GUIStoreModel: it is always overwrittenMatteo Casalin
Change-Id: Iac60c012f05916c5324e1ea8bae142ab329aa4e0
2017-04-24OUStrings: constify and avoid temporaries some moreMatteo Casalin
Change-Id: I965ea920880bb631e108bd963ac1ab21582222ef
2017-04-24Minor optimizations to loopsMatteo Casalin
* Use const value for for checks * Early bail out Change-Id: I8d280a4bfb68da108925ae6b1a3d1b0b827dc3a5
2017-04-24Fix indentationMatteo Casalin
Change-Id: I1c974fb556d5fbe8492356a7471e659035308d0e
2017-04-24OUStrings: constify and avoid temporariesMatteo Casalin
Change-Id: I2e4a36a5ac25d1c44c674eb3f721c974f29b1fd9
2017-04-24OUStrings: avoid temporaries and OUStringBuffersMatteo Casalin
Change-Id: Ibb8493807acd292add892b80839b6f6d3d90a8e9
2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky
And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329
2017-04-23tdf#95845 Use CommandInfoProviderMaxim Monastirsky
And a few unused theUICommandDescription includes. Change-Id: Ic80dbfb91e5e7662723efe0cb4090416994adabd
2017-04-23No usage of the private:commandimage thingMaxim Monastirsky
Change-Id: I8e5c1431f095c875cda6f66f16a03af4bbd1d1fb
2017-04-23Use automatic integer type, with minor simplificationsMatteo Casalin
Change-Id: I08b8370311b11d45ab744875f7ad6b885f318a74
2017-04-23OUStrings: avoid temporaries and constifyMatteo Casalin
Change-Id: Id6b4b26df09ddb750f3e5430636b41c89e4d9e8e
2017-04-23These data members can be file scope consts, and reusedMatteo Casalin
Change-Id: I977d523d6aefeb2475044783ba30744b950d3708
2017-04-22Notebookbar: better tab placing for the NotebookbarTabControlSzymon Kłos
Change-Id: Ia44ce20455829048be457584c49fde0996f4a699 Reviewed-on: https://gerrit.libreoffice.org/36814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21LOK - Calc: changed the way header is updated on row/col insert/removeMarco Cecchetti
This patch introduce a new LOK callback for informing the client that the row/col header is no more valid and needs to be updated. Change-Id: I21a3a41d69bd1a3c11c9ffaf1d7d53dbc3b9681d Reviewed-on: https://gerrit.libreoffice.org/36733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-04-21convert HTML_OPTION_IDS to scoped enumNoel Grandin
Change-Id: Ia766dc58a571e5853005fd394283d7b53f02e4a6 Reviewed-on: https://gerrit.libreoffice.org/36748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20convert EDynamicMenuType to scoped enumNoel Grandin
and drop unused E_HELPBOOKMARKS Change-Id: I5756ea326bdc1a99f7d6f1ba43baf6aca9f7f2fc Reviewed-on: https://gerrit.libreoffice.org/36728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19loplugin:inlinefields in SfxSplitWindowNoel Grandin
Change-Id: I62ea079e448c871de34d4a48a4e017dd456c7e72 Reviewed-on: https://gerrit.libreoffice.org/36664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-18Clarify intended behaviourMatteo Casalin
Change-Id: Ib1edda4886940223bd32c8a78d3aa4241f57ec84
2017-04-18Avoid 'else' after a returnMatteo Casalin
Change-Id: Ia530aa2fdaa5f6d77180da3139a47407adf9f519
2017-04-18Fix indentationMatteo Casalin
Change-Id: If2c567450c27fe442e8c68627888fe7d39a65acb
2017-04-18OUStrings: constify and reduce temporariesMatteo Casalin
Change-Id: I34f6d51ad3088d1561f103a21b78f4bb6780f95c
2017-04-18Reduce scope and simplify by early returnMatteo Casalin
Change-Id: I12f8c6cb002cb0af63a096c7b66dd1e7d2db92a5
2017-04-18Reduce scope and simplifyMatteo Casalin
Change-Id: I055e05ff04c9a839fb142be5cbf08e40e7eb35f3
2017-04-18OUStrings: constify and avoid temporariesMatteo Casalin
Change-Id: I91d5969468da6d9bd61bc7bd321cc065910f7639
2017-04-18OUStrings: constify and avoid temporariesMatteo Casalin
Change-Id: I06e058d3ae16bbf504f2e5d8f72b00527c53e336
2017-04-18OUStrings: constify and avoid temporariesMatteo Casalin
Change-Id: I8ba379d2418eec012de62354dab474e6e7c8a1c6
2017-04-18Remove isEmpty check on (just set) non-empty sURLMatteo Casalin
Change-Id: I669b720c976c51d248dadb11b5e93ab1708ccfbb
2017-04-18OUStrings: constify and avoid temporariesMatteo Casalin
Change-Id: Ib69ad52577f8d94dbd363ba1799d5294db7a580a
2017-04-18OUStrings: constify and avoid temporariesMatteo Casalin
Change-Id: I4459c84afbe68d29f1fd8dbce3c4aa6f7846a912
2017-04-18Avoid temporary OUStringsMatteo Casalin
Change-Id: I0fb456874595814339a420b61fbf4cb957af095e
2017-04-18tdf#95992 "Edit" > "Compare Document..." opens dialog that is...Matteo Casalin
misnamed "Insert" Issue is that the caption of the dialog is handled by generic code, which was not designed with comparison in mind. This fix extends the captions that can be used by such generic codes, without modifying the underlaying architecture. Letting callers directly provide caption text might be more versatile, though. The fix is extended to: * Writer Merge functionality * Calc Compare/Merge functionalities which use the same dialog (and thus were also displaying "Insert"). Change-Id: I452b37bf7d0024924c87316cd47572c09b373b65 Reviewed-on: https://gerrit.libreoffice.org/35285 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-18remove sfx2/sfxcommands.hCaolán McNamara
Change-Id: Ic131adc90f2891497623441dd94da2d3401a93e5
2017-04-15Fix typosAndrea Gelmini
Change-Id: I0238202c0dc0380b0e33a9c4567a9513c0afbe91 Reviewed-on: https://gerrit.libreoffice.org/36556 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-14convert style context menu to .uiCaolán McNamara
Change-Id: Ie72a1ecb91ddbbf2230ff2a56e361af98898d730