summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2017-05-08fold SfxPickList::Get and ::ensure togetherCaolán McNamara
Change-Id: Iab68095a9733393b656623ddd6bb8705f7cfda82
2017-05-08cleanup tools/debug.hxx includesJochen Nitschke
with command > git grep -l tools/debug.hxx | xargs grep -L DBG_ | xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d' don't change files in includes/ and */pch Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08 Reviewed-on: https://gerrit.libreoffice.org/37349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07Fix typosAndrea Gelmini
To complete commit 076758857a98 Change-Id: I6424109e3aee8a3236e40168bdd98c725a7afafb Reviewed-on: https://gerrit.libreoffice.org/37306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-07revert OSL_ASSERT changesChris Sherlock
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert sfx2 module away from OSL_ASSERT to assertChris Sherlock
Change-Id: I3facbef60a0d629db8f3028dd1b9f38e8f17e83e
2017-05-06OUStrings: constify, reduce temporaries and scopeMatteo Casalin
Change-Id: I8b5fdf6c36908704dfc90cd77d4f258373354042
2017-05-06Avoid 'else' after 'return'Matteo Casalin
Change-Id: I38daa42f0f764e05c8894f26faad14e947ee77ef
2017-05-06OUStrings: constify and reduce temporariesMatteo Casalin
Change-Id: Id1db5c17a346916a326529b750d2ff0a765af5da
2017-05-05fix spelling, methode -> methodNoel Grandin
Change-Id: I1c7a4e657601e28d9d50d86e24c4e0ba7579b9d4 Reviewed-on: https://gerrit.libreoffice.org/37289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-05Once is enoughMaxim Monastirsky
Change-Id: I0f25f68e3fda79da36921e1b0ac603a6e158fe6f
2017-05-05Defining SID_UNICODE_NOTATION_TOGGLE once is enoughMaxim Monastirsky
Change-Id: I6d63ee582ad5530ecb713dd65350912ee27dc15d
2017-05-04Fix spellingTor Lillqvist
Alternatively, we could build a higher wall. Change-Id: Id2ba91c85557ed6ac9e45ba2d9f51ca0e019cd32
2017-05-04Remove duplicated includeAndrea Gelmini
About commit 34f7e618ddd3399d9e7f3998e25545256255d02d Change-Id: I9142116305dc2cf2ecae66835facadee56ac836a Reviewed-on: https://gerrit.libreoffice.org/37214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-04loplugin:checkunusedparams in sfx2Noel Grandin
Change-Id: Iea88ddd619f10a2a2586ee24edbf07e246dcbb49 Reviewed-on: https://gerrit.libreoffice.org/37191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04Replace all OUString("") with OUString()Arnaud Versini
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03remove empty commentsNoel Grandin
found with: git ls-files | xargs grep -Pzl '/\*\* (\*|\s| )*\*/' Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597 Reviewed-on: https://gerrit.libreoffice.org/37159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02untranslated strings are just stringsCaolán McNamara
removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-02create SfxGroupId based on o3tl::strong_intNoel Grandin
Change-Id: Iaccf16f29b6f4b1a2c712d1e5e2bd0fa4fdb5e71 Reviewed-on: https://gerrit.libreoffice.org/37108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01Remove SlotType sdi propertyMaxim Monastirsky
sdi files have two ways to specify the type of a slot: (a) Put it at the beginning of the first line (b) Using the SlotType property Where (b) have higher priority, and (a) is actually ignored for "method slots" (i.e. the ones that have parameter parentheses, even empty, and therefore get the SfxSlotMode::METHOD flag), which is very confusing. The goal here is to make exclusive use of (a) for all kinds of slots, and eventually remove the SlotType support code from svidl (in a follow-up commit). Change-Id: Ib6654d34e2f8aa8ebd0bd3c41aa2a86e30e9a634
2017-05-01Return values of sdi "method slots" were unusedMaxim Monastirsky
Also expand nested methods. Only diff in workdir/SdiTarget is for SID_STYLE_WATERCAN from sw/sdi/_basesh.sdi which changed the .uno name from WatercanStyleModeOnOff to StyleWatercanMode, to match the name in sfx2/sdi/sfx.sdi (it was forced by svidl to have the same name). Change-Id: Iaeac9f4f10a36cb0b3afe3de2b6def8cd90edc6d
2017-04-30coverity#1405738 Unchecked dynamic_castCaolán McNamara
Change-Id: I15533651b1eff5c00d69f7a1e050997f25addabe
2017-04-30stop torturing std::string in SfxSlotPoolNoel Grandin
when what you really want is std::vector. Also drop unnecassary use of std::unique_ptr and constify a couple of methods. Change-Id: I676ee3460a015b0c7656167c06a569c30c861f98 Reviewed-on: https://gerrit.libreoffice.org/37106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-29tdf#39468: Translate some German comments and termsJens Carl
Change-Id: I5f33f24aa6fd1685e32c9df11855a26ad891eb5b Reviewed-on: https://gerrit.libreoffice.org/37096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-04-29also log the paramter passed as string argumentsMarkus Mohrhard
Change-Id: Id4ebdf875b8ae02b786fd703d2559594acb8b4be Reviewed-on: https://gerrit.libreoffice.org/37081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-28loplugin:salunicodeliteral: sfx2Stephan Bergmann
Change-Id: Iff0e8d0ae884cb45e18e0a84b8fdf6e7fcb5f20a
2017-04-28move builder attributes from OString to OUStringCaolán McNamara
Change-Id: I235188c9a086337b104e600f31a1c81deeca6c17 Reviewed-on: https://gerrit.libreoffice.org/37076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-28loplugin:unusedfieldsNoel Grandin
Change-Id: I67a0372d6982648717651f736c51e447d0b7d6a2 Reviewed-on: https://gerrit.libreoffice.org/37047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27tdf#39468 cleanup source code commentsdennisroczek
* translate German source code comments * remove ascii art * remove bogus source Code comments * remove old StarOffice/Sun internal bug tracker references Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451 Reviewed-on: https://gerrit.libreoffice.org/36005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27another name for a nonlocalized string is a stringCaolán McNamara
Change-Id: Ic4ff92720edd1c10dd6d5eff026e79cb02990005
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26loplugin:unusedmethodsNoel Grandin
Change-Id: If2e1241bbe8a3d17859e3ca076b0f55f25c48ea5 Reviewed-on: https://gerrit.libreoffice.org/36983 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26remove sfx2 bitmaps from .src filesCaolán McNamara
Change-Id: Ibc4261af5f479badd281211e467d2c7b524af3f3
2017-04-26remove sfx2 bitmaps from .src filesCaolán McNamara
Change-Id: I54448567db051f4446c36b16acdda2288b391537
2017-04-26use strong_int for LanguageTypeNoel Grandin
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25vcl: change ErrorHandlerFlags to DialogMaskChris Sherlock
Change-Id: I1959ac97f679d8d719f851f9869962b39a20ded9 Reviewed-on: https://gerrit.libreoffice.org/36841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25remove bitmaps from .src filesCaolán McNamara
and into includeable .hlst files, add them to postprocess/CustomTarget_images.mk to continue only including used bitmaps in icon-theme zips Change-Id: I5c24c3eca93a9c4101bcdcacb0e4b2712133968e Reviewed-on: https://gerrit.libreoffice.org/36941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25clang-tidy readability-simplify-boolean-expr in sfx2Noel Grandin
Change-Id: I388e0160daf6a7359881acb82145460ad5bbbbbf Reviewed-on: https://gerrit.libreoffice.org/36929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25make __RSC a builtin define for the RSC compilerNoel Grandin
instead of randomly defining it in only some of .src files Change-Id: Ifec3920740723d248400f451d717b5288c421b8d Reviewed-on: https://gerrit.libreoffice.org/36832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-24Do not pass a suggested name to GUIStoreModel: it is always overwrittenMatteo Casalin
Change-Id: Iac60c012f05916c5324e1ea8bae142ab329aa4e0
2017-04-24OUStrings: constify and avoid temporaries some moreMatteo Casalin
Change-Id: I965ea920880bb631e108bd963ac1ab21582222ef
2017-04-24Minor optimizations to loopsMatteo Casalin
* Use const value for for checks * Early bail out Change-Id: I8d280a4bfb68da108925ae6b1a3d1b0b827dc3a5
2017-04-24Fix indentationMatteo Casalin
Change-Id: I1c974fb556d5fbe8492356a7471e659035308d0e
2017-04-24OUStrings: constify and avoid temporariesMatteo Casalin
Change-Id: I2e4a36a5ac25d1c44c674eb3f721c974f29b1fd9
2017-04-24OUStrings: avoid temporaries and OUStringBuffersMatteo Casalin
Change-Id: Ibb8493807acd292add892b80839b6f6d3d90a8e9
2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky
And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329
2017-04-23tdf#95845 Use CommandInfoProviderMaxim Monastirsky
And a few unused theUICommandDescription includes. Change-Id: Ic80dbfb91e5e7662723efe0cb4090416994adabd
2017-04-23No usage of the private:commandimage thingMaxim Monastirsky
Change-Id: I8e5c1431f095c875cda6f66f16a03af4bbd1d1fb
2017-04-23Use automatic integer type, with minor simplificationsMatteo Casalin
Change-Id: I08b8370311b11d45ab744875f7ad6b885f318a74
generated by cgit (git 2.34.1) at 2025-02-26 00:55:35 +0000