summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2016-12-19no need to wrap calls to SAL_INFO in #ifdef DBG_UTILNoel Grandin
Change-Id: Ic373a8f145f3f78c3f109e36a9c1dd9156f0dd75 Reviewed-on: https://gerrit.libreoffice.org/32034 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-16-Werror=maybe-unintializedCaolán McNamara
Change-Id: I73eb58e44c00d5e1cfcabe71f2ba946a81a62fa7
2016-12-16lok: Fix state feedback for ToggleMergeCellsPranav Kant
Now it broadcasts "disabled" to disable the command and true/false to tell the status of the command which automatically means "enabled" Change-Id: I3314da77fb2b84d97f64b9832d65791b84fcd7df Reviewed-on: https://gerrit.libreoffice.org/32086 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2016-12-16lok: Sort ascending/descending is enabled/disabled statePranav Kant
... and not true/false Change-Id: Ie9ae6cbf70c1934dda1002deabda23c9f461c8b1 Reviewed-on: https://gerrit.libreoffice.org/32085 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2016-12-16coverity#1397200 Unchecked return valueCaolán McNamara
and coverity#1397201 Unchecked return value coverity#1397202 Unchecked return value Change-Id: I73cc6e3b08e6a44b27be2093ba568d46ebe0659a
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-14SafeMode: s/LibreOffice/%PRODUCTNAME/, small UI changesKatarina Behrens
nouns are written Upper Case only in German also Cancel button looks odd as secondary Change-Id: Id1b051cbb86ab69ea88c7b1da2cda3eb19f063de Reviewed-on: https://gerrit.libreoffice.org/31971 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-12-13That's probably not meant to be a C++ reference to a uno::ReferenceStephan Bergmann
...as introduced with e75f6e549eb825c310d16d11babf0fba5ee7fd7a "sfx2: make SfxClassificationHelper not require a full doc shell". Made CppunitTest_sfx2_classification crash now when dereferencing m_xDocumentProperties in SfxClassificationHelper::Impl::pushToDocumentProperties, when built with a recent Clang trunk build. Change-Id: Id0b7fa0627b9642f748f07d7dfa05353114225fa
2016-12-13tdf#95416 Fix an include for sfx2Adam Kasztenny
This .hrc file was used in multiple places. Change-Id: I603c6d35da2e870d8586f081ccd2672065ade5db Reviewed-on: https://gerrit.libreoffice.org/31928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-13SafeMode: Restart goes into safe mode againSamuel Mehrbrodt
Looks like the XRestartManager keeps all command line arguments when restarting, so it also keeps --safe-mode. Solution is to add a flag file when restarting from safe mode, to prevent going into safe mode again. Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808 Reviewed-on: https://gerrit.libreoffice.org/31913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-12remove useless Mutex guardsNoel Grandin
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51 Reviewed-on: https://gerrit.libreoffice.org/31875 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-09Related: rhbz#1397939 crash with null pSidebarControllerCaolán McNamara
Change-Id: I7627ff30564b2de61669c71dafd15e7b1778b5c6
2016-12-08convert SFX_HINT to scoped enumNoel Grandin
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Ifa46b0eb0fb8f288acbcf19f7090a62c6a1ecef3
2016-12-06Convert TextView to unique_ptrMark Page
The destructor contains reset to the unique_ptr's because it is not clear of the importance of the destruction order Change-Id: Ifbbb4fe8352cb3b50f18cebd60cf00af010c086a Reviewed-on: https://gerrit.libreoffice.org/31673 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-05tdf#97361 remove = None assignments in sfx2 python unit testskerem
Change-Id: Iba3926d1b044ade69e1306941ed70b644dc577d6 Reviewed-on: https://gerrit.libreoffice.org/31602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-05convert FSysStyle to o3tl::typed_flagsNoel Grandin
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05loplugin:unnecessaryoverride (dtors) in sfx2Stephan Bergmann
Change-Id: Ic086a22bccd267824e68df6c963df8da76e6df2c
2016-12-02usageinfo causes one of our more frequent fedora 25 crashesCaolán McNamara
https://retrace.fedoraproject.org/faf/problems/bthash/?bth=17ba9a57f40d5ca29778866a9f96c1c0dfc7593c&bth=2f1801e44e9cb0be2b013624521fb0959dc2c73a&bth=5e8a1e07503f53b13b3a6779084f8b0637aaf5a7&bth=8033013a2ce586bccc23245583fa86ef4a761dce&bth=975271167132418534cb07336601efb5b0c711f0&bth=de75c2ad7917bc889d6307b152f79d34e79ce74d Change-Id: Ie93afa476eca9fdbf7ea17ff0189fbaa493a5531
2016-12-01sfx2: convert legacy DBG_ASSERT in SfxDocumentMetaDataMichael Stahl
Change-Id: Ic340d7226ea3af4bbd6e52c415b32d9be7cd453f
2016-11-30ScTabViewShell::InnerResizePixel must not mark document as modified...Stephan Bergmann
...when merely toggling the edit mode of a Calc document embedded in another document (via "Insert - Object - OLE Object... - LibreOffice 5.4 Spreadsheet"). Interestingly, none of the other document kinds seem to have this problem. (Maybe it's even unhelpful that ScTabViewShell::InnerResizePixel calls SetDocumentModified() at all?) Anyway, pass this inplaceEditModeChange information down there. Change-Id: Iffb24b068419e3608c9f4b5e9645e44e1716aafe
2016-11-30sw: use auto when initializing with a cast to avoid duplicating the type nameMiklos Vajna
Change-Id: Ide7bd0f1f444824b78aa53cfe1db0129cbca1a5d Reviewed-on: https://gerrit.libreoffice.org/31397 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-30Emoji Control: Larger emoji renderingAkshay Deep
Change-Id: Iec51d4e73926cf8203638d2ad013ddfdd47d8ee4 Reviewed-on: https://gerrit.libreoffice.org/31256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-28tdf#101870 - Template manager thumbnail view control needs a borderAkshay Deep
Change-Id: If1773b99aa816b2b45fe16127ff09a646e3702ae Reviewed-on: https://gerrit.libreoffice.org/31324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-11-28These don’t need to be translatableAdolfo Jayme Barrientos
Change-Id: I889c5130bd32f038cb0b45d959b40bf63c0b3a58
2016-11-28tdf#104106 Enable save whenever edit mode activeMaxim Monastirsky
but in case of a r/o medium do "save as" instead. Change-Id: If99602481deb053c2f834b1c7f5d24eb725df9c1 Reviewed-on: https://gerrit.libreoffice.org/31308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24convert SFX_VISIBILITY constants to scoped enumNoel Grandin
* split the position and the flags information * remove unused DESKTOP constant Change-Id: Ibfccb44c7567e89d4527bfd36b3915a73682e6e2
2016-11-24convert SFXWB_ constants to scoped enumNoel Grandin
Change-Id: I63d442e51b7e22093da1c232e1b575bc961c0e69
2016-11-23make strings localizableAndras Timar
Change-Id: Ic74b55b12926a23e9e98308407a88e73dc9cb0c7
2016-11-21Kill the AutoPilotPresentations UNO commandGabor Kelemen
The presentation wizard was removed in bb8040595c9b6f0ccde39e6833f27a50abb891d8 but the corresponding UNO command is still available. Change-Id: I54e676672bb53d0283394a0ebffbe9f94f29d9c0 Reviewed-on: https://gerrit.libreoffice.org/30983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-21add missing depDavid Tardon
Change-Id: I0d2a2c32d99ee11e63a2363f8a17bd4efd72cc22
2016-11-21use the right config depDavid Tardon
Change-Id: I1d387ac566008efd5b0fe7e5e4a4f1bc8462107f
2016-11-21add missing deps on ui filesDavid Tardon
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-18editeng: assert SfxPoolItem::operator==Michael Stahl
Change-Id: Ia6c6f4f5af1e3a803b464ab410558984c3861a65
2016-11-18sfx2: let .uno:SignPDF result in a warning before editing the docMiklos Vajna
Editing such a document is most probably not what you want, help the user to avoid the trouble. Change-Id: I87d52d89e12658675b580b7dc21fb38fe41dd777 Reviewed-on: https://gerrit.libreoffice.org/30955 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-18includes should be at the top of the fileNoel Grandin
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17sfx2: let .uno:SignPDF result in a custom infobar textMiklos Vajna
To make the intention a bit more explicit. Change-Id: I70ce053b9f068a2288e4a05eba55fb3e2451b561 Reviewed-on: https://gerrit.libreoffice.org/30935 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-16make the element names in dumpAsXml match the class namesNoel Grandin
Change-Id: I955facfe3e901fcb76798dab342f96a67d5ac63f Reviewed-on: https://gerrit.libreoffice.org/30894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16new loplugin finalprotectedNoel Grandin
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15loplugin:constantparamNoel Grandin
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14tdf#103897 No space between template previews from Start CenterNoel Grandin
regression from commit 96e9ffa64706f523d67659a20a0ccce6fbd0cb91 (patch) loplogin:singlevalfields in include/ I did not notice that the mnItemPadding field was shadowing a declaration in a superclass Change-Id: I52cf9945da43fa3d1049b624a6b24bc6d974d445
generated by cgit (git 2.34.1) at 2025-02-28 20:58:05 +0000