summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2017-03-08Simplify GetStateCache callStephan Bergmann
Change-Id: I527d8112f7cf0e4fbc6380484be0c6704f3dfdd4
2017-03-08No need for extra heap allocationStephan Bergmann
Change-Id: I69435ff2be66f8b2ed879bdf7998bd8145ef59b4
2017-03-08valgrind: fix leakCaolán McNamara
Change-Id: I49a9a03ef59bca5a5c43d2835e6c4f1cbf0cfab8
2017-03-08loplugin:loopvartoosmallStephan Bergmann
Change-Id: I788afd92bb404d8faf96b631d2e7c6f869e49c2d
2017-03-08make SfxGetpApp just get and move GetOrCreate to the peripheryCaolán McNamara
Change-Id: If3b22635e46dbccf0fad101f51bb653cbbcd3a32 Reviewed-on: https://gerrit.libreoffice.org/34957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-07shouldn't need these SfxGetpApp as it will already existCaolán McNamara
SfxGetpApp will get or create SfxApplication in normal use we start SfxApplication via SfxGlobalEvents_Impl ctor theGlobalEventBroadcaster right from the start in Desktop::Main Change-Id: I5fec2dfb79c8bc322266048603252a9aa93a883f
2017-03-07Notebookbar: don't show unnecessary separators in the popupSzymon Kłos
Change-Id: I89d11e2859676696e7bc0751ae9e71e5ae939a79 Reviewed-on: https://gerrit.libreoffice.org/34945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-07only one use of GetLastSaveDirectoryCaolán McNamara
which is to get its value and do a const_cast dance to save and restore its value which is a strange thing to do just for one obscure dialog when no other use of the save/load dialogs does this Change-Id: I7700d7ed738d578869284d415197de06167001b5
2017-03-07can use a reference hereCaolán McNamara
Change-Id: I3e9599e92679a66cae410090b5d17651a3698cce
2017-03-07Add Tooltips for emoji toolbar controlAkshay Deep
Change-Id: I93d9fb1af42d83c7f7f518a1441f4666fd7ee30a Reviewed-on: https://gerrit.libreoffice.org/32231 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-07remove dead codeJochen Nitschke
was deactivated in 2010 by commit 9334f7757330fdd113d37b3faed728e56e6330c8 Temporarily disable the extra ACL check. Change-Id: Ia9d2b7f55285e78f0737bf798b627740ccb11979 Reviewed-on: https://gerrit.libreoffice.org/34937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06convert ScrollingMode to scoped enumNoel Grandin
Change-Id: Ice1628ba09998be455fd6a77a044cb403235d462 Reviewed-on: https://gerrit.libreoffice.org/34914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06make use of the SfxItemSet::GetItem<T> methodNoel Grandin
Change-Id: I8201429993129b019a6dd51c203a9f8dcbb2253e Reviewed-on: https://gerrit.libreoffice.org/34867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06templatize HTMLEnumOption::GetEnum methodsNoel Grandin
And consequently fix bug in htmlfld.cxx in the RES_DOCSTATFLD/SwDocStatSubType handling, where it was updating the m_bUpdateDocStat fields by comparing the wrong enum variable. Change-Id: If9a68699a9d375ace120a3bf4f4bf4d4ae20a8e0 Reviewed-on: https://gerrit.libreoffice.org/34857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03lok: Listen to change tracking related commandsPranav Kant
Change-Id: Ieafd31342b356d7e95e4321cc49580b57f32e5be
2017-03-02Fix typosAndrea Gelmini
Change-Id: If5e709c9d6e3a4fbb568bdc261cccd214dd0cbd3 Reviewed-on: https://gerrit.libreoffice.org/34784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-01Correct indentation of try blockTor Lillqvist
Change-Id: I32ca961ebb4393e483bab12a6c69ab4c2016cc3f
2017-02-28loplugin:unoanyStephan Bergmann
Change-Id: Id50b15bbb9f8c62ac5258358431ff6ce0e7584d1
2017-02-28don't have to create SfxApplication if none existsCaolán McNamara
Change-Id: I312f00e8b2956470eaa496abfa2687c296f256ae Reviewed-on: https://gerrit.libreoffice.org/34717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-28might as well move append 'usage' into the msConfigPath from the startCaolán McNamara
Change-Id: Ie8a15f1a20621ebdd00ab4ed195495e0acd111a5
2017-02-28Revert "move append 'usage' into the msConfigPath from the start"Caolán McNamara
oops This reverts commit dc1c69a4efe9368a1f4fae4bc11325485bcc0772. Change-Id: I5fb9016040636fb44d4337567a6b894bfe16f503
2017-02-28might as well move append 'usage' into the msConfigPath from the startCaolán McNamara
Change-Id: Ic3e141d91607f8e34ff4a74cd1ae3276e42934e7
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28Run macro:// via LOKitKatarina Behrens
Change-Id: I54d3c734d86d4b44e1dfe1ad7728e2f51cd26d53 Reviewed-on: https://gerrit.libreoffice.org/34538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-27tdf#105829 Infobar design, tdf#102785 Font issueheiko tietze
Only one constructor to append an infobar Colors defined at one place in infobar.cxx based on InfoBarType Icons as an additional attribute of the notification Change-Id: I4dc85c2b4ef0b7eafc139290b3b4ee21636da6ec Reviewed-on: https://gerrit.libreoffice.org/34426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-02-25check for SfxApplication::Get means SfxGetpApp is just SfxApplication::GetCaolán McNamara
Change-Id: I12953d93c81bd60ad27284ac0b62c4435ac9e390
2017-02-24vector::data seems more natural than &vector::frontCaolán McNamara
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-24rtfrow-crash.rtf throws a o3tl::divide_by_zeroCaolán McNamara
from writerfilter/source/dmapper/DomainMapperTableManager.cxx Change-Id: I69fca8376166850cdedbc7c2b3908d7336e8bed9
2017-02-24don't have to create SfxApplication if it doesn't already existCaolán McNamara
Change-Id: I3ade4e2c2513f334217a85c676ada93c5ed683ff
2017-02-24Notebookbar: Better resize supportSzymon Kłos
Change-Id: I0bb5a5600be60a68e53132f2c3c42f79c958b2b3 Reviewed-on: https://gerrit.libreoffice.org/34491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-23tdf#101652 No infobar when doc attr is readonlySamuel Mehrbrodt
One can set the a document attribute to open the doc read-only. In this case the read-only infobar should not be shown. Change-Id: I92b78dc3e20ccf0d258cdf3e4a79530f87a2e311 Reviewed-on: https://gerrit.libreoffice.org/34581 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-23Simplify logicSamuel Mehrbrodt
Change-Id: I4d2e94bb050f163cc691fda90be9dccbd2ca5e5f Reviewed-on: https://gerrit.libreoffice.org/34580 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-23loplugin:unusedmethodsNoel Grandin
Change-Id: I5a72ee666e71b4c5c8f43d327aa7e8eb62d1e51b Reviewed-on: https://gerrit.libreoffice.org/34537 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21Fix typos/translations, following 04644956e53dAndrea Gelmini
No automatic tools Change-Id: I3a6d18760f90c4ee02b9380758f97f6fca6c4428 Reviewed-on: https://gerrit.libreoffice.org/30874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:subtlezeroinit: sfx2Stephan Bergmann
Change-Id: I1a880bb4df7866b1185ef862ff84693c44a73385
2017-02-21sfx2: fix incorrect debug outputPranav Kant
Fallback from 9351353b63886f494782f28f5400f5d71d22bcbd While at it, add one more such statement in Execute_ Change-Id: Ibebc6f007542751718b53ed978ee52c300d14439
2017-02-20Minor capitalization issuesAdolfo Jayme Barrientos
Change-Id: I2b817859e4e6e0ea6dd15b0052da2370a262c6a4
2017-02-21Use module name when getting labelsMaxim Monastirsky
Change-Id: I1d5196e1ca888dfb11d5bd6ef4676937dce49fdc
2017-02-21tdf#95844 Refactor CommandInfoProviderRohan Kumar
Instead of a singleton, CommandInfoProvider should just be a set of static methods. Change-Id: I16d4406e361a72f013d78f18d6bd0ae20c0cc5e9
2017-02-20tdf#74739 removed 'PasteOnly' from Tools->customize->keyboard tab->editpv2k
Change-Id: I4693b09fa9b16cd5eec60a43c4653aef81860f1d Reviewed-on: https://gerrit.libreoffice.org/34245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-20Revert "tdf#105566 Close Infobar after clicking action button"Samuel Mehrbrodt
This reverts commit 057990769325b2f3dd2f198a9bf76a0a85447bb7 as discussed with UX. Change-Id: I24c2a0efc0c866f895a00121f083eb526642650f Reviewed-on: https://gerrit.libreoffice.org/34473 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-20lok: listen for DeleteAnnotation state changesPranav Kant
Change-Id: I2ea0d237cbbfd912b012ed400a328bfb6546cdfb
2017-02-19tdf#103355 Hide Notebookbar during slide showSzymon Kłos
Change-Id: Ie3e1b9f9dfc109ecb48cd384972dfa5a5118c3fa Reviewed-on: https://gerrit.libreoffice.org/34401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-02-19Typos: mainly translation remnants of Objekt instead of objectJulien Nabet
Change-Id: I84c488a4a0fa96f85158d34035a16aa5e10c7c21 Reviewed-on: https://gerrit.libreoffice.org/34418 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Fakabbir Amin (Aeimi) <fakabbir@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-16convert FrameListAnalyzer::EDetect to scoped enumNoel Grandin
Change-Id: I4e1bd449c4ad60ec810ef52c73d6c6ff3dd313ee
2017-02-15Some simplifications, using UNO_QUERY_THROWStephan Bergmann
Change-Id: Ida366e40ade98443019d3c312ae19864f93c9e5e Reviewed-on: https://gerrit.libreoffice.org/34258 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-15remove unused PREVIEW from SfxObjectCreateMode enumNoel Grandin
Change-Id: Idf930f768c978ac8aa53527f6ddb8864d0fdec1d
2017-02-15remove unused OBJECTBAR from SfxChildIdentifier enumNoel Grandin
Change-Id: I45b02055d18ca201341c61a1558ee5b0c58d7ba8