summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-02-04*_AppDispatchProvider_get_implementation cannot bypass XInitializationStephan Bergmann
...as SfxAppDispatchProvider implements new-style service css.frame.AppDispatchProvider that doesn't declare any non-default ctors (which looks broken, though) and old-style service css.frame.DispatchProvicer. (And fix the test code to pass in meaningful XInitialization arguments.) Change-Id: Ifcc32d17f6b96ade2acc40ccdb60f7bad2d503a4
2014-02-04startcenter: fdo#72469: Thumbnails also for other file types than ODF.Jan Holesovsky
Change-Id: If905b2f3e51adf7e64df9385ede74368acd11771
2014-02-03fdo#72338: startcenter: Show busy mouse pointer when starting apps.Jan Holesovsky
Change-Id: I8f254419ea7bb4e3e9835bd9fab8229ed89cd0e9
2014-02-03startcenter: Don't cut off the thumbnails.Jan Holesovsky
Change-Id: Ie5ad5f5be48aa873df94a31e980aaabc4ac24868
2014-02-03thumbnails: bSigned is always false, nobody uses the signed sign, kill it.Jan Holesovsky
Not killing the icon itself, still seems to be used by on Windows in the shell code. Change-Id: I21c3b1ae6dfc65b6852659d6157b02324a485774
2014-02-03thumbnails: Provide the size as a default parameter.Jan Holesovsky
And increase it consistently to 256 pixels. Change-Id: I123e11d597269d7e43298504f1dbd0098c9b0149
2014-02-03thumbnails: Consolidate code.Jan Holesovsky
There were 2 copies of the thumbnailing code; consolidate that to one copy directly in VCL. This kills the attempts to do alpha channel that used to be in the VCL copy of the code - it was producing wrong results, the bitmaps ended up empty. Change-Id: I415c410c287a95e75293bdcba5d71083d1d01dc1
2014-02-03Remove needless SAL_DLLPRIVATE annotationsStephan Bergmann
Change-Id: I5794e7ca922941e2d17a89cbaebfb2c6722519f8
2014-02-01fdo#64337 Do not show empty findbar in startcenter.Robert Roth
Using the shortcut for search on the start center displayed an empty toolbar on the start center. This commit adds a check to see whether the command to execute in the startcenter is FocusToFindbar, and if it is, it skips executing it. Change-Id: I0835e87d4a1eef0fc9ff17c184b531592b3e2d5a
2014-01-31Kill one indentation level.Jan Holesovsky
Change-Id: I5a5d98bb2f2d0749fb9113423f5663780ecf3520
2014-01-31fdo#71763: F6 key moves focus on this trip: Menu -> Sidebar -> Thumbnail viewZolnai Tamás
Sidebar and thumbnail View are actually not separate windows but F6 key traversal should simulate it as they would be. Define a new getfocus flag called GETFOCUS_F6 which means focus were grabed as a result of pressing F6 key. Use this and other two (GETFOCUS_FORWARD, GETFOCUS_BACKWARD) flags to indicate the focus were grabbed along subwindow relation (define a new ImplGrabFocusToDocument method with a flag parameter on the analogy of GrabFocus() <-> ImplGrabFocus()). Handle F6, Shift+F6 inside BackingWindow as it would have two subwindow (sidebar and thumbnail view). Plus Ctrl+F6 -> grab focus to the thumbnail view. Change-Id: Ie43d761e7cb0269afb79481a81947a4b96e1dde0 Reviewed-on: https://gerrit.libreoffice.org/7486 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-30fdo#73869 fix highlight RTL Problem at the StartCenter window.Faisal M. Al-Otaibi
Change-Id: I744d8f85c6e4c555ef8916281ebdc709fe6ddfa9 Reviewed-on: https://gerrit.libreoffice.org/7719 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30fdo#63154 Removed unused solar.h ref. in linguc., sfx2, starmath, svl and svxAlexandre Vicenzi
Change-Id: I241661119371b75804fcf9215ff5e5da2a5b9265 Reviewed-on: https://gerrit.libreoffice.org/7732 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.Matúš Kukan
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-30Introduce com.sun.star.ui.theWindowContentFactoryManager singleton.Matúš Kukan
Change-Id: If979db945b2f5e50e146fdadafd1559530c50122
2014-01-29Introduce com.sun.star.ui.theUIElementFactoryManager singleton.Matúš Kukan
To replace single-instance com.sun.star.ui.UIElementFactoryManager service. Change-Id: I4262909c4396e3907d271a56696a06903168a58d
2014-01-29Introduce com.sun.star.frame.ControllerFactory singletons:Matúš Kukan
com.sun.star.frame.thePopupMenuControllerFactory com.sun.star.frame.theStatusbarControllerFactory com.sun.star.frame.theToolbarControllerFactory To replace their single-instance service variants. Change-Id: I00586d0d61e63f9482cb659071e88aa9cf02d5b5
2014-01-29bool improvementsStephan Bergmann
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-29Fix the error of shutdownicon.cxx.yangzhang
Change-Id: I91d62edd72e884a0139d3aca46aff0db88b202be Signed-off-by: shaochunfang <shaochun@multicorewareinc.com>
2014-01-28coverity#1019411 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: If7cc1cd9be357c9b9bb82bfffe3f560ac29e61d9
2014-01-28bool improvementsStephan Bergmann
Change-Id: I4a09bffccc0049d81ea3113e79184f64b026a4ba
2014-01-28Fix apparently broken OSL_ASSERTs (that would have never fired)Stephan Bergmann
Change-Id: I10c5152ca09be49625f960e6dc3228ec2284ce58
2014-01-28Introduce com.sun.star.frame.theUICommandDescription singleton.Matúš Kukan
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28coverity#440971 Dereference before null checkCaolán McNamara
Change-Id: I2bd6c0cffef5bf2e2d05781d4ec151f11d517cb6
2014-01-28coverity#440811 Dereference null return valueCaolán McNamara
Change-Id: Iccf2f6dd757fe8d14a2f68a0492ea898d2f95490
2014-01-28coverity#440882 Logically dead codeCaolán McNamara
Change-Id: Ia54cffe6368d320c717b941b4f3df036f924c343
2014-01-25coverity#440744 Dereference after null checkCaolán McNamara
Change-Id: Id9ab2ffde8eb82e49164350d1703e4d93f96663e
2014-01-25Related fdo#65826: Set StartCenter's min width to display one column of docsZolnai Tamás
If there is document to display. Otherwise set minimum to the width of greating background text. Updating minimum size is needed only when the list is cleared. Change-Id: Ic089571fd21d5ab9ded0f4cde7e1aa72fd508d32
2014-01-24Introduce com.sun.star.task.theJobExecutor singleton.Matúš Kukan
To replace com.sun.star.task.JobExecutor single-instance service, incorrectly converted in 748aa84e9808ad31c6ff6b71459525c82de10e58 [including changes by Stephan Bergmann <sbergman@redhat.com>] Change-Id: I4cea2c63a20b5b22f6e1f822fb35fcc4d0397687 Reviewed-on: https://gerrit.libreoffice.org/7609 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-23coverity#440721 Dereference after null checkCaolán McNamara
Change-Id: I1a6d6f5d83f3b6c5f8d8d19b003f2e4f6976d6e9
2014-01-23SfxNoLayoutSingleTabDialog not needed anymoreCaolán McNamara
all single tab dialogs are .ui enabled now. So now we can remove SfxNoLayoutSingleTabDialog and merge SfxSingleTabDialog and ~SfxNoLayoutSingleTabDialogBase together Change-Id: If0acc792d85b7d399572257d7e9b0e12993ba3fe
2014-01-23Bin useless as96863, mb93783, mv76033 verbiage from SAL_INFO outputTor Lillqvist
Change-Id: I58b6c311e9f13e433468863e639467428e5b268e
2014-01-23Use the "sfx" log area consistently in sfx2Tor Lillqvist
Change-Id: I497d2d93e1a1819ff709c94007ae98f5ef312e77
2014-01-23Use assert() and SAL_WARN() instead of DBG_ASSERT() and OSL_FAIL()Tor Lillqvist
Change-Id: Id3be30bc95325e8f18cf8cb55da2217984a26035
2014-01-22convert more SvStream::operator<< callsNoel Grandin
.. to more explicit SvStream::Write* calls This was done using another run of the clang rewriter, and then a lot of hand tweaking to fix all the places where the rewriter did not play nice with various macros. Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18 Reviewed-on: https://gerrit.libreoffice.org/7494 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22Introduce static inline cppu::acquire(), and make use of that.Jan Holesovsky
This is much better approach compared to the callback function, as it allows passing arguments to the c++ constructor directly, while still allowing some additional initialization after having acquired the instance. Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22bool improvementsStephan Bergmann
Change-Id: Iab6343064ad002bd11660aeb8c88c54562109cbc
2014-01-22bool improvementsStephan Bergmann
Change-Id: I5f90d0acff506955d1cc5a44944311012f3b04b9
2014-01-21Change _get_implementation()'s not to do initialization directly.Jan Holesovsky
Many of the initalizations (in eg. framework) have to be done on an acquire()'d object, so instead of doing the initialization directly, return the initialization member function back to the createInstance() / createInstanceWithContext() / ... and perform the initialization there. As a sideeffect, I belive the calling initialize() from servicemanager is not that much a hack any more - whoever converts the implementation to be constructor-base has the choice to provide the callback, or still initialize through XInitialization, where the callback is preferred by servicemanager when it exists. Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-21fdo#65826 and fdo#73605: set a minimum size to start centerZolnai Tamás
This minimum size calculated like this: width: sidebar optimal width + width of text appearing in the thumbnail view when no recent document is available. height: menu width + optimal width of GtkBox containing buttons. Change-Id: Ic1fd6e33a1ec93e61318af02c09ee88909a76cf4 Reviewed-on: https://gerrit.libreoffice.org/7505 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21fdo#72639: send proper ACTIVE_DESCENDANT_CHANGED eventsJacobo Aragunde Pérez
At ThumbnailView::SelectItem the piece of code in charge of the accessible events related to selection change was mistakenly using the accessibility helper class ThumbnailViewAcc instead of ThumbnailViewItemAcc which is the proper one for managing the events related to ThumbnailViewItem objects. The methods FireAccessibleEvent and static getImplementation had to be added to ThumbnailViewItemAcc to provide the full functionality required. Change-Id: Ia5ffb24c920f3c48854021700819be683c979411 Reviewed-on: https://gerrit.libreoffice.org/7551 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky
Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
2014-01-18Unify ctor functions for component implementations.Matúš Kukan
There is no need to use different styles for writing the same thing. It also makes it easier in future to use search & replace. But of course, there are also some more complicated functions. Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
2014-01-18Window::PreNotify should return boolStephan Bergmann
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17bool improvementsStephan Bergmann
Change-Id: I9f5564100aa64ff4940dd93a81ff5a8d8edc7a07
2014-01-17Be explicit when using bool as integral value (as Link return value)Stephan Bergmann
Change-Id: I3b345be909ed2cb93cd0d478af4b26c9909d2726
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17Remove unused includes and sfx component prefix.Matúš Kukan
Change-Id: Ia6c1db331b5b4db04c46b75b2058bf2f1369070b