summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2021-06-18tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
Rename ::StateChanged methods using SfxItemState to allow better analysis of SfxItemState/SfxPoolItem usage(s), discussion see tdf#130428 comment 30 Change-Id: I736be0160ad7a9b7882c1c8a4cc05d9396ee3305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117366 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-18Add Last 4 UNO Commands To CrashReport DumpGopi Krishna Menon
Adds last 4 uno commands executed in CrashReport to assist in investigating the crashes Change-Id: Ib7307ffc62d6d51d52f9d5e7fabefc2eaf858e5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117388 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-18Add Active Sfx Object Name To CrashReport DumpGopi Krishna Menon
Adds Active-SfxObject field in CrashReport to assist in investigating the crashes Change-Id: I08637a66ae95977e7afe4f5dce634b46c928a423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117318 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-18VCL graphics rendering tests that a run on LO version changehomeboy445
This commit includes the implementation of graphics rendering tests which would be automatically triggered at first installation or upgrades of LibreOffice. These tests check the graphic rendering interface of LibreOffice by drawing and checking various graphical rendering tools (eg:. by drawing lines, polygons etc.). After the successful completion of tests, their results are stored in the user folder for future reference. Change-Id: I59c94b57a1f3f3a9cba55af1067a9702b6da98d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116779 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-17fix potential write-after-free in RecentDocsViewNoel Grandin
spotted while running a valgrind session Change-Id: I32c55ae2cc4b2d5abedca24c2f747aaa4183b3d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-17use string_view in the Translate APINoel Grandin
Change-Id: I0bb0ea9d39ed623928060ffd3f2e2bc36ba33209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-16Add Active App Name Field To Crash ReportGopi Krishna Menon
Adds a Active-App field in Crash Report to assist in investigating the crashes Change-Id: I30e5f307045b8e5def9986447551f39e70b94edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116786 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-15Update TSCP config for pt-BROlivier Hallot
Sample file updated Change-Id: I5fc8e6f65d13e44e8ebaacbb049cf997e839241f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117267 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-15remove some unnecessary LanguageType copiesNoel Grandin
Change-Id: Iec4374627c931ccecf05a712682ed18ef90bf359 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-14only one of the radiobuttons in a group should be activeCaolán McNamara
Change-Id: I0475bdd0633b54a644e205628577fac18a3af974 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-13Assert on valid order of which ids in ranges on SfxItemSet creationMike Kaganski
This allows to make sure we actually use sorted which ranges, and then it's safe to call SfxItemSet::MergeRange when needed. Also this change relaxes the previous requirement that ranges must be separated by at least one; this allows to have adjacent ranges, like in RES_FRMATR_BEGIN, RES_FRMATR_END-1, RES_GRFATR_BEGIN, RES_GRFATR_END-1, where RES_FRMATR_END is equal to RES_GRFATR_BEGIN. Allowing this makes possible to (1) self-document the ranges, so it's clear which ranges are included; and (2) be safe in case when these constants would change, so that the one merged range would not unexpectedly contain everything inserted between RES_FRMATR_END and RES_GRFATR_BEGIN. Change-Id: Iaad0f099b85059b3aa318a347aa7fbd3f6d455c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116909 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-11Simplify Sequence/vector initializationsJulien Nabet
Change-Id: Ib02e25b4600666185cf0f8d0cc8d5c64186789c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117064 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
Another place where SfxItemState was used as placeholder Change-Id: I54e549db50b7485024a305eb39fda848cbed6b78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117036 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2021-06-11tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
Another place where SfxItemState::UNKNOWN was used as placeholder Change-Id: Ie2757e8356bfea7010b0442d72ef7865cbb18d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117034 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2021-06-09Simplify Sequences initializations (sfx2)Julien Nabet
Change-Id: I1384dd80e910ba1c55ec7481ab481bc48740fc5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116937 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-09-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann
...after e79e8117dcc7475d8d90afeaaac9eb7050ff244e "loplugin:unusedfields in sfx2" had removed the (only) read of sPattern Change-Id: I2413af34b15dec45c46df0ffabf1d910f92dd695 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116822 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-08set entry to expand and combobox to fill its assigned spaceCaolán McNamara
Change-Id: Ia70513d3d6d6fa5ce69936231202f3a52fc56fe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116857 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-08resave with latest gladeCaolán McNamara
Change-Id: Ia2aa23dfa82728ac38e18bcc15e20ad72b35aa6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-08Resolves tdf#131817 - Option to globally switch toolbar locking on/offHeiko Tietze
Reverts 6993d5d0f1079fe720a7da004b70b57361c99fc6 and sets Locked in GlobalSettings to true New UNO command ToolbarLock to toggle the state added to the toolbars menu Change-Id: I246280b2b7930f2bf686e6fc26383da4799b5028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115797 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-06-08Remove SfxItemState::READONLYArmin Le Grand
As I experimented with redesigning the whole Item/ItemSet/ItemPool paradigm, I alredy checked that SfxItemState::READONLY is not used (and no one really knows what it should do or stands for). Since a removal of complexity is needed to get forward with that redesign and I already made some experiences in branch item_refactor2, I propose to remove this state. It is not really used (gets never set). It is mirrored/used in the UNO API in css::frame::status::ItemState as 'READ_ONLY', but also not used in the office's code. ItenmState itself is used in three places, but all set the Item involved by using a SfxVoidItem to state SfxItemState::DISABLED, which I described in ItemState.idl. This means that no state of READ_ONLY in UNO API is ever imported to office code as DISABLED state at all, so not used. I also marked it as deprecated in the *.idl file. I think - including the experimenting in the mentioned branch - that this is safe for now. I already run a full 'make check' on the changed stuff. Change-Id: I8c15cf7b4f803076ecaaea67659f6e022ac7ef70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-07tdf#132667 - Grab focus on the last inserted propertyAndreas Heinisch
On removing/adding custom document properties, grab the focus on the last empty shown name box. Change-Id: Ifd66566d4ae9fa57b9f1a9aae5f9cb93dbb74070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115872 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-06-07Resolves tdf#142513 fix zoom caller handlingJim Raykowski
Calling ZoomPlus has always executed shell SID_ZOOM_OUT case handling. ZoomMinus, which replaced ZoomIn, does SID_ZOOM_IN case handling. This patch changes ZoomPlus to do SID_ZOOM_IN case handling and ZoomMinus to do SID_ZOOM_OUT case handling and makes appropriate changes required by these name changes to provide expected zoom results in all module shells that have handling for these calls. Change-Id: If148f4f7866bfc8fc6452ad1c1dace723a125ef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116287 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-06-07Resolves tdf#140360 - Provide option to turn off sidebar's minimum widthHeiko Tietze
Boolean option Sidebar:General:MinimumWidth introduced defaulting to true; if false the sidebar width is under full user control Change-Id: Iab1413a83adf90461feb5d6416aad174439392ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116715 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-06-06enforce indicator consistencyCaolán McNamara
so there is either a standard indicator shown or one of a small subset of named icons a) adds an indicator to show the MenuButton provides a dropdown to the spelling dialog when there are multiple user dictionaries the word could be added to b) use open-menu-symbolic instead of gear icon for the sidebar menu Change-Id: If4f0842fb0f805dde45e375061f23d2aaea0990c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-06use open-menu-symbolic for menubutton gear menusCaolán McNamara
https: //wiki.gnome.org/Initiatives/GnomeGoals/GearIcons Change-Id: Ia95451f950728c4174887a042a6666e1dd7cc1ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-04gtk4: undo bootstrapping conditional page removalCaolán McNamara
now menubutton is available again Change-Id: If3112cde3e5231245088740ab0217a0e61b3579c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116733 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-04lok: Interaction handler for FilterOptionsmerttumer
This will enable Text Import Dialog to be executed before the document is loaded Change-Id: I263e69f0739f4971f4c4eec032ebf22ffbdeebb7 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114638 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116294 Tested-by: Jenkins
2021-06-02uniformly remove label-fill from GtkExpandersCaolán McNamara
Change-Id: Ife68cef7eeab0010c4d233c81e3bee808c2c1c28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116615 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-01GetSlotServer can modify pImpl->pCachesMike Kaganski
Change-Id: I39810a7f827f3624e26763f3e81eae2c64e656e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116455 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-01tdf#142243 actually call toLower not tuUpper when calling toLowerTomaž Vajngerl
But it doesn't have an effect as both uppercase or lowercase work as long as it is used consistently. Change-Id: I898cdc7946732f1a504d902f38ae84565c95a0c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116430 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-31fix leak in redaction dialogNoel Grandin
Change-Id: I1e918259757021a7c702196be73468d91b244e61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31flatten SfxDocTplService_Impl a littleNoel Grandin
Change-Id: Id3344141e4b65855717d4d480ab1a3a498fa2a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31tdf#142243 HUD - Use XCharacterClassification to convert caseTomaž Vajngerl
This should use international case conversion, not just ascii one that was used before. Change-Id: Id01d3d0d30a846f02f97d081491b0de2c0d6ffef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116419 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-30no need to allocate this separatelyNoel Grandin
an empty vector is only 2 words Change-Id: Ie9b6b8e97a9781916250cdc1b6b29406fe27d6b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116401 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-28Missing includeMike Kaganski
Change-Id: I7a0c1d49da993f5f9da80df5cb6b0667775c1261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116162 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-28IsDisposed->isDisposed in sfx2Noel Grandin
Change-Id: Ie717cd4ad051facdf2bcee3e521cd6e42f59003f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-28no need to allocate SfxStyleFamilies on the heapNoel Grandin
Change-Id: Ibedb36dec14c61927ef594ddf47fda94728530a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116319 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-28no need to allocate these SfxItemSet on the heapNoel Grandin
use std::optional where the code needs to control the lifetime of the object explicitly Change-Id: Ia550ce051360f68911abc68c945a97d62a637b06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116291 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27add missing xmlns:loext to example_sl-SI.xmlCaolán McNamara
added to example.xml by commit 71ee09947d5a71105d64fd225bb3672dfa7ce834 Date: Tue Sep 19 15:37:04 2017 +0200 TSCP: add advanced classification dialog but not to example_sl-SI.xml Change-Id: I8aa46554867db8c51bd118b6cc87e649b922cdfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27tdf#47065 Add new file open UI options and implement a new threadMatt K
Add new UI options when opening a locked or non-writeable document to allow the user to be notified when such a document becomes editable . If the user selects "Notify", then that document is added to a list of open documents to be checked by a thread every 60 seconds for read/write access and whether lock file is available/obtainable. If access is allowed for a document, then show UI dialog to the user asking to Reload that document. If Reload is selected by the user then that document is reloaded with read/write access. The checking thread is spawned only once no matter how many "Notify" documents there are. The thread is spawned if not already running when a new "Notify" document is opened, and it terminates when all "Notify" documents have been closed or the application terminates. Also update badstatics clang plugin to ignore new global variables introduced. Change-Id: I7555ce6f5df79c2c87216e0129ef3b2883c7d921 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-27expand frames horizontally to fitCaolán McNamara
Change-Id: I2c2fc8a726c279583ef9aa3d51eebe7f28164684 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116224 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27resave with latest gladeCaolán McNamara
Change-Id: I91a3836e02cf3ed1cfdcea93f8812dcecc43afcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26log what page id is missing if this happensCaolán McNamara
Change-Id: Ie279350446ef1892d5bb145e58b9f0d9dba683f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116206 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: reenable NotebookCaolán McNamara
Change-Id: I5342e5ef35f9d270d8ac51c3d696beddc8b67529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26don't need always-show-image if there's just an image and no textCaolán McNamara
Change-Id: Ic3a1aad525af39b723e71f579fba40157cb15ac7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26fix leak in SfxAutoRedactDialogNoel Grandin
Change-Id: I5ebfe5eba77de3380e991ced26f396821613b7f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116189 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-24fix leak in SfxTabDialogControllerNoel Grandin
Change-Id: I98a459d0b6173d367bbe596bcbf25501612ff032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21fix leak in some testsNoel Grandin
this situation only really happens during shutdown, when some of the app events are dropped Change-Id: If327daf1be243a603669f624b49917a73ddfd0fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115909 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-21tdf#132042 fix nItem id when creating regionVert D
Change-Id: I5f2d00dd58580922119b30aafce6695bacb6e2f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113331 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-07 18:26:47 +0000