summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-05-21speed-up writer conversion in headless modeTomaž Vajngerl
Change-Id: Ie5ccd62608c0643e3c8f019aea136ba74b282274
2014-05-21cp#1000072: Skip styles import for external link cache documents.Kohei Yoshida
This reduces external link update time by 10%. Change-Id: Ic14d9ea7530818f839330a2004f6aa67ef1e831e
2014-05-21Use varying aElement nameStephan Bergmann
Change-Id: Idc135ef5031a01961cc18d897a734b598bc833f4
2014-05-20Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18Julien Nabet
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-20enhance pass-by-ref plugin to detect large argumentsNoel Grandin
Detect arguments larger than 64 chars passed by value. Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-19Fix overriding exception specificationStephan Bergmann
Change-Id: I6eb46f1ffccc1d98b1a1485486cbc355ce296cd3
2014-05-19fdo#78536: sfx2: remove (likely) accidentally duplicated callMichael Stahl
It looks like commit dda842bec338efb06457551136678340d0718807 wanted to #ifdef this Execute_Impl() call but somehow duplicated it. Change-Id: I745e16cb0be19cf38eb70dd261204c879aa6986e
2014-05-19fdo#78536: sfx2: template dialog: make the am-i-dead-yet check reentrantMichael Stahl
In the fine tradition of our enterprise-grade code base, this lets the check in SfxCommonTemplateDialog_Impl::Execute_Impl() do an early return if the "this" instance has signalled its untimely demise even if there are multiple calls of Execute_Impl() on the stack; extending the scheme with further epicycles to make it work if the Execute_Impl() calls happen on 2 different threads is left as an exercise for the interested reader. (regression from bcc52fb2ebdf77a1cc089857775fd742085b45b6) Change-Id: I1d9f0d82bf6d9f5da8f9bd2be57d01937d71fd26
2014-05-19Register OpenGL windows to ScGridWindow upon file load.Kohei Yoshida
Change-Id: I6fdce232ef41079f20a983dc72da032196078858
2014-05-19remove commented out lineThomas Arnhold
Change-Id: If80632525d88ed889291913b172fa3cb2a3ac956
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19fdo#78742: SfxFilterMatcher: respect requested document service if setMichael Stahl
sfx2::DocumentInserter::CreateMediumList() creates a SfxFilterMatcher that should match Writer filters only, but actually Calc filters may be returned; check that the document service matches. (regression from 3da8f3680556e0163f660a0a159930337c8c32ff) Change-Id: I6208d38c1110355105aa5d1ffa1b57142193a4d7
2014-05-19valgrind: memory leakCaolán McNamara
Change-Id: Ica30df49caf79117bbce36ec461ec5ef37bef20c
2014-05-19Resolves: #i86528# use the module manager to identify the context...Tsutomu Uchino
for addons menu merging (cherry picked from commit 2aac0070dbef6c1ad7eeccf7d4015cdcbffe067e) Conflicts: framework/source/classes/menumanager.cxx framework/source/fwe/classes/addonmenu.cxx framework/source/uielement/menubarmanager.cxx include/framework/addonmenu.hxx Change-Id: I3b606671db3a4c6ba8ed2b850e01e1ac91db7581
2014-05-17fdo#78782 startcenter: open document on enter keyMaxim Monastirsky
Change-Id: I501dbd6a0f4e5323a003afbb19707aad67897cd0
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-16valgrind: SfxBaseModel's pImpl of fallback TargetDocument for paste leaksCaolán McNamara
e.g. repeatedly pasting a metafile into writer and deleting it. ==13369== 342 (232 direct, 110 indirect) bytes in 1 blocks are definitely lost in loss record 19,396 of 22,170 ==13369== at 0x4A06965: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==13369== by 0x686D72E: SfxBaseModel::SfxBaseModel(SfxObjectShell*) (sfxbasemodel.cxx:518) ==13369== by 0x288CA9C1: SvxUnoDrawingModel::SvxUnoDrawingModel(SdrModel*) (unomod.cxx:255) ==13369== by 0x28961055: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, char const*) (xmlexport.cxx:164) ==13369== by 0x28960FA2: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&) (xmlexport.cxx:148) ==13369== by 0x2896175E: SvxDrawingLayerImport(SdrModel*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) (xmlexport.cxx:254) ==13369== by 0x240B1002: SwFEShell::Paste(SvStream&, unsigned short, Point const*) (fecopy.cxx:1333) ==13369== by 0x247B981A: SwTransferable::_PasteSdrFormat(TransferableDataHelper&, SwWrtShell&, unsigned short, Point const*, unsigned char, bool) (swdtflvr.cxx:2207) ==13369== by 0x247B678E: SwTransferable::PasteData(TransferableDataHelper&, SwWrtShell&, unsigned short, unsigned long, unsigned short, bool, bool, Point const*, signed char, bool) (swdtflvr.cxx:1481) ==13369== by 0x247B5AE4: SwTransferable::Paste(SwWrtShell&, TransferableDataHelper&) (swdtflvr.cxx:1150) ==13369== by 0x2488FCCE: SwBaseShell::ExecClpbrd(SfxRequest&) (basesh.cxx:277) Reference< lang::XComponent > xTargetDocument( xComponent ); if( !xTargetDocument.is() ) { > xTargetDocument = new SvxUnoDrawingModel( pModel ); pModel->setUnoModel( Reference< XInterface >::query( xTargetDocument ) ); } Change-Id: I3bd0fc983d9b6bdcdc91071a4ec3d2c584397ebf
2014-05-16clean up, remove eof commentsThomas Arnhold
Change-Id: I166e781cb54181a8e5d08021cf5f6dfcd1fde5cb
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15Minor utl::TempFile clean upStephan Bergmann
Change-Id: I20de8b2321d2656d17d25c6343d72c534d47e597
2014-05-14Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part12Julien Nabet
Change-Id: I7c514b7a1d86f52d77672b826b1f08b825fd7aa7
2014-05-14bool conversion for windows, tooThomas Arnhold
Change-Id: I38e481ce7d4eeea6679e33640555469cd18d3109
2014-05-14warning C4305: 'argument' : truncation from 'const rtl::OUString *'Thomas Arnhold
...to 'bool' Change-Id: If2b2b1bf27b8e241be131c3ac63c79f8211f47d9
2014-05-14Fix warningMaxim Monastirsky
Change-Id: I90187024bc599f66bb99295ed342e106080adeb7
2014-05-14fix buildMaxim Monastirsky
Change-Id: I40b7f9388388e05ab5b034ac81861aa34a23d2a8
2014-05-14startcenter: another attempt to fix mouse up issuesMaxim Monastirsky
see commits 1a2a961c1e7cdef648c28e211433e8de6e8a831b 4a902e0c59b0dd01e6459c226268bdee4f15489a Change-Id: I94b90dfc5db779317d4dda1171aeceeac6373548
2014-05-14sfx2: remove SAL_INFO's that only mark function entryNoel Grandin
Change-Id: Ia7f59631da21b81f0c7e450c885b759cdce5a140
2014-05-14Revert "startcenter: react on mouse down instead"Maxim Monastirsky
This reverts commit 1a2a961c1e7cdef648c28e211433e8de6e8a831b. As suggested by Kendy, opening with a single click by mouse up is more natural. We need to find a better solution for the bug mentioned in the above commit.
2014-05-14Unify utl::TempFile ctorsStephan Bergmann
Change-Id: I0a781a86804808cebf7756506d9299971c13e2ff
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-12It makes no sense to create object container when no objects are embedded.Kohei Yoshida
Change-Id: Id13a0955a2b26dcc06766ad85f6ff9c598b4f0f2
2014-05-11Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10Julien Nabet
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-10coverity#1028545 Uninitialized pointer fieldCaolán McNamara
Change-Id: Idd4e1497737b8afb5eda283fe82754346f98814d
2014-05-10remove globally disabled warnings from source filesThomas Arnhold
Change-Id: Ic7b092a24b4d1e48ca11e53b507da5c2bfdeabe8
2014-05-09'!= false' is redundant, and confusing - kill it.Jan Holesovsky
Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
2014-05-09remove presys.h and postsys.hThomas Arnhold
Both files are nearly identical to prewin.h and postwin.h Change-Id: I1f45e46dfcc00043a9e2df82e0070cd1b976c4af Reviewed-on: https://gerrit.libreoffice.org/9294 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-09There is no css::uno::Sequence<bool>Stephan Bergmann
Change-Id: Ibd630320d7cfb4c80c35e91e4407203b1783e980
2014-05-09coverity#1209785 Dereference before null checkCaolán McNamara
Change-Id: Iff8553169bd4670d989b45ce488a0cd2b13e0cf3
2014-05-08cppcheck: Missing bounds check for extra iterator increment in loopJulien Nabet
Change-Id: Ia6f7d35acacc99b4cfe4f8b8d5a7c81e97558205
2014-05-08use new VCL IsValueChangedFromSaved methodNoel Grandin
follow to commit ff1a7a59434f5f793d4044aad615bcf78148e963 "RFC: add IsValueChangedFromSaved to VCL button and listbox" Change-Id: If2e6d9e7c18590dc4abbc90362d7897ca2557dd6
2014-05-08various: sal_Bool->boolNoel Grandin
Change-Id: I30fa5227f30373f95060148f269450d2945c1bb9
2014-05-07coverity#735848 Explicit null dereferencedCaolán McNamara
Change-Id: I9fb6da4d448923fd5b8822a72d6945a0c0b5f40d
2014-05-07coverity#1209611 Explicit null dereferencedCaolán McNamara
Change-Id: I1efe68a3b63ddd4b1583a29dd8d71d217bfdd9a8
2014-05-07Resolves: fdo#68600 limit comment widthCaolán McNamara
Change-Id: I7060ae18a98e0793a936834b398f1e232d336672
2014-05-07The opaque PostUserEvent IDs are actually pointersStephan Bergmann
...so declare them as such. This avoids the recurring mistake of storing such IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to potentially not remove the event, it thus firing "too late" and probably causing a crash. While at it, consolidate the trivially unnecessary overloads of both Application::PostUserEvent and Window::PostUserEvent. And in each of them, it looks like deleting the mpLink member was missing from the failure branch. Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-06Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part4Julien Nabet
Change-Id: I8e52c2fd66f8f3291434ee82a745431e11b12caf
2014-05-06Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part3Julien Nabet
Change-Id: Ibabd6d2d5e84fe007364bd1a4182a01ea2352b7a
2014-05-06Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part2 + fix some errorsJulien Nabet
Change-Id: I9c889d718a9c91eb4c2bde2389a21dd754cbef36
2014-05-06remove uncompiled source filesThomas Arnhold
how to find possible candidates: find . -name *.cxx | grep -v compilerplugins > cxx.list for i in `cat cxx.list`; do basename $i .cxx; done > cxx.base.list for i in `cat cxx.base.list | sort -u`; do echo $(git grep -w $i -- '*.mk' | wc -l) $i; done > cxx.count Change-Id: I15c6cc7195e58d79967388850a0c90b915b001b7
2014-05-06Move a few more headers that are included only in sfx2 to sfx2Tor Lillqvist
Change-Id: I8bd81a45f5ef1b76fce1563b06e05a4eefcff0ec