summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2018-10-12We don't need to handle iOS specially in DisconnectStorage_Impl() after allTor Lillqvist
Now that we make sure UserInstallation/user directory exists, a "backup" directory will be created there, and the edited document's backup file placed in it, and not beside the original document location (which wouldn't work on iOS). Change-Id: Ibc0a6e7f0b596cc3d02774878cd8c3d53fda0c3e
2018-10-11Skip the backup dance on iOS for nowTor Lillqvist
The code is much too convoluted for my little brain. We can't create a backup copy of a file from outside the sandbox in the same folder as the original file. At least not using just normal Unix APIs. And if we store it somewhere else, how would the user find it anyway? Let's just skipt this mess for now. No idea how the code manages to create backup files in the same folder as the actual document in a sandboxed LibreOffice on macOS. Or does it? Maybe we do some similar bypassing of the backup dance at some other place in the code already, and I should just have made that happen for iOS, too? Change-Id: I0c90edf9e72f54cce78b2cd325e67c710b6df745
2018-10-11Drop duplicate WINVER and _WIN32_WINNT definesJan-Marek Glogowski
Just keep the definition of _WIN32_WINNT in windows.mk, which claims it automatically derivates WINVER in some sdk header. Change-Id: I0a83e91ffdc9e0fc847433a92a45424fbfcb189c Reviewed-on: https://gerrit.libreoffice.org/61631 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-10forcepoint#74 crash in layoutCaolán McNamara
Change-Id: Iad5770b512d7c49483ac823aa4f51212f281bbca Reviewed-on: https://gerrit.libreoffice.org/61628 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-10Unhardcode sidebar used customizable key bindingsJim Raykowski
Change-Id: Ia3bc171e2c9805955394fac274de382c3f87d35f Reviewed-on: https://gerrit.libreoffice.org/61564 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-10optimize adding a block of entries at one timeCaolán McNamara
Change-Id: I9a59154fa445cf3c44ede3ceb1d09f408d906530 Reviewed-on: https://gerrit.libreoffice.org/61618 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09use freeze/thawCaolán McNamara
Change-Id: Ia5e24c6eab1f33d8a9ef8232095cd95c68386a43 Reviewed-on: https://gerrit.libreoffice.org/61592 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09tdf#120264 - Access to "Get Involved"heiko tietze
UNO command SID_GETINVOLVED added with access to the website from all main menus under Help Dispensable ellipsis removed from other UNO commands around Help Change-Id: I79536be3de31f55a7b208bcdd5a243e05b3d3668 Reviewed-on: https://gerrit.libreoffice.org/61238 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-09loplugin:constfields in sfx2Noel Grandin
and we find that bSplitable in SfxDockingWindow is always true, ever since commit 4bd28a2fee0d36c67911019eeb7d934838e27cad Date: Tue Jan 29 15:27:40 2008 +0000 INTEGRATION: CWS fwk82_SRC680 (1.45.138); FILE MERGED so we can remove all of the non-splittable code there. ` Change-Id: Ia7fe607ed02d1a7c69a92bab57e220b19f0e6e87 Reviewed-on: https://gerrit.libreoffice.org/61550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08replace double-checked locking patterns with thread safe ...Jochen Nitschke
local statics. Change-Id: Iab4963a04d15f06e9b1a36079a36d32453e09c8f Reviewed-on: https://gerrit.libreoffice.org/61538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08tdf#120271 related: Allow finalizing of LastTimeGetInvolvedShownMike Kaganski
This avoids abort() on modifying the setting in case it's finalized Change-Id: I5982a4d7bf867301d7ba0e7e0dbb3f7c87013134 Reviewed-on: https://gerrit.libreoffice.org/61430 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-08resolves tdf#120272 List templates in template dialog doesn't accept focusCor Nouws
Change-Id: Ieb5b52051cb75f72308ad875fe8c181d5a9bee2f Reviewed-on: https://gerrit.libreoffice.org/61260 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-08tdf#99678 Show style in common template dialog tree box immediatlyJim Raykowski
...after creation using New Style dialog Change-Id: Idb24f537fe7be2dfb9660a1a5de0bcd26612affc Reviewed-on: https://gerrit.libreoffice.org/59914 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-10-07drop unnecessary includesCaolán McNamara
Change-Id: I0a873ecc812f229d972f18370ff06c02f521fedb Reviewed-on: https://gerrit.libreoffice.org/61484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06drop some now unnecessary includeCaolán McNamara
Change-Id: I9db3d9a172a41c70ed343efd76f4c7c8f88b3a3f Reviewed-on: https://gerrit.libreoffice.org/61471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05tdf#85850 Pass CTRL+F5 event in sidebar to parent classesJim Raykowski
Change-Id: I86e1fba17402d0a5f06d7942cf0733b0f2c924ba Reviewed-on: https://gerrit.libreoffice.org/61276 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-05weld modeless sfx SearchDialogCaolán McNamara
Change-Id: I90a9b5dcf8878356b6666f8fe911d5dce9391904 Reviewed-on: https://gerrit.libreoffice.org/61396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Resolves: tdf#117784 inherit SfxTabDialogController from SfxDialogControllerCaolán McNamara
Change-Id: I6b7ce81093ec402954aa5a2f4b266827fe85a88f Reviewed-on: https://gerrit.libreoffice.org/61314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Related: tdf#120277 inherit from SfxDialogControllerCaolán McNamara
where the dialog originally inherited from SfxModalDialog. Change-Id: Ibe0006de93b0a9f05fb3b6181baf3ba1b4cf04c8 Reviewed-on: https://gerrit.libreoffice.org/61313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Resolves: tdf#120277 special character dialog not appearing in OnlineCaolán McNamara
the magic smoke connecting the dialog to the viewshell was in SfxModalDialog, so not inheriting from that drops the connection add a SfxDialogController to enable setting up the connection Change-Id: I29c45cd43e05295309fc647b039db0c6565ca0d1 Reviewed-on: https://gerrit.libreoffice.org/61304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Related: tdf#120277 extract common piece of SfxModalDialog LOK notificationCaolán McNamara
Change-Id: Ie14cd80d5c33f58673823ee16fa8037efaa17773 Reviewed-on: https://gerrit.libreoffice.org/61303 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I7db0c27ff2213210ed4b46ebbadc1a2f74a18257 Reviewed-on: https://gerrit.libreoffice.org/61249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02make all notebooks scrollable and enable_popupCaolán McNamara
Change-Id: I16a6d556ca4c6b3f876dc0c8380d01fe3022209e Reviewed-on: https://gerrit.libreoffice.org/61195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30weld SvxLineEndDefTabPageCaolán McNamara
Change-Id: I3e947511bbffae4cd48388b17a8fb9a13d453bab Reviewed-on: https://gerrit.libreoffice.org/61139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28fix issues found by bin/ui-translatable.shAndras Timar
Change-Id: I443aeea9dd21e34110307e9ef5f9db4b13c50b39 Reviewed-on: https://gerrit.libreoffice.org/61080 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-09-28loplugin:unusedmethodsNoel Grandin
Change-Id: I5f9ef043d76c55f2c761fd08a2bc1dae66b675c8 Reviewed-on: https://gerrit.libreoffice.org/61073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27tdf#119238: keep replaced file's identity when renaming docfileMike Kaganski
Regression from 2157a3536f97ff5ae7c82611a801fef7e3708983 sfx2 store: try rename before copying Rename is cheaper then copying the content over manually, so try that first. On Windows, we need to keep the file's dentity, including metadata (e.g., creation time, which is kept in FS). WinAPI has ReplaceFileW specifically for this, and it keeps ACLs of the original file, and otherwise makes the changed file not a separate entry, but updated old file from system's PoV. Eventually, we could try to restructure creating backup copies (e.g., for documents when configured so) to take advantage of this function being able to do that. Change-Id: I6001a2a3af5e10bc010f5ef129f4bb6f83ee1581 Reviewed-on: https://gerrit.libreoffice.org/60163 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2018-09-27loplugin:methodcycles more graph theory for the winNoel Grandin
implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27tdf#120122 Fix key input being passed to doc view from floating sidebarJim Raykowski
...tab bar Change-Id: Iae327e0de3a129f28315a3fe2961a6ae572e4056 Reviewed-on: https://gerrit.libreoffice.org/61020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26Fix typoAndrea Gelmini
Change-Id: Ic0727720b1df3a26273e8dbe2a1a9f872f2a3e41 Reviewed-on: https://gerrit.libreoffice.org/61007 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-25loplugin:useuniqueptr in SfxWorkWindowNoel Grandin
Change-Id: I30ae51c05dfbee5fc754d26d3de3e41c30834b31 Reviewed-on: https://gerrit.libreoffice.org/60952 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in CmisPropertiesWindowNoel Grandin
Change-Id: I113160675aa7af0a3a425fe0cab4f68ee24adf27 Reviewed-on: https://gerrit.libreoffice.org/60956 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in CustomPropertiesWindowNoel Grandin
Change-Id: I8d3f700fcdcb853518729f966dd8651579676a36 Reviewed-on: https://gerrit.libreoffice.org/60954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in CmisPropertyLineNoel Grandin
Change-Id: If54a2c546cb3c65417c1ebcc4957cce41597dd07 Reviewed-on: https://gerrit.libreoffice.org/60955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in ThumbnailViewNoel Grandin
Change-Id: I95817a03afedbee4ffb28041a9834e591356102d Reviewed-on: https://gerrit.libreoffice.org/60953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-24tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-24make all the related inheritences formatted the same wayCaolán McNamara
Change-Id: I2e0c060a86cd199a640589a7599fa5f01ef77e3b Reviewed-on: https://gerrit.libreoffice.org/60943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24loplugin:external (clang-cl)Stephan Bergmann
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24Resolves: tdf#119624 stray image_position bottom for some icons in buttonsCaolán McNamara
icons are off by default so not usually seen Change-Id: I6076fd87250fc4595d279c830e14779147b7857a Reviewed-on: https://gerrit.libreoffice.org/60935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22unwind ItemWrapperHelperCaolán McNamara
Change-Id: I171150342e04bee6efd97f36f769a2c3d1db4bd7 Reviewed-on: https://gerrit.libreoffice.org/60887 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22weld AlignmentTabPageCaolán McNamara
Change-Id: I253a01b053efe836b0657f9a711cecd060b6782b Reviewed-on: https://gerrit.libreoffice.org/60883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22try other markupCaolán McNamara
Change-Id: I1d2ff100023ac6d94ea6ec65844cf509988ac90b Reviewed-on: https://gerrit.libreoffice.org/60894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21coverity#1439338 silence Time of check time of useCaolán McNamara
Change-Id: I69d17f9190c165ed787b68febd2cdb37c4e16b9e Reviewed-on: https://gerrit.libreoffice.org/60852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20weld SwDropCapsDlgCaolán McNamara
Change-Id: Ibd01c0fb54f0e3b361d5e1f196bfeb44a1fcb99c Reviewed-on: https://gerrit.libreoffice.org/60805 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19Avoid unused function in the !HAVE_FEATURE_SCRIPTING caseTor Lillqvist
Change-Id: Ic41be9447a8ac068d9616252ad3b17451234956e
2018-09-19add locale to joinus link so hub can redirect to language specific pagesChristian Lohmaier
Change-Id: Ibed6f899ad0219bf0211ac50c0595484ddba8c92 Reviewed-on: https://gerrit.libreoffice.org/60696 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-09-18weld SwParaDlgCaolán McNamara
Change-Id: Idb330d63480c0b973190d5f7696aac8f232a16c3 Reviewed-on: https://gerrit.libreoffice.org/60529 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-18weld ScCharDlgCaolán McNamara
Change-Id: Ie0fe76ef5c5c706007c2285b3a309d92ff4bc2b0 Reviewed-on: https://gerrit.libreoffice.org/60528 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17Missing include (Windows, --disable-pch)Stephan Bergmann
Change-Id: I825230daf223ff94ab1dbc19d81d478fbf464f56 Reviewed-on: https://gerrit.libreoffice.org/60596 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-17 11:45:47 +0000