summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15tdf#91721: fix crash during listbox control editing in database formLászló Németh
Change-Id: I415ccb6132b802f62c93367a050242aee3c128b1
2015-06-15java: remove unnecessary threadingNoel Grandin
there is no point in spawning a thread to load a document and then waiting for the thread to finish Change-Id: Icd5d5452471b0a50a8e3525ab2b5f32a500ebdf4
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-12std::list for SchedulerJuergen Funk
Re-factor the scheduler to use std::list Because - ImplSchedulerData - remove: mbInScheduler, mnUpdateTime, mnUpdateStack that is scheduler stuff - this struct is only a container for the scheduler-list - UpdateMinPeriod - the scheduler is the pure-virtual-class then the idle-class must override this method - ImplDeInitScheduler(bool All=true) - this patch 2e29a518b04250b5f9cc9d0d77da3df076834d60 remove all scheduler tasks and the scheduler, but after that, the scheduler is using, then crash. With this fix, only delete the scheduler-list, but not the scheduler The next steps - split the scheduler from the scheduler-list-handling the scheduler-list-handling need a static class - remove the scheduler from the timer-handling staff Change-Id: I8d4d4f27b2bc9684a48c2afafd0b3edd0716c71d Reviewed-on: https://gerrit.libreoffice.org/16148 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11speed up Java unit tests by removing sleepsNoel Grandin
and replacing them with a call to XToolkitExperimental:: processEventsToIdle Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932 Reviewed-on: https://gerrit.libreoffice.org/16201 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-10SfxObjectShell::CopyStoragesOfUnknownMediaType: still try to copy Base streamsMiklos Vajna
When Base is embedded in a Writer document, we still need this when the document is saved for the first time after embedding. Change-Id: I1103da01838abd4ac1b03dc4d44e10db3ce650bc
2015-06-09sfx2: WaE: '<::' cannot begin a template-argument listMiklos Vajna
Change-Id: I954a2128ad5845d5a58eaee2bc0709a78cffa308
2015-06-09sfx2: silence warning in SfxObjectShell::CopyStoragesOfUnknownMediaType()Miklos Vajna
I guess the intention is to catch all "own" formats, and Base is just missing from that list. Change-Id: I064068c2ab17db9109a9a4681775ba8d18292292
2015-06-09not necessary to open read/write to extract document metadataAndras Timar
Change-Id: Idf1bfbac1adc083f6d697d19ca41110f765955e9 Reviewed-on: https://gerrit.libreoffice.org/16171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: Idc749cf79afe1f6612f5f44a9c44aae853f78275
2015-06-07loplugin:unreffunStephan Bergmann
Change-Id: I7320d86de08215fb656113cdaca71645c4b9bc2e
2015-06-07Resolves: tdf#79780 use SelectHdl instead of ClickHdlCaolán McNamara
ClickHdl happens on the "down" of the click, not the "up" of the click, so the up gets lost and control isn't returned to the parent widget, so extra clicks are needed to give control back to it Change-Id: I79023d2959377ff70aa890690dde5ce852c9549e
2015-06-06tdf#91911 Start Center: Use a different icon for Recent FilesAdolfo Jayme Barrientos
Icon imported from Adwaita (32x32/emblems/emblem-documents.png) Change-Id: I4889644c5d253e1c9b722789336d911b7cdd8af9
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-06Typo: emty->emptyJulien Nabet
Change-Id: I495ae28194da449ab1b31b2b5ec0d9e08fbcc291
2015-06-05Pin_Impl doesn't have an implementationCaolán McNamara
Change-Id: Ic2eb447910b14d75911be4835a533c8575045e08
2015-06-05the only thing that calls ActivateNextChild_Impl is itselfCaolán McNamara
Change-Id: Idcc1971716e42b67739ee7e367e9dfdd835afc32
2015-06-05Resolves: tdf#91864 unset a dying childwindow as the active windowCaolán McNamara
Change-Id: Ief014895facbc092913b3069ed04cace1e233ff0
2015-06-04Match basicide_choose_macro in basctl/source/basicide/basobj2.cxxStephan Bergmann
Change-Id: I9add8be1c20c2529edf8d8616fe5e372938cd355
2015-06-04Match basicide_macro_organizer in basctl/source/basicide/basobj2.cxxStephan Bergmann
Change-Id: Ib185645e84f8792d3ed29e7d5e674e5e7cc39fc5
2015-06-04unusedStephan Bergmann
Change-Id: Ie11bf740c0ae672e7e1b14652f93bb6222bf45b7
2015-06-03Avoid various desktop GUI elements when used from LibreOfficeKitTor Lillqvist
Change-Id: Id283d185ab38427ce6887ead4e414055522e655c
2015-06-03loplugin:saloverrideStephan Bergmann
Change-Id: I1d3cd2ff9a2c579d23b97a6ab8e9cf2baadf0439
2015-06-03Missing boost_headersStephan Bergmann
Change-Id: Ic85b888ee89d0b49410d26be55333e31ffc07c0b
2015-06-03Skeletal SfxControllerItem / bindings unit test.Michael Meeks
Change-Id: I0fdda736243c3e4a74f2faedf6fa5ea49453fe8c Reviewed-on: https://gerrit.libreoffice.org/16040 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-02loplugin:loopvartoosmallStephan Bergmann
Change-Id: I721a9da1f277ce641375411f302557372331e6a2
2015-06-02tdf#88178 Avoid naming two distinct buttons the same…Adolfo Jayme Barrientos
… when these are in the same screen. Change-Id: I4e162a485f4511ae3e008446d5712562562ed64f
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: I60298e919c29454c0a3bc8d745029e4a5d4cbea6
2015-06-02cppcheck: redundantAssignmentCaolán McNamara
Change-Id: Icca51c730aa361e6a886358c396d4804501139ad
2015-06-02cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
2015-06-02remove empty lines and bring some sanity in comment positionsMarkus Mohrhard
Change-Id: I82b5e3df6a0926291719f619f344c3cccbd196e6
2015-06-02no need to make that separate statementsMarkus Mohrhard
Change-Id: I2b08d200f1e361cdb3f3d3c12fec1b3377b81e30
2015-06-02OSL_FAIL to SAL_WARNMarkus Mohrhard
Change-Id: Ic5d96e091f307798941e43368cbd2daf9f84e73c
2015-05-29tdf#91702 - fix stack-based MessBox allocation.Michael Meeks
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29loplugin:redundantcast: const_cast to same typeStephan Bergmann
Change-Id: I305f476e85b4e0bef4ef91fb5eaa75313b0e490f
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-28SvxSearchItem: add m_nStartPoint{X,Y}Miklos Vajna
The idea is that if you have your cursor at the begining of a Writer document, and you scroll down a lot, then search, then it's annoying that search jumps back to the start of the document for the first hit. Add an optional way to provide what is the starting point of such a search, so we can have "when nothing is selected, then search from the top left corner of the visible area". No UI yet to enable this, but available via the UNO API. Change-Id: Ibcf3a5f2eeba1372b1dfe8474081e6591a6e0134
2015-05-28convert GETFOCUS constants to scoped enumNoel Grandin
Change-Id: I7c324bb6358be28c119592850eb7607479279f09
2015-05-28Rewrite all calls like Dialog(params).Execute()Philippe Jung
Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-26convert INVALIDATE constants to scoped enumNoel Grandin
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the IDL docs for XWindowPeer Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-25Audit all PostUserEvent calls and instrument for VclPtr.Michael Meeks
Hold a reference on the VclPtr while we're waiting for the UserEvent. Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-25convert TOTOP constants to scoped enumNoel Grandin
Change-Id: I85ba631ba298f1034dc5b6a04a5ff3d509c41bcb
2015-05-25convert SHOW constants to scoped enumNoel Grandin
Change-Id: I2712a0901049885502cade31f9757f712048bb33
2015-05-22convert WINDOW_POSSIZE constants to scoped enumNoel Grandin
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9
2015-05-22convert WINDOW constants for GetWindow() methods to scoped enumNoel Grandin
Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33