summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2019-04-04Resolves: tdf#122780 limit massive template names in ui to a sane lengthCaolán McNamara
Change-Id: I053b30b00dbda67819af68020e2f6fa4a5b5134e Reviewed-on: https://gerrit.libreoffice.org/70255 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04rhbz#1696037 null-derefCaolán McNamara
Change-Id: I1a9eb5b1b38e2ec651f2d0286337106ab565a9dc Reviewed-on: https://gerrit.libreoffice.org/70239 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02Warn when getFileURLFromSystemPath() fails, not when it succeedsTor Lillqvist
Also, display the name that the call failed for in the warning message. Change-Id: I0b6b7baca1d534b5bada5286b2b0e5b8e94f1832
2019-04-02weld XMLFilterSettingsDialogCaolán McNamara
Change-Id: Ia027fa0b5e99651988f2447bf29f6f5653dd0c48 Reviewed-on: https://gerrit.libreoffice.org/70139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02drop some unneeded includesCaolán McNamara
Change-Id: I78b9682968acea7564554fb589d2759b6c8e67d0 Reviewed-on: https://gerrit.libreoffice.org/70126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01tdf#42949 Fix IWYU warnings in include/sfx2/[sS]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4a3baffa8944b522b16b50975185759081662020 Reviewed-on: https://gerrit.libreoffice.org/69945 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-29tdf#42949 Fix IWYU warnings in include/sfx2/[n-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia2bea9bd4775f4ed5ef0133971106a6c0bfdd1c0 Reviewed-on: https://gerrit.libreoffice.org/69896 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-29Enable redaction for ImpressMuhammet Kara
After the commit c2330b14e2bfa170131a83c375ec0b1a91c95415, different page sizes and orientations are handled properly, and Impress pages are converted to Draw perfectly. Change-Id: Ib9ab6b298e12fc0d8e9440bf63f31ad6dd05ab35 Reviewed-on: https://gerrit.libreoffice.org/69910 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-03-29Handle different page sizes for redactionMuhammet Kara
Change-Id: I7136717936668fbb1d87b5d9491430c13c5e73fd Reviewed-on: https://gerrit.libreoffice.org/69909 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-03-28weld SfxTemplateManagerDlgCaolán McNamara
like expert configuration change the gear menu not to display a down indicator and use CommandEvent to distinguish mouse/non-mouse context menus Change-Id: I64bb660a9c7dacb5b90b240d9d76d29324c5fd9f Reviewed-on: https://gerrit.libreoffice.org/69893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-28simplify reset(nullptr) -> reset()Noel Grandin
Change-Id: Iec5e93d9c59dde44571376e46fb98ea854e16b6c Reviewed-on: https://gerrit.libreoffice.org/69784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28tdf#42949 Fix IWYU warnings in include/sfx2/[e-M]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49 Reviewed-on: https://gerrit.libreoffice.org/69715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28tdf#113539 Slow opening of ODT file containing a large tableNoel Grandin
I suspect that somebody has already fixed the bulk of this, since on my machine, the opening time started as: 0m5.363s After changing from std::set to o3tl::sorted_set in SwAccessibleTableData_Impl, it dropped to: 0m4.372s And then tweaking SfxSplitWindow::InsertWindow_Imp lowered it to: 0m4.030s which seems perfectly acceptable to me. Change-Id: I0c6123e99ab560742bd3dc97bb76666b48a3b1b6 Reviewed-on: https://gerrit.libreoffice.org/69862 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-27return by unique_ptr from weld_parentNoel Grandin
Change-Id: I3582b3000330fab96f6abef0f412b648b0573af4 Reviewed-on: https://gerrit.libreoffice.org/69793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-27MSO lockfiles: Deduplicate MSO lock file reading codeTamás Zolnai
The removed code was extracted to MSODocumentLockFile class so use that class here too. Use openStreamNoLock() for reading MSO lockfiles, because otherwise we can not read lock files written by MSO. Change-Id: Ib31cb9f3783d0b0ce784f900821047b9d32156f2 Reviewed-on: https://gerrit.libreoffice.org/69759 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-26Fix Windows build.Tamás Zolnai
Change-Id: I7a8c5f16ec4ee17ec491229c7c15f9571d763d5c Reviewed-on: https://gerrit.libreoffice.org/69710 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-26Generate MSO lock files when the related MSO compat. option is setTamás Zolnai
Added a new compatibility option to the Tools -> Load / Save -> Microsoft. When this option is set on the UI or or set in the configuration files LO generates lock files for MSO supported file formats, similar to the lock files MSO generates itself. Change-Id: I2f882723841162add01be9d3f7285a5162a60331 Reviewed-on: https://gerrit.libreoffice.org/69678 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-26weld SvxRubyDialogCaolán McNamara
Change-Id: I32f26b9d3e495e64a38cd8a56e532374dd4891f1 Reviewed-on: https://gerrit.libreoffice.org/69651 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-26loplugin:unusedmethodsNoel Grandin
Change-Id: I8bbf439d69a330a9ad28ff52cc49a9fec2c12500 Reviewed-on: https://gerrit.libreoffice.org/69684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-25Related tdf#124263 Make sure sidebar is wide enough for contentSamuel Mehrbrodt
If panel's requested minimal size is smaller than current sidebar width, enlarge the sidebar to fit the content. Change-Id: I9baa4ef6c01d5563951d4df0d939883fce02e87b Reviewed-on: https://gerrit.libreoffice.org/69561 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-25ubsan detect null derefCaolán McNamara
Change-Id: I78a8c91f2c7493a12f5acb325c3f79efbbfbffcc Reviewed-on: https://gerrit.libreoffice.org/69650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-25tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4 Reviewed-on: https://gerrit.libreoffice.org/69481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25new loplugin:unoqueryNoel Grandin
look for places we are doing code like: Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty() which might result in a SIGSEGV is the query fails Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e Reviewed-on: https://gerrit.libreoffice.org/69044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-22tdf#119905 Infobar text overlapRasmus Jonsson
Make SfxInfoBarWindow text wrap (WB_WORDBREAK) by default. Make SfxInfoBarContainerWindow stretch to fit its content (the wrapped text) Change-Id: Ib6f68011b4f2a4813dc5e0316281583b9ac641ee Reviewed-on: https://gerrit.libreoffice.org/69482 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-22tdf#124263 Respect XSidebarPanel::getMinimalWidthSamuel Mehrbrodt
even if it's larger than max sidebar width (increase max sidebar width in that case). Change-Id: I2efbd546596f756df205196fae3e545beddd2f7c Reviewed-on: https://gerrit.libreoffice.org/69551 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-22weld SwFieldDlgCaolán McNamara
Change-Id: I324a581721e01c907113bb3ab1cc91a290bd71a7 Reviewed-on: https://gerrit.libreoffice.org/69475 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22refactor into a shareable base classCaolán McNamara
Change-Id: I5eb1f2b6b7b2dbc3bc675845730cb3aef1cab5f0 Reviewed-on: https://gerrit.libreoffice.org/69528 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22tdf#124255 Make maximum sidebar width configurableSamuel Mehrbrodt
Also change the default max width to 500px (instead of 400px). Change-Id: Idece5aadaf4c4165cc873b4605d2c0f026c89c6e Reviewed-on: https://gerrit.libreoffice.org/69545 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-21lok: intercept the UNO command ".uno:ThesaurusDialog"Henry Castro
Change-Id: I085cb646037f260ada4d4d04c2419638dd235048 Reviewed-on: https://gerrit.libreoffice.org/69264 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2019-03-20tdf#124168: We do need the BasicDLL thing also in the iOS appTor Lillqvist
For instance, simply inserting a table of contents needs stuff from it. But do keep use of the StarBASIC::* API inside #if HAVE_FEATURE_SCRIPTING. Change-Id: I348ce79899f468e104af336501706f88a6afa287
2019-03-20weld SwFieldEditDlgCaolán McNamara
Change-Id: I786944a4bf8979526f0ccae5b00fb42ad5016a66 Reviewed-on: https://gerrit.libreoffice.org/69463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19single source file for licensing info with conditional textTamas Bunth
... for easier maintenance. This commit only introduces the framework. Follow up commits will update the license file. Advantages: * single source, multiple outputs (html, txt) * conditional text, i.e. output will not include license terms of components that are not configured in the build Change-Id: I0ffad41119228a0a26fd1b6ce19930ca6085adb2 Reviewed-on: https://gerrit.libreoffice.org/69396 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-17tdf#120703 PVS: remove redundant static castsMike Kaganski
V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I6d1523e71b3e06be1cf41abaabb44e49fe11cd8e Reviewed-on: https://gerrit.libreoffice.org/69369 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-16Remove duplicated includeAndrea Gelmini
Change-Id: Ibef1d79b091efca721eb3e5304f4b15b95b6bfff Reviewed-on: https://gerrit.libreoffice.org/69288 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-16clarify that set_visible(true/false) is just show/hideCaolán McNamara
ditch duplicate method Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b Reviewed-on: https://gerrit.libreoffice.org/69302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-15LOK: switch view before event emission if necessary.Michael Meeks
Unfortunately we still have large amounts of global state, and key event handling in some corners requires this in addition to the window. Change-Id: Id817030536f9cb45dbc39551dfb5332fc6998c62 Reviewed-on: https://gerrit.libreoffice.org/69266 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-03-15Adapt to C++2a std::span<>::index_type being unsigned size_tStephan Bergmann
...and no longer signed ptrdiff_t (which now caused -Werror,-Wsign-compare here) Change-Id: I48234d9cc4c35583e3268441dcc21a03fab3e856 Reviewed-on: https://gerrit.libreoffice.org/69306 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-14LOK: re-factor async key & mouse event re-posting.Michael Meeks
A fairly pure re-factor, although adding disposed window checking to a number of sites with a warning. Moves the event emission helpers from VCL into SfxLokHelper: we're going to need more view / integration here next anyway. Removes lots of copy/paste horror. Change-Id: I279c11a1d8093b4feeeb6b7850f500806fff80dd Reviewed-on: https://gerrit.libreoffice.org/69218 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-03-14tdf#112411 Remove all that remains of the More controls toolbarsRoman Kuznetsov
Change-Id: I82a348c7be067e777dced15dd014b8139cc9b1dc Reviewed-on: https://gerrit.libreoffice.org/69224 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-13Make the Help URL configurableAshod Nakashian
When the Help URL is blank, the Help buttons are hidden LOK (but not desktop). Change-Id: Ibd76452108d1e3a92fb43f2c0af0586b0cbed073 Reviewed-on: https://gerrit.libreoffice.org/69071 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69142 Tested-by: Jenkins
2019-03-13Resolves: tdf#124028 dangling "completion" entries block responsesCaolán McNamara
so e.g. math font dialog doesn't react to button clicks. since... commit ab8e0f5832fa910f8b1abd36d7cb3929cbac2395 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 18 17:08:58 2019 +0000 Resolves: tdf#122484 replace gtk autocomplete with vcl-alike autoselect remove the entrycompletions but left the reference to them Change-Id: Ia02d0e657fc114692f69f88890192c470a1cab22 Reviewed-on: https://gerrit.libreoffice.org/69208 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13tdf#123293 Add testSamuel Mehrbrodt
Test for commit 0a5ca5768f56db481dd3b947b3dddaab7ed96450 Change-Id: I53b72c385d9ef4d51cefa687f07a75c9520d3e71 Reviewed-on: https://gerrit.libreoffice.org/69165 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-12insert an intermediate class to inherit fromCaolán McNamara
Change-Id: I77cc250197658fed57175b775976a3194050c0da Reviewed-on: https://gerrit.libreoffice.org/69117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12get correct frame window for SfxTabPage inside a SingleTabControllerCaolán McNamara
as opposed to the SfxTabDialogController case which already works Change-Id: If72ca14803e3ff4d716ecab56454a8e2324f460c Reviewed-on: https://gerrit.libreoffice.org/69098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11weld SvxConfigDialogCaolán McNamara
Change-Id: Ia6983fd658521cf8704ca1ed95ecff6590ddde09 Reviewed-on: https://gerrit.libreoffice.org/68906 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11weld SfxDocumentPageCaolán McNamara
Change-Id: I99f342ad1c0620147ce23b4670323056d7ccc508 Reviewed-on: https://gerrit.libreoffice.org/69008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-09loplugin:unusedfieldsNoel Grandin
Change-Id: Ifb2c9a2d1d7dcc0ed3e8458c1a13933ccababd4c Reviewed-on: https://gerrit.libreoffice.org/68939 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-08We need <basic/sberrors.hxx> for the !HAVE_FEATURE_SCRIPTING caseTor Lillqvist
Change-Id: Ie9a6b5be0729e70525be660b88e7d47e65a72f66 Reviewed-on: https://gerrit.libreoffice.org/68909 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-03-08new loplugin constvarsNoel Grandin
detect static variables that can be made const. Thanks to mike kaganski for suggesting this. Here I introduce a new plugin feature - using markers in nearby comments to disable the plugin for specific vars. Some of this stuff was old debugging code. I removed the stuff that was older than 5 years. Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c Reviewed-on: https://gerrit.libreoffice.org/68807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07tdf#42949 Fix IWYU warnings in include/basic/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9dd7984affc4343f148c66077feaac19176adf51 Reviewed-on: https://gerrit.libreoffice.org/68769 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2024-08-04 19:29:42 +0000