summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2022-10-07tdf#150622 sidebar icons empty in High Contrast modeCaolán McNamara
Change-Id: Icfa78f0f655ee467c62cbc309b8e57ac310a73e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140970 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-10-05Templates: Make localized names for "Simple" and "BPMN" show on the UIKevin Suo
Currently there are 32 localized template name strings defined in: include/sfx2/strings.hrc. However, in sfx2/source/doc/doctempl.cxx only 30 were used. This makes STR_TEMPLATE_NAME31 ("Simple") and STR_TEMPLATE_NAME32 ("BPMN"), although already localized, not show up on the Template Manager UI. This patch adds these two strings in the sfx2/source/doc/doctempl.cxx, so that they properly show as localized strings on the UI. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140785 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Reviewed-by: Laurent Balland <laurent.balland@mailo.fr> (cherry picked from commit 244063d03117119d048376c84e22cf47c4abd250) Conflicts: sfx2/source/doc/doctempl.cxx Change-Id: I64bb28cfe0a4d3b4b41c9114de7223014f6a3cfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140945 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-08-31check IFrame "FrameURL" targetCaolán McNamara
similiar to commit b3edf85e0fe6ca03dc26e1bf531be82193bc9627 Date: Wed Aug 7 17:37:11 2019 +0100 warn on load when a document binds an event to a macro Change-Id: Iea888b1c083d2dc69ec322309ac9ae8c5e5eb315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139059 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit c7450d0b9d02c64ae3da467d329040787039767e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139117 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-08-18tdf#148913 sw: fix crash with pending infobars on WindowsLászló Németh
Usage of VclPtr<SfxInfoBarWindow> wasn't thread-safe on Windows, resulting random crashing during loading big documents. Regression from commit d89786054715b44aa983d0752484216825c74ae2 "tdf#125909 tdf#141298 sw: show (Hidden) Track Changes infobar". Change-Id: Ic6a6ad43a8cf7ea650ef6d1c0aa5c76c48763ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137230 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 85a044abdf08bafa93e1caddf38f86e35d7e17f2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137184 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-08-09sfx2: check saved last tab page name exists before restoring itCaolán McNamara
since GetPage might return nullptr on a nonexisting page See https://crashreport.libreoffice.org/stats/signature/SfxHelpIndexWindow_Impl::ActivatePageHdl(rtl::OString%20const%20&) Change-Id: I26e21f783645e8a87d56cbe76c0126de8947bf3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138015 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-08-04Resolves: tdf#147782 restore focus to launching frame asynchronouslyCaolán McNamara
Change-Id: I7ebde70e4e1aae861f6ac7d70a91741596cb2cc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137526 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-07-24tdf#141294 Use DPI scale factor for sidebar width limit in configAron Budea
And don't lock up if the calculated minimum exceeds the maximum (sidebar remains unresizable in that case, however). Change-Id: Ibe96a43ad5d6a3fe4132a9fb64fe244ab022668d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137267 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit f319363b0e07010eea806c723254f17dacdf1b06) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137189 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-11rhbz#2104545: Only call utl::IsYounger when its result is actually usedStephan Bergmann
...as it may be expensive, or even throw (uncaught) exceptions (as apparently happened at rhbz#2104545, throwing some css::uno::RuntimeException while aMedObj was an sftp URL). The two branches in the if statement's condition that will now potentially call physObjIsOlder are disjoint (one for aMedObj being a file URL, the other for aMedObj being any WebDAV-related URL), so there is no chance that this change accidentally causes utl::IsYounger to be called more often than it used to be called. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136904 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 27ffdcf096a7e9863489599dd80528b088d1e9b8) Conflicts: sfx2/source/view/viewfrm.cxx Change-Id: I29a5f18a12a8b83ec603366db26451175b5622c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136909 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-07-07sfx2: fix null derefs of SfxViewFrame::Current()Xisco Fauli
See https://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace'::lcl_tryLoadBibliography Change-Id: I80d764c4bbcf0c5affa3386fbb11f5a79e98b699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136767 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-07-01tdf#149603 macOS: fix workaround to use web help if Safari is the default ↵Christian Lohmaier
browser Safari won't access the local helpfiles from LO's app folder unless you enable Safari's webdeveloper menu. The workaround broke since f31f0038f5fd9254584a06665066faf9715d1cd8 switched from window to widget references and hence using a different codepath, skipping the workaround added in 44893662d510c4173e55ba27af02d0258a697a5d Change-Id: I0c59066fe1cef1514c6595e0439d31d3e60e02f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136685 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 82acd35e3cc5dc458930daaf6de9f41c7deb73dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136704
2022-05-27Resolves tdf#119447 - Improve sidebar height in start centerHeiko Tietze
Reduced the font size multiplier from 1.4 to 1.2 to fit the window into 768px height and added the branding image to the height calculation Change-Id: I05473155f0068880298a461fe8491468b07079b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134867 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit ed45b67db66ef0f6c69887c75013a178c4412f74) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135006
2022-05-11tdf#108188, tdf#131190 - Verify that the page style is actually usedAndreas Heinisch
Change-Id: I007d26c6fcaf60d2a2378cc00e630da447f95a8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134022 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit ad79900cd62c487bda9d2515892d62b3b08a5dfa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134067 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-22sfx2: do reload on SID_EDITDOC in SfxViewFrame::ExecReload_Impl()Michael Stahl
commit b505ca5b9c31b3d9c639406d03a25bea4e914242 "Switch to read-only mode: do not force reload document if possible" replaced "true" with "bNeedsReload" here - but this is a problem when switching from read-only to editable. 1. Start LO and load a document from WebDAV editable 2. Start other LO and load the same document from WebDAV read-only 3. In first LO, edit document, store it and close it 4. In second LO, click "Edit Document" button 5. LO doesn't reload the document and shows stale content It's not clear what problem that commit was trying to solve, but let's assume that it intended to change only what happens when switching from editable to read-only. Change-Id: I69c779c5c0c5c2ccda677ea8cb353c8716916861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133171 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit c929c563e2029bbb969dc417a688cca8934e69b0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133141 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-19tdf#148101 don't autocomplete remote files dialog entry on delete/backspaceCaolán McNamara
Change-Id: Ieddb41eb37e7090416a418afeffb76ce0eddf90a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132873 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-14Resolves: tdf#141625 give enough space to see full date+timeCaolán McNamara
Change-Id: I31193783231f27494ed1507faa143697e8facc30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132987 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-06Resolves: rhbz#2069486 classic help index entry autocompletes on del/backspaceCaolán McNamara
when it shouldn't Change-Id: I90fa338479e0d5612d7b09f94c45e356ea71f89e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132596 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-31add infobar to prompt to refresh to replace old formatCaolán McNamara
Change-Id: Id99cbf2b50a4ebf289dae6fc67e22e20afcda35b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131976 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit bbd196ff82bda9f66b4ba32a412f10cefe6da60e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132187 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-03-23tdf#111924 - Special characters: don't lose focus on context menuAndreas Heinisch
Don't lose focus on the favorite or recently used items in the special characters dialog when right-clicking them to show the context menu. Change-Id: Iaedc4bbc6fb627591b9c0cd9a2c44940312eeb1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131721 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit ce3e760f9155ac8d80f60054be036e862df7029a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131858 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-10tdf#147782 retain focus in launching frame on first activateCaolán McNamara
Change-Id: I813c675ecf7c4a364f9d770af12e99275f510e7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131017 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-27lokit: double check for disposed windows & fix leak.Michael Meeks
it seems we can get windows disposed before we get to the emission. <segv> vcl::Window::IsTracking() const vcl/source/window/window2.cxx:341 (anonymous namespace)::LOKPostAsyncEvent(void*, void*) sfx2/source/view/lokhelper.cxx:725 LokChartHelper::postMouseEvent(int, int, int, int, int, int, double, double) include/rtl/ref.hxx:112 SwXTextDocument::postMouseEvent(int, int, int, int, int, int) sw/source/uibase/uno/unotxdoc.cxx:3561 Change-Id: I93aea931dad1e7f43d3d610568424c53d2b22fbc Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127907 (cherry picked from commit 7ba99b8d6da07c2133c644de4d1a3613a9fa5a68) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129839 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-18tdf#143817 Fix HUD deleting text contents in WriterRafael Lima
Change-Id: Ie28388016c475907c5d8fbe51906bc4a01d6b0d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130091 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 3c94a0f7729f1638ab3b273a186c48de859cfb49) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130092
2022-02-01tdf#122708: on GetFocus, select something also when items are filteredKatarina Behrens
Previously if nothing was selected, we picked item with ID 1 to select/highlight. But if a filter is active, such item may not match the active filter (case in point: document template no. 1 matches 'Writer templates' filter, but not 'Impress templates' one) Try harder to find an item to select by looking at the list of filtered items too Change-Id: I9cb053b884dc724c7a6199ec002d83024ed83976 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129117 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org> (cherry picked from commit 4bb0ffa4684dada708ecdf727f4fc9f500a9bced) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129081 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-25tdf#146571 Ignore focus changes after closing Manage changes dialogCaolán McNamara
Change-Id: Ib588310410a265acdd129a8e51adf56bb5973bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128910 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-21tdf#140020: Disable also menu File->SaveAll for docs with LockSaveVasily Melenchuk
If LockSave attribute is applied, docs with it are not affecting File->Save All menu item: these documents are not enabling this menu and also not saved during this process. Change-Id: I00bcd251fccfab3f13cb42c20ccb61b54ab49346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128650 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> (cherry picked from commit 87fe449c4c1ed46003e9d5fdaf1919f11a53b959) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128676
2022-01-20tdf#140019: Revert "Don't disable "Send doc via email" ..."Vasily Melenchuk
Locked export should also disable ability to send document. This reverts commit b9930d0d05db39a8466b18dccf626bc3d8ae5c4e. Change-Id: I3b7b423c0e17a59872065ec7ceadbaf1cda45ccc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128550 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> (cherry picked from commit f4559274154324e132f82ba9c21676326f6db7e5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128546
2022-01-12tdf#146375 Cannot rename user-defined categories in template managerNoel Grandin
Regression from commit 3624a703361b108d22448bd60a97733f05e37820 tdf#135316 remove OTempFileService pessimisation So fix two things here (1) make it so the tempfile service flushes the SvStream buffer and resets the file position, so we can read the data after writing it. (2) Simplify the UCB usage to just write the contents of the tempfile via the tempfile InputStream, which is simpler and safer Change-Id: I15ed3b02c2d6415d10a9579f66374e6268188d5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128195 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128274 Tested-by: Jenkins
2022-01-02Bump copyright year to 2022Adolfo Jayme Barrientos
Change-Id: Icbb000677066127fa67e8c22fb0ab6880acc0169 (cherry picked from commit fb32c4d96141ccc1766fa4e39405130fcf409a6a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127848 Reviewed-by: Martin Srebotnjak <miles@filmsi.net> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-15tdf#131850: avoid encryption check for recent docs overlayMike Kaganski
Change-Id: I673de978c39492bf9be78945ece95ade2a943ffc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126849 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 2f848eb5dc6f6f9344f250ac9860065130aaf436) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126869 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-09tdf#117280: derive SfxEvents_Impl from css::document::XDocumentEventListenerMike Kaganski
It abused XEventListener, and created a DocumentEvent object from the incomplete data passed to notifyEvent in EventObject. That way, the data initially created for the document event (in Supplement) was lost on the way. Change-Id: I409611482ce2323a3192c68f3525f450a9395815 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126090 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 28eef82cb16faef0b8ddc9912560efb779baa9f9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126093 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-06increase maximum document thumbnail size from 256 to 512Luboš Luňák
It's 2021. Something's telling me people now care more about document previews not being blurry than an insignificant size increase of documents. See e.g. comments #21,#25 in the HiDPI bugreport tdf#144214. It also doesn't make much sense for the thumbnail creation to try hard to make the image smooth and then downscale it too much. Change-Id: I8df778dda05cf42cd27adf8f7757097fc7650acb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126376 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 374e261ad1ea8b41f5ecdd850c27fdc961c4868b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126301 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-11-29tdf#117280: fix multiple Macro execution when triggered by Document print eventJulien Nabet
Change-Id: Ibfebcc1a31464b2610afea2035e3d723a0c79167 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126018 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 774c6a6e1603bf3f12f1573b0778e0f0f9783169) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126006 Tested-by: Jenkins
2021-11-29cid#1494452 sfx2: fix null ptr deref in SfxInPlaceClient_Impl::saveObject()Miklos Vajna
Null-checking "this->m_pClient" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Add the missing check at a previous usage. (cherry picked from commit d9105d434ac6127f151843c7a7dbcd16257fcc0b) Change-Id: I8ebb4f41b9c83d59e65563c26729e899d45881b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126014 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-26tdf#145814 fill format mode is mostly disabledCaolán McNamara
when it shouldn't Change-Id: Ic282c313a6986d7d08f54b475c5d2ce32098ada1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26m_xTreeBox is always trueCaolán McNamara
this has evolved from an optional m_pTreeBox widget to an always present widget that's optionally visible and this case wasn't updated somewhere along the line. Use "IsSafeForWaterCan" which the other cases of this pattern were merged to Change-Id: Ia20327ade5378bbdfa9fbfecbfa9705a33555f17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-25sw: allow viewing OLE objects in protected sectionsMiklos Vajna
The problem was that we don't allow even opening embedded objects in protected sections, which means the content of multi-page embedded objects can't even be viewed in protected sections, which probably goes too far. Fix this relaxing the condition in SwEditWin::MouseButtonDown() to allow launching the OLE object on double-click, and then make sure that the native data is not updated in SfxInPlaceClient_Impl::saveObject() and the replacement image is not updated in svt::EmbedEventListener_Impl::stateChanged(). This is complicated by only the Writer layout knowing if a given OLE object is anchored in a protected frame, so pass down a callback to sfx2/ and svtools/ to check if the OLE object is protected. Not copying the protected bit has the benefit of behaving correctly if the section turns into non-protected: copying would not work properly, as SfxInPlaceClient is created on demand, so not re-created when the protectedness of the section is changed. Change-Id: Ib3a8f2092d27dc1ebd3ef355c95a4a473988b163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125815 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-11-24Convert sal_IntPtr into int + use constexpr int in sfx2/dinfdlgJulien Nabet
Change-Id: I39ab8370f0d01441d59e12fa120bbef4d767c2fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125747 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-24loplugin:stringliteraldefine in comphelperNoel Grandin
Change-Id: I60ccd6049db65fef2397798ab916b0d1e24c0fdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125531 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-24tdf#145852 Revert "Make "uno:Printer" actually work"Samuel Mehrbrodt
This broke a macro (see tdf#145852) This reverts commit 3f4d96767fb510f07577ba4f28e60f05a370a5b2. Change-Id: Ic3b4f31182e2f4e13d33f2b7711fec9ae62b1fd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125704 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-11-23Resolves tdf#145801 - Uniform height for sidebar's panel titlesHeiko Tietze
Set height of all panel titles to the maximum height a panel title could need Change-Id: I1c023224fbca09b8f73151126b25df5f438260ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-23O[U]String::replaceAt overloads that take string_viewNoel Grandin
which results in lots of nice string_view improvements picked up by the plugins Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-23tdf#144769 Properly encode file name in error dialogGabor Kelemen
Change-Id: Ie8f0b57c33fff787735b09ecf8308f86b56d8bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125121 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2021-11-19gtk3: default to an explicit constrain-to for PopoversCaolán McNamara
with the intent to do the same replacement with GtkWindow under X11 for gtk3 that we do in MenuButtons for the popover with direct popovers when the constraint is GTK_POPOVER_CONSTRAINT_NONE Change-Id: I629c30b44a9e362ba0d924bb229930b5f0dc7ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125540 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-19Change About LO dialog to run asyncJan-Marek Glogowski
Change-Id: I7255a8510e4cf983ebab477cbdb7cdcf00dabc98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125512 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-11-18rtl::Static->thread-safe static in sfx2Noel Grandin
Change-Id: I8074494094f561c5ff21d13c68430798dc242604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-17tdf#143971 Removes pop-up dialog for read-only documentsMatt K
No longer does the user get a pop-up dialog when opening documents that are read-only, asking whether they want to be notified when the document becomes editable. The change removes some of the functionality introduced in commit 95eb088802562b75f8b299908160145c7e88d763 "tdf#47065 Add new file open UI options and implement a new thread". Change-Id: Ic25e8e293e7224fb5086249a9d4814914fa961d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125340 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-15add a rule to enforce always-show-image of True if an image is usedCaolán McNamara
If not set, then gtk3 will show the image if there is no text, but only the text if there's an image. For simplicity sake just enforce it as true if an image is referenced. Change-Id: Id4bb9140ba83e7e07e0d8ec5e3c29aece49b9087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-12make it explicit whether to ignore the result of getLOKPayload()Luboš Luňák
Returning an empty string to signify 'ignore' was a poor design, as some messages types actually may have valid empty messages. Change-Id: Ia82d3d97d150bc5ef412a1bd4b1091d9b2d84385 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124979 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-12Fix (mis-)uses of temporary O[U]StringLiteralStephan Bergmann
...as sub-expressions of ternary operators, which happened to keep compiling after 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String" and e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uString" because both branches are of the same type O[U]StringLiteral<N>, and which didn't cause any issues because no dangling pointers to those temporary objects escaped the surrounding full expressions. This was found with an experimental build with VS 2022 with --enable-latest-c++, which would support HAVE_CPP_CONSTEVAL after some linking fix in the configure.ac detection code (which is forthcoming in a later commit) and flagged all these uses in ternary operators as error C7595 "call to immediate function is not a constant expression". That error looks bogus (and it also caused a false > sd/source/ui/unoidl/unoobj.cxx(742): error C7595: 'Color::Color': call to immediate function is not a constant expression so HAVE_CPP_CONSTEVAL will need to remain undefined for VS 2022 until that compiler bug is fixed), but it nicely found all these cases that should arguably be cleaned up. Change-Id: I81de94e8af5a6c50e5fe7dfa1a4b253e0c2a68f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-08use more OUStringLiteral in MediaDescriptorNoel Grandin
Change-Id: I0567d103db8db401c737fed98483912a39352929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-07forward decls go after #includeNoel Grandin
Change-Id: I54c33508639044092356eed5144720261b4f65db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-05-22 10:24:10 +0000