summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2021-03-09master slide panel shouldn't have "more options" buttonCaolán McNamara
default the toolbox to hidden and show it if "more options" is enabled Change-Id: I6ff867268809d949e7854e0e76d3e45c8806797b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111955 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-23tdf#139039 sfx2 store: fix export to PDF when dir name is URL-encodedMiklos Vajna
Regression from commit 5259ab8104cfba60c40748ed0cd59d93df038c5b (sfx2 store: create temp files next to local files, 2018-01-08), the problem was that the directory hosting the input ODT file was called "Bugzilla%C3%BF" (URL-encoded from "ÿ"), we got this as "Bugzilla%25C3%25BF" (encoded from directory name), but we forgot to decode it before passing this URL to the utl::TempFile ctor as a parent directory, which resulted in failing to save as PDF, and crashing on DOCX export. Note that in practice this only caused a problem on Windows. (cherry picked from commit aaf7fe0326b3be088a5440525363317fb3d0f158) Change-Id: I5fc8a356b63efc2f16405a14ee59a061b52c5205 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111372 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-02-17tdf#140387 grab focus to first panel widget on panel gaining focusCaolán McNamara
otherwise focus is getting lost in these currently mixed vcl+gtk widget panels. Change-Id: I6488ddfc98afdedb55bb3217f3877e96258dd65a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110956 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-15tdf#140308 Crash import old OpenOffice templateNoel Grandin
regression from commit cfe5a5044845a3fc90e3634e996edb4d85808d3c sfx2: use the fastparser API when possible We end up using the OOo2OasisTransformer filter, which is not fastparser compatible Bisected with: bibisect-linux64-7.1 Change-Id: I7bd4191f098096034dc8ff368aba4b1ff313ce18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110883 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 228f43f2e3c2896c227f1ea30c5d16231acf66da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110866
2021-02-11tdf#140280 sfx2: fix crash on double-clicking a no-sign shape in read-only modeMiklos Vajna
Don't assume that all shapes provide an InteropGrabBag UNO property, check for it. (cherry picked from commit c76e6307b6cf33bda0cfa12647ed0342aecc1b29) Change-Id: I6347c54b0631c37154424babbfbd52f802af57d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-30Improve macro checksSamuel Mehrbrodt
Change-Id: Ie40801df8866b52c1458e020ffa9cba120720af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109552 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 1dc71daf7fa7204a98c75dac680af664ab9c8edb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110056 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-30tdf#139981: remove unsupported unused 'stock' propertyCaolán McNamara
which doesn't exist in GtkDrawingArea Reason: LibreOffice doesn't startup with GTK3 Change-Id: Ifbd3eb7c49df308f2e9d395a583072584183a500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-29tdf#123476 filter: Also handle empty ODFMike Kaganski
This builds on top of commit ada07f303e7cd1e39c73abe0741aefe7d9d73a57, to allow 0-byte ODT, ODS etc. Possible TODO would be somehow use default template for such empty files, getting the template name using SfxObjectFactory::GetStandardTemplate. That would enable using 0-byte ODF files as means to "create new document at this location from default template" workflow. Change-Id: I36e07b80f60c42aecdcc6a7357e5bdd18f62e4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109989 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 2854362f429e476d4a1ab4759c6a1f1c04150280) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110060 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-28Make brand image clickableHeiko Tietze
and link to LibreOffice volunteer page Change-Id: Ie422983d0e23faa16c2e2364b25798b938712a43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109637 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 35713de9d0b4981a019edd25591285d0bc6107db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109972 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-27tdf#138727 help browser didn't flow textCaolán McNamara
because of its size request, while the paned shrink lets the pane shrink below the size request the contents stay at a min of the size request and aren't really shrunk, just clipped. Instead don't let the pane shrink but don't set a size.request letting it shrink to its natural min of its contents which are then truly resized so the text flow works. Change-Id: Iaf6738ace28c82379ac6322310de9a22f9653473 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109983 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-22tdf#135590 MapUnit::Map100thMM fallback is inappropiate for writerCaolán McNamara
which uses MapUnit::Twip so directly after insert, envelope, ok the new document sidebar was using MapUnit::Map100thMM to lookup paper sizes instead of MapUnit::Twip giving inconsistent results against format, page Change-Id: I6a92fddedfe9fef8ad7532ad00b2b38b9741bb69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109751 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-01-20silence "gsignal.c:2731: instance X has no handler with id Y" warningCaolán McNamara
Change-Id: Iafc0aa085338fb41758fa845252f584c2a8aea76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109584 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara
except for extensions/uiconfig/spropctrlr/ui/multiline.ui Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109311 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-14Resolves tdf#139343 and tdf#139335 - Community/Enterprise flavorHeiko Tietze
* Switch CE/EE per --disable-community-flavor internally use HAVE_FEATURE_COMMUNITY_FLAVOR * Version info in about dialog shows text depending on this flavor * Start center also shows the brand image now * TDF builds use a brand image with TDF tagline in the about dialog * Brand images with just "Community" (no Edition) Change-Id: I363dd2b39df9aad951c9d79addf9bdedfc4a3495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108980 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 2d69acfde50cb0e06a9a057939078fd102d371a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109274 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-10Bump copyright year to 2021Adolfo Jayme Barrientos
Change-Id: I3159bfc21a35fc80aef57c7d809d8ea8c62a732e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108566 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 1f1f68d6e8a32d8884e8de322e32c588a87964db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108581 Tested-by: Jenkins Reviewed-by: Martin Srebotnjak <miles@filmsi.net>
2021-01-08Missing construction of SfxCmisVersionsDialog::m_xVersionBoxStephan Bergmann
...ever since b1baf73dc671069bedec18d170f8199b0766ea60 "weld SfxCmisVersionsDialog". (Found by GCC 11 trunk with --enable-optimized, > sfx2/source/dialog/versdlg.cxx: In constructor ‘SfxCmisVersionsDialog::SfxCmisVersionsDialog(weld::Window*, SfxViewFrame*)’: > sfx2/source/dialog/versdlg.cxx:435:36: error: ‘this’ pointer null [-Werror=nonnull] > 435 | m_xVersionBox->set_size_request(m_xVersionBox->get_approximate_digit_width() * 90, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 436 | m_xVersionBox->get_height_rows(15)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I2720d6bc49af717951a0af6a262fb013a27e09df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108886 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 29e36c699c610be4fe6f8a2fe21ae3e4c8bdbd38) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108908 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23tdf#89709 Make statusbar page number/bookmarks control tooltip showJim Raykowski
Change-Id: I3a84ae29d4758799e1ee7e2ab1349ca3b30fb5f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102883 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit c81fea2e78d66c1978cb2340868c938ba9d6c9f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107701 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-12-18Delete Category dialog includes '~' text in the titlebarCaolán McNamara
Change-Id: I8581e5219ffc690e686a0d563463c19b682ea04b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107910 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-16tdf#138938 put the tooltip on the toolbar item instead of the toolbarCaolán McNamara
Change-Id: I69ff3813a726f26daa20a00ce3a0bb311a162c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-15tdf#138935 rsDeckId is invalid by the time collectUIInformation is calledCaolán McNamara
Change-Id: I4afc1ed1bbbfbbd510617a51b9aa6d627471d80d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-12tdf#138823 "Recent Files" --> "Recent Documents" in StartcenterSeth Chaiklin
Change-Id: I70121805e5b6ff4b6eed841e5f3a27302162f50b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107616 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit cb323d8616700eaf5052e4467396d6b56118b064) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107618
2020-12-11tdf#138762: crash when trying to open sidebar w chart in WriterAron Budea
In Writer when in chart edit mode, and the chart is deselected, the object selection remains. Opening Properties sidebar at this point crashed. Calc and Impress were unaffected. Regression from b5fdb148fe87a90f3e586efcea7aa6ef865fa42a Change-Id: I356c3a42c41dd38e4739df27c72c6d67722b1dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107500 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 7e5991dc695d1e590483615c2907811ce4117834) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107542
2020-12-09cid#1470371 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ida60f251e83ea150e563bc0ef5a2be64f481fb08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-07Remove remaining bogus use of objc_msgSend()Tor Lillqvist
Follow-up to 5bf61e98b0746a4afeb68a80e54b4eb4bf4ea89f. Should avoid crashes when running as arm64 code on macOS on arm64. Change-Id: Id05d182684df82c8a7bf09f6bb7e8ccb01997b62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107259 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107324
2020-12-03tdf#107870 sw: don't jump to cursor setting Record ChangesLászló Németh
Using Edit->Track Changes->Record or Record Tracked Changes on Track Changes toolbar scrolled the pages back to the text cursor, breaking the review process of the document. Change-Id: I890e845ff94b636dd6edae19969d913e8d7a7b65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107005 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 1fd0919d92e792fa4af209a0fc7fde55c9958d1a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107103 Tested-by: Jenkins
2020-12-03uno:Printersetup: Allow preselecting a printerSamuel Mehrbrodt
When calling "uno:Printersetup" from a macro, allow preselecting a printer in the printer setup dialog by passing the printer name as an argument "PrinterName" Change-Id: I6b435f52a4123dc7fd49f6d771052ff1b8e743c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106634 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit ccb0b825305a158d9142e1a5316c6ff7905f6ecb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106678 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-12-03Add 'SinglePrintJobs' to PrintOptionsSamuel Mehrbrodt
So that this option can be set via UNO API Change-Id: I0b69162661a4327d59aaed82d5eff98cb50d852c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106593 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 2e2c162b7a816d990415fca434e6d3d5600b2858) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106677 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-12-01Resolves: tdf#138417 crash on customize sidebarCaolán McNamara
Change-Id: Icbb08b44e7f8729704d8278378a259fecb9bee4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-01cid#1470362 Uninitialized scalar fieldCaolán McNamara
Change-Id: I8828b7e098c1af9411b15b449f425242f5e64635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24center the button for narrower Colibre theme iconCaolán McNamara
Change-Id: I7feb62abf4e4f4b635c0e3096ff67f698d8de6b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106514 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24open_more.png is narrower than other icons in Colibre themeCaolán McNamara
so use a different one to measure desired width of tabbar Change-Id: Iace4b46d77d5cb52b2faaf6bb035be50fd556d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106512 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24tdf#132860 Assign value to set_sensitive flag in m_xNameshubham656
Change-Id: I9438e1a18253d90ff26e71b3aab83e96468fb9d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106461 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 1795cfde106c830bff513d3a9ff27d1759f9b227) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106441 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-22tdf#123936 Formatting files in module sfx2 with clang-formatPhilipp Hofer
Change-Id: I0ddd7b531cbf9aed6a3834e3cd15c7fe3644736e (cherry picked from commit 92daf140419e4539f6843e30428e786c3e655dcc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105706 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-11-21sfx2: lok: reliably support multi-documentsAshod Nakashian
Instead of using the current view to set the DocId, we instead make sure that the ShellView object has the DocId set at construction time. This turned out to be necessary in at least one case (which has a unit-test that failed), which is when events fired during the creation of a new view. The cursor position is notified before we have a chance to set the DocId and because of that we miss the notifications (or worse, we end up sending them to all other documents' views in an effort to fix this bug). This approach is clean and always guarantees that all views have the correct DocId set as soon as possible and that all notifications are sent as expected. A unit-test is added to exercise mult-document usage, which exposed a number of bugs and issues that have been addressed in this patch. Change-Id: Icf5145fb1dabd0d029368310c2b9bf73ae927ccc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99975 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106252 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-21these don't need to include vcl/button.hxx anymoreCaolán McNamara
Change-Id: I6af85519b1fd55c1b4192cbdc9661b053b302f51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-21Avoid unused parameter 'pImpl'Tor Lillqvist
Change-Id: I8dd30ed3ffffa0e5340b32ce4399dd05cc57e2b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105962 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106258 Tested-by: Tor Lillqvist <tml@collabora.com>
2020-11-20weld TabBarCaolán McNamara
Change-Id: I698f4dfc64bfa9bc4896111757616b4051b10293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105797 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-20sfx2: lok: refactor notifications and const correctnessAshod Nakashian
This reduces the stringification and reuses the notificaiton helpers to reduce code duplication. Change-Id: Icf9f9c50f3eeee61a0ded741d39fed37cfcc8da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99972 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106221 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-20fix tdf#138335 guard sidebar uno methods with SolarMutexThorsten Behrens
Wasn't threadsafe before; using vcl/gui code, so we need the SolarMutex. Change-Id: I3d4407f095837d03ad492fcdf9a08746cf911d25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106169 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-11-19tdf#138315 make More options buttons in Chart Sidebar deck work againCaolán McNamara
Change-Id: I513c09bcec21fcb9a6c7c08ba528822ba06474f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-19sw replacement image creation: fix this when an ODT's settings.xml is invalidMiklos Vajna
This builds on top of commit c123bfff501229f398a1b679fc7434b82d53685c (Bin overly eager early return that stops replacement image creation, 2020-08-20), and handles a similar case, when SwView::ReadUserDataSequence() is not called at all. The result is the same: no shell is selected on the command dispatcher stack, so .uno:UpdateAll is ignored and the replacement images are not created. Change-Id: If8b74424b0ad88e63129fd8f7efd09f85e300895 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106068 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-17Remove unused SfxFrameDescriptor::SetActualURL parameterStephan Bergmann
It got technically unused when e79e8117dcc7475d8d90afeaaac9eb7050ff244e "loplugin:unusedfields in sfx2" removed SfxFrameDescriptor::aActualURL, which in turn had apparently become unused over a series of commits cleaning up unused code. The function looks like a misnomer now, and it is not clear to me whether what it does is still useful (and whether or not all the clean-up that brought us here was actually good), but lets leave the remains as they are for now. Change-Id: I0479068176cc72193b2b44fc49d8fd3d71eadcb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106013 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-17loplugin:stringviewparam extend to constructorsNoel
Change-Id: Ia573921566ec6079b843cbcc0401d9d0f5c62089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105969 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-17loplugin:stringviewparam check methods tooNoel
not just functions Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-16tdf#138024 Default Icons not refreshing in template manger search viewVert D
*added missing funtion to searchview *call searchupdate when refreshing Change-Id: I576b2e2de37e3f34b7499a914f0707586687643e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105387 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-15add <!-- n-columns=1 n-rows=1 --> before every GtkGridCaolán McNamara
for a in `git ls-files '*.ui'`; do sed -i 's/^\( *\)\(<object class="GtkGrid".*\)/\1<!-- n-columns=1 n-rows=1 -->\n\1\2/' $a; done so we get the same behavior in glade as before 3.38 in that the grid preview don't show any unoccupied grid squares replace all existing n-columns=X n-rows=Y lines because they are all wrong, except for cui/uiconfig/ui/additionsfragment.ui sw/uiconfig/swriter/ui/pageheaderpanel.ui sw/uiconfig/swriter/ui/pagefooterpanel.ui which are correct. Change-Id: I401bbe8e098c26e7f57d6a872d3b70fc1ce85a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105846 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-12loplugin:unusedmethodsNoel
Change-Id: I90d402a5c18ab16424a042bcea1470fa8a3a5839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105629 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-12New loplugin:stringviewparamStephan Bergmann
...to "Find functions that take rtl::O[U]String parameters that can be generalized to take std::[u16]string_view instead." (Which in turn can avoid costly O[U]String constructions, see e.g. loplugin:stringview and subView.) Some of those functions' call sites, passing plain char string literals, needed to be adapted when converting them. Change-Id: I644ab546d7a0ce9e470ab9b3196e3e60d1e812bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105622 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-12Revert "remove Fraction::operator tools::Long()"Noel Grandin
This reverts commit 48b667a7e7d25f835f95df89162a7849d6972531. Reason for revert: some discussion required Change-Id: Ia0990d280837fb68b7ddc9f472ec78b1467b4311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-12notebookbar: set language before creatingSzymon Kłos
Change-Id: I04243667b564670096d2c8db0352ab179e1b0151 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104212 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105595 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
generated by cgit (git 2.34.1) at 2024-05-21 21:45:19 +0000