summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30remove type decorations on char literalsJochen Nitschke
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: https://gerrit.libreoffice.org/35893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30use SFX_INTERFACE_NONE constantNoel Grandin
inside of constructing SfxInterface(0) by hand Change-Id: Ic2cbe39366a36b40b672242a250f68135d4e2cd3 Reviewed-on: https://gerrit.libreoffice.org/35892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29Fix typo in methodAndrea Gelmini
Change-Id: Ib2b05abaeacd3b8787f938a49a0d9673096b5f42 Reviewed-on: https://gerrit.libreoffice.org/35857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29convert EViewType to scoped enumNoel Grandin
Change-Id: I5b10aada64408897a56a5932aa28486d7562d617 Reviewed-on: https://gerrit.libreoffice.org/35822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29expand vis to visible; fix typosdennisroczek
* translate German source code comments * remove bogus surce code comments * remove ascii art * removed old StarOffice/Sun internal bug tracker references * remove left over from commit dcd5dee88e3c1185638b190553bef65c2ef6566f Change-Id: I3c5cce621c43e4a03afb76f4cc5a12065914e5ad Reviewed-on: https://gerrit.libreoffice.org/35404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29loplugin:singlevalfieldsNoel Grandin
Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61 Reviewed-on: https://gerrit.libreoffice.org/35804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28remove enum slot code from sfx2Noel Grandin
since we only used it for the pseudo-slot stuff, which is now gone Change-Id: I72146090e7741d5b71d581fa0b5c6d43c154445a Reviewed-on: https://gerrit.libreoffice.org/35759 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28remove unhandled SID commands from sfx2Noel Grandin
Change-Id: I5473dbb1fdc2c3779892610ab4ea5f6146291921 Reviewed-on: https://gerrit.libreoffice.org/35742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27create SfxInterfaceId o3tl::strong_intNoel Grandin
Change-Id: Ie52f63382a9fb36f9a472801be012b140bfb51f6 Reviewed-on: https://gerrit.libreoffice.org/35722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27remove unhandled SID commands in sdNoel Grandin
checked to make sure none of the related .uno commands are present in any .xcu files. Change-Id: Iec555836a0a926e070b7632dc1205decf49d331f Reviewed-on: https://gerrit.libreoffice.org/35615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-26Fix typosAndrea Gelmini
Change-Id: I5518e764fd8349c476e79bb888e93a1dab01ed1d Reviewed-on: https://gerrit.libreoffice.org/35644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24Just include sal/types.h nowadaysStephan Bergmann
Change-Id: Ic8f6322854ff0ac25c34cd9286545c8aaa27d03b Reviewed-on: https://gerrit.libreoffice.org/35628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23remove unused helpid in SfxShellNoel Grandin
Unused since commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae "update unusedmethods plugin to deal with constructors" where I removed a unused SfxDockingWindow constructor. And in that case, the helpid was only being used to assign the window a UniqueId. Change-Id: I148e424424fcf08449440b83a8600071b39d7a07 Reviewed-on: https://gerrit.libreoffice.org/35554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22create SfxDisableFlags enumNoel Grandin
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f Reviewed-on: https://gerrit.libreoffice.org/35514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-21Notebookbar: correct initial icon sizeSzymon Kłos
Before this patch initial icon size in the NotebookbarToolBox was determined by Sidebar settings not Notebookbar Change-Id: I66ac709c606ef60fb3505bbbe51dfebbcc81d20c Reviewed-on: https://gerrit.libreoffice.org/35493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-20uitest: use the new ui test logger also for the UNO commandsMarkus Mohrhard
Change-Id: I220b817df82cd0f26f6d8b72a28b7becfd954461 Reviewed-on: https://gerrit.libreoffice.org/35448 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-19uitest: add a way to log the UNO commandsMarkus Mohrhard
Change-Id: Ibbf7fd8e44b0be82e496eab6d98468f03038e60f Reviewed-on: https://gerrit.libreoffice.org/35441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-19Use just geParameter instead of hasParameter + getParameterMatteo Casalin
getParameter returns and empty string if the key is not found, so we can just avoid searching twice for the same key. Change-Id: Ic48debce05fe94d8e087b64bde5a589e54bfb616
2017-03-19OUString-related simplificationsMatteo Casalin
Change-Id: I2f4099410bcdb9e04583cd37bf63ef86ce81f7e5
2017-03-19Can return const OUString&, hereMatteo Casalin
Thanks to Noel Grandin for his suggestion. Change-Id: Ia0d9c46c03928e5551e766572c814f4e9ba6f278
2017-03-19SfxViewFrame::ExecReload_Impl - remove written-only variable aURLMatteo Casalin
Its only user was commented-out by commit 6c1be80980cbf02ecaf07996b1c2be5777f59124 (2004) and then removed by commit 40fe03745fc75609350cf8115134eb07f04eefa7 (2010) Change-Id: I821a97275b79230e9e389a9b57c82110fa16aa8e
2017-03-19Fix typos + some German translationsAndrea Gelmini
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: https://gerrit.libreoffice.org/35406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19fix typo/grammar: "the the" --> thedennisroczek
* also removing pointless ASCII art (tdf#62475) * truncate ending whitespace in Doxyfile Change-Id: I59b012f41ac0d170216229da85a49aa41689dee5 Reviewed-on: https://gerrit.libreoffice.org/35151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17SfxObjectFactory: directly store factory name as OUStringMatteo Casalin
Change-Id: I0779be1e4b344124514115c6645394d26ac09c36 Reviewed-on: https://gerrit.libreoffice.org/35375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17Remove SfxObjectFactory::GetShortName()Matteo Casalin
Used in just two places, where GetFactoryName can also work. Change-Id: I8d498345c41aef520ef776a3deb6744cc64756f5 Reviewed-on: https://gerrit.libreoffice.org/35374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17Use SfxObjectFactory::GetFactoryName, againMatteo Casalin
Change-Id: I653fdaa2564a97716e400b509eb7408ffe6050a3 Reviewed-on: https://gerrit.libreoffice.org/35373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17Simplify same assignment in both branches of a conditionalMatteo Casalin
aTitle was assigned GetTitle() in both branches since initial commit (2007) Remove the (used just once) temporary, while at it. Change-Id: I0c6cb0ef8f720fea7f4105edf8233a2c64377e4f Reviewed-on: https://gerrit.libreoffice.org/35372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17Use SfxObjectFactory::GetFactoryName/URLMatteo Casalin
instead of OUString::createFromAscii( GetShortName() ), in one case manually added to factory URL prefix. Change-Id: I762fc1bcd6dcf7246531816faad2682caf9133fb Reviewed-on: https://gerrit.libreoffice.org/35371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17cleanup double includes and declarationsJochen Nitschke
Change-Id: I770e09f48b1a3e8299f59a8e475ba3c18d436d7b Reviewed-on: https://gerrit.libreoffice.org/35312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-17remove unused defines from HRC files in sfx2Noel Grandin
Change-Id: Iffe6508558795e059048acae2ca955a78d3e9d6d Reviewed-on: https://gerrit.libreoffice.org/35279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17gpg4libre: Also show Infobar when signature is validSamuel Mehrbrodt
Change-Id: I5eb639d5cc298b595ccee71f00c1f2fc54867186 Reviewed-on: https://gerrit.libreoffice.org/35287 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-16No need to keep these booleans as data membersMatteo Casalin
Change-Id: Id56cb074a3b62423769afc3c4a3ab2f7a312f1be Reviewed-on: https://gerrit.libreoffice.org/35284 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16tdf#103355 Working menu after closing slideshowSzymon Kłos
Change-Id: Ic6bfb6f9a86d9c475d2d3368b924b56a89c90551 Reviewed-on: https://gerrit.libreoffice.org/35251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-16Notebookbar: fixed crash after customizationSzymon Kłos
+ removed listener + prevent from using invalid pointers Change-Id: I3a846d2344148456d3edba23296a4781496eba8b Reviewed-on: https://gerrit.libreoffice.org/35248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-15tdf#105040 Notebookbar: added shortcuts toolboxSzymon Kłos
In the tabbed notebookbar the shortcuts toolbox is introduced. It is placed before tab labels, after the menu button. Customization is possible, buttons are loaded from the newly created toolbar "Notebookbar shortcuts". NotebookbarTabControl was moved to the sfx module. Change-Id: Ifa4a1688c6e92c2f03bd386608e3e9d1c28069d4 Reviewed-on: https://gerrit.libreoffice.org/35194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-14remove unused RID constantsNoel Grandin
found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14remove noise UUUU tags in commentsNoel Grandin
Change-Id: Id8a2940ae7348bf75ca967f31adf8489dc678d00 Reviewed-on: https://gerrit.libreoffice.org/35161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13tdf#95416 remove ../ in #include headers of sfx2 filesJeevan
Change-Id: I5f3e1a8fe559500aec7ea9e38edaba42dff3f98b Reviewed-on: https://gerrit.libreoffice.org/35028 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-11Fix typosAndrea Gelmini
Change-Id: Ia79bc8d35cf19438d177f31a8e0c8603102b4ef1 Reviewed-on: https://gerrit.libreoffice.org/35061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-10shuffle this around a littleCaolán McNamara
Change-Id: Ibf23114885c49163d50b3249db8788770fe74352
2017-03-09Clean up uses of integer typesStephan Bergmann
Change-Id: If022ca9de8db49b885065c32b4f6f89debae1392
2017-03-08Simplify GetStateCache callStephan Bergmann
Change-Id: I527d8112f7cf0e4fbc6380484be0c6704f3dfdd4
2017-03-08No need for extra heap allocationStephan Bergmann
Change-Id: I69435ff2be66f8b2ed879bdf7998bd8145ef59b4
2017-03-08valgrind: fix leakCaolán McNamara
Change-Id: I49a9a03ef59bca5a5c43d2835e6c4f1cbf0cfab8
2017-03-08loplugin:loopvartoosmallStephan Bergmann
Change-Id: I788afd92bb404d8faf96b631d2e7c6f869e49c2d
generated by cgit (git 2.34.1) at 2024-07-15 15:09:12 +0000