summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2017-02-15Some simplifications, using UNO_QUERY_THROWStephan Bergmann
Change-Id: Ida366e40ade98443019d3c312ae19864f93c9e5e Reviewed-on: https://gerrit.libreoffice.org/34258 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-15remove unused PREVIEW from SfxObjectCreateMode enumNoel Grandin
Change-Id: Idf930f768c978ac8aa53527f6ddb8864d0fdec1d
2017-02-15remove unused OBJECTBAR from SfxChildIdentifier enumNoel Grandin
Change-Id: I45b02055d18ca201341c61a1558ee5b0c58d7ba8
2017-02-15remove unused MOVEDOCKINGWINDOW from SfxDockingConfig enumNoel Grandin
Change-Id: I457596ed438b6c2173f25136bb8a99730b8f3a48
2017-02-15Related: tdf#105672 Load toolbar properties from .uiMaxim Monastirsky
- Supports toolbar-style, icon-size, orientation. - Defaults are: toolbar-style = icons only icon-size = what's set in Tools > Options... for Sidebar/Notebookbar orientation = horizontal - Remove no longer needed BigToolBox (use toolbar-style=both + icon-size=3 instead). Change-Id: I185388255a351dfd6719a363b7e399bf36b0b25d Reviewed-on: https://gerrit.libreoffice.org/34281 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-14Convert WindowType to scoped enumNoel Grandin
Change-Id: I85cfe02f28729e13f2c0dd3d91cd89e6f3e3b6a9 Reviewed-on: https://gerrit.libreoffice.org/34219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-13Fix typosAndrea Gelmini
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-10Remove MinGW supportStephan Bergmann
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-10convert InsertOperation to scoped enumNoel Grandin
and drop unused LINK enumerator Change-Id: I6c42424ae5a7503b3e14e5f04fcf7a49b595b416
2017-02-10convert SvtSaveOptions::EOption to scoped enumNoel Grandin
and remove unused E_SAVEUNPACKED, E_USESHA1INODF12, E_USEBLOWFISHINODF12 enumerators Change-Id: I7c384e0c30af5091a22beeda1c77e4b71fdde55e
2017-02-10convert SvtSecurityOptions::EOption to scoped enumNoel Grandin
and drop unused E_MACRO_DISABLE enumerator Change-Id: I0bd706d4d4e1d8b9004e68c9e77c11410c62a64a Reviewed-on: https://gerrit.libreoffice.org/34067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09Resolves: tdf#101648 disable new/modify of table stylesCaolán McNamara
cause there is no ui for it at the moment, so it crashes Change-Id: I703449ff69f93b6385d3bf9225abe81682d3b893
2017-02-09convert BmpConversion to scoped enumNoel Grandin
and drop unused 4BIT_TRANS and 1BIT_MATRIX enumerators Also fix a bug in x11::convertBitmapDepth where we were incorrectly passing BmpConversion enumeratirs to ReduceColors Change-Id: I903c6866750e46ee752e10a17c05fcaaf6b11242 Reviewed-on: https://gerrit.libreoffice.org/34062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09Reapply "create ErrorHandlerFlags scoped enum for error handling flags""Noel Grandin
This effectively reverts commit 32cae6a2eaa41568888df9c8fc5605debd8d704a. Change-Id: I15bb0a5c4acaeee6d47dd93a71601d9687d701bc Reviewed-on: https://gerrit.libreoffice.org/34028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08oox, sfx2: can use std::move() hereMiklos Vajna
Change-Id: I0add196f79045e8cb7280b2b7d1d8620e4ec669e Reviewed-on: https://gerrit.libreoffice.org/34013 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-07Revert "remove ugly operator* in DynamicErrorInfo"Michael Stahl
This reverts commit b5e3f8a5fa98a249ecd50021c33cf2a5c7a3b4fc. The problem is this: ==24217== Conditional jump or move depends on uninitialised value(s) ==24217== at 0x29A25FCE: SfxObjectShell::SetError(unsigned int, rtl::OUString const&) (objmisc.cxx:220) ==24217== by 0x29A35E6E: SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) (objstor.cxx:2300) ==24217== by 0x29A3705C: SfxObjectShell::DoLoad(SfxMedium*) (objstor.cxx:765) ==24217== by 0x29A6BC48: SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (sfxbasemodel.cxx:1802) The commit is bogus because it introduces a DynamicErrorInfo::GetErrorCode(), which overloads ErrorInfo::GetErrorCode(), which is used at least in DynamicErrorInfo_Impl::RegisterEDcr() and used to return a constructor argument of DynamicErrorInfo but now returns pImpl->lErrId, which is what this statement is trying to initialize. Ultimately this causes my clang+ASAN build to fail because the uninitialized error code happens to be detected as a mere Warning: Test name: testMathMalformedXml::Import assertion failed - Expression: !xComponent.is() - loading succeeded: sw/qa/extras/ooxmlimport/data/math-malformed_xml.docx Change-Id: I9141144e0bc356ee54279948f2fce036d1831a86
2017-02-07Revert "create ErrorHandlerFlags scoped enum for error handling flags"Michael Stahl
This reverts commit 05e78bde26d8b8b257ed22a0ce20c5b386a629d1. Depends on the other commit that needs reverting
2017-02-07sfx2: if the exception thrown by filter isn't known...Michael Stahl
... then don't silently ignore it but just abort. Evidently this cannot happen, because if it were a real possibility the author of this exception handler would have at least called SetError here. Change-Id: Iaa5f1f1d4cac388ae08214f6031a8bc279e6fceb
2017-02-07tdf#104870 - keep reference on the TitleBar while setting title.Michael Meeks
Unlikely to fix the issue, but may help. Change-Id: I3c319f550e86f2ab731b072d86d258dca12d34fa Reviewed-on: https://gerrit.libreoffice.org/33998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-02-07create ErrorHandlerFlags scoped enum for error handling flagsNoel Grandin
Change-Id: I30c80979c87bad7bc98f36a158c31c88d80d1caf Reviewed-on: https://gerrit.libreoffice.org/33991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07remove ugly operator* in DynamicErrorInfoNoel Grandin
I can see why you'd want to hide this horrible tunnelling of information with objects registering themselves in a global list. Urrgh. Change-Id: Ib151a0d2d5a4508dc456e52883e488ce56d9a095 Reviewed-on: https://gerrit.libreoffice.org/33984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06Indentation fixesMiklos Vajna
Change-Id: I3e7262c26c848f8c16564d4b27218611bf880903
2017-02-05sal_uIntPtr to sal_uInt16Matteo Casalin
Change-Id: If463ae457f53a0a8b12cc0748afbc654f54ae3c3
2017-02-03TyposJulien Nabet
Change-Id: I36f443c266670bd26aa6b813075e18653f372f52 Reviewed-on: https://gerrit.libreoffice.org/33900 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-03new loplugin:unusedenumconstantsNoel Grandin
These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03tdf#80807 guisaveas: never recommend system's tempdirJustin Luth
Various download-and-open mechanisms save to the system's $TEMP dir. If so, don't recomment saving in that same location in the GUI dialog! That's just silly. Change-Id: Ifa20fdfd81d768bbd893f92a50355f08c3aab356 Reviewed-on: https://gerrit.libreoffice.org/33353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-02-02loplugin:useuniqueptrStephan Bergmann
Change-Id: I3a246a22baaac8195dc1b94c42994de7d80e8336
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02expand out ::sax::Converter::convertNumber to OUString::numberNoel Grandin
which results in much simpler code overall, there is no need to go via an OUStringBuffer all the time Change-Id: I69eba92c93f471fa9a45f97c29c56dcf3cd1ebf8 Reviewed-on: https://gerrit.libreoffice.org/33773 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01InfoBar: Introduce different typesSamuel Mehrbrodt
Makes it easier to push various infobars without specifiying the colors manually. Change-Id: I0f861ba02409a42ba2ae767a1ca7634eaf0e7aef Reviewed-on: https://gerrit.libreoffice.org/33777 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-01Improve InfoBar labels for signaturesSamuel Mehrbrodt
Change-Id: I50619d94c7bebeb99b5dbb9e21f0eefa3fd39482 Reviewed-on: https://gerrit.libreoffice.org/33778 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31SolarMutexGuard for ImplDbgTestSolarMutex assert in JunitTest_dbaccess_complexCaolán McNamara
Change-Id: Ic2109abdec0ad3305c2720ac9012585cd7ceb25b
2017-01-31Build the json message a much less expensive way.Jan Holesovsky
Change-Id: I10911deb52f6a0c65262f9d6af459cf6ddd2fae9
2017-01-31Resolves: tdf#104884 print preview replaces the frame controllerCaolán McNamara
so the sidebar is listening to the old controller which has been disposed[1] so when print preview exits and yet another controller replaces the print preview one then the sidebar still doesn't listen to the current one. framework broadcasts COMPONENT_DETACHING/COMPONENT_REATTACHED around these changes, so if we listen to them we can keep attached to whatever is the current component [1] note that ContextChangeEventMultipler doesn't inform clients that the controller has been disposed, this remains unchanged here Change-Id: I141509d4a262307afd7dcfc3d77de6cdd6dbfa5f Reviewed-on: https://gerrit.libreoffice.org/33758 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-31tdf#105566 Close Infobar after clicking action buttonSamuel Mehrbrodt
gpg4libre Change-Id: I24c7021043c5fb1a2a8ef1fbce66f8e416377692 Reviewed-on: https://gerrit.libreoffice.org/33755 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31Use white font for colored InfoBarsSamuel Mehrbrodt
Change-Id: I35ac32fc213afe7dc8f3ed29caaa982117ec7737 Reviewed-on: https://gerrit.libreoffice.org/33748 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31tdf#105566 Show InfoBar also for signed docs with warningsSamuel Mehrbrodt
gpg4libre Change-Id: Ia3df9d9d8121539fd1c6b77f8872287b0b432d8e Reviewed-on: https://gerrit.libreoffice.org/33744 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31Add helper methods to get common colors to SfxInfoBarSamuel Mehrbrodt
Change-Id: Ic3816b046839636fa0d1b8cb881725bcc80ef011 Reviewed-on: https://gerrit.libreoffice.org/33742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31tdf#105566 Show InfoBar when signature is invalidSamuel Mehrbrodt
gpg4libre Change-Id: I272ac155889e25b9af91ff723a014588a65b045a Reviewed-on: https://gerrit.libreoffice.org/33737 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31sfx2: fix comment copypastaMichael Stahl
Change-Id: Iebb5f51afe6f32883a535656d8b9e1f0ec678050
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31a whole bunch of SAL_WARN_UNUSEDNoel Grandin
Change-Id: Iea28debc7d3abc58cca21bd3856cb65b321dc1e6 Reviewed-on: https://gerrit.libreoffice.org/33693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27use a define for invalid SfxPoolItemJochen Nitschke
and use helper function IsInvalidItem() more Change-Id: Ifd651a336a7bd4ef4f945219d765afb827465438 Reviewed-on: https://gerrit.libreoffice.org/33611 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-27-Werror=int-in-bool-context (GCC 7)Stephan Bergmann
Change-Id: I69f31a94f3e57b3488c576f8d8e0569f459a2117
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor sfx2..storeNoel Grandin
Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf Reviewed-on: https://gerrit.libreoffice.org/33514 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25sw: various small cleanupsMiklos Vajna
Change-Id: I1eb56649fb9913cb32397c1ef49634a0d202f1a1
2017-01-24Resolves: tdf#105450 calc navigator gets 0 height on toggle off/on when dockedCaolán McNamara
Change-Id: Icd346cdf0a208ccaeddd77e6803f4f906361324c
generated by cgit (git 2.34.1) at 2025-01-02 19:38:05 +0000