summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-09-29sfx2: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I7bac4105494cdbbadd4c4d78ce1fcf03b8ccae6c
2014-09-28border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos
Second pass. Change-Id: Ic4702d2ca7a9d54ee4712dcd073006f16b2d5d1d Reviewed-on: https://gerrit.libreoffice.org/11669 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-28fdo#75757: remove inheritance to std::vectorTakeshi Abe
from SfxVerbSlotArr_Impl. Change-Id: I84582f10095638a0fef82aa46f721d57a8b27c27 Reviewed-on: https://gerrit.libreoffice.org/11662 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-27border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos
I know the old GNOME HIG mentions extra spacing for queries, but I’ve never understood why -- not even GNOME itself respects that rule. It just looks inconsistent and wastes space. Change-Id: I181f800957f69b0943369791e460c7273b6b08f6 Reviewed-on: https://gerrit.libreoffice.org/11658 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-27fdo#84376 Add missing title to the Template Manager dialogAdolfo Jayme Barrientos
Change-Id: I514cc4354950119caa4c16d0ccb6b9d18290dee3 Reviewed-on: https://gerrit.libreoffice.org/11659 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove unnecessary casts in calls to SvStream.WriteSCharNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I4f17a2fd6a68f8078b97c96e89e27a5627c57c03
2014-09-26remove unnecessary casts'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-26remove unnecessary static_cast'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods e Please enter the commit message for your changes. Lines starting Change-Id: Ibfe7635451ef7b8813d7a59c78c5223092a17ad5
2014-09-26cleanup GUID/ClsId/CLSID typesNoel Grandin
- rename GUID to SvGUID so we don't need an #ifdef WIN32 - drop ClsId struct, since it is used interchangeably with GUID and has the same structure Change-Id: Idf5c14c82a6861ef585fb57896a9b12cfe40374c
2014-09-26fdo#75757: remove inheritance to std::vectorTakeshi Abe
from SfxFoundCacheArr_Impl, by typedef'ing it as boost::ptr_vector<SfxFoundCache_Impl>. Change-Id: Id0e50370b440fb53dbb56dabca9743b27a08b90d Reviewed-on: https://gerrit.libreoffice.org/11650 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25Start Center Template Manager TweaksEfe Gürkan YALAMAN
Template Manager and the related Start Center view has same transparent highlight color as Recent Documents. Also Template thumbnail containers should have the same size as Recent Docs view. Change-Id: I22e417a5c5ca5a849577d5a438a193371368fe24 Reviewed-on: https://gerrit.libreoffice.org/11467 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25Fix miscellaneous memory leaksMatthew J. Francis
thumbnailview.cxx: ::ImplInitSettings is called from various places other than the constructor, so mpItemAttrs must be freed each time gloactiongroup.cxx: Must call g_list_free on list returned by g_hash_table_get_keys Change-Id: Id5a592520987a1596debdbc48bfa171a537e400b Reviewed-on: https://gerrit.libreoffice.org/11638 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25coverity#1240261 Logically dead codeCaolán McNamara
we must check the new proposed state for sanity, not the old state Change-Id: Iabab0ccda4942ec82b243ad07762187be916d43f
2014-09-25Revert "fdo#73151 Always open Styles&Formatting dialog in the sidebar"Stephan Bergmann
This reverts commit 473ed449a4b6f550dc1af47a07c6e0ef243a98b2, which made JunitTest_toolkit_unoapi fail, as AccessibleDropDownListBox.createTestEnvironment (qadevOOo/tests/java/mod/_toolkit/AccessibleDropDownListBox.java) was no longer able to find its AccessilbeRole.COMBO_BOX AccessibleDropDownListBox, which it apparently expected to find in a docked stylist (cf. DesktopTools.dockStylist in AccessibleDropDownListBox.initialize).
2014-09-24fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt
This removes the floating window for Styles&Formatting as discussed in fdo#73151. Change-Id: I352d27a4d30632dcfda8963c23629e62ab850524 Reviewed-on: https://gerrit.libreoffice.org/11253 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-23loplugin: cstylecast, update PTR_CAST macro to use static_castNoel Grandin
I introduce a template method into the PTR_CAST machinery to maintain constness. There is now a FIXME in sd/../docshell.cxx because I needed to use a dynamic_cast there to work around the games it appears to be playing with OLE in-place activation. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, dropping the GCC-extension, unnecessary use of typeof from tools/rtti.hxx Change-Id: Iba5ace1aa27e02b34fcc91af1e658c43371afd03
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-22remove unused fields pName and pMethodName in SfxSlot classNoel Grandin
Change-Id: Icca5a0dee296fae1abeb78ea8ffa2f9e934bb111
2014-09-22fdo#84086 Fix assorted use-after-free bugsMatthew J. Francis
Change-Id: Iec004fffdb0afbe27bd69f379db90f6d904a8a65 Reviewed-on: https://gerrit.libreoffice.org/11553 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-22fdo#62104 Optimize thumbnail size by using PNG8 and other tricksTomaž Vajngerl
Change-Id: I54ece4a1977fe93c0e7bbb11774bd8657912c6bb
2014-09-21Disable the email sending menu entries when sandboxed on OS XTor Lillqvist
The way we send email doesn't work anyway in a sandboxed app on OS X. If we want to offer the functionality, we need to implement it in an OS X -specific way, perhaps using the Scripting Target functionality of Mail.app. What we need, to be really "native" in this regards on OS X, would be to have a "share" functionality that would in addition to sharing through email offer AirDrop, Facebook, Twitter etc. Like Apple's own apps. Quite possibly there are system APIs that automate much of that. But they probably require your app to be more "native" in other ways, too, like using NSDocument etc. Later... Change-Id: Id1424377b7d493d4ec696f3242dae55a2a67dfc7
2014-09-21Present tense and capitalizationAdolfo Jayme Barrientos
Change-Id: I4a4301f166036e294e4250c1ab1b599ad5bba7c5 Reviewed-on: https://gerrit.libreoffice.org/11526 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-19fdo#62947 make IDs unique, fixes, better namesTomaž Vajngerl
Change-Id: I6cbfd43f037fe89e0f753c67c9368b981b85bd35
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-17TyposJulien Nabet
Change-Id: Icf850c4b7b146a82a5638a3cd88ad02f3171aff3
2014-09-17Convert SvxColorWindow_Impl to Widget LayoutKrisztian Pinter
Change-Id: I8c830de56892fd8eb1c14add25f65c25046d47fd
2014-09-17Add writer document font colors to color palettesKrisztian Pinter
Change-Id: If3fedc45586eee068c40e92da87d5d550a456a64
2014-09-15Resolves: fdo#81635 crash after 3rd call to ApplicationScriptLibraryContainerCaolán McNamara
in PackageImpl::processPackage_ xComponentContext->getServiceManager()->createInstanceWithContext( "com.sun.star.script.ApplicationScriptLibraryContainer" does not increment the refcount, so on leaving the method the refcount is decremented by 1, because on the first enter the refcount happens to be three, then if the extension has more than 3 items in it the refcount hits 0 here and falls over some of fdo#79301, fdo#70607, fdo#66706 might be dups of this regression from 306efefe22e02248eff14f8be2cef68d75d26e55 I believe Change-Id: I3da50693fe656b68c5555b641d9b32246c8fc208
2014-09-12sfx2: remove optimization disabling workaround for GCC 4.2 bugMichael Stahl
i#116803 was filed against OOo Linux baseline (some GCC 4.2.x); let's hope the current GCC versions that are required for C++11 work fine. Change-Id: Ie95b52c801564519aec348ae3fd56b14e2408234 Reviewed-on: https://gerrit.libreoffice.org/11396 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-09-12sfx2: sal_Bool -> boolStephan Bergmann
Change-Id: I2db25fa6f7b9fdc2096e622918b7e55228960a94
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-11create a master document template typeCaolán McNamara
of application/vnd.oasis.opendocument.text-master-template with suffic otm https://lists.oasis-open.org/archives/office-comment/201002/msg00042.html desktop/icons/oasis-master-document-template.icns is just a copy of desktop/icons/oasis-master-document.icns because I can't draw Change-Id: I0d18c79c4c893e97505052884ee8be97d0f117a1 Reviewed-on: https://gerrit.libreoffice.org/11350 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-10Typo: (N|n)ormaly->(N|n)ormallyJulien Nabet
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
2014-09-10no member named 'UNKNOWN' in 'SfxItemState'Tor Lillqvist
Change-Id: Ice3d2bc4a575b324377273cdb655e06577f6a4a2
2014-09-10more fixes for SfxItemStateNoel Grandin
In commit 88a874fc "convert SfxItemState constants to a proper enum" I made some mistakes in converting bitwise logic to boolean logic. I fixed one of those places in commit 7ad83656 "fix bitwise->logic conversion in SfxItemState commit" This commit fixes the other places where I converted bitwise to normal boolean logic. I also validated that none of the existing code tries to uses combinations of these enum values. This commit also introduces an exception-throwing check in the one place where the enum is explicitly cast to make sure that no combinations sneak in. Change-Id: I545f7d17b76c4fd999078867caec314e83ffe165 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-10Replace uses of old SFX_ITEM_AVAILABLE alias with SFX_ITEM_DEFAULTStephan Bergmann
Change-Id: I88eeac06413fc3935cbbdb357ff8bf9acaa383a8
2014-09-10fdo#55380 replaced use of obsolete interfacesDaniel Sikeler
Change-Id: I94fed6a9361f21457b3e631efffc0db833068aef Reviewed-on: https://gerrit.libreoffice.org/11256 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-09-10callcatcher: update unused codeCaolán McNamara
Change-Id: Ie31c16318b09699e080484292d489a378e3a6dce
2014-09-10vcl: sal_Bool -> boolStephan Bergmann
Change-Id: Iff4da6d6281eb9194db348ebc10fbe7718538401
2014-09-09Doxygenize comments, and move them in front of the functions.Jan Holesovsky
Change-Id: I03723d1078b7ba726c8cc94887ca854324e3f9d8
2014-09-08coverity#1237351 Logically dead codeCaolán McNamara
Change-Id: Ia82d8d137c5f36cc48826cc851d6f00626e978aa
2014-09-06Related fdo#82088: removing aliases in headersStefan Weiberg
Change-Id: Id3496d1720630dd7a873edd04b664fc279c1c25e Reviewed-on: https://gerrit.libreoffice.org/11294 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06fdo#56562 OSX: Update URL in Writer title bar when saving .docMatthew J. Francis
Change-Id: I839ee3fd76d9c5666dd7f82cba26596c80ff2602 Reviewed-on: https://gerrit.libreoffice.org/11106 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06FloatingWindows are no longer loaded from resource filesCaolán McNamara
Change-Id: I2705bbb4db52779e0065400f09604384fd9cf151
2014-09-06Window::GetType returns WindowType not ResourceTypeCaolán McNamara
yikes! Change-Id: I5aba88fbc1e452c85fb4a75260bc3518bdf5facc
2014-09-05convert RID_SCROLL_NAVIGATION_WIN floating window to .uiCaolán McNamara
Change-Id: I92d13856fc4d206323d5517a8a48671bba683fec
2014-09-03These slots not meant to be added to a toolbar or recordedMaxim Monastirsky
Change-Id: Iaf847c02265fcc7d75c1cd54bc836ec85cb830ec