summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-03-03minor comment changeTomaž Vajngerl
Change-Id: If917e7e9897db0fb486f4852feb0d73e951c8b74
2014-03-03fdo#61320: Allow user to choose whether to create thumbnails inside odf.christianju
Change-Id: I8c8129534ebcca32941ad76b201bb9a0243d8c3e
2014-03-03SFX2 : Remove usage of DBG_CTOR and DBG_DTOR.Arnaud Versini
Valgrind is capable of detecting such bugs. No need for extra macros. Change-Id: I35a9403da152ea2b637c0235d776c7789e2ef207 Reviewed-on: https://gerrit.libreoffice.org/8420 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03remove unused code in sfx2::sidebarNoel Grandin
sfx2::sidebar::ContextList::IsEmpty() sfx2::sidebar::Deck::PrintWindowTree(std::vector<sfx2::sidebar::Panel*> > const&) sfx2::sidebar::EnumContext::EvaluateMatch(sfx2::sidebar::EnumContext const&) const sfx2::sidebar::EnumContext::GetContext() const sfx2::sidebar::Paint::Set(sfx2::sidebar::Paint const&) sfx2::sidebar::Panel::PrintWindowTree() sfx2::sidebar::SidebarDockingWindow::GetChildWindow() Change-Id: I285567320677a831b2b786f4f73b000eed39987b
2014-03-02coverity#704705 Dereference after null checkCaolán McNamara
Change-Id: I7571b8d05f96ce8a3bf8532d4def647b6815854a
2014-03-02coverity#704703 Dereference after null checkCaolán McNamara
Change-Id: I272a37a9935785d86ad76db3978cb658573e998c
2014-02-28loplugin:literaltoboolconversionStephan Bergmann
Change-Id: Ic8d00f036ef439ae8e1184289edb3ba6a117e1f6
2014-02-28sal_Bool -> bool in mostly vcl moduleChris Sherlock
Conflicts: include/vcl/settings.hxx svtools/source/table/tablecontrol_impl.cxx sw/source/core/frmedt/fecopy.cxx vcl/inc/canvasbitmap.hxx vcl/inc/headless/svpframe.hxx vcl/inc/unx/salframe.h vcl/inc/win/salframe.h vcl/inc/win/salprn.h vcl/inc/win/salvd.h vcl/osx/DragSource.cxx vcl/osx/DragSource.hxx vcl/osx/DropTarget.cxx vcl/osx/DropTarget.hxx vcl/osx/OSXTransferable.cxx vcl/osx/OSXTransferable.hxx vcl/osx/clipboard.cxx vcl/osx/clipboard.hxx vcl/osx/salprn.cxx vcl/qa/cppunit/canvasbitmaptest.cxx vcl/source/components/fontident.cxx vcl/source/control/edit.cxx vcl/source/control/spinfld.cxx vcl/source/gdi/gdimtf.cxx vcl/source/gdi/virdev.cxx vcl/source/helper/canvasbitmap.cxx vcl/source/window/dockwin.cxx vcl/unx/generic/dtrans/X11_selection.hxx vcl/unx/kde/UnxFilePicker.cxx vcl/unx/kde/UnxFilePicker.hxx vcl/unx/kde4/KDE4FilePicker.cxx vcl/unx/kde4/KDE4FilePicker.hxx vcl/unx/kde4/KDESalFrame.hxx Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0 Reviewed-on: https://gerrit.libreoffice.org/8219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28remove unused code RecentDocsView::SetThumbnailSize(long)Noel Grandin
Change-Id: I9a898fda8e494693f48d7611c07bd65e86c22bdf
2014-02-27Remove unused OpenStatusListener_ImplStephan Bergmann
Unused since a7551a6a18fd46b4e287225c84807f9665db63ab "INTEGRATION: CWS fwk02ea (1.93.78); FILE MERGED." Change-Id: I090e8182a91c180bc8d875ba054ec3c94722d699
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from sfx2Alexander Wilms
Change-Id: I0f556a386ce64d154b695c2a35f808c94b9f0b7a Reviewed-on: https://gerrit.libreoffice.org/8310 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26remove unused code in sfx2::sidebarNoel Grandin
removes these methods: sfx2::sidebar::Context::EvaluateMatch(std::vector<sfx2::sidebar::Context>) sfx2::sidebar::EnumContext::EvaluateMatch(std::vector<sfx2::sidebar::EnumContext>) Change-Id: I14314d526a5306530d0381ca8bf6ab150d3dd5a0
2014-02-25Yet another one undefined comparison of 'const' and a 'non-const' iterators ↵Douglas Mencken
(hope the last one) Change-Id: Iefcd1f5561e5a8cac4152f16e72e8f628e9204a5 Reviewed-on: https://gerrit.libreoffice.org/8223 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25remove unused method SfxBindings::GetDispatchProvider_Impl()Noel Grandin
Change-Id: Ie2a04a2b5056bf607911f9705c06b74b9637d211
2014-02-25remove unused code SfxTemplatePanelControl::SetParagraphFamily()Noel Grandin
Change-Id: Id2edc693bcac57ebc56db2115829f77c202d8f62
2014-02-25writeble->writableCaolán McNamara
Change-Id: If1617d6cbdafa989fa3134842dd2238d06a1d06e
2014-02-25callcatcher: update unused codeCaolán McNamara
Change-Id: Ia8e6abffb85b92ee4538fb0aeaee4e4aa18f2772
2014-02-25Replace deprecated std::auto_ptr with boost::scoped_ptrTakeshi Abe
Change-Id: I72b0e8b07bd7309a23d5635b7e0b7dbdc9c2c721
2014-02-24Related: rhbz#1065807 rework #i66157# for multiple writable template dirsCaolán McNamara
if there are multiple user-level template dirs then we should be able to remove/rename content in all of them, not just the default writable target. The target scenario here is to default to ~/Templates when it exists as the template dir, but to retain ~/.config/libreoffice/user/template in the dir for any pre-existing templates and to treat both as equivalent in terms of removing their content etc. i#66157# wanted to avoid remove extensions templates and other internal ones, so rework that logic to instead just be hands off internal templates and allow modification of the remainder Change-Id: I56afe991d4297ba692e914ae95ea02d68553f60a
2014-02-24implicitboolconversion: warn about implicit conversion of call args to boolStephan Bergmann
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f "sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it" earlier when converting occurrences of sal_Bool to bool. Restricting this check to function call arguments avoids too much noise while hopefully still catching all the relevant problems. (This check partially overlaps the pointertobool check, so implicit conversions from pointers to bool call arguments will now generate two loplugin warnings, but that's harmless.) Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-24fix 'delete' not working in the Template ManagerCaolán McNamara
regression from b29c078c7f193dd7dae74baf89fe1abb9264239c because if the search view widget is visible then its assumed that we are in search view mode Change-Id: I8e81ffa06d5d3ac50e110105c9444707fd4c41c6
2014-02-24Replace exisiting TriState, AutoState with more generic TriStateStephan Bergmann
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-23coverity#440977 Dereference after null checkCaolán McNamara
Change-Id: I8350641f3b07e8a25080d4dfe7d9c212f89dd992
2014-02-23fdo#74913 The delete style confirmation dialog asks the question now.Rachit Gupta
Change-Id: I9d2ed3b233f83d05314c2ad1453be487b25d6be8 Reviewed-on: https://gerrit.libreoffice.org/8163 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23coverity#441618 Dereference null return valueCaolán McNamara
Change-Id: Id3e2ba08093bc618c17485122579898301df14d8
2014-02-21Bug #63962 Dynamically scan the config directory for icon themesTobias Lippert
The hard-coded icon themes have been replaced by a dynamic list which is filled by scanning the config directory Conflicts: include/vcl/settings.hxx vcl/source/app/settings.cxx vcl/source/window/window.cxx Change-Id: Ie3680ffe27d06e375acf22753e036cb6ddabc4ed Reviewed-on: https://gerrit.libreoffice.org/7935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21Add config option used when we try to link one huge object file.Matúš Kukan
In theory, it should not be used, we use it now to mark duplicated symbols from sdi slots as weak. See idl/source/objects/types.cxx. Change-Id: I3c6fccfb96884df6b9e6eb35b8615ba4d66ca208
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20cid#1078824 Dereference before null checkNoel Grandin
Change-Id: Ic68e7048786415a847a67723890a92cb542bbf80
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-19unotools: sal_Bool -> boolStephan Bergmann
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
2014-02-18vcl: CUPS printing: notify user if spooling failedMichael Stahl
CUPS does not accept jobs for a printer that has been stopped; pop up an error message in this case instead of silently ignoring failure. Change-Id: I1bc9120c9c9f438e350c964ed7ef29924a72ce78
2014-02-18Resolves: fdo#75121 align checkbox with message textCaolán McNamara
Change-Id: Ib8379cbdb6cf16f8799c1e34b9bd7ff2e62e27f4
2014-02-18Use correct log areaTor Lillqvist
Change-Id: Idcbb480be0c6bba1215bf75310cd6fc7bfd101a3
2014-02-18assert() is too harsh here I think, use SAL_WARN_IF() insteadTor Lillqvist
I run into the assertion now in TiledLibreOffice, but if I drop the assert(), it still works. So let's just print a warning (that everybody will cheerfully ignore, ha ha) instead. I have no idea what this code actually is doing... (Originally the code had DBG_ASSERT(), which despite its name also just prints a warning, which I changed to a real assert() in 8293b29304716d6bd117ab233b1238e1385ae592 for some reason.) Change-Id: I928078aaf3648c8d04c59f271504c7d3b02e1bb5
2014-02-18callcatcher: update unused code listsCaolán McNamara
Change-Id: Ie975f8a970eec63b593933ebb2394db76d537c51
2014-02-18tools: sal_Bool -> boolStephan Bergmann
Change-Id: I3aad235d92b3972b44199294c0f3de65ad57f450
2014-02-17comphelper: sal_Bool -> boolStephan Bergmann
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17Do not crash when no interfaces are registered.Matúš Kukan
Change-Id: Idee3bb5821e8b46da78243f6396780b35f23e30a
2014-02-17Resolves: fdo#72233 too long style names over-stretch dialogCaolán McNamara
Change-Id: Id6f102a3def1928ad8f6b4d27eb32f8c69bdba49
2014-02-17cid#705884 dereference before null checkNoel Grandin
Change-Id: I55258bb30034b95f53134a9747088fc488796564
2014-02-13cosmeticsMatúš Kukan
Change-Id: Ice4f20db3a590568a7ae4ae59fa0c4ff13e59051
2014-02-12Don't include filename extension in e-mail subjectStephan Bergmann
...as suggested to me by a user. Change-Id: Iaad83e761884b7b43cf92ebb10cf553df1b97cd0
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12coverity#441125 Dereference after null checkCaolán McNamara
Change-Id: Ia8046dc20ff46612ad3ffeba098bee079858e8da
2014-02-12coverity#441010 Dereference after null checkCaolán McNamara
Change-Id: I3f35f2ed2154f75303d561efecd1638b73872b61
2014-02-12coverity#440982 Dereference after null checkCaolán McNamara
Change-Id: I5e19801311c2cb038b6e1c5e7e52a6022f62ea86