summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2019-07-27Fix typosAndrea Gelmini
Change-Id: I389c9aaa5788bf26398e0639c0f11f9dfbe4e3da Reviewed-on: https://gerrit.libreoffice.org/76374 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-26weld SfxCommonPrintOptionsTabPageCaolán McNamara
Change-Id: I11fa5e3b39b7ab0142192c293205dc8e23caaa0c Reviewed-on: https://gerrit.libreoffice.org/76386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26sfx2: LOK: better fit of sidebar decksAshod Nakashian
As the patch comment explains, the properties deck needs to be rendered with height long enough to avoid scrolling, but others would be greedy in using up all the available height, so we render them in more restricted space. Change-Id: I361e653239e22a7be0e5d75505cdcde18f2367d3 Reviewed-on: https://gerrit.libreoffice.org/73524 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx2: LOK: resize the sidebar after layouting to avoid scrollbarsAshod Nakashian
By resizing the deck we ensure that if the contents do not fit in the existing height, they will after we expand to the minimum height. Also, the minimum height is now the correct one. This prevents seeing vertical scrollbar in LOK, which is very slow and unfriendly, instead renders the full sidebar and lets the client scroll, if necessary. Change-Id: Idc2a622a65074b7afb26263624f2df0b5968f40d Reviewed-on: https://gerrit.libreoffice.org/73523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx2: avoid unnecessary dynamic_castAshod Nakashian
And reformat. Change-Id: If8a3dd4d16dfd51f8006d2d5d47951db30390fd8 Reviewed-on: https://gerrit.libreoffice.org/73522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: fix the minimum height of sidebarsAshod Nakashian
Change-Id: I29d4eb38c72db50061266f0cf0ace31bab690315 Reviewed-on: https://gerrit.libreoffice.org/73521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: notify clients of the sidebar stateAshod Nakashian
Change-Id: I35b174c3a5e302ce52ee4063fa71d47feffab624 Reviewed-on: https://gerrit.libreoffice.org/73520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: don't shrink sidebar height below minimumAshod Nakashian
This avoids scrolling within the sidebar and makes it possible to scroll the rendred sidebar image in the client, which is more responsive and lighter. Change-Id: I0713c699ba82bfc5fe503c9351402c67aef4494e Reviewed-on: https://gerrit.libreoffice.org/73519 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx: LOK: toggle sidebar decksAshod Nakashian
Change-Id: I0559a2a4ae041bc61cf3a2d5979656a7941f4b02 Reviewed-on: https://gerrit.libreoffice.org/73518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26decode url escape codes and check each path segmentCaolán McNamara
Change-Id: Ie8f7cef912e8dacbc2a0bca73534a7a242a53ca1 Reviewed-on: https://gerrit.libreoffice.org/76378 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-07-26sfx: LOK: no sidebar tabbarAshod Nakashian
Change-Id: I210df42fec4404ed9629c9b1c24c78b680212214 Reviewed-on: https://gerrit.libreoffice.org/73517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: publish notifications to the correct viewAshod Nakashian
The ViewShell, which represents the view in question and therefore which view gets the window notifications, is incorrect when the sidebar is first created upon creating/attaching a new view. This leads us to a workaround to make sure that we publish notifications to the correct view. We also have to hide the sidebar instead of closing because the workaround wouldn't work when re-creating the sidebar on an existing view. See comments in code. Change-Id: I9d3be901688291b04d634b68e1e20c7add77381f Reviewed-on: https://gerrit.libreoffice.org/73516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26Fix typoAndrea Gelmini
Change-Id: I4ef49f18dd1cf864cc875f12740e027e5e1c1de9 Reviewed-on: https://gerrit.libreoffice.org/75981 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: hide gallery, navigation and styles decksAshod Nakashian
These aren't fully functional, so not very useful in LOK. Change-Id: If6330b1f7bf911bbb9edad00aaea7c4d37671746 Reviewed-on: https://gerrit.libreoffice.org/73514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: start collapsedAshod Nakashian
Change-Id: I589fce5ee207da0e0ac113b7ccc1ed1edd06c5da Reviewed-on: https://gerrit.libreoffice.org/73513 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: release LOKNotifier on destructionAshod Nakashian
And enable sidebar routing only while we have a valid SidebarController instance (i.e. not disposed). Change-Id: I665f934f762c0ce9efdce5489ec9babe006376a8 Reviewed-on: https://gerrit.libreoffice.org/73512 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: enable only for Impress in LOKAshod Nakashian
Change-Id: Idb361164db9ea8681b45fe99608d2cb5690db161 Reviewed-on: https://gerrit.libreoffice.org/73511 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sidebar: send close notification on disposing sidebarAshod Nakashian
Change-Id: Ia8f197d07ba4b6a089571e9ca23b4697d04e7734 Reviewed-on: https://gerrit.libreoffice.org/73510 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26sfx2: LOK: route the parent sidebar window instead of the deckAshod Nakashian
Change-Id: I0269a67c637afbc63a81405918f620009e681ff6 Reviewed-on: https://gerrit.libreoffice.org/73508 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-26LOK: sfx2: disble sidebar menu-button when deck is hiddenAshod Nakashian
There is no render area on the sidebar virtual-device to render the popup menu when the sidebar is collapsed into the TabBar, so we disable it altogether as we can't properly display it in LoKit. Change-Id: I2edee9e734485bb685f0ddc0c30bfe584e42a550 Reviewed-on: https://gerrit.libreoffice.org/73507 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sfx2: customize the sidebar popup menu for LokitAshod Nakashian
Don't show customization or docking options. Change-Id: I313868cb2b2d0444ee90cf9709a326a81d0e5ed8 Reviewed-on: https://gerrit.libreoffice.org/73506 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sfx2: collapse the sidebar instead of closing on toggleAshod Nakashian
When toggling a sidebar deck that is open, the default behavior when floating is to close the sidebar altogether. This is both inconsistent with the behaviour when docked and unexpected. Now we simply collapse the sidebar into the TabBar (toolbar) as is done when docked. This is also the behavior desired from LoKit since the sidebar is rendered floating (to allow arbitrary resizing). The collapsed sidebar into toolbar is shown in same-position. Change-Id: I0519c5ad012cc9df31758927a4dbcd774d47fcd3 Reviewed-on: https://gerrit.libreoffice.org/73505 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sfx2: LOK: support resizing the sidebarAshod Nakashian
Change-Id: I852c522f176a8d11d3a19709ab1cd75023645c66 Reviewed-on: https://gerrit.libreoffice.org/73504 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sidebar: support closing the sidebar through the X buttonAshod Nakashian
Change-Id: I078c27d22bbee3d02ad4a3fb97ba01a394f171e1 Reviewed-on: https://gerrit.libreoffice.org/73503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sidebar: Add .uno:MasterSlidesPanelAshod Nakashian
Change-Id: I578dc8b1f9c8df7f7cc9108c70d6fad8006871c6 Reviewed-on: https://gerrit.libreoffice.org/73502 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25sd: sidebars are now visible in LOOLAshod Nakashian
Change-Id: I7ceae056e3d6ce1c991fe1194faa8bebfd6aae1e Reviewed-on: https://gerrit.libreoffice.org/73500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24expand LibreLogo check to global eventsCaolán McNamara
Change-Id: I7f436983ba0eb4b76b02d08ee52626e54b103d5f Reviewed-on: https://gerrit.libreoffice.org/76189 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22Patch fixes the image rendering issue of extension in NotebookBarSumit Chauhan
Change-Id: I7645766af1a6acfd7117fce3fcb29da038d9d92f Reviewed-on: https://gerrit.libreoffice.org/75986 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-07-21Fix typoAndrea Gelmini
"an OLE", to complete: https://gerrit.libreoffice.org/#/c/75983/ Change-Id: Idd5b9286348b4fa1e3382983c72b010654a1f4c2 Reviewed-on: https://gerrit.libreoffice.org/76038 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-20loplugin:referencecasting in sfx2Noel Grandin
Change-Id: I97cd8821aa9a6f462f9b271940483738655ee9cf Reviewed-on: https://gerrit.libreoffice.org/75979 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19Engine to add Extension inside extension tab in NotebookBarSumit Chauhan
The patch provides backend for adding the extension.Schema for the adding extension in notebookbar can be seen here https://gerrit.libreoffice.org/#/c/75134/ Change-Id: I10f0e83d1aaec5330c80b3b53cf59a21b93be015 Reviewed-on: https://gerrit.libreoffice.org/75650 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-07-19loplugin:constantparamNoel Grandin
and tweak the plugin to handle a crash seen with clang-9 Change-Id: Ie1ccf80c16a20dbca58e5bd081af13f75cf5ac8f Reviewed-on: https://gerrit.libreoffice.org/75850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-18cid#1448294 Unchecked return valueCaolán McNamara
Change-Id: Iee0153a00df72cf9353d2e40ff02f81f96522afe Reviewed-on: https://gerrit.libreoffice.org/75873 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18tdf#126461 incl. document name in link update msgJan-Marek Glogowski
If you open a OLE-linked document from the console, LO will ask to update the linked information on open. But this happens before the document shell has even has set the title of the shell, so a user has no way to know, what "This document" really refers to. This is even more problematic if you have multiple open documents restored by a session manager. So this changes the string to include the document name. Change-Id: Ife7b21f6eeb4dd5c1aebd383752cc62279da33fb Reviewed-on: https://gerrit.libreoffice.org/75777 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-18tdf#126424 Don't dispose decks before saving their stateSamuel Mehrbrodt
Only dispose them in SidebarController::disposing after the state has been saved. Change-Id: I9e42383e20e2bc0100557b8cb8fbd26b3505f236 Reviewed-on: https://gerrit.libreoffice.org/75719 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-18cid#1448252 Negative array index readCaolán McNamara
Change-Id: Ia81e2a58e372455531479c98d11a88cd950441df Reviewed-on: https://gerrit.libreoffice.org/75808 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17loplugin:unusedfieldsNoel Grandin
Change-Id: I38abc54776cc605c76faf94e9e8c0f4fa75b8788 Reviewed-on: https://gerrit.libreoffice.org/75740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-17tdf#126427 Fix deck highlighting after activating via UNO APISamuel Mehrbrodt
Change-Id: I4ff7dfa156905abcba0df8e6bfbddc9e7d37cbbb Reviewed-on: https://gerrit.libreoffice.org/75723 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-16cid#1448409 Uninitialized scalar fieldCaolán McNamara
Change-Id: I308ef87305efa1e37207f606470b6650dc301b58 Reviewed-on: https://gerrit.libreoffice.org/75696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15Fix error in JSONtoRedactionTargetMuhammet Kara
Change-Id: I6e82f86adfc6e1ebff2d9377dd011d0d97648848 Reviewed-on: https://gerrit.libreoffice.org/75602 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-07-14Simplify OUString concatenationChristophe JAILLET
Change-Id: I584d400791b3f7ee419f620255e65d9ea7d5145a Reviewed-on: https://gerrit.libreoffice.org/75570 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-12tdf#126241: make sure to fill input stream before LockOrigFileOnDemandMike Kaganski
Otherwise, the function returns early, without providing lock file information to the caller. Change-Id: I1740ff0f5a982f7b22f9e3dcdf97631ab6ea6fe0 Reviewed-on: https://gerrit.libreoffice.org/75465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-11Restore original value of SID_DOC_READONLY item on cancel or SID_EDITDOCMike Kaganski
Otherwise, SfxObjectShell::DoSaveCompleted later calls SfxMedium::LockOrigFileOnDemand, which sets error state for the medium reopened in read-only mode, as if it were opened in read-write mode. Change-Id: Ib2df62470878ea609552ccc76df84a3fdde30646 Reviewed-on: https://gerrit.libreoffice.org/75413 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-11Deduplicate URL tooltip creationSamuel Mehrbrodt
Change-Id: I94eb40ff4d727029ad764a381df300beee90481c Reviewed-on: https://gerrit.libreoffice.org/75409 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11Fix typoAndrea Gelmini
Change-Id: If83573ab4b427b84f5c125d1fc2509996ed8bdfc Reviewed-on: https://gerrit.libreoffice.org/75398 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-11Fix a typo in a commentChristophe JAILLET
Fix a typo (s/these/this) and merge some comment lines that are split for no reason. Wording is still not perfect, but is better :) Change-Id: If97b648fb5645f4ec1ecb0c0208467c9eee430b4 Reviewed-on: https://gerrit.libreoffice.org/75383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-11Simplify ThumbnailView::CalculateItemPositions()Christophe JAILLET
There is no need to call 'setPosSizePixel()' twice, once at the beginning of the function just to set the width (in case of changed settings) and once at the end of the function to set the position and the size. The size obviously includes the width. Change-Id: Ie1806fe21eb28af12f1c77ac1494bb970575eff9 Reviewed-on: https://gerrit.libreoffice.org/75382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-11Warn when LayoutSize constraints were not respectedSamuel Mehrbrodt
Change-Id: I5145bc4e10928ed456b36617de3345512b7a35d9 Reviewed-on: https://gerrit.libreoffice.org/75351 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-08no need to use AlphaMask in RecentDocsViewItemNoel Grandin
since it's purely opaque Change-Id: Id9df52f860946cfd4c30c406d5748224a2a4f4df Reviewed-on: https://gerrit.libreoffice.org/75226 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-07Fix unused parameter 'pParent' when !HAVE_FEATURE_SCRIPTINGTor Lillqvist
Change-Id: I1c4b58c55213ce9baadc0c1d4b4e394ee62fa053
generated by cgit (git 2.34.1) at 2025-01-14 12:21:05 +0000