summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2023-06-28tdf#148416 saveas: preserve loadreadonly with passwordJustin Luth
If a document is set to load readonly, and that setting is password protected, then at least suggest using a password on save-as. Change-Id: I788da43733470e56af988e7c4b9f2cae01573e50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153726 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-28tdf#146547 sfx2: preserve modified state from read-only to editableMichael Stahl
SfxViewFrame::ExecReload_Impl() calls DoSaveCompleted() which resets the modified state, but in this case the document wasn't actually saved. Change-Id: I54f6508a652cc42a127bc59058c5b435dd1a25a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153676 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-28Drop i18nutil::SearchOptionsMike Kaganski
It was mostly unused by now, only remained in a couple of function arguments, where callers actually passed SearchOptions2, and where internally it was converted back to SearchOptions2. Change-Id: Ib188ec3bf0de6d1f70a04eb90fb3a577df8b3d98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153687 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-28Resolves: tdf#156067 merge special char dialog/popup logicCaolán McNamara
there was some cut and paste done to create the popup at some point, so put it back together and reuse the "delete recent" etc which is missing from the popup case Change-Id: Idc33d83ea04b46b0255e77bcecf565dc8174e426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153647 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-27loplugin:stringstatic look for more stringsNoel Grandin
that can be initialised at compile-time instead of runtime Change-Id: I08d516fdc13a3a79f93c079f89ac44cbc7a1ed71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-27lok: only publish MEDIA_SHAPE to selecting viewAshod Nakashian
We now publish the url for the media shape in the LOK_CALLBACK_GRAPHIC_SELECTION message. This has many advantages, most notably that it only sends the URL to the view selecting the media. Also, it is now easier to handle the message as there is no need for both a LOK_CALLBACK_GRAPHIC_SELECTION and a LOK_CALLBACK_MEDIA_SHAPE. However, the latter is still defined as we might still use it at some point. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I8d4b8794d8e590628630f2b0bfbfb5debe02515f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146848 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153009 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153369 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-06-26LOK: send state of DataFilterAutoFilterPranam Lashkari
Change-Id: Ib71dcdb6b02f3c1e9e1c552a718cb03e7cd9a4b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153532 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 0407d4290617dc717abed3ea48f1abf3cf1d750f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153602 Tested-by: Jenkins
2023-06-26new loplugin:constexprliteralNoel Grandin
OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-24Change LocaleDataWrapper::getDuration() parameter to tools::DurationEike Rathke
... instead of tools::Time Change-Id: I8e49de43a1870541d75add34089eec67b7a8be31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153533 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-21tdf#122270 sd: refresh notebookbar after switch to/from master viewJustin Luth
Although the state of the uno items was changing, the notebookbar was not refreshing to display the new state. Change-Id: Ifda5e6dcfa1d569ba75d0c94cdf0bc94c63977d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153360 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-20Resolves: tdf#155750 allow private:factory urls in floating framesCaolán McNamara
they create a new document so there isn't an associated location which would trigger the prompt to allow it so just allow factory urls Change-Id: I7b693bcfe5ac04aaed06905637ab3c1eba43c51f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153316 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-20lok: sfx2: fix change state "SheetRightToLeft"Henry Castro
The UNO command "SheetRightToLeft" can be disabled Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I54742c9d52eb52e36154e0aac2cdf440771eb177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152502 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit fc8270f06eca5ba2ba25673a424b36d9e352f62a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152546 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153267 Tested-by: Jenkins
2023-06-19Initialize SfxObjectShell::bRememberSignatureStephan Bergmann
...introduced in 46722dbaa7795074e3c5043a76ae3f3a7782491e "tdf#155665 Adding option to remember signatures for each save", to avoid > sfx2/source/doc/objserv.cxx:1230:39: runtime error: load of value 190, which is not a valid value for type 'bool' > #0 in SfxObjectShell::ExecFile_Impl(SfxRequest&) at sfx2/source/doc/objserv.cxx:1230:39 > #1 in SfxStubSfxObjectShellExecFile_Impl(SfxShell*, SfxRequest&) at workdir/SdiTarget/sfx2/sdi/sfxslots.hxx:220:1 > #2 in SfxShell::ExecuteSlot(SfxRequest&, SfxInterface const*) at sfx2/source/control/shell.cxx:456:9 > #3 in ScTabViewShell::ExecuteSave(SfxRequest&) at sc/source/ui/view/tabvwsha.cxx:840:34 > #4 in SfxStubScTabViewShellExecuteSave(SfxShell*, SfxRequest&) at workdir/SdiTarget/sc/sdi/scslots.hxx:1481:1 > #5 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) at sfx2/source/control/dispatch.cxx:254:9 > #6 in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) at sfx2/source/control/dispatch.cxx:753:9 > #7 in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) at sfx2/source/control/bindings.cxx:1060:22 > #8 in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) at sfx2/source/control/unoctitm.cxx:688:53 > #9 in SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) at sfx2/source/control/unoctitm.cxx:266:16 > #10 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> const&, com::sun::star::util::URL const&, bool, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/dispatchhelper.cxx:163:30 > #11 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/dispatchhelper.cxx:120:16 > #12 in non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/dispatchhelper.cxx > #13 in unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:94:33 > #14 in testInvalidEntrySave::TestBody() at sc/qa/unit/tiledrendering/tiledrendering.cxx:2826:5 during CppunitTest_sc_tiledrendering Change-Id: Ie3a8453c0222cb0a2a239d6d9133a9aafe1e2870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153265 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-06-19tdf#38742 - Start Center: move last opened documents to the topAndreas Heinisch
Change-Id: If395b0784d9bdcdc1200c15fca60647da825ea1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153150 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-06-18tdf#155665 Adding option to remember signatures for each saveTokieSan
Added the option in digital signatures dialog to remember used signature. Implemented ResignDocument function in objserv.cxx to resign after every save in case the option to remember signature is on. Added a new dialog box that checks whether there is a need to remember the signature. Change-Id: Ia7dbcc952044e9542e3fe6cd84b5d6633fcd1461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152687 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-06-16tdf#155720 remove old skip notebookbar init workaroundSzymon Kłos
This was introduced due to not working Paste Special dialog in LOK case. Now everything seems to be ok. Single initialization should make loading process faster. Change-Id: Ic464908ef044cc446626fff0fb9b4f57e061aea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-16tdf#146547 sfx2: allow read-only documents to be modifiedMichael Stahl
This is particularly useful for a Writer document that contains a section that is set to be editable in a read-only document, so that the user is warned when closing such a document without saving it. Originally this check was added in commit 27db57efc51487b3976fbf73df1868b8fb78d201 "CWS fwkbugfix05" "#i39869#: readonly docs should never become modified" but the actual problem there was that the read-only document was displayed in a wizard dialog, not in a document view, so let's instead check that the document is some kind of "internal" document. Also the dialog's Save button should do something, and since the document is read-only, a Save As dialog appears appropriate. Change-Id: I339cbe92a2c9eb74a1f5061246f921037a47f79c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153180 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-16Fix typoAndrea Gelmini
Change-Id: I774554c7945d5560e229d6c94e9efbafd77deeca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153106 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-15tdf#103064 sw: improved notifications on style modificationMaxim Monastirsky
- More useful notification on undo - Added notifications for theme change and UNO API. Change-Id: I554dceff92f4f8a6dd5c39c6965b7de706ab6678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153110 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-14Add editengine view separation in tiled renderingParis Oplopoios
Editengine now gets the background color from the current view instead from a global variable Change-Id: I98a0fccf4d0c83f4dabf8e534a9228b8a5e271d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152996 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> (cherry picked from commit 7baa475342b67c10537e11da37b8862648679b02) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153073 Tested-by: Jenkins
2023-06-12sc: fix freeze row/column panesHenry Castro
The UNO command state has changed to Point (row, tab) and Point (col, tab), Otherwise, if the row or column has the same value for all sheets, the state cache will not report any changes to the client side. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I2080f5e664825d81c4fa4dbb2c5d782f188dae64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151344 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151975 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152908 Tested-by: Jenkins
2023-06-11Related: tdf#155507 don't broadcast UI Theme change unless it did changeCaolán McNamara
a problem since: https://github.com/CollaboraOnline/online/commit/b6d4c88f9011845acae5c8537c0826055c8327a2 Change-Id: Iac1189ba7b892324b5f000f5f6240787b3209892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152799 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-09notify async password changeJaume Pujantell
Change-Id: I2d16c9804e65f093239e810d466de35286b28dee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151651 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-06-08restore, not clear, existing interaction handler after saveCaolán McNamara
put things back the way they were found. In this case I want it back to the original state, because a) lok sets its own interaction handler on load b) at framework/source/loadenv/loadenv.cxx:1137 Because that handler supports XInitialization we show the window early c) that happens to be before the menubar is set d) so the menubar changes the size of the window after it is shown e) so Window::ImplPosSizeWindow calls ImplInvalidateFrameRegion(nullptr, InvalidateFlags::Children) f) which sets ImplPaintFlags::PaintAllChildren on the PaintFlags of the workwindow g) which means that when a SwEditWin calls PaintImmediately vcl sees that flag on its WorkWindow grandparent and calls ImplCallPaint with the grandparent, not the SwEditWin. It happens that the grandparent has no LokId so that does nothing. if we clear this interaction on save, then the next joiner instead has no interaction so gets the default one which does not support XInitialization, so the window is not shown before menubar is added, so when it is shown it is already at the final size, so there is no ImplInvalidateFrameRegion and so no ImplPaintFlags::PaintAllChildren bits on the WorkWindow, so PaintImmediately on SwEditWin calls that Invalidate, which is special cased to broadcast the invalidation as a real thing Change-Id: Ie3fde4c53476aada2b1fdabb1dc70b08485074b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152772 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2023-06-07tdf#155376 partially convert SvCTLOptions to officecfgNoel Grandin
When accessibility is enabled, Calc will add tens of thousands of listeners. We then spend a significant chunk of time creating SvCTLOptions objects (attached to ImpEditEngine) and adding and removing those objects from the related listener lists. But the required information is already globally cached by the officecfg module, so we can avoid that overhead and just fetch it directly from officecfg. Change-Id: I7ff55fd7c4926866eb7086812275ba8bd6e84c75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152645 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-06Revert "tdf#146547 Mark read-only docs as modified"Julien Nabet
This reverts commit e7e9991fd06ba2e0484ae5e6b6acc323ab8bf66b. It generated tdf#155638 "Forms: Form couldn't be closed after it has been opened" Change-Id: I854c194c718cae51fd0081534570269332d119c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152685 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-06use more officecfg for SvtMiscOptionsNoel Grandin
Change-Id: I6c87025fc0997b5edbc085fc88333fe9e150eb3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-06sfx2: SfxMedium::Transfer_Impl() ignore exceptions when getting propsMichael Stahl
Somehow (bisected to commit bc48f2656c9a7bc1f41541bff66ec2c4496466a4) this throws an exception now when getting "Title" when storing a new file to a WebDAV server (the server naturally replies with 404). There is already a fallback to get the filename, so just ignore exceptions here so the transfer can succeed. Change-Id: Ic609f2a4f5a67670b2d8eeb74680730053a7d3a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152678 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-06SvtCommandOptions only supports CMDOPTION_DISABLEDNoel Grandin
CMDOPTION_NONE is just ignored, so remove this parameter Change-Id: If9de22a6b0522620a267cbc92b118f79e200d999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152671 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-06tdf#38742 - Start Center: introduce push pins to favorite documentsAndreas Heinisch
Change-Id: I879e4d93e1da222d9acabb776552ca1cf819574b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152136 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-06-05tdf#152431 Fix line count resets to zero after 65535Bogdan B
GetLineCount was a sal_uInt16 value, that allows only 65535 lines to be counted. This is changed to sal_Int32 and also the underlying data type for the lines number is changed from sal_uLong to sal_Int32, but not for pages number. With this change, the maximum possible line number is now increased to 2^31-1 = 2,147,483,647. Change-Id: Ibee2d24e638204133f0ef085564016543f73d351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143173 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-06-05svx: extract theme color generation into ThemeColorPaletteManagerTomaž Vajngerl
The generation of theme colors generation code is moved to the ThemeColorPaletteManager class, so it can be reused. Also change the GetThemeColors return type from std::vector<Color> to std::shared_ptr<theme::ColorSet> as we can now safely do that and simplifies things. Change-Id: I4a54bff889a1f97cb1e30467188dc69e07e8c518 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152588 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-02Resolves tdf#155200 - Don't scale overlay images in start centerHeiko Tietze
Thumbnails don't change their size so overlay must not too Change-Id: I83ff2bb60ec619686b583180ebabe194c4a77b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152193 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-06-02WaE: fix more warnings I see with gcc-13.1.1Caolán McNamara
Change-Id: I8f1087cb98991363ec78a21a90a55724ba3628ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152466 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152528 Tested-by: Jenkins
2023-06-02lok: accessibility event listener for focused paragraphMarco Cecchetti
LOKDocumentFocusListener keeps track of the currently focused paragraph. Also includes: Author: Andras Timar <andras.timar@collabora.com> Date: Mon May 15 22:06:10 2023 +0200 fix unused exception parameter 'e' Change-Id: Ibfee099e4e9b724648d7500b9ebb4e8ab84989b8 and: Author: Marco Cecchetti <marco.cecchetti@collabora.com> Date: Thu May 4 12:11:53 2023 +0200 lok: a11y: focused paragraph info sent to client For the currently focused paragraph the following data is notified to client: paragraph content, caret position, text selection start/end These data is kept as an instance state so the client can request such info at any time. Change-Id: Ic1a3be0d93472300b1b6a91fb0de5bad87c031aa and: Author: Marco Cecchetti <marco.cecchetti@collabora.com> Date: Sun May 7 11:52:14 2023 +0200 fixup! lok: accessibility event listener for focused paragraph It seems it was not a good idea using a unique_ptr as smart pointer for an instance of LOKDocumentFocusListener Change-Id: I8e6b0f48fee3c5db3c9b074a663f7f3fb96a601e Change-Id: I0fa400694f3129608228ade0b96e0b4e0aee87e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152488 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-01Revert "Convert XFastParser into a normal C++ interface"Noel Grandin
This reverts commit 5e68d6cfade45f40b1ad46025a81afe4cb8dd337. Reason for revert: Seems like outside users have been using this API Change-Id: I8814cf1eb4f000eeb4cbbb5db9c282d001465993 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-01Convert XFastParser into a normal C++ interfaceNoel Grandin
There is no need for it to be an UNO interface anymore (ever since we started supporting dynamic_cast on UNO objects). Which means that XImportFilter2 also needs become a C++ interface. Change-Id: Ice2db0f098271bba32b199bd083b08cb8410ce93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-31Resolves: tdf#109149 don't poll the Default Printer Name on every queryCaolán McNamara
We are queried on every change, so on every keystroke, and we are only using this to fill in the printername inside the label of "Print Directly (printer-name)" On Printer::GetDefaultPrinterName() is implemented with GetDefaultPrinter so don't call this excessively. 5 mins seems a reasonable refresh time. Change-Id: I71e87f26ed022241e09f9ab0eed94d09648ec9b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-26use more TypedWhichIdNoel Grandin
which flushed out an inconsistency in how SID_NUMBER_TYPE_FORMAT was being used Change-Id: Ib59ae4c4950136703d18d7485db432a39e3dc39c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152300 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-25use more TypedWhichIdNoel Grandin
Change-Id: I6c54c1276b36cbc71417486ffcee2ef9ef0cff7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152270 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-25merge some stringaddsNoel Grandin
found with a lightly tweaked version of the loplugin:stringadd and some hand-holding. Change-Id: I146aadcaf665e98fea89a9cad2df4dc3935622f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-23[API CHANGE] Add createShortCutManager function to uiconfigurationmanager.Gökay Şatır
We need to have different accelerator classes for differnt languages. This PR creates a new accelerator class for different languages. Since current code uses single instance for accelerators, i needed to add a create function. Also we now have an unordered map for different languages and modules. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147157 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148680 Tested-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: Ia646f20b3206f430ece614fc127e8b748044e4c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151798 Tested-by: Jenkins
2023-05-22tdf#146547 Mark read-only docs as modifiedSamuel Mehrbrodt
when an editable section is changed. Change-Id: I588b09f160974d3a3833bfa011fd07f2ee496616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151535 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-05-17navigator: use toggle available for all appsSzymon Kłos
Change-Id: I3136071ee943b120ebb2ad6491c91d8ebbcd6244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151573 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151752 Tested-by: Jenkins
2023-05-15LOK: Navi-1 open/close on sidebarAttila Szűcs
Enabling Navigator sidebar in case of LOKit. Change-Id: I3a656fa12822e5866c2cd4fbf82627a88f26903a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151307 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151704 Tested-by: Jenkins
2023-05-12lok: escape notifyWindow messageSzymon Kłos
File properties dialog contains problematic characters. In lok case and nl language it was constructing incorrect message so boost JSON parser was throwing an exception and dialog was not created correctly. Change-Id: I7e81c9407fcbf57355c0890c9540ce1f828904e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146900 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150042 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150389 Tested-by: Jenkins
2023-05-12tdf#134901: update print statistics on PDF exportJustin Luth
From a modern point of view, a PDF export could be considered a print event. If one agrees with that point of view, then updating the print statistics whenever a PDF is generated makes sense. That is what the bug report requested, and what this patch does. That is what MS Word does also. Downsides: -there is no setting for a user to disagree with this bug's POV. -doesn't work for Send - Email a PDF -open a doc: export to PDF: close -> "Do you want to save changes?" -I tested on --headless --convert-to pdf -> no problems -a setting does exist to avoid modified status by printing. -that setting defaults to avoid modifying the status - YAY! -the print date is changed even if the export fails -NEEDS to be changed before export: time needed in PDF itself -didn't seem important enough to waste the time coding it. -for real printers the old print date is restored on failure. Change-Id: I0d1387c1c2c925f3be772c5bdad7187f9f6a4d7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151682 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Tested-by: Justin Luth <jluth@mail.com>
2023-05-10Revert "Resolves tdf#134941 - Fix size issue on start center"Heiko Tietze
This reverts commit 77ed6380dda73a9716f48f73c3ff730380557a09. Reason for revert: Scolled window looks ugly and does not solve the issue; we just cannot support +2x scaling on small screens Change-Id: I2fb9759d55e28169508f33a822241efe955d5699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151525 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-10Revert "Resolves tdf#155167 - Start center app pane issue under gtk3"Heiko Tietze
This reverts commit b7632b68c5398fce8a22ec09414e0075709fbc32. Reason for revert: Scrolled window looks ugly and does not solve the issue; we just cannot support +2x scaling on small screens Change-Id: I1c908dfc801a3867597feefa2a8852b871f7df3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151526 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-08Resolves tdf#155167 - Start center app pane issue under gtk3Heiko Tietze
Issue introduced with 77ed6380dda73a9716f48f73c3ff730380557a09 Change-Id: I093808b87bca5f93e28239f22886f543a053e62b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151493 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2024-12-28 08:13:07 +0000