summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2016-02-04remove unused GET/SET/STATUSBARCONFIG in .SDI filesNoel Grandin
Change-Id: I74404d72e9146950a9881d2a59323c2bf08c9742 Reviewed-on: https://gerrit.libreoffice.org/22100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04sfx2: fix locking after signing OOXML documentsMiklos Vajna
File -> digital signatures looks like a way to view and modify digital signatures, internally it's a sign action, that at the end may not modify signatures after all. For this to work, SfxObjectShell::ImplSign() calls GetMedium()->CloseAndRelease() to release the document's lock file, invokes the signing dialog, then DoSaveCompleted() creates the lockfile again. When signing OOXML documents, the lock file is not re-created, as DoSaveCompleted() only creates the lockfile in case IsPackageStorageFormat_Impl() (== own format) is true. Fix this by adding a mode that creates the lock file, even in case of a foreign format. With this, closing the digital signatures dialog for OOXML documents no longer results in a confusing "Document in Use" dialog after closing the signatures dialog. Change-Id: Ie9e56b88768825e61765669b27a89082cdc1981f
2016-02-04remove unused HasDialog from SDI filesNoel Grandin
Change-Id: I26f2cef48fcc7a6c4a6b93668b836879254f3eb0 Reviewed-on: https://gerrit.libreoffice.org/22098 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04remove unused Synchron from SDI filesNoel Grandin
Change-Id: I0b8c63a97bfa4a49ac87869e164ab22d2aa99de3 Reviewed-on: https://gerrit.libreoffice.org/22097 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04remove unused Cachable keyword from SDI filesNoel Grandin
Change-Id: I60c423b799f34f79f58bc39cf7ea616ec4f5d16a Reviewed-on: https://gerrit.libreoffice.org/22096 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-03remove unused HasCoreId from SDI filesNoel Grandin
Change-Id: I4aca4b8a79ce92d64ce004ccdb7e9a0f408dc768
2016-02-03tdf#95505 Dump usage stats to text file.aybuke
Creating file's content reformatted for csv. Change-Id: Ifefdddcae1265ad1e68e192981d6435712a9f607 Reviewed-on: https://gerrit.libreoffice.org/21920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-02Avoid unncessary, premature null derefStephan Bergmann
...when SfxTabPage::Reset (sfx2/source/dialog/tabdlg.cxx) calls into DoApplyFlags/DoRest with a null rSet (but which apparently isn't actually used then), e.g. upon "File - Export as PDF..." in Impress. Change-Id: Ie2f255694212356fa8fc994287c45f2b4730a5bd
2016-02-02tdf#97051: prevent duplicate copy of SfxItemSetOliver Specht
the patch f7424ed710e54bb2437a28380b03ed7c26290edc introduced copying of the input item set of SfxTabDialog so now the item set of the style must not be copied anymore. Change-Id: If4155ee5999f0c5cd2ac754578a2c1b5ec33b14b Reviewed-on: https://gerrit.libreoffice.org/22022 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-02-02boost::hash->std::hashNoel Grandin
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8 Reviewed-on: https://gerrit.libreoffice.org/21989 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-01tdf#96327: Fix accelerator for remote filesGabriele Ponzo
Change the accelerator from F to S, because it was conflicting with file menu. Change-Id: I1f3959ae12b09fb5d48a7379693c6afc1bafa906 Reviewed-on: https://gerrit.libreoffice.org/21898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-01-31unnecessary use of OUString constructorNoel Grandin
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31implement missing FID_FUNCTION_BOX GetStateCaolán McNamara
since it was turned into a sidebar thing Change-Id: Ic7e53b9da3255bb8dfde048e0a12f1d9c89102d0
2016-01-30Remove unused includesMiklos Vajna
Change-Id: I38784900d5b4fcf99d5fc881f0ec7a9833fe2d5b Reviewed-on: https://gerrit.libreoffice.org/21917 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-01-30these checks for DockingWindows are all wrongCaolán McNamara
the type is WINDOW_DOCKINGWINDOW not RSC_DOCKINGWINDOW maybe better drop the wrong paths ? But try and do what the original intent might have been. Change-Id: Ibbcf885d82e498d38c1c82b9b647ef3cdd8f146a
2016-01-30strange bit of oddity here, these all call the same thingCaolán McNamara
no need for the switch at all Change-Id: I8fc52a1533697f5e9271aa76a17ceb58835ae1da
2016-01-28sw: add AnchorType parameter to .uno:PasteMiklos Vajna
Which allows not hardcoding as-char for LOK. Change-Id: I3b2987abbaf1f259c614b7b2a8709f15048d362d
2016-01-28use unique_ptr to manage memoryDavid Tardon
Change-Id: I2f22dfc6c9ddbaf07145ca553fdb53c12cd94dcb
2016-01-27tdf#95505 Dump usage stats to text file in user profile.aybuke
Change-Id: I12c44db6f03c789682688d39aafb650d074c63f5 Reviewed-on: https://gerrit.libreoffice.org/21609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-25Revert "fdo#62947 make IDs unique, fixes, better names"Maxim Monastirsky
This reverts commit 5398664eed621fbcc644ff949d4841590973bfa3. Conflicts: include/sfx2/sfxcommands.h sw/source/ui/app/mn.src Change-Id: Ic55cfb51a726ab9ee19bac6719d5e2670d1fb494
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-23tdf#96434 Activate usage data collection from commandline.aybuke
Possible env variable: $ export LO_COLLECT_USAGE=1 Change-Id: Ic253850ca73551bad8b44072164881c5039615c9 Reviewed-on: https://gerrit.libreoffice.org/21596 Tested-by: jan iversen <jani@documentfoundation.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-21loplugin: unused return valuesNoel Grandin
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-20i#107205 Remove SfxDispatcher::Popup and SfxPopupMenuManager::PopupMaxim Monastirsky
Change-Id: I1a8bee75a2dbfb039ec32faf001b75b26ea1f3fe
2016-01-19SfxMedium: only own format has the signature in a single streamMiklos Vajna
OOXML has one stream for each signature, so it wants a storage instead. Change-Id: Iff2ed4b65d8c2023d02578ec4e80c13e36f55390
2016-01-19CppunitTest_desktop_lib: add ModifiedStatus callback testcaseMiklos Vajna
Change-Id: Ieb7e808ebc7619c3a4a013cad776eeefd6163e22
2016-01-19LOK: include ModifiedStatus in CALLBACK_STATE_CHANGEDMiklos Vajna
Change-Id: Ic44a9266a67bfad8b0490a8acb4a419af99ea42c
2016-01-18fix a crash found in passingCaolán McNamara
save a spreadsheet with an embedded formula in it to xlsx and alt tab away before the save has completed Change-Id: I9df996d4cb459a2aa688d06a7d53465518bebf5c
2016-01-18loplugin:unusedfieldsNoel Grandin
Change-Id: I321b594f1190cdd997b4769161e1c02d31f46213 Reviewed-on: https://gerrit.libreoffice.org/21566 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-14sfx2: Convert the exception to one that we actually announce.Jan Holesovsky
Otherwise saving to a non-existing http:// URL leads to a crash. Change-Id: Ia4b49e2872616545dcedb2fc5553cf5a20a1f97d
2016-01-14loplugin:unusedmethods unused return value in sfx2Noel Grandin
Change-Id: I9c16c3f2754f181571faf7d5e1c48fa8bda59f7d
2016-01-14tdf#95845 Use CommandInfoProvider to receive UNO command labelssusobhang70
Change-Id: I04227652cc1b94129514ddb61ce66d7d9b365807 Reviewed-on: https://gerrit.libreoffice.org/21402 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-01-13Just use the strings as suchTor Lillqvist
Change-Id: Iab4d669ef5dc397786de2aadc2222d4efb7a244a
2016-01-13Increase relevancyTor Lillqvist
Change-Id: I3a7e46f96898d535b4beff35fdf7245c0eea989e
2016-01-13Revert "svl, sfx2: WaE - unused variables removed"Stephan Bergmann
This reverts commit d2dc3c20ab6240884164ab89f9388958069697fc, conflicts with 200434b1419afe375e104da76c68f81253374645 "-Werror=unused-but-set-variable" pushed slightly earlier.
2016-01-13svl, sfx2: WaE - unused variables removedChris Sherlock
Change-Id: Icb465506f945ab35a732db488ae9cef8f248d09f Reviewed-on: https://gerrit.libreoffice.org/21417 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13-Werror=unused-but-set-variableStephan Bergmann
Change-Id: I142e95b9736545c7771274e315419cec12d9cf49
2016-01-13loplugin:unusedmethods unused return value in include/sfx2Noel Grandin
Change-Id: Id4017bdfe18f8224d28a9f787865c7a880aeeed8
2016-01-12SfxObjectShell::ImplAnalyzeSignature: handle SfxFilterFlags::SUPPORTSSIGNINGMiklos Vajna
Change-Id: I9d45d3a39c8332c01fcc23dcc5da8db7ed4c5cdc
2016-01-12comphelper: initial SfxFilterFlags::SUPPORTSSIGNINGMiklos Vajna
Currently digital signatures can be made only on OWN formats. Add a new flag that can be used to mark filters (only DOCX as a start) which could also support signing and fix the first place that assumes that only OWN formats support signing. Change-Id: If9fbf956b765d75838986762e4d4063a9e8c0b5e
2016-01-12GetImageFromURL/SetImageProducer unusedNoel Grandin
looks like these have been abandoned recently in the toolbar manager update Change-Id: I5556833dfef0db5958a5779bdb32482c18a46a5f
2016-01-11loplugin:defaultparamsStephan Bergmann
Change-Id: I919f9f5f9ccb1429624f9c8e75574fec71a2b370
2016-01-11Merge BitSet into IndexBitSet (and remove unused parts)Stephan Bergmann
Change-Id: I8cab0aac2f67b88936e4bed459dd43b08429b136
2016-01-11loplugin:privatebase: Make derivation from BitSet explicitly privateStephan Bergmann
Change-Id: I9c61aee4cbf3f461c84f064ac8259e51aa7b0ada
2016-01-11loplugin:privatebase: Make derivation from noncopyable explicitly privateStephan Bergmann
Change-Id: Ia410950353aec0106ea82d025ed3ee89c79ca127
2016-01-11sfx2: change variable jan to aUsageInfoMessage for clarityChris Sherlock
Change-Id: Icc9d9b277ce2dca5ee13c381a105c387a42525c7 Reviewed-on: https://gerrit.libreoffice.org/21337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-11PCH support on LinuxAshod Nakashian
Fixes and improvements to support Precompiled Headers on Linux. Change-Id: I8145c146b0dba56c7a4d0fdf9c330164b67ada53 Reviewed-on: https://gerrit.libreoffice.org/21307 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10tdf#95505 Dump usage stats to text fileAybuke Ozdemir
1de031c94b2ef9c4ae45a8906b250a95d3c47c47 Change-Id: I1de031c94b2ef9c4ae45a8906b250a95d3c47c47 Reviewed-on: https://gerrit.libreoffice.org/20413 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> Tested-by: Jenkins <ci@libreoffice.org>