summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2017-11-08sw lok: add Accept/Reject All tracked changes, tdf#101977Henry Castro
Change-Id: I04d747343e24cb498a621c965d034d0791411d83 Reviewed-on: https://gerrit.libreoffice.org/44311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-11-07sfx2: SfxInPlaceClientList is just a std::vectorTakeshi Abe
Change-Id: I6b676d17d9592a0ca998cdafb25b1aa12e11b6d6 Reviewed-on: https://gerrit.libreoffice.org/44384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-07ofz#3577 TimeoutCaolán McNamara
little speculative given https://github.com/google/oss-fuzz/issues/960 Change-Id: Ie844ebdd1e693ce8589fba9b7370d55914d844a7 Reviewed-on: https://gerrit.libreoffice.org/44377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-07sfx2: Simplify SfxVersionTableDtor's code with std::unique_ptrTakeshi Abe
Change-Id: I8279f7ae14301f485c2678271939fb6ad72d4721 Reviewed-on: https://gerrit.libreoffice.org/44350 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-11-04lok: temporary workaround: disable formula mode for onlineMarco Cecchetti
- Start empty spreadsheet, open it with two users (let's call them A & B). - Type "=" with user A. - Start moving around to different cells with user B. => Cell name of user B's selected cell is entered in user A's formula. This is due to the fact that ScModel::GetInputHandler() returns always the input handler which is handling the edited formula and not the input handler of the current view. That really messes up collaborative editing, so better to disable it, until we implement an alternative solution. Change-Id: I6e779cba3f377d12b7a4a19a6ee53c924fc9ba20 Reviewed-on: https://gerrit.libreoffice.org/43035 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-04sfx2: Omit unnecessary indirection of SfxFrameDescriptor_ImplTakeshi Abe
Change-Id: I43c9df757d78420bd119a06e7f7224e40690b753 Reviewed-on: https://gerrit.libreoffice.org/44255 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-11-03Revert "Replace list by vector in filtergrouping (sfx2)"Michael Stahl
This reverts commit 62896fb7a5983eb13ee87b94ae803e6552626d8d. The usage of iterators in CreateEmptyClassRememberPos operator() is bogus and causes: Error: attempt to dereference a singular iterator.
2017-11-03TSCP: use the BAC identifier as the RDF keyAshod Nakashian
DOCX RDF -> SmartTag logic expects urn:bails namespace to dump the RDF, and it also needs to have the rdf file in tscp/bails.rdf, hence the move. Change-Id: I9ae496c97abe97d3596de46ffccd5f7c80e37d34 Reviewed-on: https://gerrit.libreoffice.org/44116 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-03sfx2: Simplify SfxDocTemplate_Impl with std::unique_ptrTakeshi Abe
Change-Id: Ie736bcb6ca636cd5f34f12f7b4fdb234d18f3999 Reviewed-on: https://gerrit.libreoffice.org/44202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03Replace list by vector in filtergrouping (sfx2)Julien Nabet
Change-Id: Ic5170843d8f47f92c7975cceaa9c33d278445b98 Reviewed-on: https://gerrit.libreoffice.org/43378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-03ofz#3577 TimeoutCaolán McNamara
Change-Id: I723552fe277a9a16c8a14c01f4701e1077ddfac3 Reviewed-on: https://gerrit.libreoffice.org/44223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-01sfx2: Simplify RegionData_Impl's code with std::unique_ptrTakeshi Abe
Change-Id: I87dba62abc48e70cfb019ddaa4cc93779ee844b5 Reviewed-on: https://gerrit.libreoffice.org/44155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31sfx2: Kill dead codeTakeshi Abe
which has been obsoleted since 387a35cedd74fee295dfeb2ad59a74cd8dabc451. Change-Id: Icd3f0044ea67b0cecf4491399e875197282ea476 Reviewed-on: https://gerrit.libreoffice.org/44106 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-31loplugin:constantparam in sfx2Noel Grandin
Change-Id: Id52809401fb848d7169a665903e67ba28f4af598 Reviewed-on: https://gerrit.libreoffice.org/44084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31loplugin:constantparam in sal,saxNoel Grandin
Change-Id: I7ca2fd05d1cf61f9038c529a853e72fedb1c9ed0 Reviewed-on: https://gerrit.libreoffice.org/44087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31sfx2: Kill useless mutex guardTakeshi Abe
Change-Id: Idcbb1eff983bb82d29b8e53f09c0b7e73a8aab39 Reviewed-on: https://gerrit.libreoffice.org/44046 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30'r' means C++ reference, but this mormal local OUString variable is not thatTor Lillqvist
Change-Id: I56d21c3dc09f972a415bbd74dc635b231373d9f3
2017-10-30tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+Furkan Tokac
Change-Id: I32aab185cd0572353f4d94cfe4b16af25a665ef4 Reviewed-on: https://gerrit.libreoffice.org/43684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-30related: tdf#103884 remove gltf/collada featureThorsten Behrens
Change-Id: Icd26ad96c0337844ef1463dabfbe791caa00dd2d Reviewed-on: https://gerrit.libreoffice.org/43972 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-28lokdialog: Use UNO name as dialog id when invoking lok callbacksPranav Kant
... not the frame id from the .ui file Remove temporary hacks introduced earlier in GTV also. Change-Id: I71290a5fac6547a5584094da21e2301ef8fbce0c Reviewed-on: https://gerrit.libreoffice.org/43957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-28TSCP: bump the doc classification if lower than paragraphAshod Nakashian
The document classification should not be lower than the highest-classificed paragraph. This insures that the document classification is as high as the highest classified paragraph upon saving. Change-Id: Ic838b886ecf97da2eca56870f68aa3e51c7291f6 Reviewed-on: https://gerrit.libreoffice.org/43772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-27tdf#113446 Make EditStyle appear in customization dialogYousuf Philips
Change-Id: I4340ee14478384d84148323345b498710cba4696 Reviewed-on: https://gerrit.libreoffice.org/43868 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-10-27loplugin:includeform: sfx2 (Windows)Stephan Bergmann
Change-Id: I2ce3e5012b368a9e390d927a3dfd2150c0d5d9f7
2017-10-27sfx2: Drop unnecessary abstraction of SfxFrameArr_ImplTakeshi Abe
Instead, use plain std::vector<SfxFrame*>. Change-Id: Ib32e748a0ce744d15cbe48f5d03e28c57b731394 Reviewed-on: https://gerrit.libreoffice.org/43938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26Avoid undefined left shift of signed integerStephan Bergmann
...after 022b1b2a40fcaf8d201081dead44c1d3346d1972 "tdf#96505 Get rid of cargo cult long integer literals" Change-Id: I9e5cc9d63c2eddd1ad766c2f6b01a9ff49a09bfd
2017-10-26vcl: make MapMode constructor explicitMichael Stahl
Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26More loplugin:unnecessaryparenStephan Bergmann
81892b2037453108b9bde1512a500cf3b2ce438a "loplugin:unnecessaryparen when compiling as C++17, so the ParenExpr is no longer hidden behind ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave me the idea to generally look though IgnoreImplicit instead of IngoreImpCasts in loplugin:unnecessaryparen. However, that would still not look through implicit CXXConstructExpr, so would still not have found the occurrences in 81892b2037453108b9bde1512a500cf3b2ce438a when compiling in pre-C++17 mode. Therefore, let ignoreAllImplicit also look through CXXConstructExpr. (I am not entirely sure in which situations non-implicit CXXConstructExpr---that should thus not be ignored---would occur, but assume they would be underneath something like a CXXFunctionalCastExpr, which is not ignored.) Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843
2017-10-25tdf#112430 improve popup of special character group buttonYousuf Philips
Change-Id: I132b7702cda2504ecad07d407b160eeb47798624 Reviewed-on: https://gerrit.libreoffice.org/43693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-10-24sfx2: finally resolve FIXME and test custom metadataMichael Stahl
Yay, we have assertXPath now! Change-Id: I74dedf535f5f0997dc94b3654558ccd451db813a
2017-10-24loplugin:finalclasses in sfx2..svlNoel Grandin
Change-Id: I71b78135b3d0259657438c4401340bb35ab5c6e0 Reviewed-on: https://gerrit.libreoffice.org/43742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-24loplugin:includeform: sfx2 (macOS)Stephan Bergmann
Change-Id: Id189589ae0847a1c14f512ab0912bf47f7838e43
2017-10-23loplugin:includeform: sfx2Stephan Bergmann
Change-Id: I5e9a7a2580a710880023288f5ed3584708c4769d
2017-10-23tdf#96505 Get rid of cargo cult long integer literalsudareechk
Removed 0L, 1L and 2L Change-Id: Icb38de1cdd8e1215a86118b0c8af993025fd790e Reviewed-on: https://gerrit.libreoffice.org/42567 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-22sc lok: fix spell checking languages in CalcHenry Castro
Change-Id: Iadcc3b55a30ce2a2c785366fb3807ff6e4bda1fe Reviewed-on: https://gerrit.libreoffice.org/43581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-10-22TSCP: classification abbreviation and sensitivity supportAshod Nakashian
Change-Id: I4d165be565193857c3c7839102d72371b4c5ad44 Reviewed-on: https://gerrit.libreoffice.org/43628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-22TSCP: support abbreviated classification namesAshod Nakashian
Change-Id: Ib7edc491d2f8a69c48f1515ba29d79e09c88c3b7 Reviewed-on: https://gerrit.libreoffice.org/43627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-21check seeks earlierCaolán McNamara
Change-Id: Id392f2299b6bdacb9a71e94959d24d02417d571e Reviewed-on: https://gerrit.libreoffice.org/43657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-21tdf#67770: Read/writer LastActiveDeck bitsKatarina Behrens
Change-Id: Id5e3c3cb4144b9fc56ab5e4a4e49f1fc69e70023 Reviewed-on: https://gerrit.libreoffice.org/43493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-20ensure init codepage on short readCaolán McNamara
Change-Id: Id288b7473fa65c35c45d726d47e5016ae0b630e4
2017-10-19Replace list by vector in Metadatable (sfx2)Julien Nabet
Change-Id: I707dd27be91711e4f80d39c620a3b9784b5ef122 Reviewed-on: https://gerrit.libreoffice.org/43376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-18tdf#99537 set expand for re-used sidebar panelsJan-Marek Glogowski
When re-using a panel, reset the expand state from the stored state in the PanelContexDescriptor. Change-Id: I00851982bbd36cacdc57459bb6e5be9fcc719e81 Reviewed-on: https://gerrit.libreoffice.org/43466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-17turn implicit container explicit in buildable notebooksCaolán McNamara
as in interim measure for SfxTabDialogs we throw away the TabPage if its not suitable for reuse Change-Id: Ic5776ca3d2a8cb6bf41f33df01b211f81c62a842 Reviewed-on: https://gerrit.libreoffice.org/43134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-16tscp: move getting the current policy type to class. helperTomaž Vajngerl
Change-Id: I54afcca1c1fc1a27458c75ab9fd3405d6f7e9239 Reviewed-on: https://gerrit.libreoffice.org/43360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-15Replace lists by vectors (sfx2)Julien Nabet
Change-Id: I081d0614978bc6d9f1a137e09d09e6d2dadb925a Reviewed-on: https://gerrit.libreoffice.org/43372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-14Replace list by vector itemconnect (sfx2)Julien Nabet
Change-Id: I753f655c11883e5bf705a2361a6d4d5e55ea88c9 Reviewed-on: https://gerrit.libreoffice.org/43377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-14tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+ekuiitr
changed sfx2 module file, converted OUStringBuffer::append() with operator+ Change-Id: Ie85542358875324f9ddadffa01395aebccda9be9 Reviewed-on: https://gerrit.libreoffice.org/43357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-13Notebookbar: PriorityHBox working after reloadSzymon Kłos
Change-Id: Iba1802f386131b37b7972a7f022f85fdcdaab6fe Reviewed-on: https://gerrit.libreoffice.org/43363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-13Notebookbar: initialize correctly PriorityHBoxSzymon Kłos
Change-Id: If8d94c3496dacb3ae9e0b50ba269f3af87c3bcb4 Reviewed-on: https://gerrit.libreoffice.org/43351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-09ofz#3577: speed up short readsCaolán McNamara
Change-Id: Ic05a7eb415ca0d3ee1cef5dcf0a881119bf52ac6 Reviewed-on: https://gerrit.libreoffice.org/43276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>