summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2015-04-30Use typed Link for MenuButton::SetSelectHdlStephan Bergmann
(and MenuButton::GetSelectHdl was unused) Change-Id: I94df06bcda9e041fde65553e30247874b20ff74b
2015-04-30No need for LINK vs LINK_TYPED distinctionStephan Bergmann
(fully qualify ::tools::detail::makeLink to avoid clashes with namespace basegfx::tools) Change-Id: I52818d0a47c78f1af7673ff91eb6517bc0820655
2015-04-30Use typed MaybeFile LinkStephan Bergmann
Change-Id: Ic9eebca9d8fe3e9173b1873bdc7800e5161f9999
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30Get rid of the initial :: for the vcl namespaceTor Lillqvist
We used it all over the place without leading :: already anyway, even in many files in include. So let's be consistent. In the majority of cases, prefer the easier-on-the-eyes choice, not the "safe" one. In those files in include where *all* existing uses of ::vcl:: indeed used the :: prefix, there let's keep it for consistency. Change-Id: If99cb41d3bf290d38c601d91125c3c8d935e61d0
2015-04-29Remove unnecessary IMPL_LINK[_NOARG]_INLINE_START/ENDStephan Bergmann
...just use IMPL_LINK[_NOARG] and let the compiler decide what to inline Change-Id: I63ec5116df7e79093ebf31193f8c674f1351c0e6
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29SfxInfoBarContainerWindow: pInfoBar can be 0 hereMiklos Vajna
0x00007ffff0b36bf0 in OutputDevice::disposeOnce (this=0x0) at /git/libreoffice/master/vcl/source/outdev/outdev.cxx:193 193 if ( mbDisposed ) (gdb) up #1 0x00007ffff3c3d651 in SfxInfoBarContainerWindow::removeInfoBar (this=0x1f05b30, pInfoBar=0x0) at /git/libreoffice/master/sfx2/source/dialog/infobar.cxx:294 294 pInfoBar->disposeOnce(); Change-Id: I7b5dfddea98d8ab3d4f7db3ef53660f91e5ad80b
2015-04-29convert STR_EVENT constants to scoped enumNoel Grandin
- also add needed infrastructure to o3tl::enumarray so we can use std::find on it - move the Impl inside the .cxx file, no need to expose it in the header Change-Id: I7758a6175849f46723d97b1e657f846524c3b7cd
2015-04-29error C2666: 'operator ==' : 2 overloads have similar conversionsDavid Tardon
Change-Id: I51c71a82a312c2b059ba046ee2557117f365143b
2015-04-29WaE: C2666: 'operator ==' : 2 overloads have similar conversionsDavid Tardon
Change-Id: Ifa31130045c37aa37a1f3c9d3799a9f60fd8eb13
2015-04-29fix compile: delegate RenderContext parameter to superTomaž Vajngerl
Change-Id: I1c08e29c45d8334db52b129a957098481f3e57a4
2015-04-29replace Paint calls to Invalidate + fix compilationTomaž Vajngerl
Change-Id: Id716c47d56922ab6ce0c3adb3d426ea814980674
2015-04-29mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&)Tomaž Vajngerl
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
2015-04-28sfx2: fix GCC-4.7 buildMiklos Vajna
Change-Id: Ib98d73703eb713a38d28e96a92097b718404abc6
2015-04-28Merge remote-tracking branch 'origin/feature/vclptrmerge2'Michael Meeks
2015-04-28Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks
Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28bOleServer/bMac vars want to be of type boolStephan Bergmann
Change-Id: Ie86c43f594486b38b779df2fbc8bd8f15682fa7b
2015-04-28SfxChildWin_Impl::nVisibility is of type sal_uInt16/SVX_VISIBILITY_*Stephan Bergmann
Change-Id: I4dd0556557ead72b2a2e9f45ccdb35a77efeab4d
2015-04-28SfxDispatcher::GetShellAndSlot_Impl return type wants to be boolStephan Bergmann
Change-Id: I7897ce11621a7aac991ea64897d8fdeb06c3d2d7
2015-04-28bFound var wants to be of type boolStephan Bergmann
Change-Id: I106f8414fcf28fe314b14156d004bdb0cf20f023
2015-04-28SfxDispatcher::Call_Impl return value is unusedStephan Bergmann
Change-Id: Iecaff2b1b5449751a9787a3b27c70495d82cc623
2015-04-28SfxTabPage::DeactivatePage wants to return SfxTabPage::sfxpgStephan Bergmann
Change-Id: Iba538bb51635e6cae1e033d14e8da3dabfb36634
2015-04-28Rephrase comparisons between bool and sal_BoolStephan Bergmann
...to cater for forthcoming loplugin:implicitboolconversion improvements Change-Id: I801b6b73648715448198d582a087cc834f6e20c8
2015-04-27More loplugin:simplifyboolStephan Bergmann
Change-Id: Ifa8a855fc870a55fda8d801c22c15b0bc441fbe6
2015-04-27tdf#65498, tdf#87545: Don't confuse logically r/o doc with physically r/oStephan Bergmann
b9ecec7c74687ed5a9470cffb7d02e0e6e83107e "Allow for editing of read-only documents" introduced "A new state of 'IsOriginallyReadOnly' needed to be added to the medium, to keep track whether the medium was originally opened r/o (and is thus assumed to be physically r/o), as toggling SID_EDITDOC in the view also changes the open mode of the underlying medium. Instead of trying to fully understand and disentangle that horrible mess, I just added yet another state to the mess..." But that heuristic is apparently too simplistic, as it treats documents originally opened "logically r/o" (via --view command line argument, or by checking the corresponding checkbox in the Open dialog) as "physically r/o" too, which leads to unexpected behavior when such documents are later switched into r/w Edit mode. An approach that hopefully works better overall is to set IsOriginallyReadOnly only if the document originally is r/o as reported by OSL (for a document with a file URL). Change-Id: I32d5ec655d7556a70680aee55feda4c6eea7795f
2015-04-25remove some @author tags from suspiciously unidiomatic codeMichael Stahl
Change-Id: I3930420fe502978f8e14a688f2eb99c74d185f7b
2015-04-24loplugin:simplifyboolStephan Bergmann
Change-Id: I0a2a7d1af979b24f6d3db9783984e85e1992643d
2015-04-23loplugin:staticcallStephan Bergmann
Change-Id: I27c1e94ab94aa242cf73732f3402b169d6d48238
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23Use comphelper::SequenceAsHashMap::getUnpackedValueOrDefault<bool>Stephan Bergmann
...instead of ...<sal_Bool>; plus ensuing loplugin:implicitboolconversion Change-Id: I5400e9d3175b9fe9b6088d37fe6bf3275314d7d0
2015-04-23loplugin:staticmethodsNoel Grandin
Change-Id: Id7fc12bc61c6e803f45cc60556d9cf54ac2e529f
2015-04-23loplugin:staticmethodsNoel Grandin
Change-Id: I6207b475127099872c6f3764331006688129b673
2015-04-23loplugin:staticmethodsNoel Grandin
Change-Id: Ib0c0841e48814d1a6e13bcd4575725d86ffa5e5e
2015-04-23make "Styles & Formatting" preview HiDPI awareTomaž Vajngerl
Change-Id: I6f167bc8310b75dbe8bddbfe331853dc6d17c9fc
2015-04-22convert SV_DRAGDOP_ constants to scoped enumNoel Grandin
Change-Id: If953610ed24a2b6d5f33f2ba014fba2ca5308d7d
2015-04-22convert SFX_TOOLBOX_ constants to scoped enumNoel Grandin
and move them to a more logical header Change-Id: I56956969d3067d66ccdadd53cd5630409de16cd8
2015-04-22convert HIB_ constants to scoped enumNoel Grandin
Change-Id: I6fa3ecde4a1c5f9c7e6e1dcd22250cba065933e3
2015-04-22callcatcher: update unused codeCaolán McNamara
Change-Id: I8a596153fe6ab34c56a956731d7f9909e71044aa
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-21No more need for PartialWeakComponentImplHelper hereStephan Bergmann
...since 70626249cd247d9acdad417b8eaf252bae22c059 "API CHANGE a11y unpublishing and add/removeListener rename." Change-Id: I89d81326d97712abcac94c3436a13905954c55cf
2015-04-21loplugin:passstuffbyrefStephan Bergmann
Change-Id: I882ef5f8d1193ab3f3daeff0f4eb755c40c898ba
2015-04-21simplify gathering XML conf. data in sidebar ResourceManagerTomaž Vajngerl
Change-Id: I218698079d205690b596f3d36ff7dedea08c92fa
2015-04-21cleanup ResourceManagerTomaž Vajngerl
Change-Id: Ic07e0a9eb72fc78c23d65c82420daa57dbeb44f7
2015-04-21sidebar panel or deck can now be marked as experimentalTomaž Vajngerl
.. so they show up only when experimental mode is enabled. Change-Id: Ib89b8b03290b7c04edc4da48ed328f03cd88d02c
2015-04-21cleanup templdlg.cxx (Style and Formatting)Tomaž Vajngerl
Change-Id: I94758b6462c589b1f7eea9bac634e2f33646651b
2015-04-21preview of styles in "Style And Formatting" dialogTomaž Vajngerl
Change-Id: Ic10025f8b27c87ae40f62cb04653cc8e6abc7fc1
2015-04-21highlight the whole entry in "Style And Formatting" tree/listTomaž Vajngerl
Change-Id: I2968541be05aafbd39a161b48d840f7be66deee1
2015-04-21StyleManager & StylePreviewRenderer + common implementationTomaž Vajngerl
StyleManager is a new class responsible to handle document styles. The current implementation has only the responsibility to provide a implementation of StylePreviewReneder, but the idea is to move all style related functionallity to this class (and relieve the SfxObjectShell a bit). CommonStyleMAnager is the common impl. StylePreviewRenderer is responsible to render a preview of a style. As styles can be handled differently by each component it is possible to provide component specific StylePreviewRendered, but currently only the common one is implemented and used by sw. Change-Id: Id271485f571a777a3e94f855d3c614a2efc14628
2015-04-21cleanup SfxTemplateControllerItemTomaž Vajngerl
Change-Id: Ia29d45ed1fe41c986bf7d15d4da4557011544daa