summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2018-04-16Make linked graphic register into LinkedManager againTomaž Vajngerl
Change-Id: I16b162f86d6221d120f6355f9a52c1abfcd0ac73 Reviewed-on: https://gerrit.libreoffice.org/52911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-15Resolves: tdf#116996 null is a bad parentCaolán McNamara
Change-Id: I85f2816f1d28260c46ebe7996a74d870321a26a8 Reviewed-on: https://gerrit.libreoffice.org/52895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-15tdf#108556 - Start center welcome text should respect window widthheiko tietze
Wordwrap on second line added Change-Id: I1b50173eca4fa1c19d25291413fa0bebbcad9190 Reviewed-on: https://gerrit.libreoffice.org/52906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-15remove some unused comphelper includesJochen Nitschke
and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: https://gerrit.libreoffice.org/52894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-14Fix typosAndrea Gelmini
Change-Id: I9ea95f5b7b6cd056cc1aad146c8841877d187d55 Reviewed-on: https://gerrit.libreoffice.org/52742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-14look for check buttons without underlinesCaolán McNamara
Change-Id: Ia9963190cf3dccbfa82951a3f2c0e29e00171429 Reviewed-on: https://gerrit.libreoffice.org/52847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13weld ScInsertCellDlgCaolán McNamara
Change-Id: I91118d4c0c5e2fa17fed02377547caa65e11bfdc Reviewed-on: https://gerrit.libreoffice.org/52824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13PRODUCTNAME not expanded in help missing dialogCaolán McNamara
Change-Id: I6fb0e64566eacadc963f1b7ff570e021abe29522 Reviewed-on: https://gerrit.libreoffice.org/52817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13weld SfxAddHelpBookmarkDialogCaolán McNamara
Change-Id: I3724b0e92cfd3103f7ecdadbcf6c1efc501e6c04 Reviewed-on: https://gerrit.libreoffice.org/52822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13weld DurationDialogCaolán McNamara
Change-Id: If69c4259c3fd40c822a2dd505e51059a805813f4 Reviewed-on: https://gerrit.libreoffice.org/52821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13weld SfxTemplateCategoryDialogCaolán McNamara
Change-Id: I7462102797e3b0f552aec97f6cbae919e89e7099 Reviewed-on: https://gerrit.libreoffice.org/52820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13Resolves: tdf#116865 trigger pending sizing timers before arrangingCaolán McNamara
trigger pending sizing timers now so we arrange with the final size of the client area Otherwise calling GetSizePixel in the Arranging loop will trigger the timers anyway, causing reentry into Arrange_Impl again where the inner Arrange_Impl arranges with the final size, and then returns to this outer Arrange_Impl which would rearrange with the old client area size. Change-Id: Ibc2b97f679ceaa0a825cee015576f403703a5f9e Reviewed-on: https://gerrit.libreoffice.org/52815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-13Don't abuse loading of a Graphic to actually load an ImageTomaž Vajngerl
Change-Id: I816c46542088f36ef69b127cc13080e3bc8cdfc2 Reviewed-on: https://gerrit.libreoffice.org/52806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-12Fix typosAndrea Gelmini
Change-Id: Ie6ce882d5d39cdd24d0647b9fdddabafeee1d25f Reviewed-on: https://gerrit.libreoffice.org/52277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-11return std::unique_ptr from SfxItemSet::CloneNoel Grandin
Change-Id: Ie747b5c8ff0b82b9f8d268f9a60dbde41b5f022b Reviewed-on: https://gerrit.libreoffice.org/52712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10loplugin:unusedfield improvementsNoel Grandin
improve the read-only check to ignore reads from fields that are guarded by a boolean check, something like: if (field) field.foo(); this produces some false positives at the moment because I'm not correctly handling the else block, but also some useful new dead code. Change-Id: Id21fa1a56c171d09d979769b978b6eef14e8b695 Reviewed-on: https://gerrit.libreoffice.org/52664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10graphic: rename Set{Get,Is}Link to Set{Get,Is}GfxLinkTomaž Vajngerl
The main reason is to differentiate when we have the GfxLink from other (url, file) links which use the same terminology. Change-Id: I805c61e7fb231062340562c51c25a189b2cfc7f7 Reviewed-on: https://gerrit.libreoffice.org/52245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-09use more DBG_UNHANDLED_EXCEPTIONNoel Grandin
so we get nice logs of the exception dynamic type for UNO exceptions. Change-Id: Ic0b10dc14d354a2c9a0591b3a51d2f1640d54bdb Reviewed-on: https://gerrit.libreoffice.org/52465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-07Revert "long->sal_Int32 in tools/gen.hxx"Stephan Bergmann
This reverts commit 8bc951daf79decbd8a599a409c6d33c5456710e0. As discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-April/079955.html> "long->sal_Int32 in tools/gen.hxx", that commit caused lots of problems with signed integer overflow, and the original plan was to redo it to consistently use sal_Int64 instead of sal_Int32. <https://gerrit.libreoffice.org/#/c/52471/> "sal_Int32->sal_Int64 in tools/gen.hxx" tried that. However, it failed miserably on Windows, causing odd failures like not writing out Pictures/*.svm streams out into .odp during CppunitTest_sd_export_ooxml2. So the next best approach is to just revert the original commit, at least for now. Includes revert of follow-up 8c50aff2175e85c54957d98ce32af40a3a87e168 "Fix Library_vclplug_qt5". Change-Id: Ia8bf34272d1ed38aac00e5d07a9d13fb03f439ae Reviewed-on: https://gerrit.libreoffice.org/52532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-07sw lok: View jumps to cursor position even if it is moved by an other view.Tamás Zolnai
Scrolling is done twice. Once in SwCursorShell::UpdateCursor() by SCROLLWIN flag. Here we can check the actual viewid and avoid scrolling if the cursor is move by an other user. The second instance in the LO online code, for it we need to pass the viewid identifying the view which moved the cursor. Change-Id: I033274f88ce41acbb632e2aeb0d986ab11cd2d52 Reviewed-on: https://gerrit.libreoffice.org/52220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-04-06weld linkeditdialogCaolán McNamara
which enables changing FileDialogHelper over to welded Change-Id: I988342a6574cb7ed09b2724929e8c7117474a56c Reviewed-on: https://gerrit.libreoffice.org/52388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-06tdf#116628: Fix expanding the entries in Help's Contents tab.Jan Holesovsky
Change-Id: I50627ca577bf89810c716bf9e1db9ae74cec58d1 Reviewed-on: https://gerrit.libreoffice.org/52473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-04-05fix bug in SfxDockingWindow::CalcAlignmentNoel Grandin
ever since commit 715b590e8753fac3083e15a13f14270f15162050 Date: Tue Jul 6 12:35:55 2004 +0000 INTEGRATION: CWS docking1 (1.29.254); FILE MERGED Change-Id: Ic447e12592b30f9cfe8ad22bd32214d02cf36477 Reviewed-on: https://gerrit.libreoffice.org/52389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-04drop mysterious bare SetUpdateMode callCaolán McNamara
Change-Id: I9ab52107e87c7154a50ed5ae89bd89c354e25b51 Reviewed-on: https://gerrit.libreoffice.org/52387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-04weld SvInsertOleDlgCaolán McNamara
and weld SfxInsertFloatingFrameDialog and smuggle in the parent widget for the Gtk File dialog via an XWindow interface Change-Id: I971b3a0ffe661c9268115fd5d00bf8eee80e77b3 Reviewed-on: https://gerrit.libreoffice.org/52373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-04loplugin:unusedmethodsNoel Grandin
Change-Id: If88b11419fc6d483ef689d2199a347c00622e01c Reviewed-on: https://gerrit.libreoffice.org/52358 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-03weld SfxViewVersionDialog_ImplCaolán McNamara
Change-Id: I5486df92b4e1d0ad5be18a35e72a7a6dbcc3b715 Reviewed-on: https://gerrit.libreoffice.org/52334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-03tdf#116066: call DoSaveCompleted after SetReadOnlyUIMike Kaganski
Change-Id: Ided8f12764585b2ba62e4c296af43ac07b9e31ed Reviewed-on: https://gerrit.libreoffice.org/51051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-03long->sal_Int32 in tools/gen.hxxNoel Grandin
which triggered a lot of changes in sw/ Change-Id: Ia2aa22ea3f76463a85ea077a411246fcfed00bf6 Reviewed-on: https://gerrit.libreoffice.org/48806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-03pass area param to DBG_UNHANDLED_EXCEPTIONNoel Grandin
and update sallogareas plugin to enforce this Change-Id: Id0782c8a1f619372e10d931aec3c6a4743a4c86a Reviewed-on: https://gerrit.libreoffice.org/52249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-02drop the spurious invisible_char[_set] propertiesCaolán McNamara
Change-Id: I8264a4f6035fd19c7a892902c41127615eaf6dd3 Reviewed-on: https://gerrit.libreoffice.org/52265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-02can now remove ResId based config id schemeCaolán McNamara
Change-Id: Id1ad413dacc7eb07269debba65426236bef28610 Reviewed-on: https://gerrit.libreoffice.org/52259 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-02tdf#115131 made a common submenu for toolbars and notebookbarsKshitij Pathania
Also added the submenu in base, maths and draw Change-Id: I94850c09c08fd3848eabe2597679634f30fbc735 Reviewed-on: https://gerrit.libreoffice.org/49575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-04-01fix some openoffice bugzilla linksdennisroczek
* remove redirects * use https links * replace old attchment links with working ones Change-Id: Ic9a154f46e142138f0adea7d7b8be3b6cfe8af18 Reviewed-on: https://gerrit.libreoffice.org/52224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-30weld SvxCharacterMap dialogCaolán McNamara
and SmSymDefineDialog There's a whole bunch of interrelated stuff which needs to work at the same time. add menu support, keyboard support, better mouse support, a gtk scrollable adaptor to support pseudo scrolling drawing bodge, plugable uitest support for custom widgets, plugable a11y support for custom widgets via the existing atk_object_wrapper_new wrapper for XAccessible In this specific case, change SvxCharacterMap from something that has an internal scrollbar to a scrolledwindow where the scrollbar is external, which drops the need for the a11y impl of SvxCharacterMap to emulate being a scrolled window and internal table and just needs the table a11y impl Change-Id: Ia2743d6958021c525a1900154dcbb69ae33fc400 Reviewed-on: https://gerrit.libreoffice.org/52084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-29tdf#116680 fix sidebar can't undockJim Raykowski
Change-Id: Ic3d198488de6d0420dbdb8fb7dbfb0335556e108 Reviewed-on: https://gerrit.libreoffice.org/52047 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-29coverity#1433647 Unchecked return value from libraryCaolán McNamara
Change-Id: I05c91dc21ddcef0f64f712f4fe9a5736b0cee0f9 Reviewed-on: https://gerrit.libreoffice.org/52059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-29loplugin:virtualdown in sfx2Noel Grandin
Change-Id: I51e79a4a3d2c799e69bc13c66b5b84056bee6206 Reviewed-on: https://gerrit.libreoffice.org/52034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-27tdf#115786: Fix reopening undocked sidebarKatarina Behrens
while trying hard to keep tdf#88241 fixed. Had to introduce yet another bool variable as now that previously active sidebar deck is remembered (= it is visible when floating window opens) it's impossible to tell whether sidebar was already opened or not Change-Id: If2c9edfa2f9beb400537b106d3094f256b0cc183 Reviewed-on: https://gerrit.libreoffice.org/51866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-26sfx2 store: avoid rename() for files with >1 hard link countMiklos Vajna
Rename would break the hard link; in practice e.g. Online's 'make run' debug feature depends on not breaking hardlinks. Change-Id: Id3ac19493b6b473274b7ed53a4ca06fc34bc1668 Reviewed-on: https://gerrit.libreoffice.org/51858 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-26use boost::optional in OutDevStateNoel Grandin
Change-Id: I83fb85fcba6cd2a5dc4f99fdfd3238d72afb7bc2 Reviewed-on: https://gerrit.libreoffice.org/51770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-25Remove useless checkMike Kaganski
Change-Id: I9cfb8e7865e31b5c69e0b4b99426e96c7444224f Reviewed-on: https://gerrit.libreoffice.org/51820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-22set parent for password dialogCaolán McNamara
Change-Id: I3276cdc1a9f94aead260706cb378e278000081be Reviewed-on: https://gerrit.libreoffice.org/51728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20drop unnecessary includesCaolán McNamara
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20tdf#116494: Don't ask parent if no help textMuhammet Kara
And add/use an IsHelpInstalled() method to SfxHelp. Change-Id: Ib87573067d6c44fa5adb22253c1a51a78580acf6 Reviewed-on: https://gerrit.libreoffice.org/51584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-20Show start centre thumbnail indicating the file is encryptedKatarina Behrens
Change-Id: Ie46096b3198852c6ef70960b22652767c09d4779 Reviewed-on: https://gerrit.libreoffice.org/51532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-19coverity#1430074 Uncaught exceptionCaolán McNamara
and coverity#1430066 Uncaught exception coverity#1430095 Uncaught exception Change-Id: Idca2e12d3911e3ea768a2a9fb8e7f3b03a2c887f Reviewed-on: https://gerrit.libreoffice.org/51567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19lokdialog: Set parent for AutoCorrect Options... so that it can be tunneled.Jan Holesovsky
To get this dialog: Right-click on a mis-spelled word, and it's in the tunneled context menu. Still it should be converted to async though. Change-Id: Ia8f2aaf0d04f144c74999107de98e52cd51876e7 Reviewed-on: https://gerrit.libreoffice.org/51441 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 7b83827d7b5d07401878fe552c421331629a7880) Reviewed-on: https://gerrit.libreoffice.org/51548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-19coverity#1430073 silence Unchecked return valueCaolán McNamara
Change-Id: I3c40f0679fea99b22489fedb5af17982c1502a86 Reviewed-on: https://gerrit.libreoffice.org/51560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>