summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-08-07Resolves: fdo#82043 use a bold font for the start-center buttonsCaolán McNamara
Change-Id: I4d947060815559f68cd200d8103868014ea6ac2d
2014-08-07Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann
Change-Id: I712d10c80ffbd3c4b9d628497eca006a912955ce
2014-08-07rhbz#1079672: FileDialogHelper: don't hand out stale preview GraphicMichael Stahl
The maGraphic is updated from a timer, and if you double-click on a file then the dialog may exit with the previous file still previewed in maGraphic, so the wrong image is returned by the dialog. Change-Id: I99094d85d8d68d5c8a842f52e7039dbbbf095995
2014-08-05fdo#82017: Rename 'Close without saving' button to 'Don't Save'.Adolfo Jayme Barrientos
It matches other applications both in Windows and OS X. Users expect to press the 'D' key to activate this button. Also, it's shorter. Change-Id: I08f80fd9dbfbc5e2a5dc69ff2f72d55b80ccda5a Reviewed-on: https://gerrit.libreoffice.org/10685 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2014-08-05java: remove commented out codeNoel Grandin
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-04avoid buffer overflow by using wrong bufferMarkus Mohrhard
Found by Asan. (regression from CWS mba34issues01) Change-Id: Ia7159c9bed9d7f823448acd02e18568a5f3f2093 Reviewed-on: https://gerrit.libreoffice.org/10717 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-01typo: more then -> more thanTakeshi Abe
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01hidpi, startcenter: Don't set fixed font heigt in the startcenter.Jan Holesovsky
Change-Id: I68efbd08d21b514ab1659cd6bddfc2c4788c4a74
2014-07-29simplify "no delete" logic in SvRefBaseNoel Grandin
by converting the bit munging to use bitfields. Remove unused return values. Add asserts to check that AddRef() is not called after the object is deleted. Fix the code in SfxObjectShell to not call AddRef() after SfxObjectShell is deleted. Change-Id: I3a3565a0bc45fc9d1d086222265ab8b8175818a7
2014-07-29fdo#46037: remove unused comphelper/configurationhelper.hxxAlexandre Vicenzi
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa Reviewed-on: https://gerrit.libreoffice.org/10603 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29Drop unnecessary SfxApplication::CreateResManager wrapperStephan Bergmann
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
2014-07-29WaE: 'initializing' : truncation from 'double' to 'float'Tor Lillqvist
Change-Id: Ie61d007857a62facac9d4e21ec494195041eeffb
2014-07-29simplify return argument of SfxPoolItem::GetPresentationNoel Grandin
since all two of the actual call-sites only care about whether it is a valid presentation or not, not what kind of presentation it is. Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
2014-07-28sfx2: -Werror=parenthesesMichael Stahl
Change-Id: I94973343bb3ec4a055d9a46ca7ac800dd08406ad
2014-07-28Some properties in File->Properties->General Tab are not set for remote docsMihai Varga
This patch handles the case in which no meta information could be extracted from the file, so CMIS properties are displayed instead, if it is a CMIS document. Size and creation/modification dates are handled here. Change-Id: I97f920172b15a76297d78a33ac3a07a8333ef8a6 Reviewed-on: https://gerrit.libreoffice.org/10511 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2014-07-26fdo#71770 Fixed Cut/Copy/Paste popup menu items to appear at the topJeffrey Stedfast
Change-Id: I14b3ad87536b2cf7e2e21ba00cb2afa18c2c95a3 Reviewed-on: https://gerrit.libreoffice.org/10564 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-07-25gcc 4.3.4: no matching functionCaolán McNamara
Change-Id: I65b4eff7c7a9912433a91739a8e2db4cfaf17b90
2014-07-25convert the weak reference macro in tools into a templateNoel Grandin
which required making SfxFrame subclass SvCompatWeakBase, but that makes the relationships clearer anyhow. Change-Id: I209d05359d50111eacac72c971bb46ccf569ba49 Reviewed-on: https://gerrit.libreoffice.org/10285 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-25Remove 1 px border around Start CenterAdolfo Jayme Barrientos
It leaks workspace background color (behind the sheet in Writer etc.), which looks bad as it's much darker now under Windows and OS X. Change-Id: I29034be86d3cf5537384b325fc6734b4dc05f077 Reviewed-on: https://gerrit.libreoffice.org/10521 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-24Resolves: fdo#80476 Start Center sidebar button are too largeCaolán McNamara
Change-Id: Iedf67b5591d84963e1caf3e8d9d17d42175bb604
2014-07-24sfx2: remove another DBG macro that arose from the graveMichael Stahl
The callers in dispatch.cxx use methods that were removed by commit a1ce4fb4f0dbc3c4141f510e5b2b732a24d862c8 - not sure if this warning is useful or not. Change-Id: I8bb654de8e26c054318dd2037055a85d013c8bfa
2014-07-24Related: fdo#81641 create new styles with an initial nameCaolán McNamara
instead of creating with a blank name and changing it later this way undo of a style creation is initialized with its name and so create a style followed by deleting a style and undoing all those steps doesn't crash Change-Id: Ida7a34410d5d7b05edcb86950aabb3c672b82c8f
2014-07-24style category listbox depends on being unsortedCaolán McNamara
regression from commit 6ecfbf153a7c11c63d208630ac6a27064058099d Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Mar 13 15:10:25 2013 +0000 drop unused resources and toggle label to activate replacement widget Change-Id: I65ca8ec58ed984120f3c2e7ba68507cbf8acf089
2014-07-24Related: fdo#81641 exclude 'all styles' category from organizer pageCaolán McNamara
it doesn't make sense to be able to assign a style to 'all styles' Change-Id: I632c62f293b553e436ceb8da0baf2bb39941fd39
2014-07-23convert SfxItemState constants to a proper enumNoel Grandin
and while we're at it - use the enum type all over the place instead of passing around sal_uInt16 - don't use bitwise logic on enum values - use enum values instead of numeric constants Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-22do not unescape sequence in original name in GetRecommendedName()Eike Rathke
Noted with the fix for fdo#81304 the code unescaped an escaped sequence in the original file name, for example "foo%20bar" became "foo bar". This change preserves such sequences, though the final result at the (GTK) file picker is still unescaped, which happens somewhere else. However, now for the suggested file name "foo%20bar#baz" an InetURLObj of "foo%2520bar%23baz" is created and results in a recommended name of "foo%20bar#baz" again. Change-Id: I620811e33bdb74323ddcb3d732428179bf7181d4
2014-07-22Related: fdo#81457 quadratic time required when setting a11y nameCaolán McNamara
when calling SetAccessibleName GetAccessibleName is called in order to send a name changed a11y event. Getting an Accessible Name is very slow in a non-layout aware widget because it scans for a "nearby" label and there is none in this widget, but it has a huge pile of other widgets to iterate over. call add_mnemonic_label before hand to cut off that entire branch. While we're at it, only call InitControl to adjust to a new width if the new width is different from the old width Change-Id: Ie4ba1276127226e49442278e46447b84bbeb1cde
2014-07-22callcatcher: update unused codeCaolán McNamara
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-20fdo#63756 build libxml2 with ICU supportDavid Tardon
Change-Id: I0523e49e640812be435ba4c97b1881ca253eb2ab
2014-07-17fix spelling structur -> structureNoel Grandin
Change-Id: I7aa4a9bf72732db95a67cee368f3a83a0d71bb9c
2014-07-17rename the Weak stuff in tools/ref.hxx to WeakRefNoel Grandin
.. which more accurately reflects it's purpose Change-Id: Ibb87a47a3d1f3e35ac2820f14c71adf3b227c961 Reviewed-on: https://gerrit.libreoffice.org/10283 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-14fdo#81304 don't parse file name as part of URLDavid Tardon
... because the name is not URL-encoded at this point, so parsing it as a part of the URL will interpret special characters, e.g. #. Change-Id: I780baed1753e9674d835dc296d31c088b67d8ba7
2014-07-14inline tools::SvRefBaseRef typedefNoel Grandin
..it is only used in two places Change-Id: If333936b26592ed44d3525f2eb3c21aafde7dddc
2014-07-14Related: #i125226# expect DDE servers to be already upHerbert Dürr
"soffice" is always up anyway and other DDE apps should be started manually (cherry picked from commit e0bfdb26cef87c8d3b3435293116a33cf99c11f0) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I52ebb26528952a4abf33ac95cb67c598f08b2790
2014-07-13SfxModelessDialog ResId ctor bites the dustCaolán McNamara
Change-Id: Ia1bc255de0f38c058a3ab622d87af8b346a2075f
2014-07-11Convert DLG_TEMPLATE_INFORMATION to .uiPalenik Mihály
Change-Id: I66469c17a46c1157b8e3801c0dc2b252c569a4bd Reviewed-on: https://gerrit.libreoffice.org/10213 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-11new loplugin: externalandnotdefinedNoel Grandin
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-10make label translatableAndras Timar
Change-Id: I1e7703489ad9c41efbd22863fc9dbe86afee5e3e
2014-07-10MD_DDE_LINKEDIT conversion to .uiSzymon Kłos
Change-Id: Id058400bad5a8b100ef5a07060ea1c5013c6e6d6 Reviewed-on: https://gerrit.libreoffice.org/10146 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-10Related: #i125226# disallow absolute and relative paths for DDE serversHerbert Dürr
(cherry picked from commit 6b64ada6e3a902ac4b44fe49476514d49138d4d4) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I127add375a127dbbd0eaf12a10884e2636f1a332
2014-07-10Related: #i125226# some macro preferences are directly...Herbert Dürr
applicable to DDE servers (cherry picked from commit 2c835e761e1e9ddb6794895e6f3538b918160dd1) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: Ic16b3df34ac1b003a8a5cabab15ea655d05bdd18 Related: #i125226# typo fix (cherry picked from commit 727ea069c6342e01a50c8b068ec302574b251cbd) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: I8db53b7e8529d05e660a2d69e669b44c9045712c
2014-07-10Related: #i125226# don't try to access known-bad DDE serversHerbert Dürr
(cherry picked from commit 88de6a59d9d7933b86fdcba733277aa4fbd5e132) Conflicts: sfx2/source/appl/impldde.cxx Change-Id: If4dcd49cfe15188d06e4e06cd8e58cdcc66ed5a4
2014-07-10coverity#1224981 Dereference null return valueCaolán McNamara
Change-Id: I1623f7d61e849a59c8f23f2df18827df4a9c25c0
2014-07-10coverity#1132691 Dereference null return valueCaolán McNamara
Change-Id: I0da2f6956cf7675cce0d7d82a0ec797b50542c7f
2014-07-09provide a route to get the default document targetsCaolán McNamara
Change-Id: Ia163d2a69b33c18e18f81f0f82855d1caa4c2c1a
2014-07-08use SimpleReferenceObject in svtools moduleNoel Grandin
to replace hand-rolled version Change-Id: I7a1048ff1ea335c3934fe7e91a09489a4d7aeb96
2014-07-07Resolves fdo#80477: duplicate key for Help button in Start CenterAdolfo Jayme Barrientos
Change-Id: If46baf8613c6202e84a985ad7e2ce658e1d42193 Reviewed-on: https://gerrit.libreoffice.org/10102 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-07DBG_ASSERT->assert when followed by dereferenceCaolán McNamara
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-06coverity#706056 Unintended sign extensionCaolán McNamara
Change-Id: Iafb36f8135893186710ae3a939e50596a372d065
2014-07-06coverity#706055 Unintended sign extensionCaolán McNamara
Change-Id: Ie917cfd5f41a6f5e58a4c629a6a5b800e2e0b42f