summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06Revert "Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule ↵Noel Grandin
flag"" This reverts commit abde31a2bc68302e1afafe1fcc3f5d85369010f8. Since my analysis was completely incorrect, and the bug was elsewhere.
2016-06-06tdf#89329: use rtl::Reference for pImpl in querystatusXisco Fauli
Change-Id: Iebc26867ebca7b61c0c54eb36bef035f4c9fc28a Reviewed-on: https://gerrit.libreoffice.org/25909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06loplugin:defaultparamsStephan Bergmann
Change-Id: Ib86c93a1858ef29323a1dd7b766497dde470b712
2016-06-06Improve Impress Template Selection DialogAkshay Deep
1. Hide controls: export, move, action menu, repository menu, Online Button 2. Checkbox to easily hide the dialog Change-Id: Id2899edb9ba280c9a714d09fa534f975600b05af Reviewed-on: https://gerrit.libreoffice.org/25913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-06Hitting return in search field should not open a templateAkshay Deep
Change-Id: I85d8096489debdbda1b3883f9335dd1218e567ec Reviewed-on: https://gerrit.libreoffice.org/25915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-06tdf#94131 Easier access to set a default template when saving a templateAkshay Deep
Change-Id: I2a3732a178f47ce49c77089a6e0865b609efd499 Reviewed-on: https://gerrit.libreoffice.org/25916 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-06Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flag"Noel Grandin
This reverts commit e319ef1171dab61fff2201f5c1470ca09894c395. Apparently, at some point, someone added a 'bool bDummy' param to SfxModule, but only updated 2 of the 5 callsites. Since we're passing in pointers here, at the other call sites, the bDummy param evaluated to 'true'.
2016-06-06Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flagMark Page
The SfxModuleArr_Impl is a static container of SfxModule, since this is private to the SfxModule class it does not require wrapping. The bDummy flag is unused, and complicates the class Change-Id: Ib03b215543a0c37d4edf20b2d0fc141a783e115e Reviewed-on: https://gerrit.libreoffice.org/25859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06loplugin:unusedvariablecheckTor Lillqvist
Change-Id: Icbf2138d3ac69fb0022134fb7ceab34935ccdc2a
2016-06-06loplugin:passstuffbyrefTor Lillqvist
Change-Id: Ie1cd7d63aaf2963137138def86cf5f4e141569b2
2016-06-06tdf#89329: use unique_ptr for pImpl in objshXisco Fauli
Change-Id: I572436af608821c3f6fad4deb66ebe2598a2df8a Reviewed-on: https://gerrit.libreoffice.org/25912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in prnmonXisco Fauli
Change-Id: I73fe5dc51f2352c5def618ad4011b436f15230a2 Reviewed-on: https://gerrit.libreoffice.org/25900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in viewfrmXisco Fauli
Change-Id: I330b3910e3e551ce43c2772fc63777de27901e0d Reviewed-on: https://gerrit.libreoffice.org/25910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in unoctitmXisco Fauli
Change-Id: I580c6c9999b35137ae883a84898b9d03fd7cb056 Reviewed-on: https://gerrit.libreoffice.org/25899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in appXisco Fauli
Change-Id: Ia4e53f6e2973c1dd439e22bd93329bfc6e21ba75 Reviewed-on: https://gerrit.libreoffice.org/25908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in mailmodelapiXisco Fauli
Change-Id: I12a6cb23b938f0d9151fb90437956ddb9d63d66f Reviewed-on: https://gerrit.libreoffice.org/25907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in viewshXisco Fauli
Change-Id: I8847b734c90adf2710f5481af41883eb5017c44a Reviewed-on: https://gerrit.libreoffice.org/25911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06Mark Default Templates in Template ManagerAkshay Deep
Change-Id: I1dff486605efce09e862d2924b24949601ae0f17 Reviewed-on: https://gerrit.libreoffice.org/25816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-06Convert DeactivePage return code to scoped enumNoel Grandin
Change-Id: Idd5372ad20fc6676864b31b3796f8b9bc0ad73dd Reviewed-on: https://gerrit.libreoffice.org/25918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove unused constants in HRC filesNoel Grandin
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1 Reviewed-on: https://gerrit.libreoffice.org/25817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f Reviewed-on: https://gerrit.libreoffice.org/25806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Template Manager: Ctrl + A to select all templatesAkshay Deep
Change-Id: I8398268752c78a30d5fc076d6f2b6249cbf89ec2 Reviewed-on: https://gerrit.libreoffice.org/25860 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-03tdf#100195 Enable Keyboard Navigation in Template Manager and Start CenterAkshay Deep
Change-Id: Ic5447a4af091a4e3dcab4d909fc6bfb9e559defb Reviewed-on: https://gerrit.libreoffice.org/25848 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-03Reduce duplicate code in Template ManagerAkshay Deep
Remove ViewBar and put contents in ActionBar Change-Id: I6551d36503f659f076ecf2b6766c6a14db771a1d Reviewed-on: https://gerrit.libreoffice.org/25833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-03Resolves: tdf#96008 crash when an extension with legacy decks is installedCaolán McNamara
ReadLegacyAddons modifies its vectors of maDecks and maPanels in this case, but a load of things have (c++) references contents of the original contents. Its such a rats nest that the easiest thing seems to be to make them vectors of shared_ptrs and hold DeckDescriptor and PanelDescriptor by shared_ptr and it all works out Change-Id: I3f628e12c7d5f4224d14d5e0769e450ce893fb54
2016-06-03OpenThenSwitchToDeck actually *toggles* deck visibilityCaolán McNamara
so rename it to that and add a OpenThenSwitchToDeck that actually does that, using the Toggle varient as the callback from the sidebar button which toggles the current deck on/off which retains the features of // tdf#67627 Clicking a second time on a Deck icon will close the Deck // tdf#88241 Summoning an undocked sidebar a second time should close sidebar but means that calls to OpenThenSwitchToDeck from e.g. slide layout don't auto close it if that deck is already open Change-Id: I3e3724626b93447a7ab6bc7032e9c6839dabcf55
2016-06-03Add an assert for a good measure.Jan Holesovsky
Change-Id: I764e5c96b60705f01db9525ee02fdf9959db5663
2016-06-03notebookbar: load ui for the start centerSzymon Kłos
Change-Id: Iaf0e46436524e081edb287efd4074becaf02a98f Reviewed-on: https://gerrit.libreoffice.org/25799 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-06-02loplugin:unusedfieldsNoel Grandin
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d Reviewed-on: https://gerrit.libreoffice.org/25724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Impress: Replace Presentation Wizard with Template ManagerAkshay Deep
Drop the Presentation wizard and show the Template Manager instead when starting Impress. 1. Opens a blank template with Template Manager. 2. If user selects a template, load it over the blank template. 3. SfxTemplateSelectionDlg for impress integration. Change-Id: Ia9c3cafc973e3741c6ea9f838018a35956f37f4a Reviewed-on: https://gerrit.libreoffice.org/25642 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-01tdf#89329: use unique_ptr for pImpl in msgpoolXisco Fauli
Change-Id: I97f7deab763b4da8e267e871cb78d0547711e777 Reviewed-on: https://gerrit.libreoffice.org/25751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01tdf#89329: use unique_ptr for pImpl in objfaceXisco Fauli
Change-Id: Ie4d84a7e9958c5291b3a9db7f9e7e019ff27cfbd Reviewed-on: https://gerrit.libreoffice.org/25750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01remove unused SID constants and associated codeNoel Grandin
found with a python script that looks like: process = subprocess.Popen( "git ls-files *.hrc | xargs grep -hE '#define +SID_' | cut -d ' ' -f 2 | sort -u", shell=True, stdout=subprocess.PIPE) for line in iter(process.stdout.readline, b''): line = line.strip() if line.startswith("//"): continue if line.startswith("sfx"): continue if len(line) < 10: continue i = subprocess.check_output("git grep -nP \"#define +" + line + " \"", shell=True) if i.count("#define") < 2: continue print line + " " + i Change-Id: I40eac2569c2b5b129d9459cb723a9d6f26d09264 Reviewed-on: https://gerrit.libreoffice.org/25715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert printer enums to scoped enumsNoel Grandin
Change-Id: Ic0f9d57181809b3fef3abbad462456fc2d5ced55 Reviewed-on: https://gerrit.libreoffice.org/25719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Remove inline renaming of title in ThumbnailViewItemAkshay Deep
Change-Id: I8fa2cae3390dd1576aab531bc826b8bb5985eaf9 Reviewed-on: https://gerrit.libreoffice.org/25645 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-31loplugin:unusedmethodsNoel Grandin
Change-Id: Ifeb818227a960cab8fd2e8e7352468efbfe1232c Reviewed-on: https://gerrit.libreoffice.org/25668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert PrinterSupport to scoped enumNoel Grandin
Change-Id: I2bde7261b8e8f31e6dd5a02cd4130156a04b8a7f Reviewed-on: https://gerrit.libreoffice.org/25657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Context Menu for templates and other fixes in Start CenterAkshay Deep
Removed: 1: Save Mode Variable. 2. maSelTemplates and maSelFolders 3. OpenRegionHdl 4. cmpSelectionItems Change-Id: I108da3a0ddfb4954a60fbb0df44eba0457326ca9 Reviewed-on: https://gerrit.libreoffice.org/25459 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-30Convert SelectionMode to scoped enumNoel Grandin
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert ApplicationEvent::Type to scoped enumNoel Grandin
Change-Id: Ie65951d5fd1e155e3d3b36d4725792fb95fb9a52 Reviewed-on: https://gerrit.libreoffice.org/25608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Resolves: Error when overwriting a template in Template Save As DialogAkshay Deep
After overwriting a template, overwritten template does not exist in the template manager because SfxDocumentTemplates is not updated.. Change-Id: I7e8605091de71b921f8dbed5ab2022ac292fe4b2 Reviewed-on: https://gerrit.libreoffice.org/25584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-30loplugin:unusedmethodsNoel Grandin
Change-Id: I08e9bb65b2530148b80c67f01d51e594fc698acb Reviewed-on: https://gerrit.libreoffice.org/25543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-29coverity#1362173 Dereference after null checkCaolán McNamara
Change-Id: I75c6f6fba947ac56c198afdef9b5ad078a76cdc5
2016-05-28Improve alignment and use of space in Document Properties dialogAdolfo Jayme Barrientos
Change-Id: Id4da1138931ef1601541b7108a4e90b3656a5ccb
2016-05-28lok: add uno command AssignLayoutHenry Castro
Change-Id: I959d1a57945a3b5aa3f2c273c4b885ed5f628f6e Reviewed-on: https://gerrit.libreoffice.org/25569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-05-27Template Manager: Option to rename categoryAkshay Deep
Change-Id: I7a9a0a42afbf5f8a293a130a0b84e72a54540579 Reviewed-on: https://gerrit.libreoffice.org/25539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-27Convert GRAPHIC to scoped enumNoel Grandin
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in sfxhelpXisco Fauli
Change-Id: I357b53f644384452c5dc2b74d3aba3d3dafae00e Reviewed-on: https://gerrit.libreoffice.org/25314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-27 13:20:28 +0000