summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2020-11-02use officecfg or MacroRecorderModeNoel Grandin
Change-Id: I2a8d4f401ddfd4368a7b50b4c3c8a72724f9afa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105154 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for IsPluginsEnabledNoel Grandin
Change-Id: Id80ba8a87af7f87b8232949b70804b1a021b23d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105147 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for UseSystemFileDialogNoel Grandin
Change-Id: I1419af229a67d6ebb1cf2c63757656beb3f512db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105142 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for Experimental flagNoel Grandin
move IsShowOutlineContentVisibilityButton out of header to avoid having to add extra include paths to all the unit test makefiles. Change-Id: I2763390e07cd85b8f09b6f2ad7702039daecb22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-30SidebarToolBox.hxx can be a private headerCaolán McNamara
Change-Id: I2367ef3912f3b84cdd0324b8e76598fc44a22874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-30pSysWindow is unusedCaolán McNamara
Change-Id: I36250d032af49f83f28be175a081dba344eac631 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-29tdf#137754 Crash in styles tree in sidebar in impressNoel Grandin
this is a timing bug - easier to hit on a slow machine, or with a debug build - it happens when mouse movement triggers a request for a tooltip in the tree, but the tree is in a transition state. Change-Id: Ibed7ffd01483b26f2debb1aa9cc99e23b38ba950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-29loadtemplatedialog better resizingandreas kainz
Change-Id: Idddd4abf9f94fee46b95e006400f85631ad66bc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104912 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-10-28tdf#137643 Revert "lock refreshing font data when loading a document"Caolán McNamara
from tdf#69060, to replace with an alternative solution This reverts commit 98d71c4e0847797a4ba9229a8e6d832a8a3d5e0f. and This reverts commit 64d8e5f8db70f4f913abb902b41f4cff8dd1cdad. Change-Id: I384e994b54aa1bfc735c6ab591b9b1410058451f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-28tdf#123476 filter: try to detect 0-byte files based on extensionMiklos Vajna
A 0-byte ("empty") pptx file is obviously junk input, so it's not surprising if the catch-all generic_Text filter is chosen to open it in Writer at the end. But we can do better: if we really get an empty file URL with an extension we can recognize, that we can fake the filter type / filter name, so the empty "presentation" opens in Impress, and also a re-save works as expected. This builds on top of commit 8a201be240b6d408d15166be7ffc576b9e123634 (fdo#68903 Import .tsv and .xls plain text files in Calc by default, 2013-10-27), just the new way works for all supported file extensions and also with filters which would not handle empty input (e.g. pptx refuses the import if the ZIP storage is broken). Change-Id: Ie01650a5eb6ca42c35e090133965467b621bb526 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104939 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-28Extend loplugin:elidestringvar to OStringStephan Bergmann
(In VisitVarDecl, filtering out AbstractConditionalOperator avoids an unhelpful > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:63:32: error: replace single use of literal 'rtl::OString' variable with a literal [loplugin:elidestringvar] > aXmlWriter.content(sPdfConformance); > ^~~~~~~~~~~~~~~ > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:52:21: note: literal 'rtl::OString' variable defined here [loplugin:elidestringvar] > OString sPdfConformance = (mnPDF_A == 1) ? "A" : "B"; > ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I7d0410f04827d79b4b526752917c37d33cad2671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-28convert some more long -> tools::LongNoel
grepping for stuff in template params this time Change-Id: Ia37bfd85480b3a72c3c465489581d56ad8dde851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-27tdf#116214 Allow for scientific notation in Custom PropertiesBartosz Kosiorek
To keep compatibility with OOXML format, it should be allowed to use Scientific Format in Custom Properties. The solution is backward compatible with standard numbers (it is still possible to write integer numbers and fractions). With that fix it is also possible to store very small and very big numbers in scientific notation. Change-Id: Ic788a6e3f4f748b905828f3d6c8c40dc7e46ba52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104569 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-27tdf#136555 apply window bg color for button boxesJan-Marek Glogowski
The default background color of the frame is APPBACKGROUND, which is matched to GetWorkspaceColor(). That color is visible in Writer as the default document workspace background. Originally I just saw the dark background of the button box in the start center, and thought the workspace color in Qt is wrong and changed it in the reverted commit, missing the change of the color around the Writer document. Now that the button boxes's background color isn't fixed via the "branding" setting, we also must react to changed style settings, so we override the DataChanged function. This also reverts commit e0c72e31c1d455c26110c35e8780d420e17cdea6. Regressed-by: a927e0964ba0442d53fffb22c577e54bcf183ed7 Change-Id: I62396355054523baef1197a8a8af61c2f0d29ef3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104740 Tested-by: Jenkins Reviewed-by: Thorsten Wagner <thorsten.wagner.4@gmail.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-10-26switching long to a 64-bit type on 64-bit windowsNoel
(*) create a rewriting plugin to do most of the work, heavily based on the fakebool plugin (*) but there are still a number of "long"s in the codebase that will need to be done by hand (*) the plugin needs lots of handholding, due to needing to add #include and update macros Change-Id: I8184d7000ca482c0469514bb73178c3a1123b1e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104203 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-23-Werror,-Wunused-private-fieldStephan Bergmann
...since 5a342bde16fb46c895eec302af73d7836226eccf "weld backing window" Change-Id: I1a34c70fa0357a05c8e864106261868e04171a87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104713 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-22set all .ui min require version of gtk to 3.20Caolán McNamara
and update the version mentioned in our min req in the readme.xrm follow up to commit 0c9ccc7dbf6deb4d012e0d1e6eb934e54e0f19bc Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Oct 2 21:21:45 2020 +0100 raise min version of gtk to 3.20.0 Change-Id: Ibae55c97e1ee577f4b7435d124cda6a21005ad0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22if nothing selected, don't select something on gaining focusCaolán McNamara
which is how this traditionally worked before commit fd2ea8e03510c6a99ec8be6228b7422f6c5b182b Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Aug 19 14:59:33 2020 +0100 weld OApplicationSwapWindow Change-Id: Ib844f903bf160eb7a58c2860e41b0b7acf4aa783 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104688 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22rename SfxTemplateLocalView back to TemplateLocalViewCaolán McNamara
Change-Id: Ib5221799604886120f498313ffd37c0a80987bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22rename SfxThumbnailView back to ThumbnailViewCaolán McNamara
Change-Id: I07251905c3bf5bccb23c684d47ed34e79dde55fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104645 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22drop newly unused ThumbnailViewCaolán McNamara
Change-Id: I6c025120abf7f7dfbc1c06ad47e80e1d23ba731d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22drop newly unused TemplateLocalViewCaolán McNamara
Change-Id: I8c7fb0fe21df55056eba4a0672cff1689f0f4aea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22weld backing windowCaolán McNamara
Change-Id: I250e46d3f1d558567bddbd4f0330470222e8fd4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22Resolves tdf#137671 - Extensions on Impres start-upHeiko Tietze
Change-Id: Id84b97d7f99f142b94ef1304bf202d1026ff4120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104651 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-22long->tools::Long in sfx2Noel
Change-Id: Ie1283e353598cd05e5a2933814f618649b89de01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-21mirror changes of ThumbnailView to SfxThumbnailViewCaolán McNamara
in advance of replacement commit 6cd1591fb8b0a550067c37cf720708c6a5630b6d Author: Roman Kuznetsov <antilibreoffice@gmail.com> Date: Sun Apr 26 20:49:22 2020 +0100 tdf#132441 thumb scrolling in Start Center should be more accuracy Change-Id: I9e267adcbed9c4ccd7ee8632b0c921a4809737d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-21new tools::Degree10 strong typedefNoel Grandin
partly to flush some use of "long" out the codebase, but also to make it obvious which units are being used for angle values. Change-Id: I1dc22494ca42c4677a63f685d5903f2b89886dc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104548 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20remove motif from startcenterCaolán McNamara
the icon doesn't exist in the normal case since commit 60413c9800c27f53c1108015b50754b065bc98c6 Date: Wed Apr 18 12:22:07 2018 +0200 Replace Galaxy icon theme by Colibre through a theoretical route via installing a gallery icon extension still exists. Use a different existing icon for the vcldemo Change-Id: I81ab87742eaf2720877782a4425ef83719ee6ed9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104556 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-18we can use Desktop::queryDispatch and avoid using getActiveFrameCaolán McNamara
Change-Id: I5582b4d588e1e1b47cd8aef78e6e73b2dece9d82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-17consistently use gnFineness scaling factorCaolán McNamara
Change-Id: I34b32987cc16200a163088779df41a65320deb1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104468 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-17tdf#133771: remove encryption data during SaveAsVasily Melenchuk
If document was password protected but during SaveAs it wasn't selected to use a password we should remove EcnryptionData. But we should not do this unconditionally: in general case we should try to keep all encryption metadata. Change-Id: Id91a88790deccd7377fb5d394b36395d13748c31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104454 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-10-17sfx2: use the fastparser API when possibleNoel Grandin
part of the process of making SvXMLImport fastparser-only Change-Id: Ib5acae303483eb86338cb39dd97a357ff90b1870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104453 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-16unused forward declarationCaolán McNamara
Change-Id: I565f4d9627dc906db816864b5a6fc5e47ffd5ac9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104431 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Resolves tdf#137477 - Access templates via tight extensionsHeiko Tietze
UI modified and code added Change-Id: I1231bb03bc96295b9a7e6cdb85162f7f8ea3add0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104285 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-13static_cast after dynamic_castNoel
Change-Id: If93fa126f10393a250cc1ad64bee28e84c42a6b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104226 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-12Resolves tdf#137187 - More dictionaries via extensions dialogHeiko Tietze
UNO command and linkbutton interaction replaced with the internal dialog DICT_REPO_URL removed, README adjusted Change-Id: I401737b538da229ac0d432007e7564105672ff40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103769 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-12render document thumbnail directly to bitmap, without metafileLuboš Luňák
I don't see the point of taking the detour via GDIMetaFile and then immediately drawing using it to a bitmap. Simply draw directly to a bitmap. Especially given that when drawing to a metafile some fast cases are skipped, e.g. DrawTransformedBitmapEx() avoids DrawTransformBitmapExDirect() and resorts to using the slow BitmapEx::getTransformed(). E.g. with tdf#136223. this makes SfxPickListImpl::AddDocumentToPickList() go from 30% to 13% of the total document loading time. Change-Id: Ib1643eddfc2b75a3d7be60138fb5226352805826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104114 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-08we only should have one has_default==True in these dialogsCaolán McNamara
undo the part of 3d056824c687df567c05bf31554fa40ea2baef18 to restore the part of c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. where the code does no special show/hide of buttons Change-Id: Iacc37e5250468f2b626c3212c30bdd254966fdb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104067 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07Resolves tdf#117463 - Dialog to show UI optionsHeiko Tietze
* New dialog to pick and apply one of the UI variants * Tip-of-the-Day enhanced to execute UNO commands in order to advertise the UI chooser on first start Change-Id: I5e5c4a8e0fb11d11bafc99cc37b7ec244a993781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99957 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-07ui files: fix some capitalisation issuesNoel
Change-Id: Id2efb6e5f1c115cb31a6afd3f988fe156c5ad56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07Revert "lint-ui: check that we only have one has_default==True"Noel Grandin
This reverts commit c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. Reason for revert: Some of the code manipulates visibility programmatically, and it is quite fine to has more than one has_default if only one of them is visible at a time. Change-Id: Ia4f565c7d21d232d3038c3489952782c8e2a7be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103977 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07tdf#136555 drop custom start center button colorsJan-Marek Glogowski
Custom button text or background colors don't play nice with any complex theming. Maybe we should still allow a custom background color for the button bar, but probably that attempt is also futile and clashes with theming easily. As long as the botton bar uses themable push-buttons as a control custom coloring will break at some point, as these buttons can have too many states, which curently depend on the theme. There is no way for LO to know, if a roll-over button will return with a different backround or just some changed border from a themed paint call. So this reverts the button part of tdf#90452. It doesn't affect the preview area, as that is a custom widget, which doesn't use any theming, but has it's own setting - for better or worse. Change-Id: I1ef17a50d15a5876a11bce89ae3f764aa91f66bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103041 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-10-06move set_user_managed_scrolling to an initial weld argumentCaolán McNamara
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06loplugin:const& make some params and methods constNoel
Change-Id: I2973128a9c6c53187e1da400d1a5df763d515596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-05lint-ui: check that we only have one has_default==TrueNoel
Change-Id: Ic61e14c3b98a85a5f05b448db9805ac296c041ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-05lok: sidebar: avoid deactivation when the sidebar is paintingHenry Castro
When two views (SfxViewFrame) get activated and deactivated frequently when one view grab the focus and lose focus (respectively), in multiple user this is not true, both users have the view active at the same time. The patch removes the overhead when painting a sidebar window to avoid unnecessary deactivation. Change-Id: Ica5837c9f2eda5db1bee69ec2297e54c4845d467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103263 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit 0a8be32f6130a4b84cd3f9ca70f6109dd78bf434) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103441 Tested-by: Jenkins
2020-10-05Disable WhatsNew infobar with standard methodHeiko Tietze
WhatsNew IB uses the Newly introduced Enabled property now IsReadOnly got removed Follow-up to 3fb1477de164bba260e3e9a39afcb3f67c78fb5e Change-Id: I3989acf835ee219575106bc6c7d5edac4e6accd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103841 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-03use more TOOLS_WARN_EXCEPTIONNoel
Change-Id: I8b5cde993c13e0b7c8c830b1ff698933a6b7cfd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-02sfx2: downgrade a warning in SfxViewFrame::ChildWindowState() to infoMiklos Vajna
It happens every time on startup, so it's not that useful. Change-Id: I570b8892847f2da3dd5b52e150eb7a2802bb407b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103828 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-01tdf#128174: Master password dialog misplacedAyhan Yalçınsoy
Change-Id: Ib8834c58e6c3af88de3eb7b450076c79fb5edda5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103745 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2025-01-30 20:41:32 +0000