summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-06-23fdo#76203 - use consistent titlecase for UI title labelsJoren De Cuyper
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9 Reviewed-on: https://gerrit.libreoffice.org/9858 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-20Missing null checkStephan Bergmann
As Kendy found out, "In Writer: Enable the drawing functions [view -> toolbars -> drawing], choose 'Line Callout 1' among the presets Callouts [to the left from the stars], and attempt to click and drag in the document to insert it" triggers assert in SvRef<T>::operator* introduced in 160ae9889e4d16217a7cca7d930f776f5a645ec8 "Catch illegal null pointer dereferences early." Given how most places in sfx2/source/doc/sfxbasemodel.cxx already check for null m_pObjectShell, looks like this had just been missing here, and the SfxDocInfoListener_Impl's modified has probably never been called, so it went unnoticed that its m_rShell was a "null reference." Change-Id: I6b6dad831938d5fa89340895b98797686b60c5cc
2014-06-19fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19GetFileTimeValue can produce a "null" DateTimeStephan Bergmann
Change-Id: I96bf1aa2d889c4d0925d073d1d7b4be47c23b3ac
2014-06-19Prevent null pointer dereferenceStephan Bergmann
Change-Id: Ia197152f6ece37dd2dd2ce1b41c1dfd1a985781c
2014-06-18coverity#1028261 Uncaught exceptionCaolán McNamara
Change-Id: I7dd08c182657084ffa635e1960f4d0def6d7a6bb
2014-06-18Use ImplInheritanceHelperStephan Bergmann
Change-Id: I259bf6012684e393765cfd73e813bcf2875abd5f
2014-06-17coverity#706054 Unintended sign extensionCaolán McNamara
Change-Id: I69df0aa6091263cbb6e500a5015915c6678764ec
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: Ie5e9e21f4c592c58094afc954f1de54512719fd5
2014-06-11Change SfxTabPage ctor SfxItemSet param from ref to pointerStephan Bergmann
...and also corresponding param of CreateTabPage function type and corresponding Craete functions. There were some call sites that passed undefined "null pointer references" and SfxTabPage internally uses a pointer member pSet that is checked for null anyway. Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11Change SfxTabPage::Reset param from ref to pointerStephan Bergmann
...there was a call site that passed undefined "null pointer reference" (apparently in a case where the passed argument was actually unused) Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-10Change SfxTabPage::FillItemSet param from ref to pointerStephan Bergmann
...there were a number of call sites that passed undefined "null pointer references" (apparently in cases where the passed argument was actually unused) Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-10fdo#79676: Fix the Java UNO API test with regard to chart tests.Kohei Yoshida
The Java tests rely on the "undocumented" behavior that, when loading an empty chart document, the chart automaticallly created a "default chart" which is a column chart with many of its properties filled. Unfortunately this behavior caused ugly side effects when loading documents with charts via flat ODF filter. I believe fixing the test this way is the right fix. Change-Id: If3e6c8979da9d0731346ebeedc23c0d3363e83fd
2014-06-10-Werror,-Wtautological-undefined-compareStephan Bergmann
Change-Id: I2e05bcf91c534d2aed6e296fe03d367c4c1b7212
2014-06-10coverity#441139 Explicit null dereferencedCaolán McNamara
Change-Id: I015125fca5cd3e4c1ac2407c0449fe641991f8f6
2014-06-10coverity#706615 Uncaught exceptionCaolán McNamara
and hopefully a boat load more Change-Id: I31cd4e530bd38dda845478a36d8216b7b3f9d7fd
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-06html export: More standard time specification in <meta/>.Jan Holesovsky
Change-Id: I1a62d12531029cc36fb8aeabecb9d92a8af837f7
2014-06-06html export: Close the <meta> tags.Jan Holesovsky
Change-Id: Icca58dd1531f2442fe5878ed9524a3611c0601ea
2014-06-06coverity#704789 Dereference after null checkCaolán McNamara
Change-Id: Iac238d68502cab137ce1530bffca4909cd9ea956
2014-06-05coverity#1000658 Missing break in switch, assuming its intentionalCaolán McNamara
Change-Id: Id208942e98c8b8fc685aa77c3c11468ed2af832d
2014-06-04coverity#982646 Missing break in switchCaolán McNamara
Change-Id: I83cdafe9a27f026e2b6c8e9153de9e8270304686
2014-06-04fdo#79597 Password UI: correct typo for 1 characterLaurent Balland-Poirier
Display a different string in case of 1 character for minimum length Change-Id: Iba2fbbb7d4101718def7c79ce5354debf5d97041 Reviewed-on: https://gerrit.libreoffice.org/9631 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-02coverity#1219793 Uncaught exceptionCaolán McNamara
and hopefully a gadzillion others Change-Id: I853e997aa6510ed99c1af39eecfd80dba2d5c2a9
2014-05-30coverity#1202815 Missing break in switchCaolán McNamara
Change-Id: Ic18a984c4c05367ac1a863a27620c83391d5bac5
2014-05-30Resolves: fdo#79360 impress hangs on using sidebar new styleCaolán McNamara
because those styles are "pseudo-styles" and a new one cannot be added. The possibility is supposed to be disabled, and it is disabled in the floating stylelist. The old code assumes there can only be one of these stylelists and when a stylelist queries if the "new" should be disabled the callback asks the stylelist what family is selected, but only asks the floating one. So, floating closed, sidebar open, the new is not disabled. Implement the ancient TODO now that we have to. Instead of asking the stylelist what family is selected, query the frame for what is the current SID_STYLE_FAMILY as set by whatever is the active stylelist. What's disturbing is the SID_STYLE_FAMILY values are not SfxStyleFamily, but indexes that have to be mapped to SfxStyleFamily. I bet there are a pile of bugs around that, especially with little islands of different conversion codesites Change-Id: I85c8032d7c26ae6eea245685748f89b2a860e767
2014-05-29convert from NId to FamilyId instead of FamilyId to NIdCaolán McNamara
should be equivalent for comparison purposes Change-Id: I45ed21ee3b45425b5e1ca39e0774c6d34cd2ee76
2014-05-29remove unused virtual method, slim this down initiallyCaolán McNamara
Change-Id: Ie4a912cc3c144c47a4bb59551ebb1c68f302569e
2014-05-29Related: fdo#79392 std::out_or_range -> terminateCaolán McNamara
Change-Id: I0aada90e9ea4e9fc92fd9c365aa9c7171cb10a55
2014-05-29the dubious SfxModelSubComponent and friends aren't used outside sfx2Caolán McNamara
so move out of the globals headers and drop their public visibility markup Change-Id: Ie0a852c962a9d05488022397e83152d1c73cfa29
2014-05-29valgrind: memleak when sidebar open in writer on closeCaolán McNamara
==3768== 512 bytes in 1 blocks are possibly lost in loss record 25,532 of 28,010 ==3768== at 0x4A06965: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==3768== by 0xB52FA41: __gnu_cxx::new_allocator<bool>::allocate(unsigned long, void const*) (new_allocator.h:104) ==3768== by 0xB52EC00: std::__cxx1998::_Deque_base<bool, std::allocator<bool> >::_M_allocate_node() (stl_deque.h:533) ==3768== by 0xB52DE4E: std::__cxx1998::_Deque_base<bool, std::allocator<bool> >::_M_create_nodes(bool**, bool**) (stl_deque.h:627) ==3768== by 0xB52C624: std::__cxx1998::_Deque_base<bool, std::allocator<bool> >::_M_initialize_map(unsigned long) (stl_deque.h:601) ==3768== by 0xB52ACA0: std::__cxx1998::_Deque_base<bool, std::allocator<bool> >::_Deque_base(std::allocator<bool> const&, unsigned long) (stl_deque.h:461) ==3768== by 0xB5296D3: std::__cxx1998::deque<bool, std::allocator<bool> >::deque(std::allocator<bool> const&) (stl_deque.h:791) ==3768== by 0xB52840E: std::__debug::deque<bool, std::allocator<bool> >::deque(std::allocator<bool> const&) (deque:73) ==3768== by 0xB52786B: framework::UndoManagerHelper_Impl::UndoManagerHelper_Impl(framework::IUndoManagerImplementation&) (undomanagerhelper.cxx:221) ==3768== by 0xB525882: framework::UndoManagerHelper::UndoManagerHelper(framework::IUndoManagerImplementation&) (undomanagerhelper.cxx:879) ==3768== by 0x6872683: sfx2::DocumentUndoManager_Impl::DocumentUndoManager_Impl(sfx2::DocumentUndoManager&) (docundomanager.cxx:88) ==3768== by 0x6870FB6: sfx2::DocumentUndoManager::DocumentUndoManager(SfxBaseModel&) (docundomanager.cxx:227) ==3768== by 0x687A272: SfxBaseModel::getUndoManager() (sfxbasemodel.cxx:1677) ==3768== by 0x260E562A: (anonymous namespace)::getUndoManager(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (PagePropertyPanel.cxx:74) ==3768== by 0x260E6C60: sw::sidebar::PagePropertyPanel::PagePropertyPanel(Window*, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, SfxBindings*) (PagePropertyPanel.cxx:189) ==3768== by 0x260E593C: sw::sidebar::PagePropertyPanel::Create(Window*, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, SfxBindings*) (PagePropertyPanel.cxx:101) The SfxBaseModel creates the DocumentUndoManager on demand at sfx2/source/doc/sfxbasemodel.cxx:1685 m_pDocumentUndoManager is a rtl::Reference but debugging into the acquire/release I see that the DocumentUndoManager::acquire/DocumentUndoManager::release forward to those of SfxModelSubComponent which forward them to its rModel without doing anything else, so the implementations of DocumentUndoManager::acquire/DocumentUndoManager::release don't actually do anything directly to the DocumentUndoManager itself so there is nothing that will really release it. Either the rModel needs to explicitly destroy it somehow, given that the acquire/release delegate responsibility to it, or the whole thing is addled. I rather feel it's addled, so implement as a normal WeakImplHelper1, but cowardly in addition also keep acquire/release on the rModel. Change-Id: Ib52544a9276fd8d9d489ad6b6afda12498cc39fa
2014-05-29pTemplateCommon is never set, so always NULLCaolán McNamara
Change-Id: I2311b33034c281cba66d7cce80a6556e27b2b322
2014-05-29remove unnecessary NULL parameter passed to UNO ExceptionNoel Grandin
.. now that we have a default value for that parameter Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-28update_pchThomas Arnhold
Change-Id: I5316693452427ed76a7738b090de023b110caa40
2014-05-28Related: fdo#79142 make SetName default to ReindexingCaolán McNamara
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5
2014-05-28Resolves: fdo#79142 When Creating Styles - The 2nd One Always Replaces the 1stCaolán McNamara
regression from 0c17ccc493d0c7a80f37600dae76a09a119bef78 I think it might actually make more sense for SetName to always Reindex and have another SetNameNoReindex for selective use where its known safe to get away with it Change-Id: I6bf7e1f45130f741954ab525b838f3ac5ff61a89
2014-05-27css already means ::com::sun::starThomas Arnhold
Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
2014-05-27Resolves: fdo#79275 File Properties dialog’s layout is subparCaolán McNamara
Change-Id: I594d93c0630528841a1f243e6b6e9eda67b6138d
2014-05-27cid#707147 Uncaught exceptionNoel Grandin
Change-Id: Ie49e70c3fa7704727129e613814aaf559d1a7fb6
2014-05-27remove more unnecessary use of OUString constructorNoel Grandin
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
2014-05-27remove unnecessary use of Reference constructor in throwNoel Grandin
Convert code like this: throw IOException("xx", Reference< XInterface >(static_cast<OWeakObject*>(this)) ); to this: throw IOException("xx", static_cast<OWeakObject*>(this) ); Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-26coverity#704795 Unchecked dynamic_castCaolán McNamara
Change-Id: I8526944acfb319f3e8e1e1927e94ea44eb59f5d6
2014-05-26coverity#705232 Missing break in switchCaolán McNamara
Change-Id: Ifa6de9e9d1138e4962cd8cf0716fd6e06894c34f
2014-05-25Resolves: fdo#79161 sidebar crash on deactivatingCaolán McNamara
Change-Id: I0d559bd8c16243fdc398f6bff0aa915a83a29dff
2014-05-23Correct #endif placement (avoid linking error for TiledLibreOffice)Tor Lillqvist
Change-Id: I37577456740b4dd255df22047ce7740bd1e43ace
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23Avoid including <config_features.h> in <sfx2/objsh.hxx>Tor Lillqvist
Change-Id: I36969367e47c1ed1368ed46638ff9e7768e8a008
2014-05-23coverity#1215382 Uncaught exceptionCaolán McNamara
and hopefully a gadzillion more, but I've said that before :-( Change-Id: I2e36485ae2ce831fdf250464b254d42f5bc55fe3
generated by cgit (git 2.34.1) at 2024-12-30 21:03:59 +0000