summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2018-01-30tdf#115090 prevent SfxBaseModel destruction during notificationsThorsten Behrens
Additionally ensure refcount stays above sea level while notifying clients (who might dispose their own references, causing our own refcount to drop to zero). Otherwise, 2nd loop in postEvent_Impl() might already operate on freed mem. Change-Id: Ie06de9ea33f7e2e334e0ef39d13c50009261791e Reviewed-on: https://gerrit.libreoffice.org/48871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-29loplugin:useuniqueptr in SfxMedium_ImplNoel Grandin
Change-Id: Iccd03ce2af58c4c3c90add9fc08c27502b5fface Reviewed-on: https://gerrit.libreoffice.org/48742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in SfxChildWindowNoel Grandin
Change-Id: I6c9db4cd4f46790295f37c620e2efea4f61870bf Reviewed-on: https://gerrit.libreoffice.org/48741 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in ModelData_ImplNoel Grandin
Change-Id: I66866ed1698fafe59ba31f99df09fb792da410e3 Reviewed-on: https://gerrit.libreoffice.org/48702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in SfxShell_ImplNoel Grandin
Change-Id: If59142c2d55da5f3ccf2de101dbd9f18a8bda84c Reviewed-on: https://gerrit.libreoffice.org/48701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-28loplugin:useuniqueptr in SfxRequestNoel Grandin
Change-Id: Id2b2a1ac9803b0caa2d28163160d85be5253dd9e Reviewed-on: https://gerrit.libreoffice.org/48699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-27tdf#115090 keep internal BaseModel alive long enoughThorsten Behrens
There's reams of code already preventing a close during save (SfxSaveGuard), but this looks equally effective. Avoids SfxBaseModel::dispose() pulling the rug under us, when SfxBaseModel::postEvent_Impl() wants to access parts of the interface containers during notification. Change-Id: Iace1f9922c47a97ab2e798b577c6aec8a729da48 Reviewed-on: https://gerrit.libreoffice.org/48709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-27Fix typosAndrea Gelmini
Change-Id: I914ac70f39028caebafb874e871f11017fda7795 Reviewed-on: https://gerrit.libreoffice.org/48682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-25lokdialog: Fix incorrect dialog sizes sent to clientPranav Kant
GetSizePixel triggers pending resize handler and gives more correct sizes than GetOptimalSize(). Some of the dialog with inconsistencies in sizes like EditStyle, Manage Changes, etc. are fixed with this patch. Change-Id: I0661b7d2e98233edf0cd2c9c525b271d0724da08
2018-01-25lok: Send the enabled / disabled state of .uno:TransformDialog.Jan Holesovsky
Change-Id: If2d8e0da6c289deb65dc8a6b38a21dfd5bbfc1bd Reviewed-on: https://gerrit.libreoffice.org/48534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-24Fix typosAndrea Gelmini
Change-Id: I359c5aff8c90359783588d189de4e5b94224fa9c Reviewed-on: https://gerrit.libreoffice.org/48232 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-24loplugin:useuniqueptr in SfxCommonTemplateDialog_ImplNoel Grandin
Change-Id: I484cb863c054c71cb22b30d108c95692213c8451 Reviewed-on: https://gerrit.libreoffice.org/48407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:useuniqueptr in FileDialogHelper_ImplNoel Grandin
Change-Id: I91f831be99284b61385cee42dc59efd0cf7f45ba Reviewed-on: https://gerrit.libreoffice.org/48406 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:unused-returns in drawinglayer..svxNoel Grandin
Change-Id: I033a78cc7fe7d8e5086f1c855c4aa371cc98dc7c Reviewed-on: https://gerrit.libreoffice.org/48400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:constparamsNoel Grandin
Change-Id: I7c695073d9a9d3b7a641d6eb9fe01a47d8c3a504 Reviewed-on: https://gerrit.libreoffice.org/48392 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:useuniqueptr in GroupData_ImplNoel Grandin
Change-Id: Icddaf78a58b74338ac763c12c8ac06f464986cac Reviewed-on: https://gerrit.libreoffice.org/48371 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:unused-returns in vclNoel Grandin
Change-Id: I507320900a47f604d17ed7d402d531a7cbdf744e Reviewed-on: https://gerrit.libreoffice.org/48331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23Remove dead code from SfxFilter ctorStephan Bergmann
In fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import" the code was: +void SfxFilter::InitMembers_Impl() +{ + String aExts = GetWildcard()(); + String aShort, aLong; + String aRet; + sal_uInt16 nMaxLength = +#if defined( WIN ) || defined( OS2 ) + 3 +#else + USHRT_MAX +#endif + ; + String aTest; + sal_uInt16 nPos = 0; + while( ( aRet = aExts.GetToken( nPos++, ';' ) ).Len() ) + { + aTest = aRet; + aTest.SearchAndReplace( DEFINE_CONST_UNICODE( "*." ), String() ); + if( aTest.Len() <= nMaxLength ) + { + if( aShort.Len() ) aShort += ';'; + aShort += aRet; + } + else + { + if( aLong.Len() ) aLong += ';'; + aLong += aRet; + } + } + if( aShort.Len() && aLong.Len() ) + { + aShort += ';'; + aShort += aLong; + } + aWildCard = aShort; + + nVersion = SOFFICE_FILEFORMAT_NOW; + bPlugDataSearched = 0; + pPlugData = 0; + + aName = pContainer->GetName(); + aName += DEFINE_CONST_UNICODE( ": " ); + aName += aFilterName; + + aUIName = aFilterName; +} where USHRT_MAX apparently effectively meant "arbitrarily large". But when b7c596059dfa9a808f587af9f30b01489e75fb0e "INTEGRATION: CWS sfxcleanup" removed the WIN/OS2 special case it didn't remove all the other code that was now effectively useless. Change-Id: I883759f13e0267a189ad176c2ffcc1c78680b0a5 Reviewed-on: https://gerrit.libreoffice.org/48336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23Translate German SAL_WARN messageStephan Bergmann
Change-Id: Ica04ee68f18ec6c1e0cd59a0f35ab35ce3c05745 Reviewed-on: https://gerrit.libreoffice.org/48374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23loplugin:useuniqueptr in CntStaticPoolDefaults_ImplNoel Grandin
Change-Id: I8d7766d473499b4d154debc1aafaf03359078aa3 Reviewed-on: https://gerrit.libreoffice.org/48372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23loplugin:useuniqueptr in SfxDocTplService_ImplNoel Grandin
Change-Id: Iacda2920f632a6f21d852d843e97086a23479bbd Reviewed-on: https://gerrit.libreoffice.org/48370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23USHRT_MAX -> SAL_MAX_UINT16 in IndexBitSetStephan Bergmann
...which is based on sal_uInt16 instead of USHORT since c5b727675460581258489d3bd569a61184ad69cd "removetooltypes: #i112600# remove tooltypes" Change-Id: I6b937961a69cc904226b05fe9679ac62e2f01c0a Reviewed-on: https://gerrit.libreoffice.org/48333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23loplugin:useuniqueptr in HelpInterceptor_ImplNoel Grandin
Change-Id: I75c1ca2d6b0e03604bb6c96d2613261a1a05b988 Reviewed-on: https://gerrit.libreoffice.org/48297 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23loplugin:useuniqueptr in SfxItemDisruptor_ImplNoel Grandin
Change-Id: Ie85c1a8fd699f68ffcc8853be4bf8a86cfec06e7 Reviewed-on: https://gerrit.libreoffice.org/48295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-20loplugin:useuniqueptr in SvBaseLinkNoel Grandin
Change-Id: Iaa133fa7f3b4bc4adea1c1568015327b1694161b Reviewed-on: https://gerrit.libreoffice.org/48169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19loplugin:useuniqueptr in SvDDEObjectNoel Grandin
Change-Id: Ia7f98a84bd42289ef0673b52e5e74a6a24554402 Reviewed-on: https://gerrit.libreoffice.org/48168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19new loplugin:emptyifNoel Grandin
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42 Reviewed-on: https://gerrit.libreoffice.org/48128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19Call new helpOlivier Hallot
With contributions from Kendy Call new help * If LibreOffice online, call help online * If no local help, call help online else call offline html help if offline help return false, call old-help * left tempfile to be deleted when LO exits (ESC) * hasHelp function now check if the right locale exist Change-Id: I14893e8ba4998773706b9cf8164636475d1f2356 Fix HIDs with a ':' inside Change-Id: I17b7c96b6b0003e8d933131b7b251f3191389a0f Call new help directly, fix locale issue Avoid passing by a html file that is necessary only in the online case. Fix path location of help/ folder Implement fall back in languages locale -> lang -> en-US. If none of the theree above, call online help with locale. fix scope Change-Id: If92673594c92e0d5a6064bc0e0bb4b66a52730ec Reviewed-on: https://gerrit.libreoffice.org/47748 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-19loplugin:useuniqueptr in SfxAppData_ImplNoel Grandin
Change-Id: Ic8b02f5c6582a992b64f31435332ee37d826ad48
2018-01-18sw lokit: add page syles to header & footerHenry Castro
Change-Id: I3c0b0603d1e03f1cc19af4324dd2b909320d9d4a Reviewed-on: https://gerrit.libreoffice.org/47687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-01-18No need for an 'if' when the body is empty.Jan Holesovsky
Change-Id: I69e3f2145f95424e7c524127492fd7f8a03ed3ca Reviewed-on: https://gerrit.libreoffice.org/48091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18lokdialog: No modal mode in LOKPranav Kant
... otherwise the cursor in the document goes invisible as soon as the dialog is launched. Change-Id: I77bc30879550b354e1a9593db3c2db7ad3c68193 Reviewed-on: https://gerrit.libreoffice.org/48126 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-18lok dialog: enable MessageDialog tunnelingHenry Castro
Change-Id: I05b270a19e29c5ed3a2482fd8163e61e66bfdf74 Reviewed-on: https://gerrit.libreoffice.org/47772 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-18sfx2 store: create temp files next to local files (storage case)Miklos Vajna
This is similar to commit 5259ab8104cfba60c40748ed0cd59d93df038c5b (sfx2 store: create temp files next to local files, 2018-01-08), except there only the stream case was handled (e.g. sw HTML export), while this is the storage case (e.g. ODT export). Change-Id: I88d78aa0f09e9fdfdd27cd0fad1a2633ff54d576 Reviewed-on: https://gerrit.libreoffice.org/48071 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-17coverity#1427631 sfx2: fix silly infinite loopMichael Stahl
(regression from 9ef1734f03a008545a01fd394dd0e979bb230a0f) Change-Id: I31dc5e7aff80f647d8417c290f8f34c43e54486d
2018-01-17tdf#60937 Open Start Center on Quickstarter left-clickAbhishek Shrivastava
This patch modifies the click actions on quickstarter on Windows. Earlier a left double click opened up Template Manager, which wasn't user friendly. Now on single left click on quickstarter icon it opens up Start Center Change-Id: I23e56d5d1bb3f4bfc060149dec60de30ae1207cd Reviewed-on: https://gerrit.libreoffice.org/48026 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-17loplugin:unnecessaryparen extend to delete statementsNoel Grandin
Change-Id: Ic4383ea948876a26f791f0e5b0110cef978a26e1 Reviewed-on: https://gerrit.libreoffice.org/48027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-16tdf#113755 - avoid null ptr de-reference during shutdown.Michael Meeks
Why the PostUserEvent's that should do the XTDataObject async destroy are not completed by here, is rather unclear; but - de-referencing NULL is not a great thing to do during shutdown. http://crashreport.libreoffice.org/stats/crash_details/a7d8fd19-0512-4292-b3a0-140dcff204c8 Change-Id: I3f294379f07f4cfc0106c1b5fc5e705c41e78b03 Reviewed-on: https://gerrit.libreoffice.org/48007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-01-16use more ScopedVclPtr to avoid missing disposeNoel Grandin
follow on to commit 315be3a276b01e88c794da1dbc6252a8b803d269 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 12 10:48:59 2018 +0000 VclPtr, missing dispose Change-Id: Idfa4709f10928ef6d53ada93db0f5452e5d5c4eb Reviewed-on: https://gerrit.libreoffice.org/47982 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-16Fix typosAndrea Gelmini
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16sfx2 store: handle NoFileSync for Save (not SaveAs)Miklos Vajna
The code-path in SfxMedium and lower layers is the same, but not in SfxObjectShell. Change-Id: I85542d17cd6b3c2a0d257f5ff196e6504a194e51 Reviewed-on: https://gerrit.libreoffice.org/47903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-15lokdialog: Allow closing the Format Cell dialogs in any order.Jan Holesovsky
Includes also lots of infrastructural changes, making the conversion of the rest of the dialogs much easier. StartExecuteAsync should be used in-place of StartExecuteModal and the latter removed from the code-base incrementally. More common code from Dialog::Execute should be moved to ImplStartExecuteModal in a next step, as this is used more widely. Change-Id: Idb2c1ec790e38f582438471a0419a56cdcf1439d Reviewed-on: https://gerrit.libreoffice.org/47722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-15More loplugin:cstylecast: sfx2Stephan Bergmann
Change-Id: Ifdb964558f070e7c9ee87eabeaafa5c3c079c0c9
2018-01-14Fix typosAndrea Gelmini
Change-Id: I2b4988e1d81fe60f7699362480cd739d2620c053 Reviewed-on: https://gerrit.libreoffice.org/47856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-14Fix typosAndrea Gelmini
Change-Id: I2a578961837076ebce3c1fb2681b0785d1d490ac Reviewed-on: https://gerrit.libreoffice.org/47857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-13Foreground colors adjustedCaolán McNamara
to comply with WCAG 2.0 level AAA requiring a contrast of 7:1 Change-Id: I71edc354f3f9a3d534452bb378743d1f9639a08f Reviewed-on: https://gerrit.libreoffice.org/47825 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-13gpg4libre: open encrypted files also via gpgThorsten Behrens
Adds code to sfx2 and package to try gpg4libre for extracting session keys, and use them in turn to decrypt odf storage. Change-Id: I1f626143e6c8443b4ad0c4fc5bdbd5ab8d56a451 Reviewed-on: https://gerrit.libreoffice.org/47780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-12tdf#114939 sfx2: notify user of non-interoperable passwordsMichael Stahl
For ODF 1.1 encryption, SHA1 is used as the start-key digest algorithm of PBKDF2. For the ODF export password-to-modify "feature", PBKDF2 is used without a start-key digest round, so the UTF-8 encoded password is directly the input. In both cases, if the user entered a password with a known problematic length, reject it and request a new one. Change-Id: Ie6510c1e668e1ed32be439ebe00354881b6ca83f
2018-01-12tdf#114939 officecfg,sfx2: always use AES/SHA256 in ODF 1.2Michael Stahl
The setting ODFVER_012_EXT_COMPAT "1.2 Extended (compatibility mode)" no longer has an effect on the encryption algorithms. API CHANGE: Remove the configuration settings: Office.Common.Save.ODF.UseSHA1InODF12 Office.Common.Save.ODF.UseBlowfishInODF12 Rationale: * Every release since 2012, from LO >= 3.4 and AOO >= 3.4, can read AES/SHA256 encrypted files. * SHA1 is broken anyway * tdf#114939 causes SHA1 interop issues Retain SHA1/Blowfish only for ODF 1.1 export. Change-Id: I007511d4830a90121e38bf5bb4534df5695621e9
generated by cgit (git 2.34.1) at 2025-01-14 18:14:07 +0000