summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2013-10-09More OUString::copy out-of-bounds fixesStephan Bergmann
Change-Id: I45762d167d04252e32155a7b23a3290688bccdf6
2013-10-09Improve ErrorCodeIOException messagesStephan Bergmann
...and clean up some includes. Change-Id: Ia5843cd38f967722d7173a6c87fba26064e3ffd6
2013-10-09update unusedcode listCaolán McNamara
Change-Id: I201985753fc53f037807e7870c6786a442717d6e
2013-10-08CID#1079304 uninitialized membersCaolán McNamara
and CID#1079303 Change-Id: I52e70424ca83ae7c9c73dd28d93912a1228ce2bd
2013-10-08CID#1079305 uninitialized membersCaolán McNamara
Change-Id: I00d716a0f05d50fd7a7a1c43772af51224a6b15a
2013-10-08CID#1079306 uninitialized membersCaolán McNamara
Change-Id: I40838e5816439b95a33da6e6896f5ae0b89dbbef
2013-10-08CID#1078685 consider if there is < 3 %Caolán McNamara
Change-Id: I2807a16548af4202d42448c6ef66f240ab4cc920
2013-10-07startcenter: Hide template toggle button if no templatesKrisztian Pinter
Change-Id: I9c6f2058e67990156a4be928449c6ebe6614e486 Reviewed-on: https://gerrit.libreoffice.org/5913 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-07Use URL as fallback for DocumentBaseURL in css.document.MediaDescriptorStephan Bergmann
...in SfxDocumentMetaData::getURLProperties, to avoid "tools/source/fsys/urlobj.cxx:1741: cannot make <[...]> absolute against broken base <>" warnings when SvXMLImport::GetAbsoluteReference tries to make absolute against an erroneously empty base URI any relative URIs contained in the document's meta data. As a consequence, such relative URIs contained in the document's meta data will now be made absolute upon loading in SfxDocumentMetaData::getURLProperties. However, I saw no negative consequences of that (other than having to adapt sfx2/qa/complex/sfx2/DocumentProperties.java in the obvious way). Whether a document written out again contains such meta data URIs as absolute or relative is only controlled by "Tools - Options... - Load/Save - General - Save - Save URLs relative to file system" and not affected by this fix. (I verified that by loading sfx2/qa/complex/sfx2/testdocuments/TEST.odt, which contains a relative meta:auto-reload xlink:href="../TEST.odt" in its meta.xml, and saving it as a new file, with and without "Save URLs relative to file system" checked, and inspecting the resulting documen's meta.xml entries.) Change-Id: Ia1b6004c8597a726eb59c6b2234fd3ecb0bdcc09
2013-10-07sfx2: use a smart pointer in IMPL_SfxBaseModel_DataContainerMiklos Vajna
Change-Id: Ia13c94e05d26d66ebee00ca89030b6947c5efc0c
2013-10-07Use org.junit.Assert.assertEquals where appropriateStephan Bergmann
Change-Id: I3811578a76f6c5c98c955819ca004f2062d273b8
2013-10-04fdo#39674 fix some spellingThomas Arnhold
Change-Id: I72e497fb97edf8782c69000576f42896594e1556
2013-10-02-Werror,-Wunused-variableStephan Bergmann
Change-Id: I55da6a2df8c65460204f66679156516db1370b07
2013-10-02-Werror,-Wunused-variableStephan Bergmann
Change-Id: Icf7976fe38402d7e6d0b25186b57a2b4dc68c0ae
2013-10-02Resolves: #i123276# Properly forward Deactivate() call...Andre Fischer
and still don't broadcast context change. (cherry picked from commit 520cc667c80cea6bb48422825250b72ff36bb4ef) Conflicts: sd/source/ui/view/drviews1.cxx sfx2/inc/sfx2/shell.hxx sfx2/inc/sfx2/sidebar/ContextChangeBroadcaster.hxx sfx2/source/control/shell.cxx sfx2/source/sidebar/ContextChangeBroadcaster.cxx Change-Id: I753009041a999bc31a0528e37f0a499897f311c5
2013-10-02Use std::auto_ptr::reset where applicableStephan Bergmann
(avoids warnings about std::auto_ptr ctor being deprecated) Change-Id: I39d2d155c0bc62ca77a30c02428ea39102213f42
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: I499e5832999fd54b44774877da2ec3838d21ce75
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: I5bb9982daa0dfbbe97e82e8598fec8d0d05b93cb
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: Ibaf2c42050c85d9b87d58204f1c68422e33da4c1
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: I8e907dd0e0a38eb250b77123dc3f604b79c0a695
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: I3a85878b5e8a346b58e15877c7ddb8bf90eac6a1
2013-10-02remove some UniString::GetBufferCaolán McNamara
Change-Id: I808026a6f593b0251ee107d27e7ca12d55b2d0a0
2013-10-01fix conversion to OUString in filedlghelper.cxxNoel Grandin
in commit c82d932510c88a12b260b1684522efbc69f07b26 "convert remnants of String to OUString in SFX2 module" when I created the SetToken method, I forgot to make the first parameter a reference. Change-Id: Id587e69ff0cdf46f645d8f9d1dc0e110ae80daa5
2013-10-01convert remnants of String to OUString in SFX2 moduleNoel Grandin
Change-Id: Ie07684f2b8b902b0ce0844eabc8174482e02d8db
2013-09-30Fixing the problem with Sidebar-alignmentPrashant Pandey
Currently, when the sidebar is taken from right side of the screen to left side of the screen, the vertical tab -bar is still attached towards the right side of deck. Ideally, when the sidebar is attched towards the left side of the screen, the tab-bar should automatically set towards the left side of deck. Change-Id: I1f56e5f0b7dfef37760e6563e7d757f7901cf2cd Reviewed-on: https://gerrit.libreoffice.org/5979 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-30Add hack to optionally get stable ODF output from the same inputTor Lillqvist
To be used in regression testing and similar scenarios, where the output ODF is *not* intended to be further manipulated in LibreOffice. An environment variable LIBO_ONEWAY_STABLE_ODF_EXPORT is used to toggle this behaviour. I am not 100% sure whether the generated ODF with the hack toggled on is even fully correct, but correctness is not the purpose of the hack anyway. Two classes of issues handled: 1) Automatic style names and 2) use of randomness. For class 1), when the hack toggle is in effect, we generate the names at first as strings based on all the properties of the style, and sort them based on those, and then rename them (for brevity in the output) to the "normal" form of a short prefix plus a number (like "P12"). Sure, it would have been better to just figure out *why* the automatic style naming currently is not stable in the first place, but outputs the styles in different order (with some styles being assigned different numbers) in separate invokations of LibreOffice), but I was unable to understand that. Possibly this code could be used in all cases, except that it does break some unit test (can't recall which right now). I don't know whether that is simply because the unit test assumes too much knowledge of the internal workings of the automatic style name generation, or whether the generated ODF is actually invalid. For 2), I found a handful of places where randomness was used to generated various kinds of identifiers in ODF output. I changed those to just use large (64-bit) non-overlapping integers instead. I assume there *is* a point in the original code in each case that explains why randomness is needed, so the hack definitely needs to be optional and used only for the above mentioned scenarios. Change-Id: I17b657197e38bcf24abdfe61ad4a277f4339eeae
2013-09-28fix change tracking options preview sizesCaolán McNamara
Change-Id: I39bf97cd84685132180694fc99bb3a298ec798ed
2013-09-27cppcheck: redundantAssignmentJulien Nabet
Change-Id: I43ae91f0b91479fb279b0efbeb0cb4195e7b083a
2013-09-27Google Drive files don't need Checkout bar.Cao Cuong Ngo
Plus, the Name property has been changed to Id, that was the reason the Checkin bar disappeared. Change-Id: I03f6ef4e1399c0f8b2a347ca8acd8a42daffa497
2013-09-27Move the current template dir a bit down.Jan Holesovsky
Change-Id: I7d8fea0a2fb8a73a5d108cc8b2ac36b7829f029c
2013-09-26Fix Infobar crashCao Cuong Ngo
The infobar should be added to the infobar list. Change-Id: I105dd5091daf3596fdd7dd119a07d6160444c673
2013-09-26CMIS file picker: it really does not like ID MarkCao Cuong Ngo
The file picker can't go back folder if we use ID mark in the URL. Conflicts: ucb/source/ucp/cmis/cmis_content.cxx Change-Id: I6985feec71dc23848ee022e0bab9e8515a21ffd2
2013-09-26typo fixes in commentsAndras Timar
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-25We need <tools/string.hxx>Tor Lillqvist
Change-Id: I1e4df48bbbdb8c2ee4840e02aeb1d585aeec63f7
2013-09-25Related: fdo#38838 remove UniString::EqualsIgnoreCaseAsciiCaolán McNamara
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-09-23Cmis Versions dialogCao Cuong Ngo
Change-Id: Ie863282062a6932a55543143e841917c54223ac9 Reviewed-on: https://gerrit.libreoffice.org/5925 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-09-22gbuild: add gb_Library_use_restargetMichael Stahl
Change-Id: Ic0a2fd3c1adeb55ec27f6a2eb4709be598120fba
2013-09-21sfx2: fix sfx2::sidebar::Theme lifecycleMichael Stahl
It's a horrible idea to have global VCL Images, since that will inevitably crash on shutdown when the static dtor runs after DeInitVCL, which breaks ~every JunitTest now. 0x00002af6750d2d51 in rtl::Reference<sfx2::sidebar::Theme>::~Reference (this=0x2af6756ceb28 <sfx2::sidebar::Theme::mpInstance>, __in_chrg=<optimized out>) Try to fix that by moving the global sidebar::Theme instance to SfxApplication where it can hopefully be deleted before shutdown. Change-Id: Ia78f1e458699335b53a741b6463ce48af69584a7
2013-09-21WaE: shadowed variable in higher debug levelCaolán McNamara
Change-Id: I560e5559306277006a2b6dbeacad54ee60a182d0
2013-09-20Related: fdo#69444 additionally care from zero recently-used items caseCaolán McNamara
Change-Id: I45c68dd7cac0a6666401ae4833b6ae090882659c
2013-09-20cook up a scheme to allow windows to have per-module settingsCaolán McNamara
Change-Id: I5fa62c3c2af2ccbbc7e8a61e5537488515b2808c
2013-09-20Resolves: #i122470# Fixed programmatic triggered switching of sidebar decksAndre Fischer
(cherry picked from commit 7b26aba94e5544937f1e37e34915bcb276bc3c27) Conflicts: sd/sdi/sdraw.sdi sd/source/ui/framework/tools/FrameworkHelper.cxx sd/source/ui/inc/framework/FrameworkHelper.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviews6.cxx sfx2/Package_inc.mk sfx2/inc/sfx2/sidebar/Sidebar.hxx Change-Id: Ic6b518e734fe59a7b713e85e934487347b847c5a
2013-09-20Turn sidebar back to non-experimentalCaolán McNamara
This reverts commit 7ce2a89f4f8fa84232896766276cb3433ada239c. Change-Id: I53f572777e84f66fd4c3d18fb686dac09095804a revert d38cb53e3bcf3fd95a75e03b01c3b7a209d07b46 Change-Id: I5b243b69e50084316aaeab250d6b01079c12b718 Revert "sidebar: disable impress task pane if sidebar is enabled." This reverts commit ee1726bfdba483623d496a3bcc09089e8b55cd65. revert 54d820a7815af03a248c1aa424fae9bf9a4881f4 Change-Id: Ie7c83d88f5427a7e42fa50879280a0c4a7c2cdd1 Revert "Only register and use the Sidebar if it is globally enabled." This reverts commit 66a5cc468cef0c6db8b42b7f25367f04208e6f2e. Conflicts: sfx2/source/view/viewfrm.cxx Change-Id: I17fe702996c4adf7f387573d36ea993f8cc32c96 Revert "disable sidebar menu option if it is disabled." This reverts commit 05f0eb57618d090fa45011120a907a3b1157accb. Revert "finally get the taskpane rendering again" This reverts commit 228bb7ffe0d404ba1225f7b4d26ca71e098577d9. Conflicts: officecfg/registry/data/org/openoffice/Office/Impress.xcu sd/source/ui/framework/factories/TaskPanelFactory.cxx sd/source/ui/framework/tools/FrameworkHelper.cxx Change-Id: I248cc9a769695cde19e78774d42ce666dc685599 Revert "don't throw up the sidebar on start." This reverts commit 645db9a2bd9b1eec381de60c491e6b7f9ee7a7b4. Conflicts: officecfg/registry/data/org/openoffice/Office/Views.xcu Change-Id: I911859757e2e019836e8ed5213d2ba69ff82aec8 Revert "update to the right service name for new URLs." This reverts commit 55f49970f4085e3a1498961edabd5303bd6bea6c. Conflicts: sd/source/ui/framework/tools/FrameworkHelper.cxx Change-Id: I1ba2762a4c969a9125ff8354a9b6035813290021 Revert "tentatively restore more UNO / task-pane goo ..." This reverts commit 052ac10a6f9b28b9b06884dd3ed41879722be6c9. Conflicts: officecfg/registry/data/org/openoffice/Office/Impress.xcu Change-Id: I7e62f27329af033df811549436718648a6447dea Revert "more reverts, first cut at making sidebar optional." This reverts commit a65a423e22fc03d0b7850bbf20dfc30f6cfa34dd. Revert "add experimental option for sidebar to 'Advanced' pane." This reverts commit 54d820a7815af03a248c1aa424fae9bf9a4881f4. Conflicts: cui/source/options/optjava.cxx sd/source/ui/framework/module/ImpressModule.cxx Change-Id: I09a6c0f7834c8ef330d05a014505aaaf09ae096f Revert "Restore FrameworkHelper taskpane URLs." This reverts commit e9c2d5b26b1e1b52bdf87192a76314b7362fa80c. more foo Change-Id: I2eaa2fbd74dc7a2f7ba937d310472cee6b5a0b57 really go to town on it Change-Id: I885dc03cd0286bbfdf05c05da9f0bbea2b78bcf4
2013-09-20indent: Just some indenting for better readingAndres Gomez
Change-Id: Id840dd00c71afc1930e6bb9b634e888b88fe7391 Reviewed-on: https://gerrit.libreoffice.org/6001 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-20uno: new InteropGrabBag UNO prop in OfficeDocumentAndres Gomez
Added the new InteropGrabBag property to the OfficeDocument service and modified the JUnit UNO unit tests for it. Added specific implementation in the sfx2 module for the SfxBaseModel class. Added specific inherited implementations in the sc, sd, starmath and sw modules for the ScModelObj, SdXImpressDocument, SmModel, and SwXTextDocument classes. This new property is intended by now for its usage on preserving OOX's theming although the aim is to be able to re-create the theming in the future from saved properties. It could also be used for preserving other attributes for interoperability among document formats. Change-Id: Ia822856293c70ae22911afa794e3e38bcaa31f86 Reviewed-on: https://gerrit.libreoffice.org/6000 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-19Make scrolling in ThumbnailView smoother and not per-lineKrisztian Pinter
Change-Id: I3df50dc953c6a5123b62f129b6e303ff682c6d9b Reviewed-on: https://gerrit.libreoffice.org/5951 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-18sal_Bool -> boolJulien Nabet
Change-Id: I7429af4dc64ec6c69b6b9297779e51614362cf52
2013-09-18Resolves: fdo#69444 cursor keys don't move between recent used docsCaolán McNamara
because each item is identified by an id, but that isn't set on the recent used so it stays stuck on the first one. change the ctor of the base element to require an id to be passed to it and adjust all the good code and then use the index+1 of the recently used elements as the id. Change-Id: I1e5978ddedbd4718923ef72d67598158d5ba8ee7
2013-09-18Related: fdo#69444 unsigned arithmetic is a PITACaolán McNamara
Change-Id: I8662fc36476a2a029f6bab306306181359b3f688
2013-09-18Resolves: fdo#69440 only ask for tabcontrol in builder dialogsCaolán McNamara
Change-Id: I6001f8921f3b90283525355b0094c4377c42c663
generated by cgit (git 2.34.1) at 2025-01-06 11:16:35 +0000