summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31Replace AddContext in sidebar/EnumContext.cxxJulien Nabet
+ remove extra duplicate AddEntry("Chart", Context_Chart); Change-Id: I9624000d5f9470cd4cb5072c24aa24aced740fe4 Reviewed-on: https://gerrit.libreoffice.org/23665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-30notebookbar: Trying to use the SfxChildWindow for it does not work too well.Jan Holesovsky
The notebookbar is not a child window, so trying to graft it on the SfxChildWindow infrastructure is more pain than gain, unfortunately... Instead, it's enough to create the appropriate functions for ExecMethod and StateMethod, and call them from Writer / Calc / etc. with the appropriate .ui file; that's easier & works equally well. Change-Id: I08d98d4f481bd02e90ba11df0bd1c1149697a7fa
2016-03-30notebookbar: Rename NotebookBarWindow to NotebookBar, and move accordingly.Jan Holesovsky
Change-Id: If04a8f62aba0bcb712ae6405db318a4bd073fc54
2016-03-30notebookbar: Instantiate the notebookbar via sfx2 infrastructure.Szymon Kłos
Change-Id: Iaed4596246245560e646d9086e717d5fb516897e
2016-03-30Replace MACRO_PRFIX and MACRO_POSTFIX in eventsupplier.cxxJulien Nabet
Change-Id: Ifd08a3414468e7685f55af66ed05f7a88187fa0e Reviewed-on: https://gerrit.libreoffice.org/23606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-30Replace IMPL_FORWARD_LOOP in sfx2/source/bastyp/fltfnc.cxxJulien Nabet
Change-Id: Ic9eda24be82a54c3907ffe6eb749e927db87dee7 Reviewed-on: https://gerrit.libreoffice.org/23605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-29Replace some defines in sfx2/source/appl/newhelp.cxxJulien Nabet
Change-Id: I82d13a71b59bd9cefc800f592d2b8312b70d1725 Reviewed-on: https://gerrit.libreoffice.org/23604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-28tdf#59698 Template Manager: 'OK' and 'Help' buttons addedAkshay Deep
Change-Id: I0ec224eb5c6b11a8d589def477f3cf8429195f2c Reviewed-on: https://gerrit.libreoffice.org/23552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk> Tested-by: Olivier Hallot <ohallot@collabora.co.uk>
2016-03-26Avoid nesting parentheses in this stringAdolfo Jayme Barrientos
Change-Id: I3b6fc9ca49e4a7b0019c2c9b376eb87ae8d14e4f
2016-03-24MM: remove lock from saved documentsJan-Marek Glogowski
Actually we have to call DoSaveCompleted to get rid of the locking. Instead this adds a parameter to skip the recent file registration used in non bCreateSingleFile modes. Change-Id: I57151f08ad8d737007da84c4566685cc37612dfb
2016-03-24tdf#97398: Toggle deck/panel visibility individually for each appKatarina Behrens
Change in visibility of a shared deck ('any, any, ...') or panel made in 1 app must not affect its visibility in the remaining apps Change-Id: I78472ce078409edec796ef649349df4bda62a709 Reviewed-on: https://gerrit.libreoffice.org/23432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-23tdf#92817 Fix for Error on Save with empty lock fileJaskaran
An empty lock file is of no use except that it doesn't allow you to save your file with that same name. An empty lock file doesn't have OOOUSERNAME and SYSUSERNAME. So in that case we could take ownership of our lock. bOwnLock = true makes it our own lock. Change-Id: I9490f87d69bcad3c09f6c98b4fb9318f53e1d4bd Reviewed-on: https://gerrit.libreoffice.org/23125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-23loplugin:constantparam in sfx2Noel Grandin
Change-Id: I12aa9b28a9a1e66425717820cfcedff55434dd2f
2016-03-22sfx2: Fix memleakTakeshi Abe
i.e. free pMedium when CheckPasswd_Impl() returns ERRCODE_ABORT. Change-Id: I452074e5189afe64016226c1a193a68f40e9c43d Reviewed-on: https://gerrit.libreoffice.org/23387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-21tdf#98745 Optional save button without the dropdownMaxim Monastirsky
Change-Id: I66499a9108dce76e661df9b5b45b249caf9eece8
2016-03-18tdf#98740 Infobar should not be in the customization optionsSamuel Mehrbrodt
Change-Id: I741246174a8a3b642224c63faa2891ab383b645c Reviewed-on: https://gerrit.libreoffice.org/23354 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-18drop unused params from SvLBoxItem and all it's subclassesNoel Grandin
looks like this is fallout from commit ac7acb0a "Merged SvTreeListBox and SvLBox." (in year 2012) Change-Id: Iaebeae64fc7cd3ba11f5f45b53bcb65bf906e906
2016-03-18sfx2: Improve git-grep-ability for at least few toolbars.Jan Holesovsky
Change-Id: Id5a2b98f7ce892fdf9969c676d987ee041913468
2016-03-17Revert "tdf#98458 sw: make search in shape text optional"Jan Holesovsky
Actually there seems to be a simpler solution to the immediate performance problem which I'll commit next. It still might be necessary to introduce the search switch at some stage, but first let's see if there are complaints. This reverts commit 8e0b08c3053ed5472409b1ea7e02653aad38f7d6.
2016-03-17cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Id506e26ab4986a3972ebf24397c5c0c8d131fe69
2016-03-17loplugin:constantparam in sfx2Noel Grandin
Change-Id: I53e690ab8d50fb3ce43ba633fc018e7b66e591cd Reviewed-on: https://gerrit.libreoffice.org/23321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in svtoolsNoel Grandin
Change-Id: I1a3c4a36e29a6712c589ffd3aaada593880d978d Reviewed-on: https://gerrit.libreoffice.org/23304 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17tdf#98458 sw: make search in shape text optionalMiklos Vajna
Instead of forcing it silently on everyone, add a new search option and enable it only in case it's requested, as shape search is expensive for large documents. (Regression from commit bdc1824ea7acfa2fe9d71cdbe57882acce155577.) Change-Id: Ibb6e76ad5c870dfd63b36429e16ef6d572f5f1fd
2016-03-17loplugin:constantparam in toolsNoel Grandin
Change-Id: I3774661799c074561c694515baba42a375d0a077 Reviewed-on: https://gerrit.libreoffice.org/23301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15remove unnecessary parentheses in case labelsNoel Grandin
Change-Id: I987bf68c767709080c67c8b183c036a4109c6caa
2016-03-15loplugin:constantparamNoel Grandin
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-14tdf#97885 SIDEBAR: Message missing from blank properties tabFabio Buso
Change-Id: If810c351644ef80d3882b34861fde0400236bdf3 Reviewed-on: https://gerrit.libreoffice.org/23127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-14remove some unused typedefs, and inline some use-onceNoel Grandin
Change-Id: I5ada1cff98c0a3e065d126444f8052f444323743 Reviewed-on: https://gerrit.libreoffice.org/23234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-12TypoAdolfo Jayme Barrientos
Change-Id: I834c8473a6c2ad135359c45af868132bbb6960f8
2016-03-11work on sane lifecylce for SfxFilterMarkus Mohrhard
all SfxFilter instances should now be hold inside of a std::shared_ptr. This fixes a number of huge memory leaks in the test framework and removes one huge source of memory issue in sfx2. SfxMedium contains a pointer to the SfxFilter but does not own. Therefore it is required that any SfxFilter belonging to a SfxMedium lives longer. However this seems to work mostly by hoping that all SfxFilter instances are stored in a global array. As we have seen with the tests this is not true (there are also some cases inside of sd that seem to not follow that pattern as well). Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8 Reviewed-on: https://gerrit.libreoffice.org/23140 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-10coverity#1355501 Dereference after null checkCaolán McNamara
Change-Id: I84001559ed2bafee16a176eb11ea991397b733bc
2016-03-10Improve error message when URL cannot be opened externallyStephan Bergmann
It need not be due to no browser, but might also be e.g. a misspelled URL like <htp://...>, see mail thread starting at <http://listarchives.libreoffice.org/global/users/msg48090.html> "[libreoffice-users] LO 5.1 Presentation can't find system browser on OSX 10.11." Change-Id: I74ce7abb4e78d72ce9bf92424f66608c6780d2d3
2016-03-10sfx2 classification: merge common code from sw and writerfilterMiklos Vajna
The two versions were almost a duplicate. Change-Id: I3148150d62484a55fc8d59ca354998f211435c0b
2016-03-10MenuDispatcher::m_pMenuManager is always nullptrMaxim Monastirsky
... as shown by 7da15debe39b50255cc08b3fef7ae38185a9174f. Which means that MenuManager is unused, and MenuDispatcher does nothing useful. Change-Id: Ic85619531054a573d971d38b52609e1cbcaf780c Reviewed-on: https://gerrit.libreoffice.org/23117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-10sfx2: make SfxClassificationHelper not require a full doc shellMiklos Vajna
So that input filters can build their own doc properties and can also use CheckPaste() without having the full original document around. Change-Id: I0b8a63702f73ce04e8728a360b56ab9d1ca67af1
2016-03-09Move classified copy/paste strings from sw to sfx2Miklos Vajna
So that other modules can use them as well. The RTF import in writerfilter is one potential user. Change-Id: Ib009e1be2aff14d0fcac643c0c6000d2895515b0
2016-03-09Move copy/paste classification check from sw to sfx2Miklos Vajna
So that it's easy to unit test it and other apps can use it as well in the future. Change-Id: I38d601924b7fbb17615ff6e9c031a71b40777c4c
2016-03-09remove unused NOT_POOLABLE enum valueNoel Grandin
and simplify the resulting SfxItemInfo field down to a single bool Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2 Reviewed-on: https://gerrit.libreoffice.org/23058 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09mpUpdater has been proven unusedStephan Bergmann
...by 435d6d50c3cdb6711942ee40dc2fae1865361845 "loplugin:constantparam in sfx2" Change-Id: I28db5cc1fd6506ba9e374d28b40e5d0cf7d676bd
2016-03-09loplugin:defaultparamsTor Lillqvist
Change-Id: Ib5f6412c549fe1d5bfd08ed62979a7f81fb2648c
2016-03-09loplugin:constantparam in basicNoel Grandin
Change-Id: I5b49406535c1ec95e47fe237a23184a499b875e5
2016-03-09loplugin:constantparam in sfx2Noel Grandin
Change-Id: I50a2d8221f907f0e844e558f3dbdd0346c010201
2016-03-09Add missing includesDavid Ostrovsky
These include were needed to compile on Windows, MSVC 14.0 with clang-cl. Change-Id: I4ca5cec8314920e90fcca6fa69ec4df87d680f29 Reviewed-on: https://gerrit.libreoffice.org/23044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08sfx2 classification: expose impact scale and levelMiklos Vajna
This allows application code to prevent copypaste from a more confidential to a less confidential document. Change-Id: I121c7566c948340e7b41d3f8462b0d65a2441b0f
2016-03-08tdf#97703 Removed empty setUp/tearDown methodsChirag Manwani
Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5 Reviewed-on: https://gerrit.libreoffice.org/22985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08loplugin:constantparams in vclNoel Grandin
Change-Id: I2114436f4bef3ac71a3035a206186cefaf88bca1 Reviewed-on: https://gerrit.libreoffice.org/23023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07drop unused resourceCaolán McNamara
Change-Id: Ibe52933faa6b13e2d89ab296c1cc15b70f5835af
generated by cgit (git 2.34.1) at 2025-01-28 11:02:23 +0000