summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-11-22Unneeded 'this->', kill it.Jan Holesovsky
Change-Id: Ia032ee884b98db617699e84e9c0c7980e7df0fc3
2014-11-22Cleanup some whitespace when I'm touching this code anyway.Jan Holesovsky
Change-Id: Id8e19749050f58837715f717983cb2acbcf9318a
2014-11-22fix the buildMarkus Mohrhard
Change-Id: I9a067470c53684b7ca386b1c403b4d7d36c90bbc
2014-11-21Same with SfxUnoControllerArr_Impl.Kohei Yoshida
Change-Id: I927621de8f4c486ef0f77ec6c8da336f36b38b3e
2014-11-21Forward declare SfxFoundCacheArr_Impl and SfxFoundCache_Impl in bindings.hxx.Kohei Yoshida
And remove #include <boost/ptr_container/ptr_vector.hpp> from here. Change-Id: I7624444b60ee19f0b5b19e7a7aab0210ddf90d7c
2014-11-21Forward declare all the std::vector based impl container classes.Kohei Yoshida
Now #include <vector> is a goner... Change-Id: Ia2da27bae5fadfa3f6f633e55fcedce405281b67
2014-11-21Forward declare SfxTbxCtrlFactArr_Impl and SfxStbCtrlFactArr_Impl in app.hxx.Kohei Yoshida
Now we can finally remove ptr_vector include from this header. Change-Id: I7aeaa520e10b4eacb1a24ad666086739821e56b0
2014-11-21Forward declare SfxMenuCtrlFactArr_Impl in sfx2/app.hxx public header.Kohei Yoshida
Change-Id: Iaf287912a52eb8785c687a13536fc170094425c7
2014-11-21Forward declare SfxChildWinFactArr_Impl in sfx2/app.hxx.Kohei Yoshida
Change-Id: I52128b405e861551a933d9c1625d7741b43ad2b6
2014-11-20Forgot to check this in. This should have been a part of the last commit.Kohei Yoshida
Change-Id: Id2b75e6e64b11c523ffa862f2d99bf02c2adedc5
2014-11-20Move SfxStringHint out of sfx2/app.hxx public header.Kohei Yoshida
This is only used within sfx2, and only in 2 places. Change-Id: Iebe07e2e79193c7980d8958b25aa9c4ce6188ad3
2014-11-20Remove ptr_vector header exposure from sfx2/childwin.hxx public header.Kohei Yoshida
Change-Id: I4060c8987a0da387d02f8468229854612a230db3
2014-11-20Make the ctor and dtor bodies non-inline.Kohei Yoshida
Change-Id: Ie36e3dfa808aec96c080f981a5ad9f09a0720c2c
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18Resolves: fdo#75066 add TABSTOP and DIALOGCONTROL bitsCaolán McNamara
to this custom widget to state that is is a candidate for tabstopping to, and that its a (old-school) container widget which has subwidgets which should be candidates too Change-Id: I39452f906b30c3962026ab9c4dba625ecd2d06a8
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17fdo#85478 Avoid destroying bitmaps after VCL is shut downMatthew J. Francis
Change-Id: I1ece738e7f60b6bbbdc802339f8b9deec9396e1b Reviewed-on: https://gerrit.libreoffice.org/12469 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-16vcl: let the ModalDialog ctor take an OUStringMiklos Vajna
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
2014-11-16vcl: let the ModelessDialog ctor take an OUStringMiklos Vajna
Change-Id: Iae88a9889c674337fb999a23a799d8730d2793d5
2014-11-15TabDialog ctor: take an OUStringMiklos Vajna
Change-Id: Ie390fb9debe3a80b3ebc5e609119723c78eadba2
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-12coverity#735490 reimplement bit countingCaolán McNamara
with a classic solution rather than a bizarro one that confuses coverity Change-Id: Id9427a47693897683193c0c778f0cd6c39740f6f
2014-11-12sal_uIntPtr->sal_uInt32 for BitSetCaolán McNamara
because this ancient horror expects a 32bit type here Change-Id: Icf8b775ea67afa0ead559a55b8c335ad1afc4010
2014-11-12ditch this unused idpool horrorCaolán McNamara
Change-Id: I527b310126518357f9830f75d16b4848c9383999
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84582 : fixed label in the 'Insert Version Comment' dialogSzymon Kłos
When user's data are empty, dialog shows "(no name set)". Dialog: Writer->File->Versions...->Save New Version Change-Id: I6780cbe452fbc206b3e153975dbb1c1d9570718b Reviewed-on: https://gerrit.libreoffice.org/12307 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-11HIG fixes for sfx2Adolfo Jayme Barrientos
Change-Id: Ide13fff6a3d5d82847c4886967283cb4b59bcfbb Reviewed-on: https://gerrit.libreoffice.org/12321 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-09SfxTabDialog ctors: take an OUStringMiklos Vajna
Change-Id: I91b9b2ffd19b2412ac01dd12429d6460b4c4812c
2014-11-09fdo#82707 Unify click behavior in Statusbar (Writer)Samuel Mehrbrodt
Use single click for primary action, right click for context menu Change-Id: Ia707a88b48f4af144588c45d37acea547e77773e
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#67627 fdo#85791 Allow to show/hide sidebar decks with the same commandSamuel Mehrbrodt
This also reintroduces the code to switch the decks asynchronously (removed unintentionally before) Change-Id: I825b4d7c5777097e9d3b3d82adbe1f646510dc9d
2014-11-05markup with event type not checker typeCaolán McNamara
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30HIG fixes for Document Properties dialogAdolfo Jayme Barrientos
* Add missing colons to labels that precede controls * Standardize Help button’s position * Better label for Add Property button * Add a frame for the lonely Embed Fonts option Change-Id: If12708161f2345e66ab3f49fd744bcad00d4ecc6 Reviewed-on: https://gerrit.libreoffice.org/12096 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-29Resolves: fdo#85111 put a border around the custom properties boxCaolán McNamara
Change-Id: Ibdbfb4a88c1c75aaf5d33672d8639a9ea55afbac
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29coverity#1028106 Dereference before null checkCaolán McNamara
Change-Id: I77a910542cf1b7889f69a1d3b7989779d9ecc7e8
2014-10-29ref-counting vcl::Window subclassesNoel Grandin
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-28coverity#704019 Unchecked return valueCaolán McNamara
Change-Id: I605861dd741b1899924c0079b931da418be5d647
2014-10-28coverity#704020 Unchecked return valueCaolán McNamara
Change-Id: I0f8b49bb43d88549ba90db63ce7041e6d5e0fe64
2014-10-24loplugin: cstylecastNoel Grandin
Change-Id: Ia0f5f0d0efbe4693aba347bff32cd694117251fe