summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2022-11-15sw: add online accessibility check implementationTomaž Vajngerl
Change-Id: Ic68aa91b1cbf23ac305ad4e361c56b91556757ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141604 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-11-11move password handling from SwModelTestBase to UnoApiTestXisco Fauli
so other places inheriting from UnoApiTest can also import/export protected documents Change-Id: I0e2716204dbb171c9e17e3939b266977e1b96dda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142592 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-10Simplify and deduplicate SfxBaseController::queryDispatchMike Kaganski
Change-Id: Iffc67ff7e0840bd2402c4ba357f45a1493ff78ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142543 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-10Simplify this a bitMike Kaganski
Change-Id: I6162b8f54eb685267aeebe48daa419933b6528a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142542 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-10lok: masterpage: use EditMode as parameter in invalidation callbackSzymon Kłos
Change-Id: I3905fc9e6376ca1cef3e438e7a5f229d3720b1f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138961 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142501 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-09lok: masterpage: introduce EditMode setter and getter for ViewShellSzymon Kłos
Change-Id: I74d3307aab8fc038bd2409b5f10a2d08db885223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138957 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142472 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-09UnoApiTest: factor out common codeXisco Fauli
Change-Id: I1d84d8c1e371016a4f4f068af1e9c76635f28cf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142490 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-09sfx2: fix user-after-free in SfxObjectShell::ExecFile_Impl()Miklos Vajna
This happened even with an empty Writer document, on File -> Export As -> Export Directly as PDF, since commit 1e007e8f1703851b01c68884e87c906f6bae5a5e (sw: fix merge mail to direct export as pdf, 2022-10-18). The problem is that SfxObjectShell::ExecFile_Impl() gets a SfxBoolItem* returned by GetSlotState(), and then uses it before and after calling SfxStoringHelper::GUIStoreModel(). But as part of opening the file picker for save, ModelData_Impl::OutputFileDialog() indirectly calls Dialog::Execute(), which starts to process user events on the main loop, which leads to SfxItemDisruptor_Impl::Delete(), which deletes that SfxBoolItem*. Fix the problem by storing the bool value on the stack in SfxObjectShell::ExecFile_Impl(), and work with that after our SfxBoolItem* is gone. The "freed by" backtrace from asan is cut quite early in the gtk3 case. The "gen" case is more helpful, though it's still cut at frame 29. Change-Id: Ib97c7df7c1289730dec478eede3d620f3a33ace8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142492 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-08UnoApiTest: simplify code by using tempfile memberXisco Fauli
SwModelTestBase does the same. this will help to make SwModelTestBase inherit from UnoApiTest Change-Id: If1c824cf92f0e8b70253e4d5fdeddcaa521d4632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142287 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-06Remove double functionalityArmin Le Grand (allotropia)
There was processorfromoutputdevice.cxx|hxx containing createBaseProcessor2DFromOutputDevice that does exactly the same thing as createProcessor2DFromOutputDevice in processor2dtools.cxx|hxx, so I removed one onf them to make handling of future changes easier. Change-Id: Id8d49d1572a1bc39f1d330a742d4697c8c030e75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142320 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-11-05lok: properly treat zoom in LokStarMathHelper::postMouseEventMike Kaganski
Previous naive implementation was dropped in commit 033a342a630dbb6329962156727e621866b77b48 (lok: use twips in Math, Wed Nov 02 11:03:08 2022 +0300). Unlike chart, Math expects twips, so PPT (pixel per twip) factor must be converted into percentage. Change-Id: Icd936e004d961c0abc25c241391d4e24c44e8c14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142319 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-05lok: show Math cursorMike Kaganski
Change-Id: I17a449f0a0662f0433de9cad1522a090434c1e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142178 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-04Templates: tdf#86483: Add "Localization" category and add a template for zh_CNKevin Suo
This patch adds a new template category named "Localization", to be used for templates created by our l10n team for each locale, so that languages which requires special layout or formatting (such as CJK or CTL) can have their own templates bundled by default. This patch aslo adds a (general purpose) Writer template for the Simplified Chinese language. Chinese language, by convention, need to format the document to have the first line of the paragraph be indented by 2 characters. The font size, line spacing, paragraph margin etc also need special treatment. If the Chinese users start writing using the current default Writer template, they need to adjust the style formatting every time to meet their needs. Although this template can be provided as an "extension" on the extension website, in practice very few people will go to the extension website and look for such templates. Such bundled templates can also be added by other l10n teams. The extras/README.md will be updated in a separate patch to include documentation on how to add such templates and have their template names translatable on weblate. This does not completely resolve the issue in tdf#86483, which requests to "Implement different default templates per locale". However, with this patch, we are a step closer to set a choosen template when the user switch to a certain UI. Change-Id: Ic295482354f343e981eb20908907bd6a945b7120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140802 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2022-11-04tdf#143641 Fix UNO Object Inspector window titleAmarjargal Gundjalam
When detaching the "UNO Object Inspector" window, the title is "LibreOfficeDev 7.x", and not anything related to the window. This change fixes the window title. Change-Id: I3b7c3b547e59acd108b62a537ce7ff24162d745b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142053 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2022-11-04sw: fix merge mail to direct export as pdfHenry Castro
In order to export directly to PDF, the document must remove the hidden sections (if format condition), the data source should stay on current selected record finally restore the hidden sections. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Idf8e2a26d5c9cbe61ddac6c35cc2e1df1175da27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141520 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-03qa: remove duplicated codeXisco Fauli
Change-Id: I13da5ca9d07131a340dcf95ca0b980d75ca6e9d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142229 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-03Resolves: tdf#151112 move focus into container widget hierarchyCaolán McNamara
Change-Id: I5e5ca5a377f8e4c79ec8b2e4c2674be7ed0c10a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-03UnoApiXmlTest: add new wrapper for XmlTestTools testsXisco Fauli
Change-Id: I767f464ec666330a2e8e832b6d6f5736a6bef54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142228 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-02Simplify LokStarMathHelperMike Kaganski
SfxInPlaceClient seems to have everything needed to check the OLE bounds; OTOH, the embedded Math windows/widgets lack that info. Set SmGraphicWidget MapMode to pixels when lok is active, as other windows do. Change-Id: Ib9b76a51a2d9253c20b782e8c53fbfa5dc776eca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142130 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-02CppunitTest_sfx2_view: inherit from UnoApiTestXisco Fauli
Change-Id: I5a2d62fde3e14bdd47b4d7d3511a30cbd1629b19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142125 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01CppunitTest_sfx2_misc: inherit from UnoApiTestXisco Fauli
Change-Id: Ib3eff92f9e9e84afb3953991bd453ec5e9a4cef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142124 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01CppunitTest_sfx2_classification: inherit from UnoApiTestXisco Fauli
Change-Id: Iab05ead4aecc619c41cac7cfcfa8e3f57ef21601 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142123 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01CppunitTest_sfx2_doc: inherit from UnoApiTestXisco Fauli
Change-Id: Ic28ffe09bfc79ca3b254bd060f43eae289e7b488 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142122 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-28It's Frame-Controller-Model, not Model-View-ControllerMike Kaganski
Change-Id: I23a867623f77502baed6639ad3e255c06673d67f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-28Small simplificationMike Kaganski
Change-Id: I9aed483fd21b040c486526488917398aaafbe3a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141953 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-28Introduce utl::ConnectModelViewControllerMike Kaganski
And use it to avoid code duplication Change-Id: I18447bc1a0388d57a273b310977a0f0fb54152b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141946 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-26lok: support embedded mediaAshod Nakashian
Change-Id: Ie8f3ed188cec0050a10a5d49325756931b902ef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141807 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-25Address a constexpr template point of instantiation issueStephan Bergmann
...that hits at least when building with Clang and --with-latest-c++ against recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and more class template member functions constexpr). My understanding is that there is some leeway at what point a compiler should instantiate such function specializations, and Clang decides to instantiate constexpr ones early (cf. <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511> "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do not defer instantiations of constexpr functions" comment, and the discussion at <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>). > In file included from sfx2/source/dialog/templdlg.cxx:20: > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881: > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30: > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'ToolbarDropTarget' > static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type"); > ^~~~~~~~~~~ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<ToolbarDropTarget>::operator()' requested here > __ptr_.second()(__tmp); > ^ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<ToolbarDropTarget>::reset' requested here > _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); } > ^ > sfx2/source/dialog/templdlg.cxx:665:25: note: in instantiation of member function 'std::unique_ptr<ToolbarDropTarget>::~unique_ptr' requested here > SfxTemplateDialog_Impl::SfxTemplateDialog_Impl(SfxBindings* pB, SfxTemplatePanelControl* pDlgWindow) > ^ > sfx2/source/inc/templdgi.hxx:198:7: note: forward declaration of 'ToolbarDropTarget' > class ToolbarDropTarget; > ^ Change-Id: I360f35e01e301bca6fa801a889b6d107f67faf15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141818 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-25Address a constexpr template point of instantiation issueStephan Bergmann
...that hits at least when building with Clang and --with-latest-c++ against recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and more class template member functions constexpr). My understanding is that there is some leeway at what point a compiler should instantiate such function specializations, and Clang decides to instantiate constexpr ones early (cf. <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511> "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do not defer instantiations of constexpr functions" comment, and the discussion at <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>). > In file included from sfx2/source/dialog/StyleList.cxx:20: > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881: > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30: > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'TreeViewDropTarget' > static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type"); > ^~~~~~~~~~~ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<TreeViewDropTarget>::operator()' requested here > __ptr_.second()(__tmp); > ^ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<TreeViewDropTarget>::reset' requested here > _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); } > ^ > sfx2/source/dialog/StyleList.cxx:72:12: note: in instantiation of member function 'std::unique_ptr<TreeViewDropTarget>::~unique_ptr' requested here > StyleList::StyleList(weld::Builder* pBuilder, SfxBindings* pBindings, > ^ > sfx2/source/inc/StyleList.hxx:53:7: note: forward declaration of 'TreeViewDropTarget' > class TreeViewDropTarget; > ^ Change-Id: I30c0c21a7366a9f45d8b4ce7c61270dac804c0b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141817 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-24Drop Window::LogicMouse*Mike Kaganski
As mentioned in commit 510bca3d3ab0b2fd21f0083b4e0fe14ff8c903c3, over the time these functions were changed; now they don't take logical coordinates, but pixels, so became true duplicates of corresponding Mouse* functions. The calls to SetLastMousePos are now made from LOKPostAsyncEvent uniformly. Change-Id: I2c8a9095719c0c8e21cf81342a286b00c1d1a41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141693 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-22loplugin:unusedmethodsNoel Grandin
Change-Id: I3c94d68cb85adc2005a5a5e3b03a311732f782c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-21sfx2: avoid showing 2 dialogs in case WebDAV LOCK request failsMichael Stahl
... with 403 error code, which typically indicates read-only; one dialog is enough - also for the initial load of the document. (cherry picked from commit 855d62fc841abc62e0eca079e9b30f9d0888a93f) There is an Infobar anyway that the user can click to try again to edit the document, and if that fails there will be a dialog that offers opening a copy. If opening a file:// document writable fails and it is opened read-only, there is also no extra error dialog, just the Infobar, so this is making WebDAV more consistent. Change-Id: Ice62d167199f384b246b9d60dab4eed456a62288 (cherry picked from commit 48fa1f49d97ce04c9d3749ae02b2874af6477e82) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141620 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-10-21loplugin:unnecessaryvirtualNoel Grandin
Make the script filter out more external code Change-Id: I131da451e148e193552ead7c1441b06b726df619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141616 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-17loplugin:redundantcast look for redundant dynamic_cast<T&>Noel Grandin
Change-Id: If5a8e74b7ede80b782b584b4f62ec1b8713fd86d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141445 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-15ofz#52422 Build-FailureCaolán McNamara
Change-Id: I24aae3d273190cc936996c9d81d2c07d9e436193 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141418 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-14Start to fix the "BASIC Macros" dialog's "Assign..." buttonStephan Bergmann
c79212479f42cadd39173e77acc5e6446480ff05 "Fix a misuse of two-argument std string_view rfind" found that e.g. in Writer "Tools - Macros - Organize Macros - Basic...", in "Macro From" select "My Macros - Standard - Module1" and in "Existing Macros in: Module 1" select "Main", then "Assign..." had apparently rotten over time and brought up the "Customize" dialog's default "Menus" tab. With this fix, it now brings up the "Customize" dialog's "Keyboard" tab, in the "Category" tree list selects the appropriate "Module1" line, and in the "Function" list shows all the corresponding functions (just "Main" in this case). It doesn't yet select the appropriate line ("Main") in the "Function" list, though. That apparently needs further fixing. Change-Id: Ia5b9ef88d29e01f4f5e22ce3aec20f5fc22b5d45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141303 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-11Deduplicate O(U)StringConcatenationMike Kaganski
And use an overloaded helper function with a better (?) unified name to show that the result is not an O(U)String. Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-06tdf#150622 sidebar icons empty in High Contrast modeCaolán McNamara
Change-Id: Icfa78f0f655ee467c62cbc309b8e57ac310a73e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-06Resolves: tdf#150706 don't warn about user cancelling exportCaolán McNamara
Change-Id: Ibcc6efd8ae13d27aa66da57348efe5f06f67efb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-05tdf#115634 recent/favorite widgets not hidpi scaledCaolán McNamara
Change-Id: I65c74bd443b91827f62d46968ce8fda948fc6c26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140984 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-05Related: tdf#151351 don't use stack/highlight bg for buttonsCaolán McNamara
in favor of reworked flat button default rendering Change-Id: Id1d4b773aa0bf91be0386bd9db3bb212d422f216 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140980 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-05toggle state regardless of which toggle was usedCaolán McNamara
Change-Id: I43c295e2cc39497dba8812f1c9e296068d07a224 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-05tdf#151232 Fix lines in Special Characters dialog in dark modeRafael Lima
This patch makes the lines in the Special Characters dialog visible in dark mode. The Insert Symbols widget is also fixed with this patch. Tested in gen, gtk3 and kf5. Change-Id: Id1ee21557f2a0ea4ad8b60973d3de71e4d6d5d09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140759 Tested-by: Jenkins Reviewed-by: V, Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-10-04Templates: Make localized names for "Simple" and "BPMN" show on the UIKevin Suo
Currently there are 32 localized template name strings defined in: include/sfx2/strings.hrc. However, in sfx2/source/doc/doctempl.cxx only 30 were used. This makes STR_TEMPLATE_NAME31 ("Simple") and STR_TEMPLATE_NAME32 ("BPMN"), although already localized, not show up on the Template Manager UI. This patch adds these two strings in the sfx2/source/doc/doctempl.cxx, so that they properly show as localized strings on the UI. Change-Id: I64bb28cfe0a4d3b4b41c9114de7223014f6a3cfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140785 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2022-10-01tdf#132576 Remove unused template categoriesRafael Lima
This patch removes the names of template categories that are not used. None of these template category names are reachable via the Templates Manager nor via the Save as Template function. Change-Id: Ic2caf485106134de8554b93b5d6e14bdf7f382e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140610 Reviewed-by: Laurent Balland <laurent.balland@mailo.fr> Tested-by: Jenkins
2022-09-30tdf#143673 set an explicit drawing area bgCaolán McNamara
noticed in gtk darkmode on switching from initial application to start center Change-Id: I1cffab97ecd69ca6043531a6b2b5fc34b1ca84f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140789 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-29tdf#151197: Remove EmojiControlKhaled Hosny
Change-Id: I7fb423727425ec42d1161f6ac5649f5cac82f12f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140651 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-29tdf#55922: Remove redundant macOS dock icon menuKhaled Hosny
The File → Recent Documents is redundant since macOS shows recent document on the main dock icon menu. Change-Id: I644745309fb06f340fb871f3a5dba620c279e718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140721 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-29split utl::TempFile into fast and named variantsNoel Grandin
which makes it easier to know what each variant requires to stay on it's happy path Change-Id: I3275a2543573367714bc78092e882f6535507285 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-28Related tdf#132576 Fix "draw" string in Template Manager and make it ↵Rafael Lima
translatable The Templates Manager has a category name "draw" which cannot be translated. It also looks weird because all other categories have full names whereas this one is a lowercase string. The reason the word "draw" is used is because it is the name of the folder where the template is located. This patch maps a string "Drawings" to give a proper translatable name for this category. For this patch to take effect, the user needs to be on a fresh profile (or at least reset the user UI modifications). Change-Id: I2223dfe8761a5687b02e843957ebf7fb07f4a626 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140506 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
generated by cgit (git 2.34.1) at 2025-01-19 20:35:29 +0000