summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-02weld AddressBookSourceDialogCaolán McNamara
Change-Id: I3e83c41db04268b7370fdb7370f5b630419c6d4e Reviewed-on: https://gerrit.libreoffice.org/68622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-01weld SwInsertDBColAutoPilotCaolán McNamara
Change-Id: I5e46a88de2ff11ecd38667338b84babee24a2a11 Reviewed-on: https://gerrit.libreoffice.org/68591 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-01Use lambda instead of std::bind + wrapper functionStephan Bergmann
Change-Id: Id8912b8b1b454fbc6ef58ce4fc18a15e096e5cea Reviewed-on: https://gerrit.libreoffice.org/68494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-28Create the SfxRedactionHelper classMuhammet Kara
And move some code pieces, related to the redaction functionality, from objserv.cxx to the new SfxRedactionHelper.cxx file. Change-Id: I6491c9b581ea6d3a05a72117c5b72e1dc19025dc Reviewed-on: https://gerrit.libreoffice.org/68338 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-28remove some unused typedefsNoel Grandin
Change-Id: I7775a7d86e9641cd514e58f03d3727d2ad846120 Reviewed-on: https://gerrit.libreoffice.org/68485 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-28Use lambda instead of std::bind + wrapper functionSamuel Mehrbrodt
Change-Id: I7d51d09b78297442d07dd4ecbab7b5ce38d8ffee Reviewed-on: https://gerrit.libreoffice.org/68447 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-27weld LicenseDialogImplCaolán McNamara
Change-Id: I4b2dbd2446779e7179d2b79bf81cc2ff879377bf Reviewed-on: https://gerrit.libreoffice.org/68389 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27tdf#123728 Always print on main thread to avoid deadlocksSamuel Mehrbrodt
Change-Id: Ia8c2600aee42c3063e18032d1e485ad417ec4639 Reviewed-on: https://gerrit.libreoffice.org/68421 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-27loplugin:unnecessaryoverride look for more patternsNoel Grandin
like bool Foo::bar() { b = Super::bar(); return b; } Change-Id: I5e4c8005a3da7d7487c9039c35dcbb1d17e65bd7 Reviewed-on: https://gerrit.libreoffice.org/68418 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-26loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: I94689e4eed290b4505d2caba2d9802ef7fb6cffd Reviewed-on: https://gerrit.libreoffice.org/68378 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-24Fix unused parameter warning when !HAVE_FEATURE_SCRIPTINGTor Lillqvist
Change-Id: I221d11fd3bcd33e986b582a64cdba09e5af7c66d
2019-02-23Add style options to redaction exportMuhammet Kara
* Add 2 new uno command aliases to handle 2 different styles of redaction export/sanitization: * .uno:RedactedExportBlack & .uno:RedactedExportWhite * Replace the single export button with the 2 new buttons * Add a new toolbox names .uno:RedactedExportToolbox which consists of the new 2 commands. It will be added to the Redaction toolbar after we solve the icon issue. * Now new redaction shapes are named as RectangleRedactionShape or FreeformRedactionShape based on their type. * While exporting to PDF, a seamless step of "Sanitization" takes place, in which, all shapes in the Draw doc are traversed and turned into opaq black or white (with black border) shapes, then the whole doc is converted into bitmap (page by page). * After the export operation is completed. All shapes are converted back to the usual redaction style (gray and transparent). * Icon issue: * We need 2 new icons for our new commands, one for black redaction shapes without border, and one for white redaction shapes with black border. * I tried adding links to a current icon, but it didn't work, so they are iconless for now. * Next to do: Handle icon issue, and take the redaction implementation into a separate helper class because it is growing fast. Change-Id: I9b2b7716289b800cdbe7bf3ffa4a442fe5afc474 Reviewed-on: https://gerrit.libreoffice.org/68072 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-23tdf#102005 Fix F6 regression in start centerJim Raykowski
Change-Id: I152a79b79e75bf87c437dd4dd2976c73198e6b52 Reviewed-on: https://gerrit.libreoffice.org/68185 Tested-by: Jenkins Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-02-22weld SvxScriptSelectorDialogCaolán McNamara
Change-Id: I885acfcdfd9544d7f4eb0e602a7acf0215cb9d92 Reviewed-on: https://gerrit.libreoffice.org/68220 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-22loplugin:unusedfields in sfx2Noel Grandin
Change-Id: I92b25efa78e156c89a0532aec632a31ec2029e05 Reviewed-on: https://gerrit.libreoffice.org/68202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-22SfxProgress:SetStateText is deadNoel Grandin
since commit 83ee1bccf9899bb5c1913389b9a26a73a515ad82 Date: Fri Jul 22 09:19:52 2011 +0100 callcatcher: remove unused methods and even following the history back before that only shows one previous actual place where the state text was being displayed. Change-Id: Ib520cb6e999c1e11caf7348821bb274cdd785a44 Reviewed-on: https://gerrit.libreoffice.org/68198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-22weld SvxScriptOrgDialogCaolán McNamara
Change-Id: Ic196887e963bb96f330e47a7a507c143f95e7a61 Reviewed-on: https://gerrit.libreoffice.org/68204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-20tdf#123293 sfx2: fix metadata loss when loading from streamMichael Stahl
The problem is that when loading from a stream, there is no BaseURL and also no storage for the document. Due to the lack of BaseURL, the sfx2::createBaseURI() throws and loading RDF metadata fails, which also pops up an annoying warning dialog. Try to handle this in a similar way than a newly created document (see GetDMA()), by using the vnd.sun.star.tdoc scheme URL for the document; this however currently requires that the document has a XStorage, which is also not the case here. So add another UNO method to tdoc UCP's tdoc_ucp::ContentProvider, to split out the creation of the tdoc schema URL from the creation of the ucb Content, to get rid of the XStorage requirement. Change-Id: Ica62743f9d21db0b1464b70db1a62ebc61989ef8 Reviewed-on: https://gerrit.libreoffice.org/67882 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-20Use named shapes for redactionMuhammet Kara
Change-Id: Ibb55bd503d264b618c3fbebfdbcf3fe9958c6783 Reviewed-on: https://gerrit.libreoffice.org/68031 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-19Handle redaction finalization: BlackMuhammet Kara
Convert shapes on the document to black & opaque before sending it to the pdfexport filter. Convert them back to gray & transparent after the export operation. Change-Id: Iffe66e371710f16ef1c04f0da196fc5a561af344 Reviewed-on: https://gerrit.libreoffice.org/67517 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-19tdf#42949 Fix IWYU warnings in include/framework/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia9616f644a68ec6da22e646ba0d919a3489a9481 Reviewed-on: https://gerrit.libreoffice.org/67745 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-18Resolves: tdf#122355 search help for active notebook pageCaolán McNamara
before checking for the dialog, to get more specific help results. Change-Id: I2d6128fa39d3f7ebf15e194354307dd924590009 Reviewed-on: https://gerrit.libreoffice.org/67973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-18loplugin:simplifybool, check for !(!a op !b)Noel Grandin
Change-Id: Ic3ee9c05705817580633506498f848aac3ab7ba6 Reviewed-on: https://gerrit.libreoffice.org/67866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-17SfxFilter: truncate extensions list at first empty one...Matteo Casalin
... instead of rebuilding such list token by token until an empty extension is found Change-Id: Ib084b3064dccd1cf820bbb62ed47db03224b2161 Reviewed-on: https://gerrit.libreoffice.org/67631 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use optimized OUString concatenationMatteo Casalin
Change-Id: I61cbbf8613bd0a2221a8244cb76b10cf0e81a4a8 Reviewed-on: https://gerrit.libreoffice.org/67634 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-16drop newly unused codeCaolán McNamara
drop now unused ListBoxWrapper Change-Id: I19271de67269a9e23cf889a32910405cf3dc7a2a drop unused SingleControlWrapper Change-Id: I80bd639a9d64a1b35249c1c59c1c9d134ae6f1ca drop unused PosValueMapper Change-Id: I5e3d9ed48b5f544215ae82ba7899a62be4e59a25 drop unused ControlWrapperBase Change-Id: I1890f492604ac848775e8d4b0070a3189a719a18 drop now empty itemconnect.cxx Change-Id: I5374dbf91dbe715a563e7c694c9d96fb07d8f9c8 drop unnecessary controlwrapper.hxx Change-Id: Ide633f64ca2851aee4f29a7f86e09cb78043d388 Reviewed-on: https://gerrit.libreoffice.org/67887 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15Revert "tdf#49684 Don't focus on Navigator or Sidebar on show"Jim Raykowski
See tdf#122900 for unwanted behavior changed caused by this. This reverts commit 88cbc3ea2db8358bbedff01361f95f972f2b0231. Change-Id: I9451a4b1f059b40d33b66b06f23228fc64170d8d Reviewed-on: https://gerrit.libreoffice.org/67853 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-02-15loplugin:simplifybool extend to !(a == b) where comparison an overloaded opNoel Grandin
Change-Id: I08fcbe2569c07f5f97269ad861fa6d38f23a7cc7 Reviewed-on: https://gerrit.libreoffice.org/67816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-14weld DigitalSignaturesDialogCaolán McNamara
Change-Id: I197f4805558b07aeb9e66734d0fb5c250c41ad3e Reviewed-on: https://gerrit.libreoffice.org/67796 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14[API CHANGE] add setParentWindow to XDocumentDigitalSignaturesCaolán McNamara
so we can specify which window modal dialogs are modal to Change-Id: I7cd7348b5cd0f55d698553f313f745d5e0d6389d Reviewed-on: https://gerrit.libreoffice.org/67765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14getToken() already returns an empty string if index is negativeMatteo Casalin
Change-Id: Ibb9e866cc0a84973ee950630273f229362cb1bb6 Reviewed-on: https://gerrit.libreoffice.org/67635 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-14No need to downcast integer type hereMatteo Casalin
Change-Id: I99ed9bf6443c8b3c08d9ee45d171751d603c1125 Reviewed-on: https://gerrit.libreoffice.org/67633 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-13Use indexed getToken()Matteo Casalin
Change-Id: Ibd9d23b914645fdf52403c6c9d90a4058f2cf406 Reviewed-on: https://gerrit.libreoffice.org/67637 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-13Take advantage of indexed getToken()Matteo Casalin
Change-Id: Iac7b4caf58706e153981be7994cba1929520f44c Reviewed-on: https://gerrit.libreoffice.org/67636 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-13Use indexed getToken()Matteo Casalin
Change-Id: I070cd4903a1aae0c5b22f0991ebf274b8dc09974 Reviewed-on: https://gerrit.libreoffice.org/67632 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-13Execute indexOf() only if neededMatteo Casalin
Change-Id: Ib018761e35841a5128a2ef1a7318ce7fac448e5c Reviewed-on: https://gerrit.libreoffice.org/67630 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-13Use indexed getToken()Matteo Casalin
Change-Id: I393c53d7501afc6cd75a4c463031db94574b4ec7 Reviewed-on: https://gerrit.libreoffice.org/67629 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-13Use indexed getToken() and fix integer typeMatteo Casalin
nType was defined as sal_uInt32, but initialized by a toInt32 and provided to setAutoloadSecs() which accepts sal_Int32. Change-Id: I78eb5426ddab7726ee538005cc3aa732b66ce1bf Reviewed-on: https://gerrit.libreoffice.org/67628 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-11new loplugin writeonlyvarsNoel Grandin
largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11new loplugin indentationNoel Grandin
look for mixed indentation in compound statements, which makes them hard to read, and sometimes makes it look like a statement is associated with a nearby if/for Change-Id: Ic8429cee1f9a86d938097a4a8769a2bce97b3361 Reviewed-on: https://gerrit.libreoffice.org/63283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I4449fead67459bdcbdc0e9320129e7a5b36aecd9 Reviewed-on: https://gerrit.libreoffice.org/67545 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always trueMike Kaganski
Change-Id: I598ba9c49e919c3a521b3062c83b72a1c7949b9e Reviewed-on: https://gerrit.libreoffice.org/67540 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-09loplugin:indentation in sfx2..slideshowNoel Grandin
Change-Id: I3bd23a8f6237d0887a4782b6179a413dd2f03e02 Reviewed-on: https://gerrit.libreoffice.org/67564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-08Fix typoAndrea Gelmini
Change-Id: I58c8a755584c41f070a04fafe38720286b726d63 Reviewed-on: https://gerrit.libreoffice.org/67523 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-07Resolves: rhbz#1673198 cannot overwrite open file with exportCaolán McNamara
this reverts commit 3c4cfa209f446fc433c8d3925cbbe628c2f536e8 Date: Mon Nov 26 12:51:05 2007 +0000 INTEGRATION: CWS fwk72 (1.195.14); FILE MERGED 2007/09/10 14:55:01 mav 1.195.14.1: #i81437# do not allow to export to the file the document is based on Change-Id: I8bf1524a8cc2d6d1911bdd228f33f1b7723e1d6e Reviewed-on: https://gerrit.libreoffice.org/67491 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-07lok: intercept the UNO command ".uno:EditRegion"Henry Castro
Change-Id: I3a1072e6ededbd0322c4b1dcd0ef4b16ace219d1 Reviewed-on: https://gerrit.libreoffice.org/67478 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 32555d9b5c9ef37276984eaa9d9b84007fd02038) Reviewed-on: https://gerrit.libreoffice.org/67482 Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-03 09:49:58 +0000