summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2013-11-13expand out the A2S macroNoel Grandin
Which is not doing anything useful anymore. Change-Id: I83422e811d52a77b65655924c07b55dd7229449c
2013-11-12reorient ok/cancel buttons to normal positionsCaolán McNamara
Change-Id: If562d09862cf8fee2c64e6c1b0c90f5b6527b6df
2013-11-12Convert New Style dialog to widget UIManal Alhassoun
Change-Id: Idaea69f674e1e84e3e1e649006c2d92176897fe0 Reviewed-on: https://gerrit.libreoffice.org/6607 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-12less if-nesting in ThumnailViewRodolfo Ribeiro Gomes
Easier to read. Change-Id: I1ceb551d8badffb211b1f444b61375a03cac1348 Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/6643 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-11-11sfx2: include <> for external includesNorbert Thiebaud
Change-Id: I63de4bc034020d19abd20f301194482da9a604f4
2013-11-11startcenter: Don't create the Image with every paint.Jan Holesovsky
Change-Id: I90fa5aff94de38d950a78811dad301b91ced89f3
2013-11-11startcenter: Paint either the welcome, or the recent docs.Jan Holesovsky
Otherwise the background will paint over the graphics... Change-Id: Ic62c563026daa9c4173148cd68652d8aba608089
2013-11-11startcenter: Start center shows a welcome text when recent doc list is emptyRodolfo Ribeiro Gomes
The image I got from TDF wiki. I tried to show the text semitransparent also, but set font color with any alpha degree (eg. setTransparency(254) ) made it invisible. Maybe just a gray shade? Change-Id: Iaf7efb8433e9db03862825148ed2013588a5468f Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com>
2013-11-11SAL_WARN_UNUSED INetURLObjectStephan Bergmann
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
2013-11-11Destroy SfxAllItemSet before calling framework::Desktop::terminateStephan Bergmann
...otherwise running e.g. "soffice slot:5410" would crash with > Invalid read of size 8 > at 0x712DCCC: SfxItemSet::~SfxItemSet() (svl/source/items/itemset.cxx:317) > by 0x65B4990: SfxAllItemSet::~SfxAllItemSet() (include/svl/itemset.hxx:166) > by 0x65B2CC4: SfxAllItemSet::~SfxAllItemSet() (include/svl/itemset.hxx:166) > by 0x674CD94: SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:784) > by 0x674CF46: SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:376) > by 0x674D03E: non-virtual thunk to SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:378) > by 0x4F21028: desktop::DispatchWatcher::executeDispatchRequests(std::__debug::vector<desktop::DispatchWatcher::DispatchRequest, std::allocator<desktop::DispatchWatcher::DispatchRequest> > const&, bool) (desktop/source/app/dispatchwatcher.cxx:581) > by 0x4F2CDB3: desktop::OfficeIPCThread::ExecuteCmdLineRequests(desktop::ProcessDocumentsRequest&) (desktop/source/app/officeipcthread.cxx:1061) > by 0x4EE3159: desktop::Desktop::OpenClients() (desktop/source/app/app.cxx:2493) > by 0x4EE14E7: desktop::Desktop::OpenClients_Impl(void*) (desktop/source/app/app.cxx:2012) > by 0x4EE0127: desktop::Desktop::LinkStubOpenClients_Impl(void*, void*) (desktop/source/app/app.cxx:2007) > by 0x927B9E6: Link::Call(void*) const (include/tools/link.hxx:123) > by 0x999AD8F: ImplHandleUserEvent(ImplSVEvent*) (vcl/source/window/winproc.cxx:1976) > by 0x9997E64: ImplWindowFrameProc(Window*, SalFrame*, unsigned short, void const*) (vcl/source/window/winproc.cxx:2591) > by 0x99ADCFC: SalFrame::CallCallback(unsigned short, void const*) const (vcl/inc/salframe.hxx:243) > by 0x99ACD47: SalGenericDisplay::DispatchInternalEvent() (vcl/generic/app/gendisp.cxx:91) > by 0x1783C027: GtkData::userEventFn(void*) (vcl/unx/gtk/app/gtkdata.cxx:935) > by 0x1783C13D: call_userEventFn(void*) (vcl/unx/gtk/app/gtkdata.cxx:945) > by 0x37B6847E05: g_main_context_dispatch (usr/src/debug/glib-2.36.3/glib/gmain.c:3054) > by 0x37B6848157: g_main_context_iterate.isra.22 (usr/src/debug/glib-2.36.3/glib/gmain.c:3701) > by 0x37B68481FB: g_main_context_iteration (usr/src/debug/glib-2.36.3/glib/gmain.c:3762) > by 0x1783AC3F: GtkData::Yield(bool, bool) (vcl/unx/gtk/app/gtkdata.cxx:576) > by 0x1783FEF6: GtkInstance::Yield(bool, bool) (vcl/unx/gtk/app/gtkinst.cxx:425) > by 0x9299F40: ImplYield(bool, bool) (vcl/source/app/svapp.cxx:364) > by 0x9295B52: Application::Yield() (vcl/source/app/svapp.cxx:396) > by 0x9295B1F: Application::Execute() (vcl/source/app/svapp.cxx:345) > by 0x4EDE2C9: desktop::Desktop::Main() (desktop/source/app/app.cxx:1715) > by 0x92A6397: ImplSVMain() (vcl/source/app/svmain.cxx:162) > by 0x92A7B55: SVMain() (vcl/source/app/svmain.cxx:198) > by 0x4F35980: soffice_main (desktop/source/app/sofficemain.cxx:85) > by 0x40098C: sal_main (desktop/source/app/main.c:48) > by 0x400966: main (desktop/source/app/main.c:47) > Address 0x1d719700 is 0 bytes inside a block of size 32 free'd > at 0x4A078DE: operator delete(void*) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) > by 0x6A02EA1: CntItemPool::~CntItemPool() (sfx2/source/explorer/nochaos.cxx:123) > by 0x6A02C85: CntItemPool::Release() (sfx2/source/explorer/nochaos.cxx:154) > by 0x6A02BF8: NoChaos::ReleaseItemPool() (sfx2/source/explorer/nochaos.cxx:89) > by 0x65E1A31: SfxApplication::Deinitialize() (sfx2/source/appl/appquit.cxx:147) > by 0x65A29B0: SfxApplication::~SfxApplication() (sfx2/source/appl/app.cxx:242) > by 0x65A2828: SfxApplication::~SfxApplication() (sfx2/source/appl/app.cxx:223) > by 0x65C021C: SfxTerminateListener_Impl::notifyTermination(com::sun::star::lang::EventObject const&) (sfx2/source/appl/appinit.cxx:121) > by 0x65C033E: non-virtual thunk to SfxTerminateListener_Impl::notifyTermination(com::sun::star::lang::EventObject const&) (sfx2/source/appl/appinit.cxx:123) > by 0x1F176DD2: framework::Desktop::terminate() (framework/source/services/desktop.cxx:353) > by 0x1F177E1B: non-virtual thunk to framework::Desktop::terminate() (framework/source/services/desktop.cxx:357) > by 0x4F217FD: desktop::DispatchWatcher::dispatchFinished(com::sun::star::frame::DispatchResultEvent const&) (desktop/source/app/dispatchwatcher.cxx:637) > by 0x4F2190E: non-virtual thunk to desktop::DispatchWatcher::dispatchFinished(com::sun::star::frame::DispatchResultEvent const&) (desktop/source/app/dispatchwatcher.cxx:640) > by 0x674CD77: SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (sfx2/source/control/unoctitm.cxx:782) > ... Change-Id: I6b4fb9b6f0d2afc9caecf3dd5355d11edb6abbe8
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11convert OUString 0==compareToAscii to equalsAsciiNoel Grandin
Convert code like: 0 == aStr.compareToAscii("XXX") to aStr.equalsAscii("XXX") which is both clearer and faster. Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-10ThumbnailView: item found by mouse pos is always visibleRodolfo Ribeiro Gomes
-- so it does not need to check it again Change-Id: Id6fc2732bde8dd7f6011828b6bc29d7947bf6312 Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/6629 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2013-11-08Unwind SFX_REFERER_USERStephan Bergmann
...and remove remaining unused content of sfx2/source/inc/referers.hxx. Change-Id: I5c533f63e13da930f6944af0e85d4b061c30e5b0
2013-11-08Clean up IsSecureURLStephan Bergmann
...to not use WildCard (in case a trusted location URI already contains an unescaped "*"), be specific about matching only past a final "/", and rename to isSecureMacroUri for clarification. The check with an INET_PROT_NOT_VALID default INetURLObject in SfxApplication::OpenDocExec_Impl ("we have to check the referer before executing") had efficiently been dead since its inception in 14237ac4bf497decdde8b742acea23780833ba12 "#90880#: security checks corrected," as INET_PROT_NOT_VALID is considered secure regardless of referer anyway. Change-Id: I03bca5e6dac89bb2aac52909aff273ea640228d8
2013-11-08Make INetURLObject-from-OUString ctor explicitStephan Bergmann
...and clean up call sites. Change-Id: I7219a33652835e82fdc44e9e801a7e62868e4f38
2013-11-08remove unnecessary use of OUString constructor in SFX2 moduleNoel Grandin
Change-Id: Ieafc413136a9b4b907de034914d918212e4c16e3
2013-11-07single-click for open recent documents in new Start CenterRodolfo Ribeiro Gomes
Change-Id: I34c6a5f9057707cdd1e2f4f82024818e7c8a6630 Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/6610 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2013-11-07CMIS Versions dialog is experimental-only for the whileCédric Bosdonnat
Change-Id: I39e2f3437045ae0ef7b33c65bb59f9fe201dcda7
2013-11-07CMIS Versions: removed a few useless buttonsCédric Bosdonnat
Change-Id: I08a1593700495c2262a270cb9055e973ab0ede29
2013-11-07fdo#63020: Replace ::comphelper::stl_begin()...Marcos Paulo de Souza
And use some templates inside include/com/sun/star/uno/Sequence.hxx Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47 Reviewed-on: https://gerrit.libreoffice.org/6599 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-06Drop unnecessary #includesTakeshi Abe
Change-Id: I9659279233067a8946a9e54be2f22439854a961e
2013-11-06convert xub_StrLen to sal_Int32Noel Grandin
convert various module-local functions Change-Id: I89f3eb40b107e2617958e474ffe86bd73e01cf33
2013-11-05update pchThomas Arnhold
Change-Id: I10f3dbd9513052b3bbe30ddc6523cd231f26ded3
2013-11-04fdo#68099 Move pdf viewer call to GUI related codeMaxim Monastirsky
This change fixes two bugs: 1) In it's old location at PDFFilter::implExport, the pdf viewer is called *before* the final file is actually written. It causes a problem under Windows, because we use ShellExecute function which fails if the file doesn't exist. Calling a function blocks execution, so we have no chance to write the file before that function fails. (fdo#68099) 2) Being a part of the saving/filter code means that the pdf viewer will open even when converting to a pdf in headless mode. It's definitely not something that we want to happen. Change-Id: I1a6f70ec76100ac9e008869aa57ad738ced3ab6c Reviewed-on: https://gerrit.libreoffice.org/6565 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-04fdo 70998: Termchange: Graphics->ImageSamuel Mehrbrodt
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38 Reviewed-on: https://gerrit.libreoffice.org/6524 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04remove redundant calls to OUString constructorNoel Grandin
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-03cppcheck: Reduce scopeJulien Nabet
Change-Id: I341c2b7112f32a0ab0e1a6dfac0ab4679310202c
2013-11-03SfxFrameLoader_Impl::impl_getStaticSupportedServiceNames() silly mutexMichael Stahl
Change-Id: I5b9ffed3527b5be544a7aa57f67840d30b4ebff5
2013-11-02don't warn for empty VBA structure, fdo#61059Markus Mohrhard
Change-Id: I0d0f7fa216fcea7ca893120ad183dc3758ca51d4
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-30fix indentationMatúš Kukan
Change-Id: I41c9e96e2202f1dc52ed93c03846d4d37ae6c2cb
2013-10-29startcenter: Tweak StartCenter buttons and hotkeysKrisztian Pinter
Change-Id: Ica8bf110c3a76c47417a77488657e08ee2456ac7 Reviewed-on: https://gerrit.libreoffice.org/6312 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-29Related: fdo#67461 consider hierarchical viewCaolán McNamara
check for pTreeBox in the show/hide cases. assume pTreeBox means single-select hierarchical mode (select a few things in list mode, then switch to hierarchical view, it doesn't make sense then to care what is selected in the hidden list view) Change-Id: I8ee08e578e66e14d8dea6cd7a66c1dbbbedcd6d1
2013-10-29fdo#67461 add multiple selection support to hide/show multiple stylesJoren De Cuyper
With commit 439ac45925039aa7a537feedab3e731e8a60a8e5 I only add support to delete multiple styles. Hereby I add the possibility to hide and show multiple styles too. Change-Id: I46a8400c281c87b2881367f89ee92db2ba77bfb2 Reviewed-on: https://gerrit.libreoffice.org/5935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-28fixincludeguards.sh: sfx2Thomas Arnhold
Change-Id: I135d03fa8926e0fdba977005e97452045861b2a4
2013-10-28remove local css namespace definitionsThomas Arnhold
As we have it globally in sal/types.h those are not necessary. Change-Id: I18bba2c763c4680c4fa7fde4c5158953b5cfad82
2013-10-23clean up some include guardsThomas Arnhold
Conflicts: sw/source/ui/inc/content.hxx Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6 Reviewed-on: https://gerrit.libreoffice.org/6388 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-23convert code to use OUString::endsWithNoel Grandin
Convert places that call aStr[aStr.getLength()-1] == 'x' to use the shorter form aStr.endsWith("x") Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-22sfx2: remove obsolete redefinitions of Win32 UINT64 etc. typesMichael Stahl
Change-Id: I6b7acb44c16bcf4d3f8bcc338cb785fb7262eae6
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22vcl: mark more Image constructors as "explicit"Michael Stahl
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22Remove unused SfxObjectShell::bIsTmpStephan Bergmann
Change-Id: I14b495067e25e9a80c08b08ff2034b7bfe1e6759
2013-10-22fdo#54938: Adapt supportsService implementations..Marcos Paulo de Souza
to cppu::supportsService Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14 Reviewed-on: https://gerrit.libreoffice.org/6370 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-22Remove unused SfxObjectShell_Impl::bIsTmpStephan Bergmann
Change-Id: I4040d4758a3753c2177aa2a7d3dba6c85b089b25
2013-10-21Remove comphelper::ComponentContextStephan Bergmann
Change-Id: Idc5974e5a2ec68e8f1b2312a88fab15092c82788
2013-10-21remove uses of COMPARE_*Caolán McNamara
Change-Id: Icdc36b4b24d2f399f481065df3200feb98025135
2013-10-21fdo#68849 add some header guardsThomas Arnhold
Change-Id: I9d25a58f22095689eccc0ac444c163d1e9bee69f Reviewed-on: https://gerrit.libreoffice.org/6364 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
generated by cgit (git 2.34.1) at 2025-01-22 20:46:30 +0000