summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2018-12-12tdf#122009: Hide notebookbar in full screenXisco Fauli
Follow same logic as in presentation mode. See 6a9326803c01f4c9bc7da855053ce4e80646fad8 Change-Id: I89c31e23dd97e647ab380aa30635acda46064b2f Reviewed-on: https://gerrit.libreoffice.org/64911 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-12-12use unique_ptr in SfxChildWinContextCtorNoel Grandin
Change-Id: I5ad26f30704708aac42f2c48fa38382c38f98b2a Reviewed-on: https://gerrit.libreoffice.org/64998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12use unique_ptr in SfxChildWinCtorNoel Grandin
Change-Id: I155036f6a47c765595938ff325ede6bbe6dd5c48 Reviewed-on: https://gerrit.libreoffice.org/65000 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12use unique_ptr for SfxChildWinFactoryNoel Grandin
Change-Id: I4305310ea296a5326838759742b14e687158d426 Reviewed-on: https://gerrit.libreoffice.org/64954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-11use unique_ptr for SfxChildWinContextFactoryNoel Grandin
Change-Id: Id0e30c5e591e7fb4b21fb55d47d15a5936fe1374 Reviewed-on: https://gerrit.libreoffice.org/64934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-08use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-08Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann
...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-08crashtesting: doubly deleted reloadtimerCaolán McNamara
since... commit 0cc702232e4799f03a468d1e8014d050a683165e Date: Tue Dec 4 15:00:43 2018 +0200 use unique_ptr in SfxObjectShell_Impl Change-Id: I3f3b0514bdb87f59d9c5f34d2d36dc63e8b1e33d Reviewed-on: https://gerrit.libreoffice.org/64527 Change-Id: I00e2cd2bcbb9a252a45d31da650e327506d2990d Reviewed-on: https://gerrit.libreoffice.org/64780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07loplugin:singlevalfields extend to all static varsNoel Grandin
Change-Id: Ic238bb5291539fd1b7e98cb4afc9b25f37e7d528 Reviewed-on: https://gerrit.libreoffice.org/64710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05loplugin:singlevalfields in svlNoel Grandin
Change-Id: I26d11f60f486f3cfe4615828a410789f8e22af48 Reviewed-on: https://gerrit.libreoffice.org/64602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05remove unused SfxCallMode enum valueNoel Grandin
Change-Id: Ie092724ac22088d607f6250fbed764269b3707ba Reviewed-on: https://gerrit.libreoffice.org/64571 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SfxBaseModel::storeSelfNoel Grandin
Change-Id: I73524a15b5ac33ee6243a2e0e563b9986e887e40 Reviewed-on: https://gerrit.libreoffice.org/64528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SfxObjectShell_ImplNoel Grandin
Change-Id: I3f3b0514bdb87f59d9c5f34d2d36dc63e8b1e33d Reviewed-on: https://gerrit.libreoffice.org/64527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SfxViewFrame::ExecReload_ImplNoel Grandin
Change-Id: I35a8a3a6ccbf811e529f761f840bfc7acf870056 Reviewed-on: https://gerrit.libreoffice.org/64526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05loplugin:unnecessaryparen include more assignmentsNoel Grandin
Change-Id: I9fb8366634b31230b732dd38a98f800075529714 Reviewed-on: https://gerrit.libreoffice.org/64510 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-04Resolves: tdf#121641 properties invisible after 'reset'Caolán McNamara
Change-Id: Iedb2b11be0e008501273925d6ae7137b28c3b912 Reviewed-on: https://gerrit.libreoffice.org/64537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-04tdf#34171: check foreign lockfiles to tell who has locked documentMike Kaganski
MS Office (Word/Excel/PowerPoint) lockfiles are supported now. Note that Excel does *not* create lockfiles for pre-OOXML files. This changes osl_openFile implementation on Windows, to treat osl_File_OpenFlag_NoLock to also include FILE_SHARE_DELETE flag for CreateFileW. This is required to allow opening files created with FILE_FLAG_DELETE_ON_CLOSE flag, such as Excel's owner files. The shange should be consistent with the overall meaning of the osl_File_OpenFlag_NoLock to not impose any locking constraints to the file being opened. Change-Id: I7b99012f4bd60ab3821fb91d5166a286031b7e93 Reviewed-on: https://gerrit.libreoffice.org/64496 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-04Infobar showing donation alternating with getinvolvedheiko tietze
Change-Id: Ia103201667c3469071f19450589bd22faf3ae80e Reviewed-on: https://gerrit.libreoffice.org/63883 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-12-04weld OfaAutoCorrDlgCaolán McNamara
Change-Id: Iba217a2998de57bf963872f9b8c1cf38694eb935 Reviewed-on: https://gerrit.libreoffice.org/64476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-04remove unused DataChangedEventType enum valueNoel Grandin
Change-Id: I32d3c3481f0b8bcc36613afb495b64f4eb229a67 Reviewed-on: https://gerrit.libreoffice.org/64484 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-04remove unused MouseNotifyEvent enum valuesNoel Grandin
Change-Id: I3d007287daf82a96e6aead6d75d81ef3e1a6f267 Reviewed-on: https://gerrit.libreoffice.org/64483 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-04remove unused enum SfxObjectShellFlagsNoel Grandin
Change-Id: I594e7beb3fb320b70ffe4dd98fee46c833f443dc Reviewed-on: https://gerrit.libreoffice.org/64453 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-03tdf#42949 Fix IWYU warnings in include/vcl/[n-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I5a4951e983078ab6b6cbf0e96b00a20584b85e20 Reviewed-on: https://gerrit.libreoffice.org/64398 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-03Fix undocking sidebar with tab bar menu undock locks focusJim Raykowski
Missed this in I91194db3cc23a24e805a90edaf1566f950ac129d Change-Id: I9a9bb3cb47b19929577f4ee36206ea1c052adeca Reviewed-on: https://gerrit.libreoffice.org/62833 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-12-03sfx2: Combine metadata graph lookup and filteringAshod Nakashian
The graph lookup is suprisingly costly and so is filtering. By specializing the lookup with filtering the logic is more readable and slightly faster (~35% in debug build). Change-Id: Id35a562c76a84a81362f47b61ed67fb74d0a6dc7 Reviewed-on: https://gerrit.libreoffice.org/63001 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-12-01Simplify containers iterations in sfx2, shellArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I42361d6a73d201db8eb6dca09d79768e2d62051d Reviewed-on: https://gerrit.libreoffice.org/64389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-01sfx2: fix Android build, check HAVE_FEATURE_MULTIUSER_ENVIRONMENTMichael Stahl
Change-Id: I2d78f35898cc514b20500018a7d360e3c78127aa
2018-12-01lokit: disable triggering of GUI when changing a signed docTomaž Vajngerl
When a signed document is changed and saved, the dialog pops up on the GUI to warn that the signature will be removed. When saving over the lokit this dialog isn't shown and assumes that we don't want to save (throws an exception) which means we can't save the document ever. This changes the behavior so that we allow removal of the signature and saving can proceed. Change-Id: I52e4a53f0cd3a326c767daee6301a78122af09d4 Reviewed-on: https://gerrit.libreoffice.org/64293 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-01Option to turn off WebDAV file lockingKatarina Behrens
Locking files on WebDAV shares was implemented in tdf#82744, in particular: commit 26e6d4b05ab444e6a7529ffcac7fbe592fc94833 tdf#82744: fix WebDAV lock/unlock behaviour - part 1 commit bc9a8ddbb7081f79e915c841e56fd1c40f0df6f9 tdf#82744: fix WebDAV lock/unlock behaviour - part 2 commit b4576f3da4d90139fc5140962d13cb91dab98797 tdf#82744: fix WebDAV lock/unlock behaviour - part 3 commit fed2984281a85a5a2f308841ec810f218c75f2ab tdf#82744: fix WebDAV lock/unlock behaviour - part 4 Before that, files on WebDAV shares were accessed w/o locking since the beginning of [OOo] time. This option allows to revert to the old behaviour i.e. non-locking WebDAV access. For concurrent read-write WebDAV access by multiple users it is recommended to keep UseWebDAVFileLocking at default value (true) Change-Id: Id92177631d4854d6c7bf412164acbd9740db9592 Reviewed-on: https://gerrit.libreoffice.org/64116 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-30loplugin:unusedmethodsNoel Grandin
Change-Id: Id0d68d659fa06a8230ed0d927b85b6b504525d1e Reviewed-on: https://gerrit.libreoffice.org/64328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30remove unused HeaderBarItemBits enum valuesNoel Grandin
Change-Id: I84752cb9d683cb22c96d91cc54d7c4dc474603fc Reviewed-on: https://gerrit.libreoffice.org/64269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30Revert "Revert "Notebookbar:Disabled appearence of context toolbars""Mike Kaganski
This reverts commit 9a6169529eb687190531225bfe9fef850325ee9e now that proper fix for both tdf#121591 and tdf#119945 is pushed - see commit 0a36be3fee1b4f1b47b55a64668b6aa99896ab24. Change-Id: Ia44510d427e0626a5f566210247db8848653f8e2 Reviewed-on: https://gerrit.libreoffice.org/64279 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-30tdf#93005, tdf#100611, remove the incomplete ODC export featureMarkus Mohrhard
Change-Id: I96a3882cd412ea5d993971df7e20b1fd8da73642 Reviewed-on: https://gerrit.libreoffice.org/64283 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-29tdf#121591, tdf#119945: ModuleManager::identify throws for embedded modulesMike Kaganski
Change-Id: Ief1a664fdf26c837fd55c9a236f45aa045067309 Reviewed-on: https://gerrit.libreoffice.org/64256 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-29Adds print even pages/print odd pages options in print dialogDaniel Silva
Change-Id: I17733d83cc652be8c5abaf20cd4b5e23d3a577a1 Reviewed-on: https://gerrit.libreoffice.org/57380 Tested-by: Jenkins Reviewed-by: Daniel Silva <danielfaleirosilva@gmail.com>
2018-11-29Rename Mac OS X to official name macOS in comments and documentationBartosz Kosiorek
Change-Id: I651b7f202fa52ff5f5357a11aa72c43eb7dc7f95 Reviewed-on: https://gerrit.libreoffice.org/64102 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-29tdf#42949 Fix IWYU warnings in include/vcl/[i-m]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If1b2e04872eb0dd6725802c1709a9085f4cd8c91 Reviewed-on: https://gerrit.libreoffice.org/64141 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-29remove unnecessary "if (!empty()" checks before loopsNoel Grandin
found with git grep -n -A4 'if.*!.*empty' | grep -B3 -P '(\bfor)|(\bwhile)|(\bdo)' Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334 Reviewed-on: https://gerrit.libreoffice.org/64169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28loplugin:unusedfieldsNoel Grandin
Change-Id: Iffbb4e7107a0b1ae35c879c193a9ec209addf453 Reviewed-on: https://gerrit.libreoffice.org/64144 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28loplugin:unusedmethodsNoel Grandin
Change-Id: Idbdf2d5d12fad894a3dfc3a86cae839502f42cf6 Reviewed-on: https://gerrit.libreoffice.org/64114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I3e6424e10eade04951f8ab24bb61af4ce19d1204 Reviewed-on: https://gerrit.libreoffice.org/64113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused SfxObjectShellFlags enum valuesNoel Grandin
Change-Id: I945047c0955bc66602d1a5033197a7405a69a8d3 Reviewed-on: https://gerrit.libreoffice.org/64089 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused SfxViewShellFlags enum valueNoel Grandin
Change-Id: Ie754752203dcb066c69dff6effb835d7e1db1753 Reviewed-on: https://gerrit.libreoffice.org/64088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27tdf#42949 Fix IWYU warnings in include/vcl/[f-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ice2eb8c5994bf2ccb88972332ca4a1d3ed41752a Reviewed-on: https://gerrit.libreoffice.org/63826 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-26sfx2: show partial signatures even if cert validation failsMiklos Vajna
Change-Id: I6060b7130827346ac5d6955bf38ebe3b476819fd Reviewed-on: https://gerrit.libreoffice.org/64022 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-26weld SfxCmisVersionsDialogCaolán McNamara
Change-Id: I73fc8ba88021f3d1450d10a75970e1fd58f26c3f Reviewed-on: https://gerrit.libreoffice.org/64002 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26drop unnecessary includesCaolán McNamara
Change-Id: I5305722d88ed947cbaf8015fc85d6b52900b7b75 Reviewed-on: https://gerrit.libreoffice.org/64003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26weld SfxVersionDialogCaolán McNamara
Change-Id: I0b69192a6eab9dadac892968a4a2d4fa3d9febde Reviewed-on: https://gerrit.libreoffice.org/64001 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I1ac4c52ea51503373644bc58dcd4395c69f1a675 Reviewed-on: https://gerrit.libreoffice.org/64007 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-14 05:49:43 +0000