summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2023-01-13sfx2 lok: conditionally revert CreateBackup changesMiklos Vajna
This was enabled by default in commit 5cb7fed2a5a02ff1cb4551752a0bd8d3001a1f22 (tdf#152463 Turn on AutoSave and Backup by default, 2022-12-12), and it makes sense on the desktop, but this breaks LOK clients, e.g. online.git unit-wopi-save-on-exit. Keep the desktop case unchanged, but disable it again for the LOK case to make the failing test pass again. Change-Id: I3a7eed8fdd6d394e9c7e75a477cbc11a6f40f7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145426 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-13Resolves tdf#119919 - Show hidden children in Stylist when in tree modeHeiko Tietze
To avoid styles appearing on root if their parent is hidden (eg. Heading hidden, Heading 1 moves under root), the Stylist shows all styles but with disabled color for the hidden styles Change-Id: Iec73a3010ab05d01e9b7209d81f1f03c1355ef49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145324 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-12tdf#152921 Fix sidebar tabbar tab highlightingJim Raykowski
Makes the highlight state of the tabbar tab behave as expected when the sidebar is in the collapsed or expanded state. When collapsed, the tabbar should never have a highlighted tab. When expanded, the tab in the tabbar corrosponding to the open deck should be highlighted. Change-Id: I0e6c54aff95b1f1e417f147070742e900fd51513 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145251 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-01-11tdf#152905 Use "Edit Style" instead of "Modify" for consistencyRafael Lima
As discussed in the bug report, the context menu in the "Styles" sidebar is the only place where the string "Modify..." is used to edit a style, whereas other places use "Edit Style...". Hence, let's use it here as well for consistency. Change-Id: I3244da70873dc62c302baacd614f9ada2cfe5cc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145233 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-06Fix copy/paste typosStephan Bergmann
...apparently introduced in 4883fd31141c3598b25a123033297f847cd18552 "weld ScTabBgColorDlg" and 3e078e17ee2144fb976a7e6b9227152113cea0d4 "weld SfxTemplateManagerDlg", resp. Change-Id: I08dd6df262d12bc844a992d6e13b9732860e74bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145159 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-06tdf#86630 sw: Add one-step page number insertion wizardofftkp
Add a one-step wizard for easy insertion of the page number to the header/footer. Change-Id: Idb33c92d594e04d9256460fe414e4b10e5166af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144683 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-05Revert all the recent loplugin:unocast changesStephan Bergmann
...as obsoleted by ef533553559fe09b4afab651fc692885d1acf4ed "Rudimentary support for dynamic_cast on UNO proxy objects". This reverts all of: 4cfcc9ac37b90ce64c8402a41eb4638adb185b5c "loplugin:unocast (framework::Desktop)" 03efbf72f4ddf7a84aa8aabef348331bd4b75e8a "loplugin:unocast (vclcanvas::TextLayout)" 80099fdd51a69eaa6c36ca88ef772810e4a777fa "loplugin:unocast (SalGtkXWindow)" cc147f576d8687fb79c77d47d41dc4ba1678a469 "loplugin:unocast (sdext::presenter::CachablePresenterView)" 40db42be1d8fd0f9c6c8c5ba3767ddb9ee2034c2 "loplugin:unocast (vclcanvas::CanvasFont)" 2d1e7995eae29e2826449eb5179f5fae181794a5 "loplugin:unocast (CairoColorSpace)" 4c0bbe4bd97636207cf71a6aa120c67698891da9 "loplugin:unocast (canvas::ParametricPolyPolygon)" 89803666621c07d1b1ac9d3bd883f0ca192a91a0 "loplugin:unocast (vclcanas::CanvasBitmap)" d5e0c2c8db71878d21c2a7255af08cf5f9a6dd04 "loplugin:unocast (sfx2::DigitalSignatures)" c0c4519e0d5b555f59bbc04cc616454edfd1f4ce "loplugin:unocast (VCLXAccessibleComponent)" feb8b833a6245d42400f42a0bc789dc84594ee6f "loplugin:unocast (VCLXDialog)" 1fa58cc6cc9c3849753342a5d9a6ddfa461b5e66 "loplugin:unocast (VCLXMultiPage)" f481f036deb1b1b46f3038074c4659f3a91b9c6c "loplugin:unocast (DocumentSettingsSerializer)" 73df933f5fa5932f94e5a1b338a3eda00a9ce354 "loplugin:unocast (css::embed::EmbeddedUpdate)" 420165ab0ef03c0467f9d17f504de2d2fc78f0e6 "loplugin:unocast (canvas::tools' StandardColorSpace, StandardNoAlphaColorSpace)" 9abe8ee067e6c00f19d8a13346d53c4641c27166 "loplugin:unocast (MutableTreeNode)" 9f3022ceb036f23b4b0994c3e2fbd1001bff225a "loplugin:unocast (VCLXTabPage)" 1be70dda02c12a60778b7607cff2520ae1aa611e "loplugin:unocast (vcl::unotools::VclCanvasBitmap)" d6a70bb641b96e8e5616448c2378131ed62658b4 "loplugin:unocast (basegfx::unotools::UnoPolyPolygon)" 5a14f009e6782c077463c8cbb8e9cea3d7950107 "loplugin:unocast (xmlsecurity::Certificate)" 99009c9535dfa3e0d838989ccc7d84bfa2320ff4 "loplugin:unocast (sd::Annotation)" 0c7585c5fa78887e5459885ed744e8044fd76137 "loplugin:unocast (sd::TextApiObject)" 24e14afd1bfcaed6c200ab081973fba7e47267ca "loplugin:unocast (SignatureVerifierImpl)" 1a7ad0c10d286ce9ae2700ceb2fd50eed1fb43a4 "loplugin:unocast (pcr::PropertyEventTranslation)" a97e2d2702d9a6f37775ccee2c08c4f3b2479c4b "loplugin:unocast (RangePageBreaks)" 19dfdf86ad1f5b08041d8b7a9f196caf881231ab "iloplugin:unocast (pcr::OFormattedNumericControl)" f9785ea595fd8e911f6370e836fa579225b9e571 "loplugin:unocast (frm::OInterfaceContainer)" 5e5f40a4a92a31b0932c690219d002fcf18598cf "loplugin:unocast (ScVbaShapes)" 27b35b2c215b4832d4378ec3a7ecbba926552d06 "loplugin:unocast (ScVbaShapeRange)" cb3108f860065928552a86cf8acc4b3a95718ecf "cid#1517812 Dereference null return value" feba0ddb1521d1142560fe54b7d7696ee910237f "loplugin:unocast (weld::TransportAsXWindow)" 4d6c23216559eb48f9943bb49d6e475a6d64ba15 "loplugin:unocast (oox::ForumlaImExportBase)" 4844c096a8ab6a9a620c410a0949d4499f12a504 "loplugin:unocast (cairocanvas::SurfaceProvider)" 9a0b523e0a84d403b9092176ccec4b3e3efe42d0 "loplugin:unocast (cairocanvas::CanvasBitmap)" 8a5648d8e59b4b007dbbf3824777c19a21efc61e "loplugin:unocast (cairocanvas::TextLayout)" 28c27a0623bc78a0590858f97d03b620985bc84c "loplugin:unocast (cairocanvas::CanvasFont)" 53bc223cb3288e32a417696ee61c29e5f01f209d "loplugin:unocast (cairocanvas::RepaintTarget)" 5f70b0b9f6bc4ab145ddbd9155590ed4a3b1b9ec "loplugin:unocast (SvXMLImport)" 068187a898cdd2e26e9b16c348ecc1ed2dee3f29 "loplugin:unocast (VCLXWindow)" 88b4f966202717cd4ad38a30a8eda22c3e69ed35 "loplugin:unocast (sfx2::sidebar::SidebarController)" f1b7a69b280aefe2f1b3b0f32193494fd765f2bd "loplugin:unocast (SvxLineStyleToolBoxControl)" ba76f0ba7e8de4d2953739c952004b7d9af47197 "loplugin:unocast (i18npool::Calendar_gregorian)" 840154daf934d8df52ead1cb7acd798c4d30f007 "loplugin:unocast (framework::AddonsToolBarWrapper)" b0e9c4c5f063cefa9557810e3349bdb9c7493091 "loplugin:unocast (GrammarCheckingIterator)" 8ee6cfc9655ce9de4617cea1a0d9cb9d7a4fbfac "loplugin:unocast (ucb::ucp::ext::Content)" 5b8cd77c112bc8c0e92b8fec215c3c8e802bbc0a "loplugin:unocast (basic::SfxScriptLibraryContainer)" 9e73ff9fce12e102bb3c3cea8d8bb96c88f2c9ad "loplugin:unocast (sdext::presenter::PresenterNotesView)" a98acca8fbc38d3fd5600ae5056a8e42b6d8a40d "loplugin:unocast (SelectionChangeHandler)" c0b59ad6e35b0cb0dea0821e95f95569739078c1 "Consistently use comphelper::getSomethingImpl<I>(aIdentifier, this)" 276e3ccbdd3259ec3daf8a1a98fa7f406b14e21c "loplugin:unocast (vclcanvas::RepaintTarget)" Change-Id: I37c73e3422a5154bf6cb647640d2d3f23db8bc34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-03jsdialog: fix validation error dialog in CalcSzymon Kłos
Change-Id: Ie6551e386cd53f6b4bf4cceb6d7bd6170a2072ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143599 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144951 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-01-02Only call getDocumentLocation onceMike Kaganski
Change-Id: I0d611e5170b392a6f2b78fda51e48cd1a3287fa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144909 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-02Avoid reinterpret_castMike Kaganski
Change-Id: I52b1f3d9fb0a3476ac1649ebc05c71aa8f2ce99e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144908 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-01Fix no-pch build on WindowsMike Kaganski
Change-Id: If4eadc1987bb7015d2a7d3a6fb3c25a57158b248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144899 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-01Avoid unneeded initialization, and use URLZONE idsMike Kaganski
Change-Id: I8c6f31865b992fab0739fbefed5d39f21d0fa664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144904 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-01Bump copyright year to 2023Adolfo Jayme Barrientos
Change-Id: I699112a3e554013bab75b82d1eae00098216c886 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144893 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-30Related: tdf#125093 Check Windows Security Zones for macrosVasily Melenchuk
In Windows, files get assigned security zones (local, from intranet, from internet, etc) after download via browser or email client. This is used by MS Word to decide in which mode it is safe to open file. This patch implements basic support for similar feature: by default there are no changes in macro behavior. But it is possible to use expert configuration options to tweak default behavior, and for example disable macros automatically, if a file is downloaded from Internet or other unsafe locations. Change-Id: I0bf1ae4e54d75dd5d07cab309124a67a85ef2d4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143680 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-12-23loplugin:unocast (sfx2::DigitalSignatures)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I74c76452cf7921da55462581ef48aea86f58ea18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144763 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-22Fix typoAndrea Gelmini
"an other" -> "another" Change-Id: Id0a2b8f99fd4f87e94e65570ebc75bfdf0d205ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143597 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2022-12-21cid#1517813 Uninitialized scalar fieldCaolán McNamara
Change-Id: I119e6af448d80cf47dfe3f5bd7983ebf57221790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-20tdf#142147 saveas: encrypted docs should default to use passwordJustin Luth
If a document is currently encrypted (pOldEncryptionDataItem), when the user saves as a different name, the save dialog should BY DEFAULT have the "Save with password" option enabled. That makes sense, right? If the document was secure enough to require a password, then any copies of it should AT MINIMUM suggest a password. Anyway, it worked that way prior to LO 7.0's e0cced9d4c94324e834e46d807469a0cd6c1f738. The concern was that the same password would be applied silently. That might have been true with 7.0. However, in my current testing that never happened. It always prompted the user to create a new password. And that is exactly what I would want on a SAVE-AS, whether it be from a template or a file I was copying. I would hope that this has no bad implications for headless RT. After all, this is just a "suggestion" passed to guisaveas.cxx. I did not find any parameters to provide a password via commandline anyway. Change-Id: Id3535d883cd5d2d1427055f7a21f6ae87e0d5324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143250 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-12-20lok: export PDF/EPUB with extensionSzymon Kłos
Change-Id: Ib266814d88a4f121959cb21f40293d671f242448 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143989 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144512 Tested-by: Jenkins
2022-12-20Async PDFExport dialog and parent methodsNickWingate
Filter dialogs are all called generically from guisaveas.cxx in GUIStoreModel() Signed-off-by: NickWingate <nick.wingate@collabora.com> Change-Id: Idfbe85c09f84d4a7cf3f00b9704d5af94868a051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140403 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144511 Tested-by: Jenkins
2022-12-18add some SAL_WARN_UNUSED_RESULTCaolán McNamara
commit 817dfb74d9ec9f46ba32be6d5066d534f81072a5 Date: Tue Jul 17 09:45:37 2001 +0000 #89783#: NULL-Ptr possible probably intended pViewFrame = SfxViewFrame::GetFirst() but at this distance in time, just accept the current state of things Change-Id: I8779fef1041843e9f2e6c879cfb475d8ac8251fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144401 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16Use xKeepAlive instead of m_pDataArmin Le Grand (allotropia)
There is already an instance to keep the incarnation alive, but it was not used. Instead m_pData can indeed get deleted (nullptr), so better use the alive one. Change-Id: Icdb6c841408254142561db408f876618adbc0b76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144340 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-12-16check SfxObjectShell::Current()Caolán McNamara
SfxObjectShell::Current() can return null, it's based on the equally vile SfxViewFrame::Current() Change-Id: Ia5c7783680e9d8e5d3075078f16a2c15cb6f7a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16loplugin:unocast (sfx2::sidebar::SidebarController)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: Ib681b4eaa44c65b9da5988c74c03f1829e3a1507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144334 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-16provide a parent for potential message dialogCaolán McNamara
Change-Id: I7b417c64ce08cddc2c413dae3bcab3b9fe083bc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16sfx2: check SfxViewFrame::Current()Caolán McNamara
these ones look potentially worth backporting Change-Id: I9391f266b08e3842f9686db6113b61fa814f3fbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144276 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16sfx2: check SfxViewFrame::Current()Caolán McNamara
SfxViewFrame::Current() is a festering wound, these ones look like they were safe anyway, so no need to backport. But with enough checked static analysis will kick in to flag new unchecked ones. Change-Id: I28a803be0429b97592d83d88d6c1db077fe31355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144275 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-15Resolves: tdf#92051 add tooltips to section/table statusbarCaolán McNamara
Change-Id: I649eabbe266085fdbc0ca9c4a5506c0c2a270721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-14loplugin:unocast (SelectionChangeHandler)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: Ibc2511c8521923c854e4b450649ea616581af2fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144141 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-12tdf#152266 add an infobar with indicators for macro-like content in docCaolán McNamara
Show "macros" and "events" for now if we know that are present so they can be investigated by the user. There are other things which could potentially be added in the future. Change-Id: I981ee7a8e22791cd15405894f30fee659ba0b7ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-10Related: tdf#152266 open 'event' page by default for SID_CONFIGEVENTCaolán McNamara
Change-Id: I7a3f6def8bda00588ef2846e5d3b5ed5d1da04de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09Fix hang during JunitTest_framework_complex on macOSStephan Bergmann
...when [NSSpellChecker init] is called on a non-main thread, leading to deadlock (see below). The fix is noticing that the first half of SfxFrameLoader_Impl::load and the call to SwGlobals::ensure from Writer_SwTextDocument_getImplementation both don't need to be covered by SolarMutex. Which in turn showed that the call to StartListening from the constructor of SwModule needs to be covered by the SolarMutex (which it no longer was now). The deadlock was at > thread #7, name = 'cppu_threadpool::ORequestThread' > #1: libsystem_pthread.dylib`_pthread_cond_wait > #2: Foundation`-[NSOperation waitUntilFinished] > #3: CoreFoundation`_CFXNotificationPost > #4: Foundation`-[NSNotificationCenter postNotificationName:object:userInfo:] > #5: AppKit`-[NSMenu insertItem:atIndex:] > #6: AppKit`-[NSApplication(NSServicesMenuPrivate) _fillSpellCheckerPopupButton:] > #7: AppKit`-[NSSpellChecker _fillSpellCheckerPopupButton:] > #8: AppKit`-[NSSpellChecker init] > #9: AppKit`__36+[NSSpellChecker sharedSpellChecker]_block_invoke > #10: libdispatch.dylib`_dispatch_client_callout > #11: libdispatch.dylib`_dispatch_once_callout > #12: AppKit`+[NSSpellChecker sharedSpellChecker] > #13: libMacOSXSpelllo.dylib`MacSpellChecker::getLocales at lingucomponent/source/spellcheck/macosxspell/macspellimp.mm:117:42 > #14: liblnglo.dylib`LngSvcMgr::GetAvailableSpellSvcs_Impl at linguistic/source/lngsvcmgr.cxx:969:63 > #15: liblnglo.dylib`LngSvcMgr::getAvailableServices at linguistic/source/lngsvcmgr.cxx:1395:9 > #16: liblnglo.dylib`LngSvcMgr::getAvailableLocales at linguistic/source/lngsvcmgr.cxx:1459:42 > #17: liblnglo.dylib`LngSvcMgr::UpdateAll at linguistic/source/lngsvcmgr.cxx:654:49 > #18: liblnglo.dylib`LngSvcMgr::LngSvcMgr at linguistic/source/lngsvcmgr.cxx:411:5 > #19: liblnglo.dylib`LngSvcMgr::LngSvcMgr at linguistic/source/lngsvcmgr.cxx:399:1 > #20: liblnglo.dylib`::linguistic_LngSvcMgr_get_implementation at linguistic/source/lngsvcmgr.cxx:1840:30 > #21: libuno_cppuhelpergcc3.dylib.3`decltype(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>(fp)(std::__1::forward<com::sun::star::uno::XComponentContext*>(fp0), std::__1::forward<com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(fp0))) std::__1::__invoke<com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #22: libuno_cppuhelpergcc3.dylib.3`com::sun::star::uno::XInterface* std::__1::__invoke_void_return_wrapper<com::sun::star::uno::XInterface*, false>::__call<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #23: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__alloc_func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #24: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #25: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__value_func<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const > #26: libuno_cppuhelpergcc3.dylib.3`std::__1::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const > #27: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::doCreateInstance at cppuhelper/source/servicemanager.cxx:702:13 > #28: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::createInstance at cppuhelper/source/servicemanager.cxx:667:30 > #29: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::createInstanceWithContext at cppuhelper/source/servicemanager.cxx:1002:36 > #30: libswlo.dylib`com::sun::star::linguistic2::LinguServiceManager::create at workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/linguistic2/LinguServiceManager.hpp:38:129 > #31: libswlo.dylib`SwLinguServiceEventListener::SwLinguServiceEventListener at sw/source/uibase/uno/dlelstnr.cxx:53:22 > #32: libswlo.dylib`SwLinguServiceEventListener::SwLinguServiceEventListener at sw/source/uibase/uno/dlelstnr.cxx:46:1 > #33: libswlo.dylib`SwModule::SwModule at sw/source/uibase/app/swmodule.cxx:161:44 > #34: libswlo.dylib`SwModule::SwModule at sw/source/uibase/app/swmodule.cxx:137:1 > #35: libswlo.dylib`std::__1::__unique_if<SwModule>::__unique_single std::__1::make_unique<SwModule, SfxObjectFactory*&, SfxObjectFactory*&, SfxObjectFactory*&> > #36: libswlo.dylib`SwDLL::SwDLL at sw/source/uibase/app/swdll.cxx:98:26 > #37: libswlo.dylib`SwDLL::SwDLL at sw/source/uibase/app/swdll.cxx:81:1 > #38: libswlo.dylib`(anonymous namespace)::SwDLLInstance::SwDLLInstance at sw/source/uibase/app/swdll.cxx:57:212 > #39: libswlo.dylib`(anonymous namespace)::SwDLLInstance::SwDLLInstance at sw/source/uibase/app/swdll.cxx:58:9 > #40: libswlo.dylib`rtl::Static<(anonymous namespace)::SwDLLInstance, (anonymous namespace)::theSwDLLInstance>::get at include/rtl/instance.hxx:399:18 > #41: libswlo.dylib`SwGlobals::ensure at sw/source/uibase/app/swdll.cxx:70:9 > #42: libswlo.dylib`::Writer_SwTextDocument_get_implementation((null)=0x000000011fde9130, args=0x000000028bb087b0) at sw/source/uibase/uno/unodoc.cxx:40:5 > #43: libuno_cppuhelpergcc3.dylib.3`decltype(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>(fp)(std::__1::forward<com::sun::star::uno::XComponentContext*>(fp0), std::__1::forward<com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(fp0))) std::__1::__invoke<com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #44: libuno_cppuhelpergcc3.dylib.3`com::sun::star::uno::XInterface* std::__1::__invoke_void_return_wrapper<com::sun::star::uno::XInterface*, false>::__call<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #45: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__alloc_func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #46: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #47: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__value_func<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const > #48: libuno_cppuhelpergcc3.dylib.3`std::__1::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const > #49: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::doCreateInstance at cppuhelper/source/servicemanager.cxx:702:13 > #50: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::createInstance at cppuhelper/source/servicemanager.cxx:671:16 > #51: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::createInstanceWithContext at cppuhelper/source/servicemanager.cxx:1002:36 > #52: libsfxlo.dylib`(anonymous namespace)::SfxFrameLoader_Impl::load at sfx2/source/view/frmload.cxx:668:58 > #53: libfwklo.dylib`framework::LoadEnv::impl_loadContent at framework/source/loadenv/loadenv.cxx:1160:37 > #54: libfwklo.dylib`framework::LoadEnv::start at framework/source/loadenv/loadenv.cxx:395:20 > #55: libfwklo.dylib`framework::LoadEnv::startLoading at framework/source/loadenv/loadenv.cxx:300:5 > #56: libfwklo.dylib`framework::LoadEnv::loadComponentFromURL at framework/source/loadenv/loadenv.cxx:168:14 > #57: libfwklo.dylib`framework::Desktop::loadComponentFromURL at framework/source/services/desktop.cxx:605:16 > #58: libgcc3_uno.dylib`callVirtualFunction at bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx:38:5 > #59: libgcc3_uno.dylib`(anonymous namespace)::call at bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx:293:13 > #60: libgcc3_uno.dylib`::unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx:505:17 > #61: libbinaryurplo.dylib`binaryurp::IncomingRequest::execute_throw const at binaryurp/source/incomingrequest.cxx:235:13 > #62: libbinaryurplo.dylib`binaryurp::IncomingRequest::execute const at binaryurp/source/incomingrequest.cxx:78:26 > #63: libbinaryurplo.dylib`::request at binaryurp/source/reader.cxx:85:9 > #64: libuno_cppu.dylib.3`cppu_threadpool::JobQueue::enter at cppu/source/threadpool/jobqueue.cxx:100:17 > #65: libuno_cppu.dylib.3`cppu_threadpool::ORequestThread::run at cppu/source/threadpool/thread.cxx:164:31 > #66: libuno_cppu.dylib.3`::threadFunc at include/osl/thread.hxx:189:15 > #67: libuno_sal.dylib.3`osl_thread_start_Impl at sal/osl/unx/thread.cxx:264:9 vs. > thread #1, queue = 'com.apple.main-thread' > #1: libsystem_pthread.dylib`_pthread_cond_wait > #2: libc++.1.0.dylib`std::__1::condition_variable::wait(std::__1::unique_lock<std::__1::mutex>&) [inlined] std::__1::__libcpp_condvar_wait > #3: libc++.1.0.dylib`std::__1::condition_variable::wait > #4: libvclplug_osxlo.dylib`void std::__1::condition_variable::wait<SalYieldMutex::doAcquire(unsigned int)::$_0> > #5: libvclplug_osxlo.dylib`SalYieldMutex::doAcquire at vcl/osx/salinst.cxx:215:36 > #6: libvclplug_osxlo.dylib`comphelper::SolarMutex::acquire at include/comphelper/solarmutex.hxx:86:5 > #7: libvclplug_osxlo.dylib`osl::Guard<comphelper::SolarMutex>::Guard at include/osl/mutex.hxx:142:17 > #8: libvclplug_osxlo.dylib`SolarMutexGuard::SolarMutexGuard at include/vcl/svapp.hxx:1348:11 > #9: libvclplug_osxlo.dylib`SolarMutexGuard::SolarMutexGuard at include/vcl/svapp.hxx:1348:78 > #10: libvclplug_osxlo.dylib`AquaSalTimer::callTimerCallback at vcl/osx/saltimer.cxx:140:21 > #11: libvclplug_osxlo.dylib`AquaSalTimer::handleDispatchTimerEvent at vcl/osx/saltimer.cxx:162:9 > #12: libvclplug_osxlo.dylib`AquaSalInstance::handleAppDefinedEvent at vcl/osx/salinst.cxx:406:47 > #13: libvclplug_osxlo.dylib`-[VCL_NSApplication sendEvent:] at vcl/osx/vclnsapp.mm:101:9 > #14: libvclplug_osxlo.dylib`AquaSalInstance::DoYield at vcl/osx/salinst.cxx:567:17 > #15: libvcllo.dylib`ImplYield at vcl/source/app/svapp.cxx:465:48 > #16: libvcllo.dylib`Application::Yield at vcl/source/app/svapp.cxx:532:5 > #17: libvcllo.dylib`Application::Execute at vcl/source/app/svapp.cxx:444:9 > #18: libsofficeapp.dylib`desktop::Desktop::Main at desktop/source/app/app.cxx:1587:13 > #19: libvcllo.dylib`ImplSVMain at vcl/source/app/svmain.cxx:198:35 > #20: libvclplug_osxlo.dylib`AquaSalInstance::handleAppDefinedEvent at vcl/osx/salinst.cxx:396:20 > #21: libvclplug_osxlo.dylib`-[VCL_NSApplication sendEvent:] at vcl/osx/vclnsapp.mm:101:9 > #22: AppKit`-[NSApplication _handleEvent:] > #23: AppKit`-[NSApplication run] > #24: AppKit`NSApplicationMain > #25: libvclplug_osxlo.dylib`AquaSalInstance::SVMainHook at vcl/osx/salinst.cxx:971:5 > #26: libvcllo.dylib`ImplSVMain at vcl/source/app/svmain.cxx:191:54 > #27: libvcllo.dylib`SVMain at vcl/source/app/svmain.cxx:230:12 > #28: libsofficeapp.dylib`soffice_main at desktop/source/app/sofficemain.cxx:98:12 > #29: soffice`sal_main at desktop/source/app/main.c:49:15 > #30: soffice`main at desktop/source/app/main.c:47:1 Change-Id: Ic5681f21a153e42a27680a9a6a179aff38f77fcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143565 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-06sfx2: rename FN_PARAM_1 to FN_NOUPDATEHenry Castro
The parameter is intended to not update the fields from data source otherwise it will reset to the first record. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I204cd20b8eb0b3f26c204e139c72b479c83bbf0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142276 Tested-by: Jenkins
2022-12-06sfx2: add log information to catch the exceptionHenry Castro
Add log information for data analysis if the ExportTo fails due to an exception. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I888545da14f413a970faf50b3ce60d12966f3f9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142239 Tested-by: Jenkins
2022-12-01sc: move test back where it belongsXisco Fauli
This test was moved from sc/qa/unit/subsequent_filters_test2.cxx to sc/qa/unit/filters-test.cxx in ad40ad91c5400391a0848832e91c596be8fbd811 "CppunitTest_sc_subsequent_filters_test2: inherit from UnoApiXmlTest". As the commit message says: I couldn't find a way to test testTooManyColsRows, move it to sc/qa/unit/filters-test.cxx for the time being The problem is that using loadFromDestkop resets the Error in sfx2/source/doc/sfxbasemodel.cxx:2005 - m_pData->m_pObjectShell->ResetError(); so add a way to log the WarningError in SfxMedium Change-Id: Ieda9bdc9de856b75d4b162248da41d637305e28d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143506 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-01tdf#152078 Add a Zoom slider to the Basic IDERafael Lima
This patch adds a ZoomSlider to thee Basic IDE. It has the following characteristics: - The Zoom varies from 50% to 400% considering that 100% is the font size defined in Tools - Options - Fonts dialog. - All open editor windows use the same Zoom factor - The zoom level is saved and restored across sessions Change-Id: I63df02d0dc828fca4360d61b8aa2c7af6610d4db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143159 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-11-30sfx2: extend .uno:SetDocumentProperties to update custom doc propsMiklos Vajna
Scripting clients (like the LOK API) had a way to get all custom properties where the name matches a certain prefix, but setting such properties was not possible. .uno:SetDocumentProperties can already show a dialog to edit properties interactively and had a parameter to set some properties in a non-interactive way, but there doesn't seem to be a way to influence custom properties there without using the internal API. Fix the problem by adding a new UpdatedProperties parameter that allows removing all old custom properties matching the prefix and adding new ones with a single UNO command dispatch. This is meant to be the write side of the reading commit 5e8f6dcb8ce00d2d5e35b3cf5654187b3068276c (sw lok, .uno:SetDocumentProperties: expose value of custom document properties, 2022-11-29). Change-Id: Ib7450d4d21285d9a73758e1c172543521fc07cef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143491 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-11-28f'up to the tdf#152172 fix re Safari as default browser on VenturaChristian Lohmaier
Previous patch did only adjust the check in the rarely used version of the function, not in the primarily used signature. D'oh! Change-Id: I019a74651d3ee8bab43a8c3997b8cd05040b7ba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143410 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-11-28sw: add a new .uno:TextFormFields UNO commandMiklos Vajna
Currently .uno:TextFormField can be used to insert a new fieldmark, but then there is no way to update it. Also, there is no way to update several fieldmarks at the same time. Given that the "ADDON" field type in a field mark can be used by extensions like Zotero, it's useful in case these fieldmarks can be not only inserted, but they can be also updated. This works by (in the LOK case) calling getCommandValues() with .uno:TextFormFields, and then once the client generates the new expanded values, there is no way to insert these updated expanded values into the document currently. Fix this by adding a new .uno:TextFormFields UNO command that can update all fieldmarks matching a certain prefix (looking at their field command). This allows e.g. updating all Zotero citations or the bibliography, but the API is generic to support any kind of ADDON fields. Similar to insertion, the content can be multi-paragraph, formatted HTML. This required adjusting SfxUnoAnyItem::CreateDefault(), this way an UNO command parameter can be an array of beans::PropertyValues, which is how the client can provide details of multiple fieldmarks. Change-Id: I44a1b1495ead79b92ccd0c9f6412a34cbec5d68b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143361 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-11-24Remove some unused includesMiklos Vajna
Mostly com/sun/star/frame/Desktop.hpp is unused after inheriting from UnoApiTest. Change-Id: Ifba307353a11a14e033a230a291314bee86b51c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143190 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-23tdf#152172 fix help workaround re Safari as default browser on VenturaChristian Lohmaier
the "Rapid Security Response" feature added with macOS 13 (Ventura) makes Safari a stub in a different location. Instead of the traditional /Application/Safari.app/ the call to query the default app will return /System/Volumes/Preboot/Cryptexes/App/System/Applications/Safari.app/ So instead of a full match, just check for the suffix. Change-Id: Ic4abfe33c118827bc0e089e9966e57a0fd8c0526 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143178 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-11-22lok: draw Math in-place widget in sdMike Kaganski
Change-Id: If874c0227ec724fa5b1517080db252e64f9597c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143121 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-22loplugin:unusedfieldsNoel Grandin
Change-Id: I726b8b9dee3a424f731078cd6b10027423454bee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-22loplugin:unusedfieldsNoel Grandin
Change-Id: I4a7276ffc36b4f954fe1fa39fb5666fa184e66e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-21lok: Notify about last used row and column in CalcSzymon Kłos
We use HelperNotifyChanges::NotifyIfChangesListeners notifier so we know which cell was modified and we can correctly target only affected users. Change-Id: Iaeb68e350e85e4ed1492a7d350a790e68f2d63af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139473 Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142994 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-21lok: allow password reset in properties>change passwordSzymon Kłos
Change-Id: I92a3c658e96f602549ff5282b6ed5bc9ee780bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141372 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142992 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-21lok: make properties>change password dialog asyncMert Tumer
* We now can set a password through properties->change password without having to have a password initially only for online because it needs a created file already, online works with files that are created before loading but the desktop does not need this. * The same dialog is still used as non-async for desktop version because it goes through an InteractionHandler and the result is expected not from the dialog but from the interaction handler. Therefore, making it async there did not make sense. Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: I3d02822be0b71836b1592abca191b3b1c5f6374e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139884 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142991 Tested-by: Jenkins
2022-11-20Enable File Properties for JSDialogsNickWingate
- Disable security tab as protect/password subdialog not fully async-ed - Disable custom property tab as still unstable - Hide Digital signatures button - Make duration dialog async - Set location as file name Signed-off-by: NickWingate <nick.wingate@collabora.com> Change-Id: I5843bb7737af8dd6b7d3af273ddd8997f2e35e10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138010 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142987 Tested-by: Jenkins
2022-11-20Fix opening duration custom property shows textNickWingate
Before saving a duration custom property and then closing and opening file props wouldn't show the duration type and value and instead blank text Signed-off-by: NickWingate <nick.wingate@collabora.com> Change-Id: Ie6536dd75151db40f335985c1ce92236ce77ddc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138180 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142986 Tested-by: Jenkins
2022-11-20jsdialogs: added WidgetTestDialog to test different vcl widgets in online siderash419
Signed-off-by: rash419 <rashesh.padia@collabora.com> Change-Id: I27cbb72b4ccd486b58934503b1d3d5d7ff47cbfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132865 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142970 Tested-by: Jenkins