summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2015-09-07WaE: implicit conversion of literal of type 'int' to 'bool'Tor Lillqvist
[loplugin:literaltoboolconversion]. Change-Id: Ic971c1e76d6b2f3bcdd8f575440f71212081256b
2015-09-07WaE: loplugin:implicitboolconversionTor Lillqvist
Explicit conversion (NoOp) from 'bool' to 'sal_IntPtr' (aka 'long') implicitly cast back to 'bool'. Change-Id: Id18733d1edb0aaa357f4601e9118487740e2cd0f
2015-09-07WaE: loplugin:implicitboolconversionTor Lillqvist
Explicit conversion (NoOp) from 'bool' to 'sal_IntPtr' (aka 'long') implicitly cast back to 'bool'. Change-Id: I53b2a2098eb9122aca0617d37188b62322980b72
2015-09-07WaE: implicit conversion of literal of type 'long' to 'bool'Tor Lillqvist
Change-Id: I5b5f6c41672da90a8a39e88498a0bbe5eebad909
2015-09-07convert Link<> to typedNoel Grandin
Change-Id: I38f2c15b4f8bb1d7187b019d26a2644b087898c1 Reviewed-on: https://gerrit.libreoffice.org/18357 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-06tdf#91554 OK button should be disabled initiallyMaxim Monastirsky
Regression of eb505c259d0d7bd05d1bb5be5a14ad8613c2a9c7. Change-Id: I4623c41617d92a808513f18154a7531e6dfd5463
2015-09-04convert Link<> to typedNoel Grandin
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4 Reviewed-on: https://gerrit.libreoffice.org/18306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03sfx2: remove duplicative ModelCollectionEnumerationMichael Stahl
Use the comphelper equivalent. Change-Id: Iba0567948aeec1299191c759da6aa89b4aa014d8
2015-09-03sfx2: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: Id9b4ad4d1fa700c5ea3dd7417292cf2ddb7ade50 Reviewed-on: https://gerrit.libreoffice.org/18229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-03loplugin:stringconstant also for cases using char const v[] = "..."Stephan Bergmann
Change-Id: Iba38686620624178a7be39d703389402bbcea4cb
2015-09-03convert Link<> to typedNoel Grandin
Change-Id: Ic0482dc5ed26eb2fc6ccde73022eff8b4786de83 Reviewed-on: https://gerrit.libreoffice.org/18258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-02sideber uno api test less dependant to panels orderLaurent Godard
Change-Id: I3a4ef006becbce70897505a6f3367c4b004e13b0 Reviewed-on: https://gerrit.libreoffice.org/18239 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-02Do not call external code with SolarMutex lockedStephan Bergmann
...see mail thread starting at <http://lists.freedesktop.org/archives/libreoffice/2015-September/070102.html> "deadlock question" Change-Id: Ib2ae8d46e2ba25b42aab41916ff36fde4519cdc5
2015-09-02SetXXX(bool) with a default value of false are just wrongNoel Grandin
Change-Id: I4888d0474199bb10ca81d1ad03118a150f574671 Reviewed-on: https://gerrit.libreoffice.org/18235 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-01Resolves: rhbz#1256843 no obvious means to close template dialogCaolán McNamara
under gnome-shell which doesn't put an "X" to close things in the wm decorations if the GDK DIALOG hint it set prior to tdf#72587 this was a modeless dialog and in that case it doesn't have a parent, in which case the hint is NORMAL and it used to get close decorations. easist thing to do is to remain modal so the crashes and confusion of tdf#72587 remain fixed but add a close to it to behave like all the other dialogs do Change-Id: I64450be0ad1bc7b06196e1342679e15b60fc60d9
2015-09-01PythonTest_sfx2_python: StylesPropertyPanel is the first panel nowMaxim Monastirsky
Change-Id: I352f14741dd9346bb41d4e3233b256898809773e
2015-09-01Fix PythonTest_sfx2_pythonMiklos Vajna
Adapt to 1ba1a21aa6b77ef8d3d59b3658dfd2aa87d0dee2 (tdf#73071 Enable styles content panel in calc and fix spacing issue), but the second assert should be ideally 100 and not 99 what it is actually, so comment that out for now. Change-Id: I551640c9db57285942a897eeb57515939ed3510d
2015-08-31tdf#87009 Add a tooltip to the sidebar settings buttonMaxim Monastirsky
Change-Id: I6332e9c7c98f87885f40f4d99224cccfe582029c
2015-08-31convert Link<> to typedNoel Grandin
Change-Id: I236c1a35534c3b0a8461caffbaf852e9bbbd621d
2015-08-31make Link<> typedNoel Grandin
Change-Id: I8949a92792df892b7f360e6b9979c8f61c702ce3
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: I137a0fe7f44ea46af0f9d5337c2aec61a64f508d
2015-08-30tdf#83546 Expand the sidebar if it's hiddenMaxim Monastirsky
Change-Id: I92620cb1439bd13efcdbafcdc584abd8d7bb4345
2015-08-28make PostUserEvent Link<> typedNoel Grandin
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-27coverity#1320470 Unchecked dynamic_castCaolán McNamara
Change-Id: I9abe56c88171629b68d72119f1359d750675d08a
2015-08-27Clean up sEmptyStephan Bergmann
Change-Id: If1b2bfe308caa2bce92e73d2c5c86ee273faed93
2015-08-27Clean up aEmptyStephan Bergmann
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
2015-08-26Clean up aEmptyStrStephan Bergmann
Change-Id: I5befe9deac917a28e80ed193b67ff29b5ba35149
2015-08-26add ppt to fftesterCaolán McNamara
Change-Id: I49162355ce5a58c6aaadfcfb9f45471e5c2a1424
2015-08-26Convert vcl Button Link<> click handler to typed Link<Button*,void>Noel Grandin
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-25make pWindow private in SfxChildWindowNoel Grandin
Change-Id: I585d4e8f0a53f46b6fbcef9e4d26f88b57569684
2015-08-25make eChildAlignment private in SfxChildWindowNoel Grandin
Change-Id: I68a4c3324736e111a2c88e3edb9df506c33042b7
2015-08-20it's no use to check for stream status after a seekCaolán McNamara
seek resets failures, need to check after a read and before a seek Change-Id: Ia249e258c51af5efc838f92c4ead6237b403c701
2015-08-20more config skipping stuff and a tester toolCaolán McNamara
Change-Id: I5e93a4c84b3a0940239213766eb24d21fb5fd649 Reviewed-on: https://gerrit.libreoffice.org/17863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-20better warning message for failed panel creationMarkus Mohrhard
Change-Id: I631120903f15256997e082e0d079da7c5ee9944b
2015-08-20handle new color picker correctly in chart sidebarMarkus Mohrhard
This implements the basics for that and implements it in the AreaPanel. Change-Id: I6d9e5012bbcc2c953d478a09a839f35f2ef64c5b
2015-08-19Consolidate isFileUrl checksStephan Bergmann
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-19Clean up remaining utl::LocalFileHelper::Convert...Stephan Bergmann
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040 "ConvertURLToSystemPath->getSystemPathFromFileURL" and 28f3464a571a23a2c16bd0980e9021b95d011511 "ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those Convert... functionality with direct calls to the corresponding osl::FileBase functions. Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-19Replace utl::LocalFileHelper::IsLocalFile -> ...::IsFileUrlStephan Bergmann
...given that vnd.sun.star.wfs is long gone. Note that the old code could have behaved differently in that for one it could have worked for relative URL input (as osl_getSystemPathFromFileURL is allowed to accept relative URLs) and for another could have failed for some file URLs (for which osl_getSystemPathFromFileURL would return something other than osl_File_E_None for whatever reason), but it looks plausible to assume that what the call sites are really interested in is whether a given URL is a file URL. Simplifies those call sites that already have a INetURLObject instance even further. Change-Id: Iaee4595d933a760b8321e42414a9ef0865311833
2015-08-19for testing allow disabling configmgr for time critical pathsCaolán McNamara
Change-Id: I08021f18d53e1748927f8847649994f95252bbc2 Reviewed-on: https://gerrit.libreoffice.org/17844 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-18ConvertSystemPathToURL->getFileURLFromSystemPathCaolán McNamara
Change-Id: I1c60c60f9b5318626f42e33091920a4404fb6d1c
2015-08-18ConvertURLToSystemPath->getSystemPathFromFileURLCaolán McNamara
Change-Id: I7dc0e1b596f80b8f0870aed1722f711bb287ec0a
2015-08-18rBaseURL argument now unusedCaolán McNamara
Change-Id: I02cacfeaf26788ed024fa9753af132f0d5822e6f
2015-08-17Put Polygon from tools under tools:: namespaceNorbert Thiebaud
Polygon is one of these names that Clash with some system objects A similar work has been done earlier with PolyPolygon. Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5 Reviewed-on: https://gerrit.libreoffice.org/17789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-16sal_uInt16 to sal_Int32Matteo Casalin
Change-Id: Ia693dcbcfaa0349ef13466bb2eed877c5823f5bb
2015-08-14remove default value from SfxPoolItem::PutValueNoel Grandin
more useful to make it explicit. Specifically, otherwise my defaultvalue clang plugin would want to remove lots of places that contains #define constants which, while technically the same as the default value, convey semantic information which is quite useful. Change-Id: I918ad5b0e73ba279fa1b1489b62d900339ff71eb
2015-08-14make Link<> instances typedNoel Grandin
and remove some unused code Change-Id: I934824401b5c528b07ad76f753f78440c4492885 Reviewed-on: https://gerrit.libreoffice.org/17703 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-13make Link<> instances typedNoel Grandin
Change-Id: I0727c3ac6e6e5cf087d63ddfb633845ae578cdbb
2015-08-13make Link<> instances typedNoel Grandin
Change-Id: I0805c49b1ae7f324d5235e46b3c55e67239195c7
2015-08-13remove unused codeNoel Grandin
Change-Id: I5bd42970f485bd1456f8c81934ee23e09a37a6bf
2015-08-13make Link<> instances typedNoel Grandin
Change-Id: I7d20875cc498d54140cfe75b21373fdab9c369ce