summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2019-09-03Ensure that VCL builder entry points use proper function typeMike Kaganski
This removes duplicating typedefs from NotebookBarAddonsMerger, and removes dependency of include/vcl/builder.hxx on include/vcl/NotebookBarAddonsMerger.hxx. Change-Id: Ica5787c934d1b8ce21623f28ce155337637fdf54 Reviewed-on: https://gerrit.libreoffice.org/78549 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-03Parent reference should be const in VCL builder entry pointsMike Kaganski
Change-Id: I2331e19f5e23e0dde8edd22befc7287515adf37e Reviewed-on: https://gerrit.libreoffice.org/78536 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-02Resolves: tdf#127198 assert on dialog from db wizardCaolán McNamara
Change-Id: Ibc431b4f27d1bb5c848122ef0430b13c6a9dc45b Reviewed-on: https://gerrit.libreoffice.org/78384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-31drop some unnecessary includesCaolán McNamara
Change-Id: Ic3ccc7f0e93258cce30a42c71011154bc9313f52 Reviewed-on: https://gerrit.libreoffice.org/78343 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-31Fix typosAndrea Gelmini
Change-Id: Iac08e415f84741ecdb151788776ee15e7364fae1 Reviewed-on: https://gerrit.libreoffice.org/77762 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-30tdf#127211 Revert "tdf#71087 sfx2: avoid flicker in the start center"Miklos Vajna
This reverts commit d5c7657c541c1f6d17bfe5e605594c235eecfcdb. By the time I created that, I forgot to test the case when there are no recent documents. I'm not exactly sure how to fix that, so just go back to the old behavior for now (trading a regression for a normal bug). Change-Id: I8abc251a3e6506ca17429ba106e2dd70fff31556 Reviewed-on: https://gerrit.libreoffice.org/78301 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-30Smaller-width animations pane on mobileMuhammet Kara
Change-Id: I2c3a2a703c7e9fa776e7a6c88cdca5414ce2c2c1 Reviewed-on: https://gerrit.libreoffice.org/78300 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29LOK: Proper use of isMobile() on embedded chartsMuhammet Kara
We are moving the isMobile() check to a higher layer, to avoid changing a published API method This is the follow-up of the commit feae0c186e700f6a48c3fad124fb4795ad1a8f83 Change-Id: Ia84baa36d66d5832e00e6466f5206631df0de443 Reviewed-on: https://gerrit.libreoffice.org/78277 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28Fix other signature of basicide_macro_organizerStephan Bergmann
...after 97710225f015c8716c80e55ecdb78832f2edc731 "sfx2: fix DISABLE_DYNLOADING build" had changed it to 'void const *' but the concurrently submitted 036e635678aedc414e2d55217e4f7f8359ed1b9a "Fix signature of basicide_macro_organizer" fixed the underlying issue that had been introduced with df905f41a33d0d7d2cde7fad80c5b3dc3c837c10 "loplugin:constmethod in sfx2" and had caused DISABLE_DYNLOADING builds to fail Change-Id: If5d8c3289d7c77f5e6526bf7f4e0c48292dc5f71 Reviewed-on: https://gerrit.libreoffice.org/78209 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28GtkWidget for the priority of extension under Extension Tab.Sumit Chauhan
The new structure : PriorityMergedHBox --OptionalBox --ToolBoxExtension --Extension1 --OptionalBox ..... Change-Id: I72760e4f0d60eb6f1f82c1e928601d41a2e4b6ce Reviewed-on: https://gerrit.libreoffice.org/76987 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-08-27Fix signature of basicide_macro_organizerStephan Bergmann
see the function definition in basctl/source/basicide/basobj2.cxx Change-Id: If19f0a82d5498795ceef26342e0152fb12ef983d Reviewed-on: https://gerrit.libreoffice.org/78204 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27loplugin:referencecasting find more redundant static_castNoel Grandin
Change-Id: I3a51812bbd3fcdc6b11e47cb12962f0d4fa7a2ae Reviewed-on: https://gerrit.libreoffice.org/78191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27sfx2: fix DISABLE_DYNLOADING buildMiklos Vajna
Change-Id: I61df3f0f213d1b49d2e2ffec0554bdcd92d3d11f
2019-08-27loplugin:constmethod in sfx2Noel Grandin
Change-Id: Ic129a8e136dc3f3b0a36fdb83e7aa71027ada59a Reviewed-on: https://gerrit.libreoffice.org/78190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27Use get_value_or instead of value_orTomáš Chvátal
The old boost does not understand the value_or function Change-Id: I575d04eaab62294e1b402cd8c991c0daa1854271 Reviewed-on: https://gerrit.libreoffice.org/77728 Reviewed-by: Tomáš Chvátal <tchvatal@suse.com> Tested-by: Tomáš Chvátal <tchvatal@suse.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-26Make temp strings localizable in AutoRedactDialogMuhammet Kara
Change-Id: Ic7136408b5b66ba437df92fe96d2852ae512cda0 Reviewed-on: https://gerrit.libreoffice.org/78154 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-08-26fix impress crash in shape listenerNoel Grandin
after commit ec940941e0bd7db15c5cf7d43df82226e0d849dc Date: Tue Aug 20 17:03:13 2019 +0200 tdf#119388 add new UNO listener/broadcaster grumble grumble stoopid AccessiblePageShape that overrides AccessibleShape but doesn't actually set any shape on it. Also, there appear to multiple copies of something listening to the same shape somewhere, but I didn't track that further. Change-Id: I78713716788dd99b1f56519d960b43e5538c1304 Reviewed-on: https://gerrit.libreoffice.org/78120 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-26Improve checkStephan Bergmann
Change-Id: I8280a81eef2ced0ff0ace51ea9f094421abafe13 Reviewed-on: https://gerrit.libreoffice.org/78108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-26Replace use of INetURLObject::GetNewAbsURL with rtl::Uri::convertRelToAbsStephan Bergmann
Change-Id: I45bc72b30ec51cce9e07371365879e7fe89eb54c Reviewed-on: https://gerrit.libreoffice.org/78023 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-25loplugin:sequenceloop (macOS)Stephan Bergmann
Change-Id: I9d07ec425de700917ac40c56ebddbd8fd20b890a Reviewed-on: https://gerrit.libreoffice.org/78048 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-24loplugin:returnconstval in sfx2Noel Grandin
Change-Id: I9761dbfa66ea59d5c9c0cd87740fdb8ca34008eb Reviewed-on: https://gerrit.libreoffice.org/78034 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23Related: tdf#126693 cannot put focus into combobox entryCaolán McNamara
set can-focus=True in internal GtkComboBoxText GtkEntry where the GtkEntry is editable=True Change-Id: I32cc7686c3a3cb9827f05f192227c0ad39669aa5 Reviewed-on: https://gerrit.libreoffice.org/78035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23tdf#119388 add new UNO listener/broadcasterNoel Grandin
so that we only need to fire each event to the exact shape that wants it, instead of spamming all the shapes. Takes deleting a column from 20s to 10s for me. Note that none of the broadcasters are calling disposing(EventObject), so I did not make XShapeEventListener extend lang::XEventListener. If a memory leak regression points at this commit, possibly I missed something. Change-Id: I2b8db08247d3e0203d41faf77491368168994e4d Reviewed-on: https://gerrit.libreoffice.org/77857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22Replace use of INetURLObject::GetNewAbsURL with rtl::Uri::convertRelToAbsStephan Bergmann
Change-Id: Ida2a0553ede3d6d9d7ff4a50bca6256a70286bc2 Reviewed-on: https://gerrit.libreoffice.org/77970 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-22tdf#71087 sfx2: avoid flicker in the start centerMiklos Vajna
There were a couple of problems here: 1) BackingWindow now does double-buffering to avoid flicker when e.g. navigating with the keyboard in sfx2::RecentDocsView 2) But then the menu background turned into white (instead of the gradient), so MenuBarWindow needs to differentiate between doing its own buffering vs painting into a buffer. 3) The focus rectangles were always painted directly, so keyboard navigation in the startcenter lost focus rectangles, making it hard to see which button is active currently. Fix this by explicitly painting a tracking rectangle in PushButton::ImplDrawPushButton(). This brings an improvement for the Windows GDI and Linux gen backends. Windows GL and Linux gtk3 is meant to be unchanged, they were already flicker-free here. Change-Id: Ib01e330c244c2b38a5b5c52399692e19ff811de3 Reviewed-on: https://gerrit.libreoffice.org/77969 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-20loplugin:constvars in sdext..sfx2Noel Grandin
Change-Id: Id9b05387b7b87d3af5e646e867e6ca9fda0711ce Reviewed-on: https://gerrit.libreoffice.org/77806 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-20Fix typosAndrea Gelmini
Change-Id: I77393d6329ef6f2cfc38825791b44d23e8c3af3e Reviewed-on: https://gerrit.libreoffice.org/77764 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-20Fix typosAndrea Gelmini
Change-Id: I2b21ba71cd555a88e015871e4f6f5a7747615520 Reviewed-on: https://gerrit.libreoffice.org/77763 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-19uitest: pass OUString by const reference and formatting fixesMarkus Mohrhard
Change-Id: I55eca745a84998c74e2d925ed53af20382d98289
2019-08-19uitest: Rewrite all the logger statements with the new grammar syntaxAhmed ElShreif
Finished parts from old logger: 1) UNOCommands 2) StarterCommands 3) UIObjectCommand 4) DialogCommand 5) SpecialCommand Change-Id: Ia521efef0abe1a351b9a4fcabaab6dbf20e8fc89
2019-08-19Fix typosAndrea Gelmini
Change-Id: I33a99be34f41c3583fc6684fc68ba6b76ef2f056 Reviewed-on: https://gerrit.libreoffice.org/77682 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-17tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorJulien Nabet
in sfx2, stoc Change-Id: I7138f702317d0e693438216732bf181f1972cdc1 Reviewed-on: https://gerrit.libreoffice.org/77648 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16Fix typosAndrea Gelmini
Change-Id: Ifa56c292559977577af45204f4cc8346e5706616 Reviewed-on: https://gerrit.libreoffice.org/77611 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16tdf#126663 speed up styles display by sorting twiceNoel Grandin
Change-Id: Ice5c2d0fd92196984efebf8c1183c1ed8399d1fb Reviewed-on: https://gerrit.libreoffice.org/77573 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15loplugin:sequenceloop in sdext..sfx2Noel Grandin
Change-Id: If9924566b21e50cad7a12d781ac5d337de0684ab Reviewed-on: https://gerrit.libreoffice.org/77526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15Resolves: tdf#126943 load styles should be modalCaolán McNamara
Change-Id: I7526cd974d3c3ac47f29fda95af226d42d63f583 Reviewed-on: https://gerrit.libreoffice.org/77512 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-15replace ".get->" with "->"Noel Grandin
Change-Id: I327a6fda1fe0170da33e06b735f09a39421c8a58 Reviewed-on: https://gerrit.libreoffice.org/77469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-14tdf#126859 ensure initial height calculationCaolán McNamara
Change-Id: If4125886fd8d6b70f8d1bd7fc9d89ad093ff0b26 Reviewed-on: https://gerrit.libreoffice.org/77467 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-14revert part of 'warn on load when a document binds an event to a macro'Caolán McNamara
i.e. commit b3edf85e0fe6ca03dc26e1bf531be82193bc9627 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Aug 7 17:37:11 2019 +0100 because then extensions that add a entry to menus results in menu entries that cannot run in the start center where there is no document. If allowed when there is no document, it would still result in the odd behaviour that such menu entries would not work in a document which contained macros or macro-calls if permission was denied to run them Add a similar check instead to SfxEvents_Impl::Execute Change-Id: I8084ab2dc66bb95e2562a3dba188c721d44a5676 Reviewed-on: https://gerrit.libreoffice.org/77465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-14return early on empty type and script stringsCaolán McNamara
to make reading this clearer, no logic change intended Change-Id: Icc6e40df3bf10fde0168c7480e6a3d2d9b33bce2 Reviewed-on: https://gerrit.libreoffice.org/77464 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-13warn on load when a document binds an event to a macroCaolán McNamara
a) treat shared/Scripts equivalently to document scripts This doesn't automatically warn/block running those scripts when used in a freshly loaded document on its own however because DocumentMacroMode::checkMacrosOnLoading will see at... if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() ) that the document contains no macros and flip the allow macros flag to true so that potentially new uses of macros added by the user during the edit are allowed to run b) so, add an additional flag to indicate existence of use of macros in a document c) for odf import, set it when a script:event-listener tag is encountered d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called g) for oox import when VbaProject::attachMacros is called Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b Reviewed-on: https://gerrit.libreoffice.org/77131 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I35cebe0e3f2a69872884d41d84ec9113bc5b484e Reviewed-on: https://gerrit.libreoffice.org/77287 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
"its" Change-Id: I02c660e46964270376a66210fdb5f1b1985ce5b6 Reviewed-on: https://gerrit.libreoffice.org/77255 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12tdf#126769 Sidebar can't be collapsed clicking on the hide arrowSamuel Mehrbrodt
Change-Id: I72ab41fb6c98ab548a1b3cfce837ab9312c7df66 Reviewed-on: https://gerrit.libreoffice.org/77156 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-09Resolves: tdf#126790 use TopLevelWindowLocker in welded help pathCaolán McNamara
Change-Id: I4340d021b63609189d3179a7bcff7fac4fcef69d Reviewed-on: https://gerrit.libreoffice.org/77195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09Resolves: tdf#126732 don't abort on IOException, just reportCaolán McNamara
Change-Id: Ia68b6e1e603fbc6397645abdf0ea7131a547ad42 Reviewed-on: https://gerrit.libreoffice.org/77186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-08fix typo IndexOutOfBoundExceptionMichael Stahl
Change-Id: I4699eabf4d8863acf329e7f2ed30205b67cc6070 Reviewed-on: https://gerrit.libreoffice.org/77151 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-07Consistently treat vnd.sun.star.script location case-sensitivelyStephan Bergmann
...as all other places handling it already appear to do Change-Id: I63079c077e2ac7636f07ea7748fb2f39f08157c4 Reviewed-on: https://gerrit.libreoffice.org/77113 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-11 02:45:05 +0000