summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2020-02-07rename URLBox back to SvtURLBoxCaolán McNamara
Change-Id: Icd90eeb492002c45ddd8ff562a6da411abead122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07SvtURLBox is now unusedCaolán McNamara
Change-Id: Iab78b3803272ceb62c4df74241b64f23b1437b03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07weld URLBox ItemWindowCaolán McNamara
Change-Id: I7dad000404a188e2f5588b90d73ea9b1236bd301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07Fix typoAndrea Gelmini
Change-Id: I9bae8051b27eddca47ca5ffbd17006bf23d4f232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88149 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07Fix typoAndrea Gelmini
Change-Id: I2df1bab891cb1661da48ded41f0bc669fb4b0bbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88147 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07weld SwJumpToSpecificBox_ImplCaolán McNamara
Change-Id: I4c140bccf821b6ee0ce0e734cebae722267f5430 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07test: move component context from subclasses to BootstrapFixtureMiklos Vajna
To avoid duplication. Change-Id: I0ee7c26d5d55bd868ead04c77e7f4ef2582f90e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88138 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-07loplugin:unusedmethodsNoel Grandin
Change-Id: I7296b2fc2862d0ad1f68658b19b2a25cb7609df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-06weld ClassificationControl ToolboxWindowCaolán McNamara
Change-Id: Idda0b5187201aa77b5b6d682b740a8e55719742a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88129 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06Typo fix.Michael Meeks
Change-Id: Id638f16f522b335ca9af7a805556f2061df55bf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88111 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-06use forward declCaolán McNamara
Change-Id: I21b70a405a6c5a62bc3d0f16c4a1b3f7d72c0dd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-05lok: writer: Convert row height / cloumn width to the correct unit.Tamás Zolnai
In online, the mobile wizad displayed these attributes in the wrong unit. Change-Id: I165a8ee17bebbbfd8962ac9addc89df39c77851a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88004 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-04Allow opt-out from document events checkSamuel Mehrbrodt
Commit b3edf85e0fe6ca03dc26e1bf531be82193bc9627 added a warning on load when a document binds events to a macro. This adds an option to restore the old behavior, so that the warning only appears when a document actually has Macros. Change-Id: I5ad398d3d503a0954a746f4cba150f68630b820c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87961 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-04Remove unused maAsynchronousDeckSwitch.Emiliano Vavassori
Change-Id: Icad8aa0f6ff9897b08e057856b3af981b19532df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87960 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2020-02-04weld MasterPagesSelectorCaolán McNamara
Change-Id: Ie63d7f8f83bae4f9641ab9713c6e46cd2090767b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87906 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03-Werror,-Wunused-variable (clang-cl)Stephan Bergmann
...found with 2db9a6813a3640005d9b38e419d5cc55f70b03cc "flush out unused MapModes" in code that had not used the variable ever since it got introduced with dd2f230139525891d60e06b4afdc977d5630d4e9 "INTEGRATION: CWS graphicapi" Change-Id: I7412a3badeec546ed1dff8dcf905036f06287e70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03make some headers privateCaolán McNamara
as shown with ./bin/find-headers-to-move-inside-modules.py Change-Id: I7662417e76fe00c0fc352957560e104b6c2a3d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-02don't include vcl/button.hxx from vcl/layout.hxxCaolán McNamara
Change-Id: I16a1b392c33734ef89f26e7ff9318573e9bfce88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-02no difference between ImageRadioButton and RadioButtonCaolán McNamara
Change-Id: Iae5b7fe329273f34d3e94f1136acdac0d55d1ced Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87816 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-30loplugin:unusedfieldsNoel Grandin
Change-Id: Ifb9c91b3e8d6c2dd3a639a239fa41e7d5c7a4ee6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87735 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29lok: preserve mouse event logic position and use in calcTomaž Vajngerl
When clicking in online Calc any of the charts, shapes (and other objects), sometimes the cell underneath is selected instead. The problem is that the object is not correctly recognised to be hit. From lok we get the mouse event position in logic coordinates, which we usually can just use in writer and impress. In calc however we need the coordinates in pixels, so we transform them before sending the mouse event to calc. Still calc also uses common SdrObjects (chart, shapes,...), which operate in logic coordinates. So in case of SdrObject we need to convert the coordniates back from pixel to logic again, which causes problems because conversion doesn't have access to the displaying conditions on an stateless online client. OTOH we already had the correct logic coordinates, and we can just send them along. This is what this change does. It adds an optional maLogicPosition to MouseEvent, which is filled with logic position if those is known. Change-Id: I26f6466085baf613850b5861e368f22cad7c1d26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87681 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-29bInterim is always trueCaolán McNamara
Change-Id: Id9f72fdb94a766ef58a44b3653a36f22335b5718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28remove some unused local varsNoel Grandin
found by my new loplugin:unusedvariableplus Change-Id: Ic3f55f492d43a53d8850a97d44059ff127fd69a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87573 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28tdf#127169: Auto-redaction doesn't cover the title completelyOnur Yilmaz
Change-Id: I5283ce535f436f066859467cf6ef50ee9a2d2fdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87436 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28New loplugin:unsignedcompareStephan Bergmann
"Find explicit casts from signed to unsigned integer in comparison against unsigned integer, where the cast is presumably used to avoid warnings about signed vs. unsigned comparisons, and could thus be replaced with o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx) o3tl::make_unsigned requires its argument to be non-negative, and there is a chance that some original code like static_cast<sal_uInt32>(n) >= c used the explicit cast to actually force a (potentially negative) value of sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the cast to avoid a false "signed vs. unsigned comparison" warning in a case where n is known to be non-negative. It appears that restricting this plugin to non- equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=) is a useful heuristic to avoid such false positives. The only remainging false positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast from sal_Int32 to sal_uInt32". But which of course does not mean that there were no further false positivies that I missed. So this commit may accidentally introduce some false hits of the assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan --enable-dbgutil) `make check && make screenshot`. It is by design that o3tl::make_unsigned only accepts signed integer parameter types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in include/oox/helper/helper.hxx is used with both signed and unsigned types, so needs a little oox::detail::make_unsigned helper function for now. (The ultimate fix being to get rid of the macro in the first place.) Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-27tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesiakarsu
Change-Id: Icbe4628442ec74c6dd16f42a670f42b75aefc346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87479 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-26Avoid explicit casts to smaller sal_uInt16 from larger longStephan Bergmann
...in what might be attempts to avoid warnings about signed vs. unsigned comparisons. Change-Id: I699718a90dffb4b5bcd3706eddbaf6fba71114fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87442 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-26remove some unused local varsNoel Grandin
found by a more aggressive variant of loplugin:unusedvariables. This is my first pass, committing the simplest and most obviously unnecessary vars Change-Id: I9676a6e39a101937097788548764506c93811c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87414 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-26rename some local variablesNoel Grandin
mostly to make the job of my very aggressive unused local vars plugin easier Change-Id: Ifc21a920841f8589f8b7e10de39dba6622a5d501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-25tdf#130137 Replace remaining uses of WNT define checks with _WIN32A_GAN
Change-Id: If95f1ea5a81de62eb4f725e5fcb30ccb8530062a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87372 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-24loplugin:makeshared in sfx2Noel Grandin
Change-Id: I54492b9c9bb7aaf4aed4846c68ff3545695430f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87331 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-23weld SvxFontWorkDialogCaolán McNamara
Change-Id: If9da7ad6a834d22f1bcab8d41ce7fe1f80168946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84774 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22inline some construction methodsNoel Grandin
only called from one constructor Change-Id: I082cf3b459c936b79a6df695fffac5e3cf43705b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22tdf#129829 sfx2: fix handling of password to open vs modifyMiklos Vajna
Regression from commit e0f20211a8048a87b078aa4cf0f28c0c847487ad (sw reqif-xhtml import: add a new AllowedRTFOLEMimeTypes parameter, 2019-12-16), the problem was that in case the (input) stream for an opened document is kept alive, then we don't try to re-create it, which means providing a different password behaves the same as providing the same (wrong) password. It seems CheckPasswd_Impl() in sfx2 only calls comphelper::DocPasswordHelper::requestAndVerifyDocPassword() in case we don't have a decrypted stream already. Fix the problem by deleting those streams from the remembered input parameters, the interesting ones have custom key names anyway. [ No testcase, the problem is Windows-only and it's not clear to me why the behavior is platform-specific. ] Change-Id: I2fc1f0567244897caa18548161fe426ac7d0dfd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87182 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-21Fix typoAndrea Gelmini
Change-Id: Ie4c9881fb9244980b4161275a08fac229efee88e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87147 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-21tdf#42949 Fix IWYU warnings in sfx2/source/[s-v]*/*cxx and sfx2/qaGabor Kelemen
Also quickly recheck other parts of sfx2 after recent welding there Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iff847f142557b5b253887add12c005821554ef65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86891 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-21weld gallery panelCaolán McNamara
Change-Id: I4aebb3f90e9943044d106a507972c39434988f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21Make dock/undock short cut work from sidebar tabbarJim Raykowski
Makes Shift+Ctrl+F10 short cut to dock/undock sidebar work from the sidebar tabbar Change-Id: Idd895e35e65f4cd66b7af16c39f5b0fd69fb5796 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85687 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-20Show accel key for sidebar dock/undock menu itemJim Raykowski
Change-Id: I7d9f9860fa94eeb4b8a379de8c3d3ddd5239a21d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85671 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-17tdf#129788: Revert "no need to use AlphaMask in RecentDocsViewItem"Xisco Faulí
This reverts commit 31bd8c4a4a4752dcff12ee35636193f79a6d6137. Similar to 5c54778aad677d6bb6e6687f0f43dffad1aefa1e Change-Id: Ibb4daa702df1f683888b92b8b8041f28e25e6b04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86981 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-17Avoid unnecessary explicit castStephan Bergmann
...which would only hide unexpected conversion failure, should it ever be possible to happen, from tools like -fsanitize=integer Change-Id: Ic2beab11078a40e16b92ce9ac868d296de028200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86977 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-16tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer typesOnur Yilmaz
Change-Id: I9f2b7d3cd0954f5ffa3cfb194cd625ea175ff6bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86608 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-16use sidebar icon size setting for welded toolboxes in sidebarsCaolán McNamara
Change-Id: Ie582a76e87126effca9260b58d8a8bef51c147ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16remove some unneeded includesCaolán McNamara
Change-Id: I993ed47c6b4a43f6293bdf5c2803599d75337bb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16drop some unneeded includesCaolán McNamara
Change-Id: Ib4ea839a6fffa202a98472d47933efb0ff4fff20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16rename a createPopupWindow so we can remove 'using createPopupWindow'Caolán McNamara
Change-Id: I6e24d3f796b4b958513166ba2fd9e63239729375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86886 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15SfxPopupWindow is now unusedCaolán McNamara
Change-Id: Idd4f2854eb0746a0648df30a5815bfaf8ef6a9ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15no remaining CreatePopupWindow returns non-nullCaolán McNamara
Change-Id: Ie342bd24222f622997d8dc2cda51ecb908fdb047 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86843 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-26 04:49:33 +0000