summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2023-05-04tdf#153587 Display CTRL+F in the keyboard shortcuts listJuergen Funk
* Add the missing entry to Accelerators.xcu * Handle vnd.sun.star.findbar:-command the same as .uno commands Change-Id: I69d441d63a6b0478a07c9ef10665b7d59d3334b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151322 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-04-30Use getXWeak in sfx2Mike Kaganski
Change-Id: I364f13308adf8b3257e53da2bc6576088bb958f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150867 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-28survive exporting to pdf without config for fuzzingCaolán McNamara
Change-Id: I229f25a8a15b21257756ecfa008b9e99681003c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-28optimise find/insert calls to mapsNoel Grandin
Instead of doing two lookups, we can just call insert and then update the mapped-to value if the insert actually succeeded. Change-Id: I3df3b98f0debe6bf74c739dd5850e7714d9c2789 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151030 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-27tdf#151715 sfx2: do not use FORCERELOAD for document stored in /tmpMichael Stahl
This does not fix the actual bug, but is a workaround for a bug somewhere in the Notebookbar code that was exposed by commit 5b5fb5e9c0580ecb70cf65882865bdaf16498fa5 "sfx2: do reload on SID_EDITDOC in SfxViewFrame::ExecReload_Impl()". For an ODF file, the Notebookbar is switched to editable by the call to SetReadOnlyUI() from ReadOnlyUIGuard, but the XLS file takes a different path and SetReadOnlyUI() is called in line 819. Here the SfxViewFrame is not yet connected to the SfxObjectShell so unsurprisingly it does not affect the UI; more surprising is that moving the call to around line 859 leads to the SfxHintId::ModeChanged event being handled in SfxViewFrame::Notify() with lots of things invalidated, but the NotebookBar is entirely unimpressed by that. Change-Id: I16f321bb3444eeae76348e20816af02938c3f46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151089 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-27Avoid temporary OUString creationMike Kaganski
Change-Id: I1cebcc2cbd36ed83d4898e222929c872f46c08d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151028 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-27tdf#38194 Use a hashed string HSL color approachJim Raykowski
for style name color creation New magic for style name color creation. Change-Id: Ia6eec2dcf04fc2c3c38276bf6eaed73598505947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151079 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-26assume IFrame script/macro support isn't neededCaolán McNamara
seems undocumented at least Change-Id: I316e4f4f25ddb7cf6b7bac4d856a721b987207a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26Related: tdf#155017 Stop after the first pop in case the shell was not on stackMike Kaganski
After commit 271f17a6022c64cbbe9befbc66a9eaaa0567d569 (tdf#155017: make sure that the correct shell is popped from SfxDispatcher, 2023-04-26). This restores the previous logic for a hypothetical case of a pop without POP_UNTIL scheduled for a shell, which was not on the stack (so that it wasn't removed in the code added in the commit mentioned above); I haven't a reproducer, but it definitely can happen, given how things work here. So I try to avoid breaking it even further :-) Change-Id: Ied0a1406881fbefe3cf069f816c50da03a41dcd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151034 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-26tdf#155017: make sure that the correct shell is popped from SfxDispatcherMike Kaganski
Honestly, I don't quite understand the idea of using the stack of shells in SfxDispatcher, when the order of addition of shells there does not match the order of removal. After opening the bugdoc, SfxDispatcher has these shells in xImp->aStack (from top to bottom): [8] SwWebView [7] SwWebTableShell [6] SwWebTextShell [5] SwWebListShell [4] FmFormShell [3] SwWebDocShell [2] SfxViewFrame [1] SwModule [0] SfxApplication SfxViewFrame dtor calls ReleaseObjectShell_Impl. * First of all, it calls PopShellAndSubShells_Impl for SfxViewShell; * Then it calls SfxDispatcher::Pop for SfxObjectShell; * Then it calls SfxDispatcher::RemoveShell_Impl for SfxModule; * Then SfxObjectShell is destroyed; * And finally, SfxDispatcher::SetDisableFlags is called. PopShellAndSubShells_Impl (for SfxViewShell) finds the passed SwWebView at the top of the stack (pos. 8), and removes it. SfxDispatcher::Pop for SfxObjectShell queues removal of the passed SwWebDocShell *without* SfxDispatcherPopFlags::POP_UNTIL mode. SfxDispatcher::RemoveShell_Impl first calls Flush, which actually executes the queued actions. At this point, an SwWebTableShell (pos. 7) is the top of the stack; SfxDispatcher::FlushImpl will pop it, and stop (because there was no SfxDispatcherPopFlags::POP_UNTIL at the previous step), so the intended removal of SwWebDocShell (which is at pos. 3) will not happen. Then RemoveShell_Impl will proceed searching for the specific shell (SwModule), and removing specifically that (at pos. 1). At the moment of destruction of object shell, the dispatcher's stack looks like this: [5] SwWebTextShell [4] SwWebListShell [3] FmFormShell [2] SwWebDocShell <-- The problem is here [1] SfxViewFrame [0] SfxApplication and pos.2 points to a destructed object. Finally, SetDisableFlags iterates all the shells still in the stack, setting their flags - and obviously accessing already destroyed object. In debug builds, this crashes reliably; in release builds, where dtors do not fill memory, the access of the just-destroyed objects likely often goes unnoticed. In different documents, the order and the set of shells there is different, e.g. an empty Writer document would have view shell just above object shell, resulting in correct removal of the object shell. I don't know what strategy is intended here. I decided to implement a small change, that makes sure that without POP_UNTIL, popping a shell removes exactly that shell that was requested for removal. Change-Id: I670d024056a5b32d5485f00a4799a8b0bacb6485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151003 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-25add "m" prefix to member variables - SfxTabPageTomaž Vajngerl
Change-Id: I482c341518948bf92f81d4f89b7e307635220150 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150974 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25tdf#38194 tdf#106556 Enhancement to highlight direct formatting,Jim Raykowski
paragraph style, and character style use in Writer documents Initial commit to realize direct formatting, paragraph style, and character style highlighting enhancement requests. Highlighting of character direct formatting is turned on/off using .uno:HighlightCharDF. Highlighting of paragraph styles and character styles is turned on/off using a check box in the Sidebar Styles panel. Closing the Sidebar also turns paragraph and character style highlighting off. Paragraph direct formatting is indicated by a hatch pattern over the paragraph style highlight bar and also by "+ Paragraph Direct Formatting" appended to the tooltip that appears showing the name of the paragraph style when the mouse pointer is over the style highlight bar. Colors used for styles highlighting are determined by a hash of the style name. Lightgray is used for character direct formatting. Known issue: Tooltip doesn't show for paragraph style highlighting in tables and in frames where the highlighting bar is drawn outside of the frame. Change-Id: I6e00ee38c1c169bc7c6542a1782c03b2593e1891 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150451 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-25Add script to find unused using declarationsGabor Kelemen
As a complementer to clang-tidy-12 --checks="-*,misc-unused-using-decls" Pros: - simple, fast! - finds some more unused declarations, somehow - works on non-linux specific parts of the code - clang-tidy (for me) trips on files with external headers, this does not Change-Id: If2db989114ac5c2841ed2e89ff7bd7a9e419f567 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150612 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-24loplugin:unnecessarygetstr extend to more std::string checkingNoel Grandin
suggested by mike kaganski Change-Id: I5f5f254142767aca45a6101abdd84a0163ca6a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-23cid#1524748 Uninitialized pointer fieldCaolán McNamara
Change-Id: I50becae790146538b5996df15301456d83af2ffd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150811 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-23use more TOOLS_WARN_EXCEPTIONNoel Grandin
so we get more complete information when something goes wrong Change-Id: Ia73623f748b0779cf80b0086bd8258791590e9ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-23Run clang-tidy with misc-unused-using-decls on modules [s-t]*Gabor Kelemen
To remove unneeded using declarations. Via the simple script: for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do clang-tidy-12 --checks="-*,misc-unused-using-decls" "$i"; done Change-Id: I596299084471b2904548d23875866f1583b00b2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150610 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-04-23tdf#153806 a11y Allow opening context menu of fav/recent char w/ keyboardMichael Weghorn
This is similar to commit 1f437264084fd173116965fa4d856aeafdfe7a98 Date: Sun Apr 2 00:36:44 2023 +0300 tdf#153806 a11y: Allow opening context menu in special char dlg using keyboard , but now for the character views in the "Recent Characters" and "Favorite Characters" sections in the special character dialog, and thus addresses this comment from the commit message of the above-mentioned commit: > Adding support for opening the context menu for the > recently used and favorite characters further down > in the special characters dialog is independent of this > and would have to be added separately. Turns out that the position returned by `CommandEvent::GetMousePosPixel` is good for the keyboard case as well, is right in the middle of the char view widget. Change-Id: I9f55b99398d557b19263bf531f6a857d274d3d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150815 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-23sfx2: Pass SvxCharView context menu pos as paramMichael Weghorn
... and drop the `maPosition` member that was used for that purpose only. Change-Id: If449a12e6e8e37c28d7b2b139e20c4c307d41eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150814 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-21loplugin:unnecessarygetstr extend to checking std::string::c_strNoel Grandin
Change-Id: I17398e2a6a31a2c98ba8e54b5c8045f22aee8759 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150749 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-20Typo getCurentSfxFilter->getCurrentSfxFilter in sfx2/filedgimpl-helperJulien Nabet
Change-Id: Ia428e81e9ebefcac521354d1eccb39f891fa9656 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150685 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-19loplugin::unusedmethodsNoel Grandin
Change-Id: I6a07860edb13588b83345babeb53675aedc43f7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-19sfx2: fix crash in StyleList::CustomRenderHdlXisco Fauli
GetFamilyItem() might return nullptr See https://crashreport.libreoffice.org/stats/signature/StyleList::CustomRenderHdl(std::tuple%3COutputDevice%20&,tools::Rectangle%20const%20&,bool,rtl::OUString%20const%20&%3E) Change-Id: I099f045232aac710c4f26148de5e798d00ecc7ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150602 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-15a11y: Report focusable and focused state for ThumbnailViewItemMichael Weghorn
Basically the same as Change-Id I3f14047fe721c4a2bc0c6acb2d32f185d0eed204 "a11y: Report focusable and focused state for ValueSetItem", but for `ThumbnailViewItemAcc`. Makes Orca with the qt6 VCL plugin announce the selected/focused item in the recent documents view in the LO start center. Change-Id: I8ab259ce6649904b42367ac30e4efbd6ab62cb6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150419 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-14loplugin:stringviewparam improvementsNoel Grandin
improve the check by checking for methods that exclude using string_view, rather than checking for methods that __can__ use string_view, which leads to exposing some holes in our o3tl/string_view.hxx coverage. Change-Id: Ic9dd60441c671f502692f9cd2a1bb67301c4b960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13query getUserAllowsLinkUpdate for the case of content in a floating frameCaolán McNamara
similarly to how it works for the more common "normal" embedded objects Change-Id: I83e38dfa2f84907c2de9680e91f779d34864a9ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13adjust IFrameObject so it could reuse mxFrame for a reload of contentCaolán McNamara
Change-Id: I7eec3132a23faafd9a2878215a0a117a67bc9bf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150343 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13use parent window as dialog parentCaolán McNamara
it makes no odds, but is more convenient for upcoming modification Change-Id: Ibc5333b137d2da089b3b701ff615c6ddf43063d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150342 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-11set Referer on loading IFramesCaolán McNamara
so tools, options, security, options, "block any links from document not..." applies to their contents. Change-Id: I04839aea6b07a4a76ac147a85045939ccd9c3c79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-10Drop SvStream::WriteCharPtrMike Kaganski
WriteOString is a better replacement Change-Id: Ic431b9aeb98d19fe61cff71360eee555105cc2bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150192 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-09new loplugin:unnecessarygetstrNoel Grandin
which prevents constructing unnecessary temporaries via getStr() Change-Id: I9ca70893a10e954b5ee0e6ad6098660ee24c2bef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-09tdf#154694 All icons: Sidebar's A11y CheckerRizal Muttaqin
Change-Id: Ifb91eb6d78ae1c6cb7050b89ab0ddc45fb029a09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150159 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-04-07set an InteractionHandler with the embedded frame as dialog parentCaolán McNamara
for any warning dialogs that may appear Change-Id: Ibb8f90b60cb1af625b0dc57d2f9fd01964fa9bba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150128 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-07move using the vcl file dialog in headless mode to the point of creationCaolán McNamara
instead of setting and unsetting the config option at start and exit because a document that crashes in headless mode leaves my config in an unwanted built-in file dialog state. Change-Id: Ib5fcc5994a08c78bffdf57cb5b252dc469167ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-07set m_bSystemDialogs just onceCaolán McNamara
Change-Id: I4ae32628e79902e4ce5534797cacd9ba9e8a177a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-05fix leaks when using tools::JsonWriterNoel Grandin
Specifically in sd/source/core/annotations/Annotation.cxx We seem to end up fixing leaks here often. The current tools::JsonWriter API is just very hard to use correctly. So rather return an OString, which is cheap to copy, and push that down into the LOK code. AFAIK that seems to end up requiring less code and less adhoc copying of data (specifically the queueing code in init.cxx was creating copies when converting to std::string). Ideally, we could have some special API to avoid the new strdup() calls in init.cxx, but not sure how to prevent other people from accidentally using that. Change-Id: Ia33437c1bfd9cc2d54dfb99914d1b72db20335f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149963 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-03jsdialog: keep button under content in SpellCheck OptionsSzymon Kłos
Change-Id: I75b1424fe688f975b88634d6355cd0311fc07057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149227 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149825 Tested-by: Jenkins
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-01use more XVclWindowPeerNoel Grandin
Rather than using it's superclass XWindowPeer and implicitly relying on it being XVclWindowPeer and casting it everywhere. Change-Id: Icfb46f3b920d00f4a167a31803a71bbb0368d05c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149894 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30loplugin:stringadd in sfx2Noel Grandin
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I72c2afa0b6bddfe00fe09f34eb1b1bf2177461d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149747 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29crashtesting: xSource seen as empty referenceCaolán McNamara
#17 0x00007f42f14f1662 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6 #18 0x00007f42ef64c68f in com::sun::star::uno::Reference<com::sun::star::embed::XStorage>::operator-> (this=<optimized out>) at core/include/com/sun/star/uno/Reference.h:385 __PRETTY_FUNCTION__ = {<optimized out> <repeats 151 times>} #19 SfxObjectShell::CopyStoragesOfUnknownMediaType (xSource=..., xTarget=uno::Reference to (OStorage *) 0x561536cddad8, rExceptions=empty uno::Sequence) at core/sfx2/source/doc/objstor.cxx:3566 aSubElementNames = uninitialized uno::SequencePython Exception <class 'TypeError'> 'NoneType' object is not iterable: bResult = true #20 0x00007f42ef65551d in SfxObjectShell::SaveAsChildren (this=this@entry=0x561536dad540, rMedium=...) at core/sfx2/source/doc/objstor.cxx:3328 xStorage = uno::Reference to (OStorage *) 0x561536cddad8 AutoSaveEvent = false lArgs = {<comphelper::SequenceAsHashMap> = {m_aMap = std::__debug::unordered_map with 2 elements = {[{maString = "AutoSaveEvent", mnHashCode = 528032507}] = uno::Any(void), [{maString = "FilterName", mnHashCode = -1339490047}] = uno::Any("string": "draw8")}}, static PROP_ABORTED = {{str = Python Exception <class 'AttributeError'> 'NoneType' object has no attribute 'lazy_string': , more = {refCount = 1073741824, length = 7, buffer = u"Aborted"}}}, static PROP_ASTEMPLATE = <same as static member of an already seen type>, static PROP_COMPONENTDATA = <same as static member of an already seen type>, static PROP_DOCUMENTSERVICE = {{str = "DocumentService", more = {refCount = 1073741824, length = 15, buffer = u"DocumentService"}}}, static PROP_ENCRYPTIONDATA = <same as static member of an already seen type>, static PROP_FILENAME = <same as static member of an already seen type>, static PROP_FILTERNAME = <same as static member of an already seen type>, static PROP_FILTERPROVIDER = <same as static member of an already seen type>, static PROP_FILTEROPTIONS = <same as static member of an already seen type>, static PROP_FRAME = <same as static member of an already seen type>, static PROP_FRAMENAME = <same as static member of an already seen type>, static PROP_HIDDEN = <same as static member of an already seen type>, static PROP_INPUTSTREAM = <same as static member of an already seen type>, static PROP_INTERACTIONHANDLER = <same as static member of an already seen type>, static PROP_AUTHENTICATIONHANDLER = <same as static member of an already seen type>, static PROP_JUMPMARK = <same as static member of an already seen type>, static PROP_MACROEXECUTIONMODE = <same as static member of an already seen type>, static PROP_MEDIATYPE = <same as static member of an already seen type>, static PROP_MINIMIZED = <same as static member of an already seen type>, static PROP_NOAUTOSAVE = <same as static member of an already seen type>, static PROP_OPENNEWVIEW = <same as static member of an already seen type>, static PROP_OUTPUTSTREAM = <same as static member of an already seen type>, static PROP_PASSWORD = <same as static member of an already seen type>, static PROP_POSTDATA = <same as static member of an already seen type>, static PROP_PREVIEW = <same as static member of an already seen type>, static PROP_READONLY = <same as static member of an already seen type>, static PROP_REFERRER = <same as static member of an already seen type>, static PROP_REPLACEABLE = <same as static member of an already seen type>, static PROP_SALVAGEDFILE = <same as static member of an already seen type>, static PROP_SILENT = <same as static member of an already seen type>, static PROP_STATUSINDICATOR = <same as static member of an already seen type>, static PROP_STREAM = <same as static member of an already seen type>, static PROP_STREAMFOROUTPUT = <same as static member of an already seen type>, static PROP_TEMPLATENAME = <same as static member of an already seen type>, static PROP_TITLE = <same as static member of an already seen type>, static PROP_TYPENAME = <same as static member of an already seen type>, static PROP_UCBCONTENT = <same as static member of an already seen type>, static PROP_UPDATEDOCMODE = <same as static member of an already seen type>, static PROP_URL = <same as static member of an already seen type>, static PROP_VERSION = <same as static member of an already seen type>, static PROP_DOCUMENTTITLE = <same as static member of an already seen type>, static PROP_MODEL = <same as static member of an already seen type>, static PROP_VIEWONLY = <same as static member of an already seen type>, static PROP_DOCUMENTBASEURL = <same as static member of an already seen type>, static PROP_SUGGESTEDSAVEASNAME = <same as static member of an already seen type>, static PROP_AUTOSAVEEVENT = <same as static member of an already seen type>} aExceptions = empty uno::Sequence #21 0x00007f42ef6555fd in SfxObjectShell::SaveAs (this=this@entry=0x561536dad540, rMedium=...) at core/sfx2/source/doc/objstor.cxx:160 Change-Id: Ie9bb49a8ebff6d985e93c7738da241ff8d61ff2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-29tdf#149064 ensure interaction handler is present when transfering with webDAVJaume Pujantell
Change-Id: I7a31f708e6fe01f07c7187aacd4657b5c6156c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149722 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-03-23tdf#142978 Show a11y sidebar when finding issues on PDF exportSamuel Mehrbrodt
Change-Id: I5234aca76153e1a781b7df1d3fbea8bb856af921 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149430 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-03-18loplugin:stringadd use more O[U]StringCharNoel Grandin
Change-Id: I196e4539ad430a39415eff9d7170b33df7228230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-16Add uno command that changes the themeParis Oplopoios
Add an uno command that changes the theme to the one specified in the first parameter Change-Id: Ia0fef2ca698415e07f1943cf80ab667fb5c37238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148942 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-03-14elide some temporary OStringsNoel Grandin
where we can pass a string_view into OStringToOUString Change-Id: If7803ba49aa15f6e9c7bd386d32fb84003155390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148844 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-10improve loplugin:unnecessarylockingNoel Grandin
to find more locking we can remove Change-Id: Ief7bc5ec2a1ff31f22a0ad366910b7fcc4725818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148599 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-10sw lok: notify clients about view option changesParis Oplopoios
Send a string of the view options to the kit when the view changes Change-Id: I89f65ff1d22a83a54dde35e39eb487edda0b58e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-09tdf#149144 Icons for sm Formula Editor in Sidebar DeckRizal Muttaqin
Change-Id: I851e0e45df3331012eddcaa3240c6ffb27054e57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148520 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-07lok: form controls: rendering and mouse event forwardingMarco Cecchetti
What we got - Most controls rendered on Writer and Impress (on Calc already implemented by Tomaž Vajngerl) - Text labels rendered correctly - Mouse events forwarded to controls - Control state changed on click for Writer and Calc - Control invalidation for all apps - Fixed broken LOK_CALLBACK_MOUSE_POINTER msg - Correct pointer style when mouse is hovering over a control Need to be improved - in impress click method for a control is not executed even if the mouse event is forwarded correctly - avoid not needed control invalidations (as the one occurring on document autosaving) Change-Id: I4d5012af7f90a2c726b6b6b5b068e2be1ed5568a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146569 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147320 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-08 18:16:40 +0000