| Age | Commit message (Collapse) | Author |
|---|
|
|
|
suitable for conversion from [Byte]String::GetTokenCount
converted low-hanging variants to rtl::O[UString]::getToken loops
added unit test
|
|
Remove SvStrings definition and obsolete #defines.
|
|
Remove unused variables.
|
|
|
|
|
|
Not on any Unix, at least. I have no idea how deep entrenched is this
mistake all over the code, so I'll play safe and just fix the KDE4 fpicker
(GNOME/KDE3 seem to handle it fine), but at least in the UI show just
"All files" instead of "All files (*.*)").
|
|
|
|
|
|
The ones which use a definite 8-bit encoding read/write pascal-style
strings with a 16bit length prefix.
The ones which use a definite 16-bit encoding read/write pascal-style
UTF-16 strings with a 32bit length prefix, i.e. not ByteStrings at all
The "I dunno" ones might be UTF-16 strings or 8-bit strings, depending
on the charset. Rename to ReadUniOrByteString like the other
similar horrors to flag this misery
|
|
Nobody ever used the return values anyway, so for reading just
return the string and for writing the number of bytes written
Doesn't need to be members, make standalone functions
Rename to
read_lenPrefixed_uInt8s_ToO[U]String and
write_lenPrefixed_uInt8s_FromO[U]String, lengthy,
but much less unambiguous, seeing as a lot of users of it don't
seem to be aware that they read/write pascal-style length
prefixed strings, which isn't surprising given the
apparent simplicity of their original name.
added a unit test
|
|
|
|
|
|
This reverts commit 92f396733ebc518bcb7a9eae2dd3169d333b82b9.
|
|
This reverts commit d00fc0e293852cfc019ffaffa65bee327397677b.
|
|
The ones which use a definite 8-bit encoding read/write pascal-style
strings with a 16bit length prefix.
The ones which use a definite 16-bit encoding read/write pascal-style
UTF-16 strings with a 32bit length prefix, i.e. not ByteStrings at all
The "I dunno" ones might be UTF-16 strings or 8-bit strings, depending
on the charset. Rename to ReadUniOrByteString like the other
similar horrors to flag this misery
|
|
Nobody ever used the return values anyway, so for reading just
return the string and for writing the number of bytes written
Doesn't need to be members, make standalone functions
Rename to
read_lenPrefixed_uInt8s_ToO[U]String and
write_lenPrefixed_uInt8s_FromO[U]String, lengthy,
but much less unambiguous, seeing as a lot of users of it don't
seem to be aware that they read/write pascal-style length
prefixed strings, which isn't surprising given the
apparent simplicity of their original name.
added a unit test
|
|
|
|
|
|
Clearly this iteration and reading of the referer, that is then
subsequently not used at all by the method, can go.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This reverts commit f4b3bd91ca177101d90f522e81163dc6421e14c9.
|
|
|
|
|
|
Now that we have removed all the pointless clutter, we can finally make it
possible to create a file dialog that has a link checkbox but not dozens of
graphic filters pre-registered: only add them if SFXWB_GRAPHIC is given.
|
|
There are currently 2 different ways to specify what kind of file dialog
should be created: the nDialogType and nFlags ctor parameters.
Simplify that by using the nDialogType for the API specified variety,
and the nFlags only for options that cannot be specified by the API.
This allows to get rid of 3 constructors, and the following constants:
WB_OPEN, WB_SAVEAS, WB_PASSWORD, SFXWB_PASSWORD, SFXWB_SHOWSTYLES
|
|
|
|
|
|
|
|
|
|
This can really be derived from the dialog type, don't duplicate it.
|
|
|
|
|
|
Once smaller than 1582-10-15 decrementing a Date will not produce a valid date.
|
|
type given, *not* if the type is correct, but the sequence is merely empty
* found as LGPLv3-only fix at svn rev 1172123 (http://svn.apache.org/viewvc?view=revision&revision=1172123)
|
|
|
|
|
|
If there is no cancel callback for a Cancel button, it's monstrous to dig
around the hierarchy looking for a parent to call EndDialog/Close on. Really
messes up attempts to refactor dialogs.
|
|
|
|
|
|
|
|
|
|
|
