summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)Author
2014-10-11too risky to dlclose basctl once openedCaolán McNamara
e.g. use macro organizer for the first time and launch a macro, user event with handle to basctl function posted Change-Id: I2f0f4a7536f071926ea1bd6994f8178fbd4a796f
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09Related: fdo#83003 warp directly to the templates/recentfiles on changing modeCaolán McNamara
which has the side-effect that the keyboard and tab key will cycle through all the contents of the start center. Otherwise in the template view on first clicking templates you are "stuck" Change-Id: Iceed2492e8dde28c0ada381ef0f430738441179f
2014-10-09Resolves: fdo#83003 provide a means to return from template viewCaolán McNamara
Change-Id: Ie6d2cfb5ee28fbd9395a49fa074a252c9c6e20ec
2014-10-09-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Ia7370c4aaa6c0bf69eab13979b6d2209dae695f0
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09fdo#75757: remove inheritance to std::vectorMichaël Lefèvre
from StyleTreeArr_Impl. Change-Id: I44621f913fc1b7ce0da9f41e4e0864edaea474b2 Reviewed-on: https://gerrit.libreoffice.org/11826 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09Add missing title to Template Properties dialogAdolfo Jayme Barrientos
And disable manual resizing Change-Id: I3c78b09930833eb84bbd84a553d2f07ff8573e0b Reviewed-on: https://gerrit.libreoffice.org/11870 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-08loplugin:unreffunStephan Bergmann
Change-Id: I686835f07525fa77caf292d8ee746c120e3331e3
2014-10-08fdo#75757: remove inheritance to std::vectorMichaël Lefèvre
Change-Id: I17b1057c2551f41b15547d7563434e3344ab6be8 Reviewed-on: https://gerrit.libreoffice.org/11822 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-08fdo#80927: css.office.Quickstart should be single-instance service.Matúš Kukan
Incorrectly converted in a384b21cc40818bf3c918951a086a30b5d9d8022 where SFX_IMPL_ONEINSTANCEFACTORY was used. AFAICS it's the first converted single-instance service which implements css::lang::XInitialization. That's kind of strange but can do its job. sbergman@redhat.com: Three things were necessary in order to not call the ~ShutdownIcon code too late during exit now: * Move the relevant code from ~ShutdownIcon to ShutdownIcon::disposing. * Add a dummy <singleton name="com.sun.star.office.theQuickstart"/> so the service manager will eventually dispose the (single) instance. * In cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments do not shortcut updateDisposeSingleton in that odd case of calling createInstanceWithArguments on an implementation that (effectively) is a singleton (as otherwise the service manager would still not dispose it). It looks to me like that "return inst;" was an inadvertent leftover in 874c481801434d4fac3c50f076bff0fe3a3988b6 "Simplify service manager's tracking of singletons" and wasn't intended to serve some subtle purpose. Change-Id: Icd4d3168ec0bbb820b17ac321fe897ac9f9ce7fc
2014-10-08back out more wrong and confusing tools::Time comment changesEike Rathke
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script to change all ... Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08Do not terminate desktop from a TimerStephan Bergmann
<sberg> kendy, as you recently changed Timer handling on Windows: debugging why quickstarter no longer works on Windows, I run into the phenomenon that IdleTerminate::Timeout (sfx2/source/appl/shutdownicon.cxx) executes on the main thread, and from within the m_xDesktop->terminate() call Timer::ImplDeInitTimer is called which deletes the pTimerData corresponding to our IldeTerminate, so that Timer::ImplTimerCallbackProc, after the return from IdleTerminate::Timeout, will operate on a stale pTimerData and crash; could that be related to those recent changes? <kendy> sberg: I think mst told that we were previously never deleting the timer, and that he did some changes there [...] <mst__> sberg, IdleTerminate needs a different implementation <mst__> sberg, does it work to do this via PostUserEvent, as "Application::Quit()" does? <sberg> mst__, do you think calling terminate from a Timer did work in the past? [...] <mst__> sberg, perhaps it did before [a recent] commit but i would guess it would be more by accident than by design Change-Id: I23b14ba59a963cc2209a261a1459d532a88acdc0
2014-10-08Fix build.Jan Holesovsky
Change-Id: I9676e38029c511678efed1679f9488f1f15f4f8d
2014-10-08usage info: Improve the 'what is this for' comment.Jan Holesovsky
Change-Id: If423bd3fde53695be33a4f890f7d363ccce8dbf0
2014-10-08usage info: Code to collect actions that the user performs.Jan Holesovsky
Handles the .uno: and .slot: commands. Cannot load / save the info yet, only dumps it to the screen at the application exit. Disabled in the code now, needs a configuration option. Change-Id: I4e689f534fe5c8a5af84df472e47f276fb7af89b
2014-10-08sfx2: missing semicolonMiklos Vajna
Change-Id: Id1c6357c84e03c71136eb92434002e5e0a4b71d7
2014-10-07Don't even attempt to unload libqstart_gtklo.so againStephan Bergmann
...for no apparent gain. IdleUnloader introduced in a8b42ddd66bba4b6f26a4d2d793051752989938e "Fix i#101245#" was probably a misguided reaction to osl::Module's dtor starting to call dlclose back then. Change-Id: I9a5e99d8cfba13e3750331597d64f58135537e9b
2014-10-06fdo#71248 Excel VBA: ActiveDocument is not tracking currently selected DocJustin Luth
Change-Id: I86606646206ec26e2822a6e27888537d44351b7b Reviewed-on: https://gerrit.libreoffice.org/11725 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-06fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed Reviewed-on: https://gerrit.libreoffice.org/11648 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-03coverity#1242479 Dereference null return valueCaolán McNamara
Change-Id: Ie9a9a3438408900d4a5e07b50f4e636e06f94026
2014-10-03loplugin: cstylecastNoel Grandin
Change-Id: I011a0eae37d01606d28c00f8ab3839f20bf309ce
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02coverity#1242501 Resource leakCaolán McNamara
Change-Id: I0c684565e2d5e83d7d1bb99b3d8011a1d87994d5
2014-10-02coverity#1242827 Uninitialized pointer fieldCaolán McNamara
Change-Id: I029a1fba2a204b9b2b7482258685ab404b06bef8
2014-10-02coverity#1242843 Unused valueCaolán McNamara
Change-Id: Ib7d87cfb4647b0495a122a4d63578afb5d54a965
2014-10-02coverity#1242857 Unused valueCaolán McNamara
Change-Id: I015952c56ea686f307b0b5ccaad29ace9ebfa301
2014-10-02coverity#1242904 error code overwrittenCaolán McNamara
Change-Id: Ie5dcc39f05d7fd21a873ac95ca9cc7f00c1961df
2014-10-02coverity#1242921 Result is not floating-pointCaolán McNamara
Change-Id: Iaeb1d6074fa7c9f66810cee563be0850ccc1d769
2014-10-02fdo#75757: remove inheritance to std::vectorTakeshi Abe
from SfxDockArr_Impl, typedef'ing it as boost::ptr_vector<SfxDock_Impl>. Change-Id: Ieb4f065a836cf9314464b9d5f53a09a95a974be8 Reviewed-on: https://gerrit.libreoffice.org/11707 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-02coverity#982429 Division or modulo by zeroCaolán McNamara
Change-Id: I0c75bb8729b359390fb4026496c085f2056230ba
2014-10-02coverity#705707 Resource leakCaolán McNamara
and coverity#705706 Resource leak Change-Id: Ia18954acb430464c94c5dd608abf9d6e8214058a
2014-10-02fix for older compiler, doesn't like <::Noel Grandin
Change-Id: I2d05af506ae38ec3e61c9b6afaf2b39521067005
2014-10-02fix buildNoel Grandin
after commit 039b887c54fd7e8cd8a4964d1633fdfc300e938e "loplugin: cstylecast" Change-Id: If567653833a1f164a72bd9a5a6c0fcf651e9d3c0
2014-10-02loplugin: cstylecastNoel Grandin
Change-Id: I4a230f45e91773fca7d537e91c9e9fb54773cf10
2014-10-01fdo#75757: remove inheritance to std::mapTakeshi Abe
from SfxItemPtrMap. Change-Id: Id7e9667f9b918afaf92d9e71bf0e2c2e9c296474 Reviewed-on: https://gerrit.libreoffice.org/11696 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-01coverity#735489 constant guards dead codeCaolán McNamara
Change-Id: I387dcfb34dd6f1fc74ed929cb6b2833ae8e0f574
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29MSVC 2012 apparently isn't ready yet for std::vector<std::unique_ptr<T>>Stephan Bergmann
...producing error messages about trying to access private undefined unique_ptr copy ctor etc. Partial revert of 014e7933af751bfe0a03867373b82efa806f3a3d "svtools: std::auto_ptr -> std::unique_ptr: ...changing HTMLOptions to std::vector<std::unique_ptr<...>> because boost::ptr_vector<...>::push_back only supports auto_ptr, not unique_ptr," going the awkward std::unique_ptr x(...); push_back(x.get()); x.release(); route instead (which could be simplified if boost::ptr_vector::push_back ever started to support unique_ptr). Change-Id: I15693030a0bbfdedbfdfbe76ede5d0c74f4e5b41
2014-09-29svtools: std::auto_ptr -> std::unique_ptrStephan Bergmann
...changing HTMLOptions to std::vector<std::unique_ptr<...>> because boost::ptr_vector<...>::push_back only supports auto_ptr, not unique_ptr. Change-Id: Ie5f92bc40ce5425dc1c634b17addc2b0dd9bbda3
2014-09-29sfx2: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I7bac4105494cdbbadd4c4d78ce1fcf03b8ccae6c
2014-09-28border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos
Second pass. Change-Id: Ic4702d2ca7a9d54ee4712dcd073006f16b2d5d1d Reviewed-on: https://gerrit.libreoffice.org/11669 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-28fdo#75757: remove inheritance to std::vectorTakeshi Abe
from SfxVerbSlotArr_Impl. Change-Id: I84582f10095638a0fef82aa46f721d57a8b27c27 Reviewed-on: https://gerrit.libreoffice.org/11662 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-27border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos
I know the old GNOME HIG mentions extra spacing for queries, but I’ve never understood why -- not even GNOME itself respects that rule. It just looks inconsistent and wastes space. Change-Id: I181f800957f69b0943369791e460c7273b6b08f6 Reviewed-on: https://gerrit.libreoffice.org/11658 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-27fdo#84376 Add missing title to the Template Manager dialogAdolfo Jayme Barrientos
Change-Id: I514cc4354950119caa4c16d0ccb6b9d18290dee3 Reviewed-on: https://gerrit.libreoffice.org/11659 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove unnecessary casts in calls to SvStream.WriteSCharNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I4f17a2fd6a68f8078b97c96e89e27a5627c57c03
2014-09-26remove unnecessary casts'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
generated by cgit (git 2.34.1) at 2025-02-01 12:40:18 +0000