summaryrefslogtreecommitdiff
path: root/shell/source/backends
AgeCommit message (Collapse)Author
2017-05-11cid#1403658: Try harder to make Coverity Scan happyStephan Bergmann
Change-Id: I109f95a55875b7795fc366825b3a6bb2e897d676
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09Don't use uninitialized ProxyEntry::Port valuesStephan Bergmann
...and get rid of the useless ProxyEntry struct altogether Change-Id: I846f126c96343da17518686e666a7d44c6b1bef1
2017-04-04cid#1403658: Let ImplGetLocale return empty Optional for bad inputStephan Bergmann
...like non-ASCII or too-long env var content on Linux Change-Id: Ic2c536fa92b88108e96a0fc1a657180bc1906f01 Reviewed-on: https://gerrit.libreoffice.org/36067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-23In Unix ImplGetLocale, read env vars instead of calling setlocaleStephan Bergmann
...to avoid the general problems with the latter (MT issues; changing global state) Change-Id: I21eb129b7e1422089b3449763f64f461371ffff1
2017-02-08coverity#1371289 Missing move assignment operatorCaolán McNamara
Change-Id: Idc26faf904f0c89cfd66f53bb311d8ce9b41eaab
2017-02-01loplugin:stringconstantStephan Bergmann
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
2017-02-01loplugin:stringconstantStephan Bergmann
Change-Id: Ic22b9c0c245cca23770a05518534a666e00f9f3e
2017-01-28loplugin:stringconstantJochen Nitschke
Change-Id: I7e90f4fecf7243c7551ec7ecbb29adfa92a86447 Reviewed-on: https://gerrit.libreoffice.org/33648 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27Remove dynamic exception specifications from some TDE-only codeStephan Bergmann
Change-Id: Ic5fa5648d0d52bf5a16b5d3c32c549d5fffb2f4f
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-20can use truncate instead of a new OUStringBufferCaolán McNamara
Change-Id: I6efd48af1e00c21675ef0697b38185008a794d7a
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-15clang-cl loplugin: shellStephan Bergmann
Change-Id: I98d2e5154270b795cdd11653ecfff2abd8dda294 Reviewed-on: https://gerrit.libreoffice.org/29851 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-23TDE fix some clang plugin based warningsJan-Marek Glogowski
Change-Id: I3b44038e8a889e4c13126fd8d721e53e71ea9ec6
2016-09-14loplugin:overrideStephan Bergmann
Change-Id: I7b746d652887d61e6a8a63b5b3ba37e0a158817e
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-12Bin some noise comments and superfluous vertical whitespaceTor Lillqvist
Change-Id: I3c19457bb29cd1392f14598fc8798aed4b1a1a7f
2016-08-23Revert "Remove WorkPathVariable support from KDE backends"Stephan Bergmann
This reverts commit 8da1d7869a2bdbe006265f584e0d9af5046ef723. plus: Revert "Revert "KDE: don't throw on TemplatePathVariable"" This reverts commit 72812a380c0d9587670bae1d1efa8700c874634e. I had misread the code and thought that handling of those two properties in shell/source/backends/desktopbe/desktopbackend.cxx would hide handling them in the specific KDE backends, but that is not actually the case. Change-Id: I32fae5ba34cc934ceca2f574d50fc327b506b001
2016-08-22Remove WorkPathVariable support from KDE backendsStephan Bergmann
...now that b5c05876f73c31270bc374e4f481ef1d09a42e5f "Related: rhbz#1065807 recover using xdg templates and documents settings" handles WorkPathVariable in the generic shell/source/backends/desktopbe/desktopbackend.cxx code. Change-Id: I3920cdb3f54688462813d212569c9b33a1371333
2016-08-22Revert "KDE: don't throw on TemplatePathVariable"Stephan Bergmann
This reverts commit e44a7eefb7f632977b4c8c91ad14244372c6e04d, which is no longer necessary now that b5c05876f73c31270bc374e4f481ef1d09a42e5f "Related: rhbz#1065807 recover using xdg templates and documents settings" handles TemplatePathVariable in the generic shell/source/backends/desktopbe/desktopbackend.cxx code.
2016-08-22tdf#101661: Report XDG_{DOCUMENTS,TEMPLATES}_DIR only when it existsStephan Bergmann
...as had been done in the GConf-based backend prior to 3cf557c12d27f1b2250e69a543136da098112d80 "drop gconf integration as per ESC decision". Change-Id: I56f256aaec542e0a62fc30a37d5c982e93e77812
2016-07-22shell: loplugin:nullptr / staticanonymous / stringconstantMichael Stahl
Change-Id: I67458301fb13601c5bf8d83c689fd861694ee460
2016-07-22Related: rhbz#1065807 recover using xdg templates and documents settingsCaolán McNamara
Change-Id: If2c594174a6fa8c524d9664c9f197cb7c6d4641d
2016-07-22There is no css.configuration.backend.GconfBackendCaolán McNamara
since commit 3cf557c12d27f1b2250e69a543136da098112d80 Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com> Date: Fri Oct 16 12:15:55 2015 +0100 drop gconf integration as per ESC decision Conflicts: shell/source/backends/gconfbe/gconfbackend.cxx Change-Id: If8e9b273e410250b45d3f645f6a31c1e80f02c6c
2016-06-22Work towards tdf#72606 EasyHack _tstring/TCHAR eliminationskswales
shell module largely already compiled UNICODE: A/W clarity Verified by installing release build and trying property sheets etc. Change-Id: I4965cdadbce635d86da1996c3c1bbd37a981ffde Reviewed-on: https://gerrit.libreoffice.org/26556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#94306 replace boost::noncopyable in sfx2 to sotJochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. Make some overloaded ctors explicit, seems cppcheck doesn't flag: T(const template<X>& rx). Change-Id: I63c5a3ac84a33ea6d49868e2d9aa281ada79958e Reviewed-on: https://gerrit.libreoffice.org/24050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-08cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: If1ddb112c85f127295eb55566360b066e7173ba2 Reviewed-on: https://gerrit.libreoffice.org/21245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-02tdf#84263 KDE4: unify includesJan-Marek Glogowski
Use Qt submodule notation for Qt includes and also "correct" some KDE headers AKA use <> notation for external headers. Change-Id: I9457f75baae56514989800b016a11348a72a242b
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: I721f53d79cd3e2c24542382d519a909a86a31111
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: Id3f43ba115d519e789b7eaf014734d2fd31d39cc
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
performed using: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f Reviewed-on: https://gerrit.libreoffice.org/19968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite; Mac-specific code)Stephan Bergmann
Change-Id: Iaa14c583c55c3582e33a1d073ea92b388cd6f3a4
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: Ied61699170bd5d2c3878135b1a43b4dc1deff4d4
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: I7cf9fe48cf1c38a4327290e9393a5f88f3d4a97d
2015-11-04loplugin:stringconstantStephan Bergmann
Change-Id: Ib579c499904bf10844ed58dfd3e531002b308dcf
2015-11-04yyyyyNoel Grandin
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-10-29com::sun::star->css in shellNoel Grandin
Change-Id: Id74a5e79764f37944afab4d2a0dcfc7dbfc9b295 Reviewed-on: https://gerrit.libreoffice.org/19663 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-26remove extra spaces around ::Noel Grandin
just makes it harder to grep for methods Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-16drop gconf integration as per ESC decisionBjoern Michaelsen
Conflicts: shell/source/backends/gconfbe/gconfbackend.cxx Change-Id: I609ec83ec59f5ae8d3a8c9c09649695bfcb03b87 Reviewed-on: https://gerrit.libreoffice.org/19408 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-03shell: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I0eb2efbd123198c7d8a99e9dd7c613f9b2b23c2d Reviewed-on: https://gerrit.libreoffice.org/18286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-09-03remove KDE3 support, --enable-kde and --enable-kdeabMichael Stahl
With the new RHEL6-era baseline TDF can finally ship KDE4 support. Change-Id: I227278b576a3ed2f2aaa751d41b469ca92dc78b3 Reviewed-on: https://gerrit.libreoffice.org/18267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: Idc3c74505d84a96bb5cc6713a95ef2fadc267ea8
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: I2e97fa10baa6a9bd290fabe250cf73d5f73e4537
2015-07-17formatting of public/private/protected section qualifiersNoel Grandin
make it consistent across the codebase, no space between keyword and the colon Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5 Reviewed-on: https://gerrit.libreoffice.org/17148 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-15 05:24:42 +0000