summaryrefslogtreecommitdiff
path: root/shell/source/win32
AgeCommit message (Collapse)Author
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-11tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I replaced OSL_DEBUG_LEVEL > 2 conditionals with OSL_DEBUG_LEVEL > 0 conditionals Change-Id: Ibfb3a4e00da7ef6a213dcd4659c7963935cfad1f Reviewed-on: https://gerrit.libreoffice.org/23081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-07tdf#96099 Reduce number of trivial typedefsChirag Manwani
Change-Id: I39e9fcfdf2203239ac56d1c8195ca7ac07054817 Reviewed-on: https://gerrit.libreoffice.org/22898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17Typo: namesapce(s)->namespace(s)Julien Nabet
Change-Id: Ic7c14c2e39a5ade1f5622a8350f9197d84cf9cc8
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-08cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: If1ddb112c85f127295eb55566360b066e7173ba2 Reviewed-on: https://gerrit.libreoffice.org/21245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-08Resolve Linker Warning LNK4104Mike Kaganski
See https://msdn.microsoft.com/en-us/library/e821azx1.aspx Some export symbols should be PRIVATE Also, don't export DLLMain. It is internal function used by CRT, and not intended to be exported. Change-Id: I48139b985aa2ee499c2005d8b0d966a2cc6dcd0c Reviewed-on: https://gerrit.libreoffice.org/20419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2015-11-28-Werror,-Wdelete-non-virtual-dtorStephan Bergmann
"thumbviewer.cxx(168,9) : error: delete called on 'StreamOnZipBuffer' that has virtual functions but non-virtual destructor" Change-Id: I34510d54b9a99d8f1f9e8da0236625023c3fd94c
2015-11-28-Werror,-Wduplicate-decl-specifier (extern "C" already in STDAPI)Stephan Bergmann
Change-Id: I2f170c8ad2ef30f49062fdeee4bcdcf5baf552db
2015-11-28-Werror,-Wunused-functionStephan Bergmann
...since ce59f8851472776f2ea364f7597ac887e77081c5 "INTEGRATION: CWS desktintgr03: #i34294#" commented out the uses (whicht got later removed completely with 45f0cc2ec176f02592a4e67942b1220f7837ab9f "Remove commented code in libs-core/shell") Change-Id: Icb7f97b72634d07045f5880af33b372be36e66b2
2015-11-18-Werror,-Wunused-variableStephan Bergmann
Change-Id: I7ac641d052643b205f7e470de77d962dd0499dd8
2015-11-18-Werror,-Wduplicate-decl-specifier (extern "C" already in STDAPI)Stephan Bergmann
Change-Id: Ibd633b37e134483b778dcf7bdee1a1a3f377b699
2015-11-18-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: Id3885ec6323393d07def1915b95ee02e0c3dc402
2015-11-18-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: I6e4aa7c0a3b420820d8581ce1a4a826fa777525c
2015-11-18-Werror,-Wsizeof-pointer-memaccessStephan Bergmann
Change-Id: I08d4331e5b2c9d17d16b1415d321c4f38322c251
2015-11-18-Wmissing-braces is globally disabled in com_GCC_defs.mk anywayStephan Bergmann
Change-Id: Ie2a1e6785ac925f268e63775f2282df3f3c6bcd4
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: Ib93d762cf523e0029bbed16e08beebd9f418ae24
2015-10-29com::sun::star->css in shellNoel Grandin
Change-Id: Id74a5e79764f37944afab4d2a0dcfc7dbfc9b295 Reviewed-on: https://gerrit.libreoffice.org/19663 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-26remove extra spaces around ::Noel Grandin
just makes it harder to grep for methods Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-09-30Fix typosAndrea Gelmini
Change-Id: I89ff6d31662824d83961d6457b82db8d8031168c Reviewed-on: https://gerrit.libreoffice.org/18977 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-03shell: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I0eb2efbd123198c7d8a99e9dd7c613f9b2b23c2d Reviewed-on: https://gerrit.libreoffice.org/18286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-23tdf#39440 cppcheck: redundantAssignmentMichael Weghorn
This addresses some of cppcheck's "redundantAssignment" warnings ("Variable '<varName>' is reassigned a value before the old one has been used"). Change-Id: I8fd2950d5aa1a3f4bd9e1c4c336abe465d1f657e Reviewed-on: https://gerrit.libreoffice.org/17926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13warning C4101: unreferenced local variableStephan Bergmann
Change-Id: I3d2d46c7b722557f3dbfd95eb2b8649f8078d4df
2015-07-13Code deliberately not linking against sal just can't use OSL_ENSUREStephan Bergmann
Change-Id: I20820ea382ac9933bf2c6118d466625120b49d67
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-01tdf#92269 fix Windows Explorer crash caused by shellextensionChristian Lohmaier
wcscpy_s is buffer size, not string length, so size must also account for a terminating NULL Change-Id: Ie69692e47c142f3b733b093d0b87fa4bb03db7b4
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-13tdf#82695 allow to build with system collada2gltfDavid Tardon
Change-Id: I1179e20fd5fbdecd198633d5440621ed08a0465b
2015-04-01Typo: wheter->whetherJulien Nabet
Change-Id: Iab5e7de499452924b4ac0d34cc604ee38395c813
2015-03-25Typo: formated->formattedJulien Nabet
Change-Id: Iefd4d375a0dfb36732233852f906c6b85dccc2a5
2015-03-24Fix various Windows-only XServiceInfo implementationsStephan Bergmann
...to match what is recorded in the .component files Change-Id: Ibc5bb0575f3869317e4d14614cf1dad0af728ddc
2015-03-17Fix various XServiceInfo implementationsStephan Bergmann
...to match what is recorded in the .component files Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-11V512: we want the number of wide-chars here, not the number of bytesCaolán McNamara
Change-Id: I121cdfd586562b9ce298448f51d0b2e3b2a52c39
2015-03-11leak on short readCaolán McNamara
Change-Id: I5da7ec2992f9f0b20aa075ee33d0b882cdf91901
2015-03-11V668 no sense in testing the result of new against nullCaolán McNamara
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-09V801: Decreased performanceCaolán McNamara
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-03-05shell: warning C4996 function call with parameters that may be unsafeMichael Stahl
Change-Id: Id70289b0c88dd203cac6301303fe7452088f60f9
2015-03-04V813: Decreased performanceCaolán McNamara
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-01unnecessary wstring -> char* -> wstring conversionMarkus Mohrhard
Change-Id: I21e6036a5156ed62f2c7bff6439c64d0178c96e4
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-07fdo#43368 Remove MapiLogon/Logoff calls so simplemail works with WLMAron Budea
Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: shell/source/win32/simplemail/senddoc.cxx Change-Id: I31cac063ffb4afbfde068558ebcf5f66ea34d1a8