summaryrefslogtreecommitdiff
path: root/shell
AgeCommit message (Collapse)Author
2017-02-12"Unicode" is a proper noun and should not be used in pluralTor Lillqvist
The 16-bit things that make up the UTF-16 encoding are called "code units". Change-Id: Iab2b83323783e518198c1a0553f7b053fc415985
2017-02-10Remove MinGW supportStephan Bergmann
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-08coverity#1371289 Missing move assignment operatorCaolán McNamara
Change-Id: Idc26faf904f0c89cfd66f53bb311d8ce9b41eaab
2017-02-08loplugin:useuniqueptr (clang-cl)Stephan Bergmann
Change-Id: I9b9a6af2a7ff2dd64c474ec7f2dd084d4feb76f0
2017-02-08Add missing #includesStephan Bergmann
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-02loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I7a45ef38380d62ddb847bab87a2ee15ca67621fc
2017-02-02loplugin:useuniqueptrStephan Bergmann
Change-Id: I3a246a22baaac8195dc1b94c42994de7d80e8336
2017-02-01loplugin:stringconstantStephan Bergmann
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
2017-02-01loplugin:stringconstantStephan Bergmann
Change-Id: Ic22b9c0c245cca23770a05518534a666e00f9f3e
2017-01-28loplugin:stringconstantJochen Nitschke
Change-Id: I7e90f4fecf7243c7551ec7ecbb29adfa92a86447 Reviewed-on: https://gerrit.libreoffice.org/33648 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27Remove dynamic exception specifications from some TDE-only codeStephan Bergmann
Change-Id: Ic5fa5648d0d52bf5a16b5d3c32c549d5fffb2f4f
2017-01-27improve "unnecessary user-declared destructor" checkNoel Grandin
to look for inline&empty destructors, where we can just let the compiler do it's thing Change-Id: Ibde8800bdfed6b77649c30ebc19921167c33dec3 Reviewed-on: https://gerrit.libreoffice.org/32999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-20can use truncate instead of a new OUStringBufferCaolán McNamara
Change-Id: I6efd48af1e00c21675ef0697b38185008a794d7a
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann
Change-Id: I9efdd5136fdf793e0075b91fcfae4fed42050109
2017-01-10New loplugin:conststringvar: shellStephan Bergmann
Change-Id: Ie375164d9c461c25d256f321e4efd0aedc73a263
2017-01-09New loplugin:externvar: shellStephan Bergmann
Change-Id: I280df3f20a45763d6d615ee9104a19c58ff4a046
2016-12-24tdf#90753: AutoInstall shell_senddoc packageMatúš Kukan
Change-Id: I6cc638c460a8baa2cd9d29c3b82418b6ecfb630d Reviewed-on: https://gerrit.libreoffice.org/32397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2016-12-14Dead codeStephan Bergmann
Change-Id: I70078bf77786772795bc569407a9e6ac372df758
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01loplugin:oncevar in sd..svgioNoel Grandin
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c Reviewed-on: https://gerrit.libreoffice.org/30459 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-15clang-cl loplugin: shellStephan Bergmann
Change-Id: I98d2e5154270b795cdd11653ecfff2abd8dda294 Reviewed-on: https://gerrit.libreoffice.org/29851 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-23TDE fix some clang plugin based warningsJan-Marek Glogowski
Change-Id: I3b44038e8a889e4c13126fd8d721e53e71ea9ec6
2016-09-15loplugin:singlevalfields in sc..vclNoel Grandin
Change-Id: I68752a3daf5ddd8581c07759b8be2c1dabbb9258
2016-09-14loplugin:overrideStephan Bergmann
Change-Id: I7b746d652887d61e6a8a63b5b3ba37e0a158817e
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13add xdg-email as the default email routeCaolán McNamara
because xdg-email is apparently the only route that knows how to support adding an attachment to thunderbird Change-Id: Ife1b56ccfe2434eb31ad67bef00f55197e96151e
2016-09-12Bin some noise comments and superfluous vertical whitespaceTor Lillqvist
Change-Id: I3c19457bb29cd1392f14598fc8798aed4b1a1a7f
2016-09-09loplugin:constantparam in sfx2Noel Grandin
Change-Id: If5d401001abb7bf3fc642d47f537b57836e6d9c5 Reviewed-on: https://gerrit.libreoffice.org/28772 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25new loplugin: countusersofdefaultparamsNoel Grandin
Change-Id: I79e2c690f3e664c14af12cf763dd5a8ac20d6b04 Reviewed-on: https://gerrit.libreoffice.org/28353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-23Revert "Remove WorkPathVariable support from KDE backends"Stephan Bergmann
This reverts commit 8da1d7869a2bdbe006265f584e0d9af5046ef723. plus: Revert "Revert "KDE: don't throw on TemplatePathVariable"" This reverts commit 72812a380c0d9587670bae1d1efa8700c874634e. I had misread the code and thought that handling of those two properties in shell/source/backends/desktopbe/desktopbackend.cxx would hide handling them in the specific KDE backends, but that is not actually the case. Change-Id: I32fae5ba34cc934ceca2f574d50fc327b506b001
2016-08-22Remove WorkPathVariable support from KDE backendsStephan Bergmann
...now that b5c05876f73c31270bc374e4f481ef1d09a42e5f "Related: rhbz#1065807 recover using xdg templates and documents settings" handles WorkPathVariable in the generic shell/source/backends/desktopbe/desktopbackend.cxx code. Change-Id: I3920cdb3f54688462813d212569c9b33a1371333
2016-08-22Revert "KDE: don't throw on TemplatePathVariable"Stephan Bergmann
This reverts commit e44a7eefb7f632977b4c8c91ad14244372c6e04d, which is no longer necessary now that b5c05876f73c31270bc374e4f481ef1d09a42e5f "Related: rhbz#1065807 recover using xdg templates and documents settings" handles TemplatePathVariable in the generic shell/source/backends/desktopbe/desktopbackend.cxx code.
2016-08-22tdf#101661: Report XDG_{DOCUMENTS,TEMPLATES}_DIR only when it existsStephan Bergmann
...as had been done in the GConf-based backend prior to 3cf557c12d27f1b2250e69a543136da098112d80 "drop gconf integration as per ESC decision". Change-Id: I56f256aaec542e0a62fc30a37d5c982e93e77812
2016-08-16new loplugin to check for static OUStringsNoel Grandin
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: https://gerrit.libreoffice.org/27377 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11loplugin:constantparamNoel Grandin
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01loplugin:countusersofdefaultparams in shell..starmathNoel Grandin
Change-Id: I553d1b031b8d261a1caa8b77a8d687af21a6f8d6 Reviewed-on: https://gerrit.libreoffice.org/27672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-22shell: loplugin:nullptr / staticanonymous / stringconstantMichael Stahl
Change-Id: I67458301fb13601c5bf8d83c689fd861694ee460
2016-07-22Related: rhbz#1065807 recover using xdg templates and documents settingsCaolán McNamara
Change-Id: If2c594174a6fa8c524d9664c9f197cb7c6d4641d
2016-07-22There is no css.configuration.backend.GconfBackendCaolán McNamara
since commit 3cf557c12d27f1b2250e69a543136da098112d80 Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com> Date: Fri Oct 16 12:15:55 2015 +0100 drop gconf integration as per ESC decision Conflicts: shell/source/backends/gconfbe/gconfbackend.cxx Change-Id: If8e9b273e410250b45d3f645f6a31c1e80f02c6c
2016-07-05Workaround to call /app/bin/xdg-open when run under flatpakStephan Bergmann
LibreOffice wants to open URLs by calling /usr/bin/xdg-open, which the flatpak org.gnome.Platform runtime does not provide. However, <https://github.com/flatpak/xdg-desktop-portal> will provide a Desktop portal through which an application can make an OpenURI request. So the idea is to include a fake xdg-open application in the LO flatpak, that will use gdbus to call that portal. However, I see no way to make the LO flatpak provide that as /usr/bin/xdg-open, so instead provide it as /app/bin/xdg-open and hack LO to use that path when run under flatpak (where the LIBO_FLATPAK environment variable is already used for the OfficeIPCThread). Change-Id: I63bc0bfb937ef767958ba4d34b0c3653e38ec868
2016-06-22Work towards tdf#72606 EasyHack _tstring/TCHAR eliminationskswales
shell module largely already compiled UNICODE: A/W clarity Verified by installing release build and trying property sheets etc. Change-Id: I4965cdadbce635d86da1996c3c1bbd37a981ffde Reviewed-on: https://gerrit.libreoffice.org/26556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I97f0ed6c3f4fa36523b6ecc05ab8b4e79a3a3c91
2016-04-19WIP tdf#89609 Ignore subsecond precision in iso8601Muhammet Kara
Explorer shell extension fails to convert date into locale specific string if it has sub-second precision. Change-Id: I11bd38fc2876aa1f8235dbfb8c7850ff22ac2a8b Reviewed-on: https://gerrit.libreoffice.org/24220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13tdf#94306 replace boost::noncopyable in sfx2 to sotJochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. Make some overloaded ctors explicit, seems cppcheck doesn't flag: T(const template<X>& rx). Change-Id: I63c5a3ac84a33ea6d49868e2d9aa281ada79958e Reviewed-on: https://gerrit.libreoffice.org/24050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-02 20:03:06 +0000