summaryrefslogtreecommitdiff
path: root/shell
AgeCommit message (Collapse)Author
2020-01-28tdf#130216: normalize paths with .. segmentsMike Kaganski
... which obviously are rejected by SHGetFileInfoW and SHParseDisplayName that it calls internally. Change-Id: I2f5f3c675ea6aa1c2d92eef30be4399a8d600255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87565 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-17Clean up computation of preprocessed_command passed to ShellExecuteExWStephan Bergmann
* In the URIS_ONLY case (which is intended to open documents etc.), set preprocessed_command to the filesystem pathname the first time that is computed (and which will no longer fail for file URLs with fragment since 14b36a16b225bf7c988f118d499a7287c47cd83e "Remove a fragment from a file URL early on"). * In the !URIS_ONLY case (which is intended to run other programs), we will generally be called with aCommand already being a filesystem pathname. But even if it should be a file URL, it appears to be OK to pass that as-is to ShellExecuteExW: At least on Windows 8, passing "file:///C:/Windows/System32/notepad.exe" does start it. * The code for <https://bz.apache.org/ooo/show_bug.cgi?id=4789> "Hyperlinks doesnt works" should no longer be relevant: In the URIS_ONLY case, any fragment (called a "jump mark" in that code) has already been removed from the incoming URL now. In the !URIS_ONLY case, we should generally not be called with a URL with a fragment, but even if we are, it should be OK to pass that as-is to ShellExecuteExW and let it handle that (see above). * Similarly, the code for <https://bugs.documentfoundation.org/show_bug.cgi?id=54204> "Hyperlinks between documents not works if link contains anchor at the end" is no longer relevant for the same reason. Change-Id: Ia6ec80a30f6d0603bccc87b9d6dd93ca6a84c370 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86975 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-15Remove a fragment from a file URL early onStephan Bergmann
...as ShellExecuteExW would ignore it anyway Change-Id: I969db094bb7d2ea230ac8c36eb23d71a90fbe466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86868 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-11loplugin:finalclasses in starmathNoel Grandin
Change-Id: I65ac9a8767c298c50606a3b269a227dd1513a112 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-22sal_Char->char in sfx2..slideshowNoel Grandin
Change-Id: I59667664fc097989e0a78d8876f2be8353911236 Reviewed-on: https://gerrit.libreoffice.org/85701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-10loplugin:unusedmember (clang-cl)Stephan Bergmann
PROPERTYMAP members pszXPathParent and pszValueNodeName were unused ever since 85e0cc246d4350122b17fbe2bfd15635a190ad77 "dv17: #i70994#: Use property handler instead of column info for Windows Vista" introduced the code. (And removing them allowed to simplify the code further in the obvious way.) Change-Id: Ie1247cbee31a172a15fd57c4b752d74711b1d3a1 Reviewed-on: https://gerrit.libreoffice.org/84860 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-06loplugin:external (macOS)Stephan Bergmann
* OldEntry in fpicker/source/aqua/resourceprovider.mm was apparently unused ever since it got introduced with 00657aef09d854c74fb426a935a3e8b1fc390bb0 "migrate to boost::gettext" * impl_throwError is used from multiple TU, connectivity/source/drivers/macab/MacabStatement.cxx just missed the relevant #include Change-Id: Iba131da57aa20085bb1c634ba9a3a59566070abd Reviewed-on: https://gerrit.libreoffice.org/84653 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-05loplugin:external (clang-cl)Stephan Bergmann
...plus loplugin:consttobool and loplugin:fakebool fallout Change-Id: Ie3d8121815c080b13bea6d9deca1eb138ca56138 Reviewed-on: https://gerrit.libreoffice.org/84515 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03remove some useless comment linesNoel Grandin
which merely announce that the next declaration is a class Change-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc Reviewed-on: https://gerrit.libreoffice.org/84229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-26loplugin:consttobool (clang-cl)Stephan Bergmann
Change-Id: I81fea38cd737a8be74e6ece333ca37cc434a1c33 Reviewed-on: https://gerrit.libreoffice.org/83765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19loplugin:fakebool (clang-cl)Stephan Bergmann
...plus follow-up loplugin:implicitboolconversion and loplugin:redundantcast Change-Id: I9fc9c5cb46fbb50da87ff80af64cb0dfda3e5f90 Reviewed-on: https://gerrit.libreoffice.org/83207 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: I9da73ceef20a0b2535694438a3a6b20876dccd0f Reviewed-on: https://gerrit.libreoffice.org/83208 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15tdf#128538: Open filesystem directories in Finder after allStephan Bergmann
Where option "-R" means, according to the open(1) man page: "Reveals the file(s) in the Finder instead of opening them." This appears to always reveal in Finder, even for *.app "application directories", so should not affect CVE-2019-9847.) Change-Id: I775db7bf71c09adc6570931a977b82dfee8dc95a Reviewed-on: https://gerrit.libreoffice.org/82749 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-12tdf#54204 File URLs with fragment need toIUri conversionTünde Tóth
Non-ASCII file links didn't work when the link contains anchor at the end. Note: The "correct" way to convert from a LO-internal to -external file URL would be the translateToExternal method of the css.uri.ExternalUriReferenceTranslator UNO service. But that translates the URL to be interpreted according to the current Windows code page (i.e., osl_getThreadTextEncoding), so only supports characters covered by that code page, and given that the result is passed into a Windows wchar_t API, ToIUri nicely avoids such potential conversion failure. Change-Id: I1a5b07366b0fea3da2fbe11a9378aacd765b5e04 Reviewed-on: https://gerrit.libreoffice.org/82219 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23loplugin:stringadd (clang-cl)Stephan Bergmann
Change-Id: I324496ff7c61d87a83b6b378810aa5c78cd7dba3 Reviewed-on: https://gerrit.libreoffice.org/81405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17Remove some memset callsMike Kaganski
Replace them with default initialization or calloc Change-Id: I747f53c2ced2d0473fd5a5ede4f8520a0633dcc1 Reviewed-on: https://gerrit.libreoffice.org/80805 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-14loplugin:stringadd look for unnecessary temporariesNoel Grandin
which defeat the *StringConcat optimisation. Also make StringConcat conversions treat a nullptr as an empty string, to match the O*String(char*) constructors. Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b Reviewed-on: https://gerrit.libreoffice.org/80724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-02-Werror,-Wmicrosoft-exception-spec (clang-cl)Stephan Bergmann
No idea why that started to show up now, but C:/Program Files (x86)/Windows Kits/10/Include/10.0.17763.0/um/combaseapi.h contains > #define STDMETHOD(method) virtual COM_DECLSPEC_NOTHROW HRESULT STDMETHODCALLTYPE method while C:/Program Files (x86)/Windows Kits/10/Include/10.0.17763.0/um/winnt.h contains > #define STDMETHODIMP HRESULT STDMETHODCALLTYPE which caused failures like > [build CXX] embedserv/source/inprocserv/dllentry.cxx > embedserv/source/inprocserv/dllentry.cxx(261,40): error: 'QueryInterface' is missing exception specification '__attribute__((nothrow))' [-Werror,-Wmicrosoft-exception-spec] > STDMETHODIMP InprocEmbedProvider_Impl::QueryInterface( REFIID riid, void ** ppv ) > ^ > embedserv/source/inprocserv/dllentry.cxx(143,15): note: previous declaration is here > STDMETHOD(QueryInterface)(REFIID riid, void ** ppvObj) override; > ^ Change-Id: I0fe3554c2da4089bf0f883e1132d6f2ee95ae2c3 Reviewed-on: https://gerrit.libreoffice.org/79970 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01-Werror,-Wswitch (clang-cl)Stephan Bergmann
Change-Id: I3d40104d6822ebb80ebec44b36bcdfa5c7e953ed Reviewed-on: https://gerrit.libreoffice.org/79960 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:returnconstval (clang-cl)Stephan Bergmann
Change-Id: Id1bcc878f40fba804f78f7a5b7cd463db8dc5988 Reviewed-on: https://gerrit.libreoffice.org/79957 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:sequenceloop (clang-cl)Stephan Bergmann
Change-Id: Ie55967043fd6584c8b9a0ad66fad118c70bda8f0 Reviewed-on: https://gerrit.libreoffice.org/79927 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:data (clang-cl)Stephan Bergmann
Change-Id: Ib8b2bc1c5f7b27a646036ce23cae2b6a06edd038 Reviewed-on: https://gerrit.libreoffice.org/79922 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:stringconstant (clang-cl)Stephan Bergmann
Change-Id: Id1a82cea4444255fdb693e126b7571a406094624 Reviewed-on: https://gerrit.libreoffice.org/79916 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:simplifyconstruct (clang-cl)Stephan Bergmann
Change-Id: I08da288a88c2bce1d4250ec77f17bd483e6bc09c Reviewed-on: https://gerrit.libreoffice.org/79911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27cid#1448334 silence Untrusted value as argumentCaolán McNamara
Change-Id: I13f626c29ceeafbca91b06e5efd11b79b0f25a76 Reviewed-on: https://gerrit.libreoffice.org/79679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24tdf#127710: fix sending documents to Claws MailJulien Nabet
Thanks to the Paul's (paul@claws-mail.org) contribution Change-Id: Ie4144ab78691b33d8d341d4520c40c56010a0dd8 Reviewed-on: https://gerrit.libreoffice.org/79423 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for ".." instead of "..." between words. It passed "make check" on Linux. Change-Id: I144d8061fca9f545c762941551e59dffdd3650e8 Reviewed-on: https://gerrit.libreoffice.org/78357 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-31Add version resource to executables where it was missingMike Kaganski
Change-Id: Iee965c3f720827b20347f6228e891562c8295d22 Reviewed-on: https://gerrit.libreoffice.org/78327 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-30Introduce gb_Executable_add_default_nativeres to add version resourceMike Kaganski
... to executables on Windows Change-Id: I31bd2447052915bb299820034f99128e0e97db54 Reviewed-on: https://gerrit.libreoffice.org/78290 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-22kf5backend.cxx: Use 'free()' instead of 'delete'Michael Weghorn
'strdup' doc [1] mentions: "The returned pointer must be passed to 'free' to avoid a memory leak." This silences a "Mismatched free() / delete / delete []" error that valgrind outputs. [1] https://en.cppreference.com/w/c/experimental/dynamic/strdup Change-Id: I28877be762256a7b995c09415a8ad9977b7998c4 Reviewed-on: https://gerrit.libreoffice.org/77974 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-08-15loplugin:sequenceloop in shell..sotNoel Grandin
Change-Id: I40e2a1be0ce7df627d3820192d24821ddd7c3e2f Reviewed-on: https://gerrit.libreoffice.org/77527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ic431ef6c3555f02fbc204a5b0af5f9bfe62f4a30 Reviewed-on: https://gerrit.libreoffice.org/77286 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-10loplugin:stringconstant (macOS)Stephan Bergmann
Change-Id: Icb9d9e1cd21e2506e36fe40a3b93b6a2521a868c Reviewed-on: https://gerrit.libreoffice.org/77239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-01tdf#126641: don't fail on file URLs with fragmentMike Kaganski
This only fixes part that the URL refuses to open the target file. Honoring fragment isn't fixed here, since it's the system call to ShellExecuteExW that in this case internally converts the file URL into a system path, and strips the fragment from it. Regression from commit d59ec4cd1660410fa1b18c50d2d83b1417a82ddc. Change-Id: I6c9ed27e9a5bd7f2780dd3be96f816a6e825e043 Reviewed-on: https://gerrit.libreoffice.org/76778 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): shellStephan Bergmann
Change-Id: I0045eac5f2395f56dcb1ed8a958c93c28de496a9 Reviewed-on: https://gerrit.libreoffice.org/76647 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-30tdf#126597 don't use modeless dialog for senddoc.exeJan-Marek Glogowski
There is already a large comment in initAttachmentList about problems with MAPI_DIALOG_MODELESS. Using MAPI_DIALOG_MODELESS with Outlook 2016 and multiple attachments sometimes produces a MAPI_E_FAILURE, but most times it crashes for me. And it's not a problem with the removed temporary files, as uncommenting that shows the same problem. And there seems to be many more problems: https://social.msdn.microsoft.com/Forums/en-US/5d8fece6-9d93-490c-9331-625c17e3291d/mapisendmailhelper-and-mapidialogmodeless But actually I don't see any blocking of LO, if I switch to using MAPI_DIALOG, as senddoc.exe already runs in the background. So this switches MAPI_DIALOG_MODELESS to MAPI_DIALOG. This reverts commit 5874c76371562c3e2d8564b1fb04df1997091d27 ("tdf#116074: Use modeless dialogs with supporting mailers"). Change-Id: Ie0f8f22196d1a174dfeada2bc4aabb1717ee16a7 Reviewed-on: https://gerrit.libreoffice.org/76155 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-30Fix typosAndrea Gelmini
It passed "make check" Change-Id: I50c3639ec258c7fb6d73104f8e777f96995aa8e3 Reviewed-on: https://gerrit.libreoffice.org/76543 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-28Fix typosAndrea Gelmini
Change-Id: I1b3f858cf56f93fc72f1508322c00647e12a4c43 Reviewed-on: https://gerrit.libreoffice.org/76481 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-07-22Simplify Sequence iterations in shell..svgioArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I612d36abcc09a91c60f7212de6747a1a1bdcfc69 Reviewed-on: https://gerrit.libreoffice.org/76056 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-21tdf#125922 rename kde5 to kf5 + plasma5Jan-Marek Glogowski
Just as the gtk3 plugin isn't named GNOME, rename kde5 to kf5, as it is based on the KDE frameworks 5 libraries. This also includes: * a convenience alias to load the kf5 VCL plugin in case someone requests the kde5 plugin. * keep convenience kde5 configure switch, but warn about it * rename detected desktop from kde5 to plasma5 Change-Id: I6764a05b81a5edbf284484c234fee2649aacf735 Reviewed-on: https://gerrit.libreoffice.org/75313 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-18cid#1448418 Unchecked return valueCaolán McNamara
Change-Id: Ia2cceb8e169a363a21753fbcf79fa29669957e84 Reviewed-on: https://gerrit.libreoffice.org/75886 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-04Center spsupp_helper dialog on screen; make it topmostMike Kaganski
Change-Id: I99cf333a24ddf99407b406e42930d58dc7b5fb96 Reviewed-on: https://gerrit.libreoffice.org/75076 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-27Register versions from 1 to 5 for SharePoint OpenDocuments objectMike Kaganski
This is required fro two reasons: 1. For our custom LOSPSupport.OpenDocuments, it allows SharePoint site's js code to properly find out the supported methods of the object. Previously we only registered v.1 for it, and that made SharePoint to assume that only older subset of methods is supported. 2. For SharePoint.OpenDocuments, which is used to register MS component to point to our implementation, leaving out v.4 and v.5 made problems on systems with co-existing MS Office; leftover registration of v.4 and v.5 resulted in mixed results: when opened from web view, documents used MS ActiveX, while for documents opened from list view in SharePoint, our ActiveX was used. Registering all versions produces consistent results. Change-Id: I7e8d4216cce1708e676c834a465654751f079c89 Reviewed-on: https://gerrit.libreoffice.org/74776 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17loplugin:logexceptionnicely in shell..sotNoel Grandin
Change-Id: I2ae0c0ac06f32ef91951aa4f7c98b5706178f841 Reviewed-on: https://gerrit.libreoffice.org/74115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-14Make spsupp*.dll usable on 64-bit WindowsMike Kaganski
Build spsupp for both x64 and x86, regardless of target platform. This allows to install the ActiveX component to be used by both 64-bit and 32-bit applications on 64-bit systems (especially IE, which runs both 64-bit and 32-bit processes simultaneously at least on Win10), no matter which LO (32/64) was installed. Move the DLLs from activex feature to ooo, to copy unconditionally. Registration of LO-specific component will be also unconditional; registration of replacement of MSO component will need own feature. This doesn't yet register the component in system: TODO later. Change-Id: Iccf5e73dfae306cb777f844d40611e23c4520a13 Reviewed-on: https://gerrit.libreoffice.org/71925 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-12Use 'gb_Library_add_cxxflags' for '-include chrono'Michael Weghorn
Rationale is the same as in described in commit 4aa60490622cc10f8d3a31489c62a5622d240c83 ("gbuild: treat $({QT,KF}5_CFLAGS) as cxxflags, not defines"). Change-Id: I1253e33118956b72561bd56bbc668ca345006c37 Reviewed-on: https://gerrit.libreoffice.org/73700 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-05-17Make spsupp_x64 independent of shell/CustomTarget_x64Mike Kaganski
... in preparation for further changes. Thanks to Noel Grandin for the hint! Change-Id: I2b223322d1d42099b56a74a92e3c39631d6b581c Reviewed-on: https://gerrit.libreoffice.org/72470 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-17SharePoint: Add dialog to choose opening in read-only or edit mode.Mike Kaganski
ViewDocument3 method takes OpenType parameter, which allows to decide if user can choose opening the document read-only or to edit. Since we need to show localizable strings, we need to bootstrap part of LO (l10n), which is impossible when e.g. 64-bit ActiveX DLL tries to load installed 32-bit sal DLLs. Thus, we need a separate helper .exe, which architecture matches the rest of installed LO, and which handles user interaction. Change-Id: I0ad53ba64272fb84728d2221e3dc85d3eefdda68 Reviewed-on: https://gerrit.libreoffice.org/72355 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-17Add license statementMike Kaganski
Change-Id: Ib7ed7b3d94c04c09debe910a76cd720802f1a6f6 Reviewed-on: https://gerrit.libreoffice.org/72475 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-11 17:59:14 +0000