Age | Commit message (Collapse) | Author |
|
Bin pointless '// predeclarations' or '// forward declarations' comments. If
a programmer doesn't know what a forward declaration is, well, why read C++
source code?
Also bin some pointless '// end of namespace foo' comments after namespace
blocks just a handful of lines long, and some superfluous vertical whitespace.
Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
|
|
Open TODO to actually obtain values for them, instead of returning an empty
css::beans::Optional representing "no value available."
Change-Id: Iceb286e9873216f7bc36bd88b09ac03bd3a2c895
|
|
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
|
|
Change-Id: I1179e20fd5fbdecd198633d5440621ed08a0465b
|
|
Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
|
|
Change-Id: Iab5e7de499452924b4ac0d34cc604ee38395c813
|
|
Change-Id: I443d86e9805dd994006d8bde6dabd72e14a2cff5
|
|
Change-Id: I8bb20f4ce9c8cca3b70057cd8c4fb23819fa3b23
|
|
Change-Id: Iaae87d77ea48207c3277e7107b339296f6a99772
|
|
Part of Code Review:
https://reviews.freebsd.org/D2055
Author: Don Lewis (truckman at FreeBSD)
(cherry picked from commit ecebe457c968bfd30a99a435210b0bdbb117faef)
|
|
Change-Id: I84b3843b32bbec6dfe5a9c627927b04122d50abd
|
|
Change-Id: Iefd4d375a0dfb36732233852f906c6b85dccc2a5
|
|
Change-Id: I6f9b6aa7abba6eadf4db93506bdd9a822afdf2fb
Reviewed-on: https://gerrit.libreoffice.org/14884
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
...to match what is recorded in the .component files
Change-Id: Ibc5bb0575f3869317e4d14614cf1dad0af728ddc
|
|
We always use -I$(SRCDIR)/include, and the #include statements use
<shell/*.h>.
Change-Id: I62d32b3a1bd0840f3a4bb149c5552c2aed98cb56
|
|
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
|
|
Change-Id: I121cdfd586562b9ce298448f51d0b2e3b2a52c39
|
|
Change-Id: I5da7ec2992f9f0b20aa075ee33d0b882cdf91901
|
|
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
|
|
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
|
|
Change-Id: Id70289b0c88dd203cac6301303fe7452088f60f9
|
|
... and remove the definitions in makefiles, except in fpicker, which
defines a different value for the Vista file picker.
The WINVER value is derived automatically from _WIN32_WINNT by SDK
header sdkddkver.h.
Change-Id: I73358a9bf5d070f71821654cae2a29335a754a21
|
|
Change-Id: Ib6d9233e8c322fd7165fce8763bb2a4eee9a7850
|
|
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
|
|
Change-Id: I21e6036a5156ed62f2c7bff6439c64d0178c96e4
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Adds a KDE4 specific URL processing script.
Change-Id: I0116fa95f076a5772e88c616e93de542fe4fe4e4
|
|
Change-Id: I2a3d9deb9c71bb4dfe3ad9076d7202636001e0bb
|
|
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Conflicts:
shell/source/win32/simplemail/senddoc.cxx
Change-Id: I31cac063ffb4afbfde068558ebcf5f66ea34d1a8
|
|
found with some minor modifications to find/find-unused-defines.sh
Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
http://ci.libreoffice.org/job/lo_gerrit_master/495/Gerrit=Gerrit,Platform=Windows/console
Change-Id: I0104d448906bd17857b3716856c544e632c1662c
|
|
Change-Id: I8d9846dcfd8b0f686f7321a3e7b7b0d70428723d
|
|
Apparently GetVersionEx() is deprecated now, but the replacement header
"versionhelpers.h" does not exist in older SDKs (at least not in 8.0),
so try to determine the used SDK version by checking if the Windows 8.1
version constant _WIN32_WINNT_WINBLUE (0x0602) exists.
http://msdn.microsoft.com/en-us/library/windows/desktop/dn424972%28v=vs.85%29.aspx
Change-Id: Ia9224a8c76823ada7cb294a600046c6a0fc843ad
Reviewed-on: https://gerrit.libreoffice.org/14020
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
|
|
Change-Id: I1bb1ad04adec864b594d96711f85b8fcdc1d1ef2
|
|
This addresses some cppcheck warnings.
Change-Id: I404f121ee2e5020359a662f54ffe341f466cd1d5
Reviewed-on: https://gerrit.libreoffice.org/13608
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I3b2c0a4200fa953162f40eff49289052962e73d2
|
|
Change-Id: I2647295383085abf8f217693531ef82632eb4c52
|
|
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
|
|
Change-Id: I35fcb2d73accf20baa96b62d99be6d0a3ebb3ba2
|
|
we don't really need it anymore, fallback to our own open-url
if there is nothing else to take it
Change-Id: I7a4e841a53bda30e29d48b9c34d24af085f1b4b5
Related: coverity#706194 Use of untrusted string value
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I568ee2c3f103777720f6c39340a5915b10aeebb4
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Id15c4b355591678023ae97b1183f8f3a01823084
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Ice7bc99fc5f3d26ced1b7cd5a1dbf29b0e635471
|
|
Change-Id: Ib68bf02ef7065c76ff25f36b8c29a9a4b028b2e0
Reviewed-on: https://gerrit.libreoffice.org/12268
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
|
|
Change-Id: I2f104c64601b22ce3ef078295c7da3cb21a133f9
|
|
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
|