summaryrefslogtreecommitdiff
path: root/shell
AgeCommit message (Collapse)Author
2019-10-14loplugin:stringadd look for unnecessary temporariesNoel Grandin
which defeat the *StringConcat optimisation. Also make StringConcat conversions treat a nullptr as an empty string, to match the O*String(char*) constructors. Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b Reviewed-on: https://gerrit.libreoffice.org/80724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-02-Werror,-Wmicrosoft-exception-spec (clang-cl)Stephan Bergmann
No idea why that started to show up now, but C:/Program Files (x86)/Windows Kits/10/Include/10.0.17763.0/um/combaseapi.h contains > #define STDMETHOD(method) virtual COM_DECLSPEC_NOTHROW HRESULT STDMETHODCALLTYPE method while C:/Program Files (x86)/Windows Kits/10/Include/10.0.17763.0/um/winnt.h contains > #define STDMETHODIMP HRESULT STDMETHODCALLTYPE which caused failures like > [build CXX] embedserv/source/inprocserv/dllentry.cxx > embedserv/source/inprocserv/dllentry.cxx(261,40): error: 'QueryInterface' is missing exception specification '__attribute__((nothrow))' [-Werror,-Wmicrosoft-exception-spec] > STDMETHODIMP InprocEmbedProvider_Impl::QueryInterface( REFIID riid, void ** ppv ) > ^ > embedserv/source/inprocserv/dllentry.cxx(143,15): note: previous declaration is here > STDMETHOD(QueryInterface)(REFIID riid, void ** ppvObj) override; > ^ Change-Id: I0fe3554c2da4089bf0f883e1132d6f2ee95ae2c3 Reviewed-on: https://gerrit.libreoffice.org/79970 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01-Werror,-Wswitch (clang-cl)Stephan Bergmann
Change-Id: I3d40104d6822ebb80ebec44b36bcdfa5c7e953ed Reviewed-on: https://gerrit.libreoffice.org/79960 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:returnconstval (clang-cl)Stephan Bergmann
Change-Id: Id1bcc878f40fba804f78f7a5b7cd463db8dc5988 Reviewed-on: https://gerrit.libreoffice.org/79957 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:sequenceloop (clang-cl)Stephan Bergmann
Change-Id: Ie55967043fd6584c8b9a0ad66fad118c70bda8f0 Reviewed-on: https://gerrit.libreoffice.org/79927 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:data (clang-cl)Stephan Bergmann
Change-Id: Ib8b2bc1c5f7b27a646036ce23cae2b6a06edd038 Reviewed-on: https://gerrit.libreoffice.org/79922 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:stringconstant (clang-cl)Stephan Bergmann
Change-Id: Id1a82cea4444255fdb693e126b7571a406094624 Reviewed-on: https://gerrit.libreoffice.org/79916 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:simplifyconstruct (clang-cl)Stephan Bergmann
Change-Id: I08da288a88c2bce1d4250ec77f17bd483e6bc09c Reviewed-on: https://gerrit.libreoffice.org/79911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27cid#1448334 silence Untrusted value as argumentCaolán McNamara
Change-Id: I13f626c29ceeafbca91b06e5efd11b79b0f25a76 Reviewed-on: https://gerrit.libreoffice.org/79679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24tdf#127710: fix sending documents to Claws MailJulien Nabet
Thanks to the Paul's (paul@claws-mail.org) contribution Change-Id: Ie4144ab78691b33d8d341d4520c40c56010a0dd8 Reviewed-on: https://gerrit.libreoffice.org/79423 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for ".." instead of "..." between words. It passed "make check" on Linux. Change-Id: I144d8061fca9f545c762941551e59dffdd3650e8 Reviewed-on: https://gerrit.libreoffice.org/78357 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-31Add version resource to executables where it was missingMike Kaganski
Change-Id: Iee965c3f720827b20347f6228e891562c8295d22 Reviewed-on: https://gerrit.libreoffice.org/78327 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-30Introduce gb_Executable_add_default_nativeres to add version resourceMike Kaganski
... to executables on Windows Change-Id: I31bd2447052915bb299820034f99128e0e97db54 Reviewed-on: https://gerrit.libreoffice.org/78290 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-22kf5backend.cxx: Use 'free()' instead of 'delete'Michael Weghorn
'strdup' doc [1] mentions: "The returned pointer must be passed to 'free' to avoid a memory leak." This silences a "Mismatched free() / delete / delete []" error that valgrind outputs. [1] https://en.cppreference.com/w/c/experimental/dynamic/strdup Change-Id: I28877be762256a7b995c09415a8ad9977b7998c4 Reviewed-on: https://gerrit.libreoffice.org/77974 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-08-15loplugin:sequenceloop in shell..sotNoel Grandin
Change-Id: I40e2a1be0ce7df627d3820192d24821ddd7c3e2f Reviewed-on: https://gerrit.libreoffice.org/77527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ic431ef6c3555f02fbc204a5b0af5f9bfe62f4a30 Reviewed-on: https://gerrit.libreoffice.org/77286 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-10loplugin:stringconstant (macOS)Stephan Bergmann
Change-Id: Icb9d9e1cd21e2506e36fe40a3b93b6a2521a868c Reviewed-on: https://gerrit.libreoffice.org/77239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-01tdf#126641: don't fail on file URLs with fragmentMike Kaganski
This only fixes part that the URL refuses to open the target file. Honoring fragment isn't fixed here, since it's the system call to ShellExecuteExW that in this case internally converts the file URL into a system path, and strips the fragment from it. Regression from commit d59ec4cd1660410fa1b18c50d2d83b1417a82ddc. Change-Id: I6c9ed27e9a5bd7f2780dd3be96f816a6e825e043 Reviewed-on: https://gerrit.libreoffice.org/76778 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): shellStephan Bergmann
Change-Id: I0045eac5f2395f56dcb1ed8a958c93c28de496a9 Reviewed-on: https://gerrit.libreoffice.org/76647 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-30tdf#126597 don't use modeless dialog for senddoc.exeJan-Marek Glogowski
There is already a large comment in initAttachmentList about problems with MAPI_DIALOG_MODELESS. Using MAPI_DIALOG_MODELESS with Outlook 2016 and multiple attachments sometimes produces a MAPI_E_FAILURE, but most times it crashes for me. And it's not a problem with the removed temporary files, as uncommenting that shows the same problem. And there seems to be many more problems: https://social.msdn.microsoft.com/Forums/en-US/5d8fece6-9d93-490c-9331-625c17e3291d/mapisendmailhelper-and-mapidialogmodeless But actually I don't see any blocking of LO, if I switch to using MAPI_DIALOG, as senddoc.exe already runs in the background. So this switches MAPI_DIALOG_MODELESS to MAPI_DIALOG. This reverts commit 5874c76371562c3e2d8564b1fb04df1997091d27 ("tdf#116074: Use modeless dialogs with supporting mailers"). Change-Id: Ie0f8f22196d1a174dfeada2bc4aabb1717ee16a7 Reviewed-on: https://gerrit.libreoffice.org/76155 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-30Fix typosAndrea Gelmini
It passed "make check" Change-Id: I50c3639ec258c7fb6d73104f8e777f96995aa8e3 Reviewed-on: https://gerrit.libreoffice.org/76543 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-28Fix typosAndrea Gelmini
Change-Id: I1b3f858cf56f93fc72f1508322c00647e12a4c43 Reviewed-on: https://gerrit.libreoffice.org/76481 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-07-22Simplify Sequence iterations in shell..svgioArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I612d36abcc09a91c60f7212de6747a1a1bdcfc69 Reviewed-on: https://gerrit.libreoffice.org/76056 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-21tdf#125922 rename kde5 to kf5 + plasma5Jan-Marek Glogowski
Just as the gtk3 plugin isn't named GNOME, rename kde5 to kf5, as it is based on the KDE frameworks 5 libraries. This also includes: * a convenience alias to load the kf5 VCL plugin in case someone requests the kde5 plugin. * keep convenience kde5 configure switch, but warn about it * rename detected desktop from kde5 to plasma5 Change-Id: I6764a05b81a5edbf284484c234fee2649aacf735 Reviewed-on: https://gerrit.libreoffice.org/75313 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-18cid#1448418 Unchecked return valueCaolán McNamara
Change-Id: Ia2cceb8e169a363a21753fbcf79fa29669957e84 Reviewed-on: https://gerrit.libreoffice.org/75886 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-04Center spsupp_helper dialog on screen; make it topmostMike Kaganski
Change-Id: I99cf333a24ddf99407b406e42930d58dc7b5fb96 Reviewed-on: https://gerrit.libreoffice.org/75076 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-27Register versions from 1 to 5 for SharePoint OpenDocuments objectMike Kaganski
This is required fro two reasons: 1. For our custom LOSPSupport.OpenDocuments, it allows SharePoint site's js code to properly find out the supported methods of the object. Previously we only registered v.1 for it, and that made SharePoint to assume that only older subset of methods is supported. 2. For SharePoint.OpenDocuments, which is used to register MS component to point to our implementation, leaving out v.4 and v.5 made problems on systems with co-existing MS Office; leftover registration of v.4 and v.5 resulted in mixed results: when opened from web view, documents used MS ActiveX, while for documents opened from list view in SharePoint, our ActiveX was used. Registering all versions produces consistent results. Change-Id: I7e8d4216cce1708e676c834a465654751f079c89 Reviewed-on: https://gerrit.libreoffice.org/74776 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17loplugin:logexceptionnicely in shell..sotNoel Grandin
Change-Id: I2ae0c0ac06f32ef91951aa4f7c98b5706178f841 Reviewed-on: https://gerrit.libreoffice.org/74115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-14Make spsupp*.dll usable on 64-bit WindowsMike Kaganski
Build spsupp for both x64 and x86, regardless of target platform. This allows to install the ActiveX component to be used by both 64-bit and 32-bit applications on 64-bit systems (especially IE, which runs both 64-bit and 32-bit processes simultaneously at least on Win10), no matter which LO (32/64) was installed. Move the DLLs from activex feature to ooo, to copy unconditionally. Registration of LO-specific component will be also unconditional; registration of replacement of MSO component will need own feature. This doesn't yet register the component in system: TODO later. Change-Id: Iccf5e73dfae306cb777f844d40611e23c4520a13 Reviewed-on: https://gerrit.libreoffice.org/71925 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-12Use 'gb_Library_add_cxxflags' for '-include chrono'Michael Weghorn
Rationale is the same as in described in commit 4aa60490622cc10f8d3a31489c62a5622d240c83 ("gbuild: treat $({QT,KF}5_CFLAGS) as cxxflags, not defines"). Change-Id: I1253e33118956b72561bd56bbc668ca345006c37 Reviewed-on: https://gerrit.libreoffice.org/73700 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-05-17Make spsupp_x64 independent of shell/CustomTarget_x64Mike Kaganski
... in preparation for further changes. Thanks to Noel Grandin for the hint! Change-Id: I2b223322d1d42099b56a74a92e3c39631d6b581c Reviewed-on: https://gerrit.libreoffice.org/72470 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-17SharePoint: Add dialog to choose opening in read-only or edit mode.Mike Kaganski
ViewDocument3 method takes OpenType parameter, which allows to decide if user can choose opening the document read-only or to edit. Since we need to show localizable strings, we need to bootstrap part of LO (l10n), which is impossible when e.g. 64-bit ActiveX DLL tries to load installed 32-bit sal DLLs. Thus, we need a separate helper .exe, which architecture matches the rest of installed LO, and which handles user interaction. Change-Id: I0ad53ba64272fb84728d2221e3dc85d3eefdda68 Reviewed-on: https://gerrit.libreoffice.org/72355 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-17Add license statementMike Kaganski
Change-Id: Ib7ed7b3d94c04c09debe910a76cd720802f1a6f6 Reviewed-on: https://gerrit.libreoffice.org/72475 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-16Drop obsolete commented out debug outputMike Kaganski
Change-Id: I60f7bbb2921b242396b4620077ca30e12a0d3b4b Reviewed-on: https://gerrit.libreoffice.org/72393 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-15Reimplement IObjectSafety from aggregate object into ancestorMike Kaganski
Also simplify it, don't issue warnings for now, until we understand clearly what each its option implies. Change-Id: I0d74a42b878991ad84c5c3bba36c8978d920b9be Reviewed-on: https://gerrit.libreoffice.org/72337 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-15Check passed pointersMike Kaganski
Change-Id: Idf5e77e4122ad4b5b91f25c50fdaaf25e34a76ae Reviewed-on: https://gerrit.libreoffice.org/72336 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-15Use lambdas to initialize staticsMike Kaganski
Change-Id: Ib03bfd795967ba70333d71d9e5eeec97be90be79 Reviewed-on: https://gerrit.libreoffice.org/72334 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-15Use proper VARIANT_BOOL values: VARIANT_TRUE is actually -1Mike Kaganski
Who was that idiot who initially used wrong values??? Hmm... oh damn, that was me :-( Change-Id: I3bfde7511bcf8adfa38ae68372f21511f21efca1 Reviewed-on: https://gerrit.libreoffice.org/72308 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-14Implement OpenDocuments::PromptedOnLastOpenMike Kaganski
This prevents SharePoint from trying to download documents in browser after they were already opened by LibreOffice SharePoint integration ActiveX control. The implementation just returns true, to avoid instant refresh of the site in browser. TODO: fine-tune when understood when and why it makes sense to return false. Change-Id: I1ceae82db16ca8e418850fafd8c171ee6a2e039b Reviewed-on: https://gerrit.libreoffice.org/72266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-03Use hasElements to check Sequence emptiness in sfx2..svxArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: Icabd773f3b924d465b33e8581175f1fcf70c282e Reviewed-on: https://gerrit.libreoffice.org/71704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-17Stop qt event loop after KDE settings have been readKatarina Behrens
Two use-cases here in kde5backend 1) kde or qt vclplug has already started qt event loop => just use this loop to read KDE settings 2) no qt event loop runs (we're most likely in gtk3_kde5 vclplug) => start a new event loop, read the settings and stop it In case 2) letting qt event loop run means subsequently all UI ops need to happen in main thread. This is problematic to enforce in non-qt-based vclplugs In both cases, cache those settings for future use - the assumption is, most of them are static during a session anyway. Change-Id: Ifa203f4cdb9a753db808f945762fb131ee83393c Reviewed-on: https://gerrit.libreoffice.org/70808 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-17Fix wrong proxy setting URLs in kde5backendKatarina Behrens
this copy'n'pasta blunder looks innocuous but can slow down loading of JVM (which reads proxy settings among others) in KDE environment significantly Change-Id: I98f0fb107a2ee825bcd47731a5a9d15017ba63bc Reviewed-on: https://gerrit.libreoffice.org/70806 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-13tdf#119890 followup: Forbid HOME to be the default dirTakeshi Abe
... of user templates This is kludgy yet better than making innocent users waiting for the template dialog ~forever as pointed out in the comments in <https://gerrit.libreoffice.org/#/c/67741/>. Change-Id: I6dfdc0408effb06cc9175cd976ea6687e52a7136 Reviewed-on: https://gerrit.libreoffice.org/69883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-13use more std::make_uniqueNoel Grandin
Change-Id: I7d85cbc9105c5e0c4a8d9a69c4ac9d6dfc07eabd Reviewed-on: https://gerrit.libreoffice.org/70663 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-04Drop UNICODE/_UNICODE definesMike Kaganski
The code is using expicit (mostly W) Windows API, and is independent from the macro. Removing it here allows to catch places where some UNICODE-dependent macro is used unintentionally. Change-Id: I5dff40aecfc3c3dc7fc4cf7271a995a675943a45 Reviewed-on: https://gerrit.libreoffice.org/70237 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-03WinAPI: Fix some leftovers having UNICODE-define-dependencyMike Kaganski
Change-Id: I21b4df5b595c3814a5a3fb85d9da531729447b7e Reviewed-on: https://gerrit.libreoffice.org/70193 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-03Filter out problematic file URLsStephan Bergmann
Change-Id: I87fd37e56326bef4888354b923407530c6f70760 Reviewed-on: https://gerrit.libreoffice.org/70177 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-27loplugin:typedefparam (clang-cl)Stephan Bergmann
Change-Id: I07604028845c49cc084927e21db7f21c5d053bab Reviewed-on: https://gerrit.libreoffice.org/69796 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-24Resolves: tdf#122114 remove support for ~/.recently-used fileArkadiy Illarionov
Change-Id: Ie91f0bf21e6f5c3f7a7aa4ae3d1dff6cc8e15a86 Reviewed-on: https://gerrit.libreoffice.org/69597 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-28 08:42:40 +0000