summaryrefslogtreecommitdiff
path: root/slideshow/source/engine/eventqueue.cxx
AgeCommit message (Collapse)Author
2022-08-23-Werror=redundant-moveStephan Bergmann
...with recent GCC 16 trunk. Introduced with 1a2926a995fdbdcdae0ca6407877084f3520e539 "use std::move when popping stuff off stacks" but which doesn't make sense here where std::priority_queue's top() unconditionally returns a const reference (unlike std::stack's top()). Change-Id: I408920220e3b7ffe775fa87f9edbfdc7721058db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138732 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-03clang-tidy modernize-pass-by-value in slideshowNoel Grandin
Change-Id: I89a56aa3d267f22665769ba073a47d1208d8b55d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137745 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-08osl::Mutex->std::mutex in slideshow::EventQueueNoel Grandin
Change-Id: Ie9e53e5dc2c842e11457846b5f177fc55683e0d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-05tdf#143728 Certain presentation crashes Impress after starting slideshowNoel Grandin
Revert "osl::Mutex->std::mutex in EventQueue" This reverts commit c0ce120b55ba389729e97babf80f2cb39ce38e9f. because we try to take the same lock twice Change-Id: Ie62659ec3407089f616d1ea950a3755300d68eef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119988 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-03Consolidate on C++17 std::scoped_lock instead of std::lock_guardNoel Grandin
as in commit 9376f65a26240441bf9dd6ae1f69886dc9fa60fa Change-Id: I3ad9afd4d113582a214a4a4bc7eea55e38cd6ff9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119927 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-01osl::Mutex->std::mutex in EventQueueNoel Grandin
Change-Id: Ia936a28dd2ae5b5cb1797a0e703e9d96841a1f3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-03loplugin:simplifypointertobool improveNoel Grandin
to look for the x.get() != null pattern, which can be simplified to x I'll do the x.get() == nullptr pattern in a separate patch, to reduce the chances of a mistake Change-Id: I45e0d178e75359857cdf50d712039cb526016555 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-03tdf#42949 Fix IWYU warnings in slideshow/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id1c207705b7aa9b057fb8207d735e376675c91d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86069 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-12use std::move when popping stuff off stacksNoel Grandin
Change-Id: I6ba0ee8afee1a9579045643cd0118cf19599d5b9 Reviewed-on: https://gerrit.libreoffice.org/82497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17loplugin:logexceptionnicely in shell..sotNoel Grandin
Change-Id: I2ae0c0ac06f32ef91951aa4f7c98b5706178f841 Reviewed-on: https://gerrit.libreoffice.org/74115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-19pretty up logging of exceptionsNoel Grandin
Add exceptionToString() and getCaughtExceptionAsString() methods in tools. Use the new methods in DbgUnhandledException() Add special-case case code for most of the exceptions that contain extra fields, so all of the relevant data ends up in the log Change-Id: I376f6549b4d7bd480202f8bff17a454657c75ece Reviewed-on: https://gerrit.libreoffice.org/67857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29Simplify containers iterations in slideshow, sot, starmath, stocArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I94792c28b283a0998bf813317e5beb37d93e0c23 Reviewed-on: https://gerrit.libreoffice.org/64125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-31Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from sfx2 to starmath Change-Id: I40ee7bfae6efdadd862319b7b693ad22c648e1c4 Reviewed-on: https://gerrit.libreoffice.org/58222 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-13clang-tidy modernize-use-emplace in slideshowNoel Grandin
Change-Id: Ice6ab0dcd6785a751be5a66b262690640e0a2780 Reviewed-on: https://gerrit.libreoffice.org/42239 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02remove unnecessary use of 'this->'Noel Grandin
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28remove unnecessary use of OString::getStrNoel Grandin
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-16logging the simple message is sufficientCaolán McNamara
Change-Id: I50050001f080f668bded036372feeb271da4a7c6
2017-03-09some OSL_FAIL to SAL_WARNCaolán McNamara
Change-Id: I5101e42b7a34cca9055fc805d9a392ba4f920a3d
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: Ief4dd31d68bd7c8e45070eea689d07057449ce77
2015-09-14boost->stdCaolán McNamara
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c Reviewed-on: https://gerrit.libreoffice.org/18564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-11stop inclduing canvas/verbosetraces.hxx and canvas/debug.hxxNorbert Thiebaud
also clean-up and 'standardize' the include sections of canvas' source code Change-Id: Ib437a41ea41ae2ea6528f755ae5b2828775aaf73 Reviewed-on: https://gerrit.libreoffice.org/17633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-11slideshow: stop (mis)-using VERBOSENorbert Thiebaud
converted the use of internal 'verbose' level tracing to SAL_INFO/SAL_WARN Change-Id: Iab89d9b5c75fe476c6516718f1cee3d01d196858 Reviewed-on: https://gerrit.libreoffice.org/17632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann
...in preparation of enabling the __attribute__((format(...))) in sal_detail_logFormat (include/sal/detail/log.h) Change-Id: I8a859199fa11ca0f9f4f4b4b23a8ebddec955a86
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2012-11-22always set event descriptionDavid Tardon
Change-Id: I8d83c0d65fff0b0d3d08f32aa3d5c0bb5e7e9c8a
2012-11-22OSL_TRACE -> SAL_INFODavid Tardon
Change-Id: I3c3dbe958fe50cc95b8427ac4daaca1a5bec784c
2012-07-11re-base on ALv2 code. Includes:Michael Meeks
Avoid some uses of non portable #!/bin/bash in shell scripts. Patch contributed by Pedro Giffuni http://svn.apache.org/viewvc?view=revision&revision=1235297 remove redundant namespace, patch contributed Mathias Bauer http://svn.apache.org/viewvc?view=revision&revision=1162610 removal of OS/2 port changes, and preferring our similiar tools/inc/tools/solar.h DLLPOSTFIX cleanup. i118595 - Removal of the use of getopt() from rscdep. Patch contributed by Andre Fische http://svn.apache.org/viewvc?view=revision&revision=1202270
2011-12-01typo fix: explicitely -> explicitlyLior Kaplan
2011-11-27remove include of pch header from slidewhowNorbert Thiebaud
2011-07-25Remove unused Debugging stuffThomas Arnhold
If this is still needed, please revert it.
2011-03-12Move OSL_ENSURE(false,...) to OSL_FAIL(...)Thomas Arnhold
2010-10-13Add vim/emacs modelines to all source filesSebastian Spaeth
Fixes #fdo30794 Based on bin/add-modelines script (originally posted in mail 1286706307.1871.1399280959@webmail.messagingengine.com) Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-03-11autorecovery: merged changes from m74. Still need to find out how to re-do ↵Frank Schoenheit [fs]
two patches (to module_hidden_ooo.scp and file_ooo.scp in scp2/source/ooo) which do not apply anymore.
2010-02-12changefileheader2: #i109125#: change source file copyright notice from Sun ↵Jens-Heiner Rechtien
Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision)
2010-01-29autorecovery: ENSURE_OR_RETURN => ENSURE_OR_RETURN_FALSE, added new ↵Frank Schoenheit [fs]
ENSURE_OR_RETURN taking a return value
2009-10-14#i48179# Fixed stepping back for animations with active auto_reverse.Andre Fischer
2009-04-27#i48179# Debug: added descriptive strings to events.Andre Fischer
2009-03-04#i48179# Introduced EffectRewinder class that replays main sequence effects ↵Andre Fischer
on current or previous slide.
2008-06-24INTEGRATION: CWS canvas05 (1.13.18); FILE MERGEDKurt Zenker
2008/04/21 07:53:01 thb 1.13.18.2: RESYNC: (1.13-1.14); FILE MERGED 2007/10/01 13:49:11 thb 1.13.18.1: #i79258# Merge from CWS picom
2008-04-10INTEGRATION: CWS changefileheader (1.13.46); FILE MERGEDRüdiger Timm
2008/03/31 14:00:14 rt 1.13.46.1: #i87441# Change license header to LPGL v3.
2007-07-17INTEGRATION: CWS presfixes12 (1.12.12); FILE MERGEDOliver Bolte
2007/02/25 01:10:23 thb 1.12.12.3: #i37778# Cleared up error handling a lot: no longer quenching RuntimeExceptions; reporting assertions in the debug case; ViewLayer now reports resized sprite (which needs re-render from all shapes); fixed missing subset area reduction for glyph-level animations; added return of resize state from Layer::commitLayerBounds(); adapted unit tests to corrected behaviour 2007/02/06 17:18:03 thb 1.12.12.2: #i37778# Moved clear() method from View to ViewLayer (also sprites need to be cleared); fixed a few more cases of local code style violations; removed redundant inline keywords; finished Layer/LayerManager rework (Layer now represents ViewLayers, shapes and rendering are fully under LayerManager control); made shape comparator reusable 2007/01/29 14:01:53 thb 1.12.12.1: Issue number: #i37778# Larger slideshow refactoring. Wrote design and coding style manifest, and adapted the code to actually conform to this. In detail: - cleaned up ownership/disposable/weak_ptr story. removed hacks and explicit Disposable implementations, where workaround were available - removed object mutices, where superfluous - reworked EventMultiplexer (using templatized listener class now), added more events. EventMultiplexer now serves as a true blackboard - reworked directory structure: disjunct parts are now physically separated into directories, instantiation happens via factories & abstract interfaces - added CursorManager, to make setting mouse cursor less hackish - reworked DrawShape, to implement SeparateListener pattern - reworked IntrinsicAnimationActivity, to avoid cyclic references - modified hyperlink & shape cursor handling to communicate via EventMultiplexer - renamed & cleaned up files (presentation.cxx now named slideshowimpl.cxx, etc.) - added first version of the z-order fix to layer/layermanager - cleaned up include guards and include syntax
2006-12-13INTEGRATION: CWS presfixes09 (1.9.2); FILE MERGEDKurt Zenker
2006/10/18 19:49:08 thb 1.9.2.5: RESYNC: (1.10-1.11); FILE MERGED 2006/09/15 22:11:37 thb 1.9.2.4: RESYNC: (1.9-1.10); FILE MERGED 2006/04/12 20:40:03 thb 1.9.2.3: #i37778# Replaced all shared_ptr.get() != NULL places with the more elegant automatic-conversion-to-bool version (at least where the compiler tolerated that) 2006/03/24 18:23:07 thb 1.9.2.2: #i37778# Moved whole slideshow engine from namespace presentation (which conflicts with one of the UNO subnamespaces) to slideshow 2006/03/15 15:22:17 thb 1.9.2.1: #i49357# Removed external include guards from all non-export headers (and from the cxx files, anyway)
2006-09-17INTEGRATION: CWS pchfix02 (1.10.10); FILE MERGEDOliver Bolte
2006/09/01 17:39:30 kaib 1.10.10.1: #i68856# Added header markers and pch files
2006-07-26INTEGRATION: CWS presfixes10 (1.9.8); FILE MERGEDRüdiger Timm
2006/07/14 08:16:29 dbo 1.9.8.1: #i58939#
generated by cgit (git 2.34.1) at 2024-07-13 21:22:47 +0000