summaryrefslogtreecommitdiff
path: root/slideshow/test/testshape.cxx
AgeCommit message (Collapse)Author
2020-01-03tdf#42949 Fix IWYU warnings in slideshow/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id1c207705b7aa9b057fb8207d735e376675c91d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86069 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-30loplugin:unusedmethodsNoel Grandin
Change-Id: Id0d68d659fa06a8230ed0d927b85b6b504525d1e Reviewed-on: https://gerrit.libreoffice.org/64328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28slideshow: get unit tests to work againThorsten Behrens
Change-Id: I7b5c7a20677ac0f720b41daf8ca59c3cc94f1283 Reviewed-on: https://gerrit.libreoffice.org/59964 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-21cleanup unused css/animations/ and css/presentation/ includesJochen Nitschke
Change-Id: Iafd106d431869d80f664bd540092bee4f10e14b5 Reviewed-on: https://gerrit.libreoffice.org/37862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-10-19slideshow: remove unecessary boost/bind includesDaniel Robertson
All of the remaining includes of boost/bind.hpp may be removed from slideshow, as last remaining uses of boost::bind have been removed from the module. There should be no side effects due to this change. Change-Id: I4e1855545fad69d09e594d0be139c09aad561b2d Reviewed-on: https://gerrit.libreoffice.org/19395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-07slideshow: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I3160235d0e6253626a8facbfed33e3c252505cbf Reviewed-on: https://gerrit.libreoffice.org/18336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-11slideshow: prefer value_type over manual type generationThorsten Behrens
Change-Id: I3e088a10e7bc0da73e4fa20db15e71581661fe4b Reviewed-on: https://gerrit.libreoffice.org/17641 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-08tdf#92459 replace deprecated o3tl featuresDaniel Robertson
Replace deprecated features from the o3tl including select1st and select2nd with lambda expressions. Change-Id: I0cb1aedc3e193c52d25e2837a47d9d90c898079e Reviewed-on: https://gerrit.libreoffice.org/17459 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-05-13slideshow: simplify code by replacing std::find_if by std::any_of/std::none_ofTakeshi Abe
Change-Id: Ib8eec5074e82127e11f4fba2c0b143ab8cef3bcc Reviewed-on: https://gerrit.libreoffice.org/15714 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-25Remove visual noise from slideshowAlexander Wilms
Change-Id: I87d07afbffa9d4633ed31bdb88f2dad660c25a18
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-04remove unused and commented out codeThomas Arnhold
This code gets never called. Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2012-07-11re-base on ALv2 code. Includes:Michael Meeks
Avoid some uses of non portable #!/bin/bash in shell scripts. Patch contributed by Pedro Giffuni http://svn.apache.org/viewvc?view=revision&revision=1235297 remove redundant namespace, patch contributed Mathias Bauer http://svn.apache.org/viewvc?view=revision&revision=1162610 removal of OS/2 port changes, and preferring our similiar tools/inc/tools/solar.h DLLPOSTFIX cleanup. i118595 - Removal of the use of getopt() from rscdep. Patch contributed by Andre Fische http://svn.apache.org/viewvc?view=revision&revision=1202270
2012-06-27targetted re-work of cppunit pieces.Michael Meeks
2011-09-12sb140: #i113503# mixing system CppUnit and OOo STLport does not work, backed ↵Stephan Bergmann
out a6913c9677c2 For LibO, that just means replacing sal/cppunit.h with sal/precppunit.hxx.
2011-02-08Port stuff to our private implementation of SGI extensionsFridrich Štrba
2010-11-15Make slideshow unittest work againThorsten Behrens
Well, it still fails. But for all the right reasons.
2010-10-13Add vim/emacs modelines to all source filesSebastian Spaeth
Fixes #fdo30794 Based on bin/add-modelines script (originally posted in mail 1286706307.1871.1399280959@webmail.messagingengine.com) Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-02-12changefileheader2: #i109125#: change source file copyright notice from Sun ↵Jens-Heiner Rechtien
Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision)
2009-09-14#i103496#: split cppunit in a pure external lib and a lib depending on sal ↵Mathias Bauer
-> testshl2
2008-04-11INTEGRATION: CWS changefileheader (1.2.46); FILE MERGEDRüdiger Timm
2008/03/31 14:00:33 rt 1.2.46.1: #i87441# Change license header to LPGL v3.
2007-07-17INTEGRATION: CWS presfixes12 (1.1.2); FILE ADDEDOliver Bolte
2007/02/25 01:10:29 thb 1.1.2.2: #i37778# Cleared up error handling a lot: no longer quenching RuntimeExceptions; reporting assertions in the debug case; ViewLayer now reports resized sprite (which needs re-render from all shapes); fixed missing subset area reduction for glyph-level animations; added return of resize state from Layer::commitLayerBounds(); adapted unit tests to corrected behaviour 2007/02/10 23:23:53 thb 1.1.2.1: #i37778# Renamed setMouseCursor() to setCursorShape() at View interface (name clash with API method otherwise); added LayerManager/Layer unit tests; fixed a bunch of bugs/glitches found during unit testing